1. 16 May, 2023 1 commit
  2. 22 Mar, 2023 1 commit
  3. 21 Mar, 2023 1 commit
  4. 24 Jan, 2023 1 commit
  5. 09 Jan, 2023 1 commit
  6. 04 Jan, 2023 1 commit
  7. 21 Dec, 2022 2 commits
    • Renzo Olivares's avatar
    • Renzo Olivares's avatar
      Add support for double tap and drag for text selection (#109573) · cd0f15a7
      Renzo Olivares authored
      * Replace PanGestureRecognizer in TextSelection with TapAndDragGestureRecognizer
      
      * add tracking of _DragState to new tap_and_drag recognizer and remove some legacy double tap code from text_selection.dart and add logs"
      
      * add dragTapCount, a tap count that is persistent for an entire drag and is set to null on drag end vs the regular tap count which is reset on a timer
      
      * basic double tap to drag functionality and add a local dragTapCount in text_selection.dart to use with the timer callback
      
      * Add offsetFromOrigin and localOffsetFromOrigin to DragUpdateDetails similar to LongPressMoveUpdateDetails, eliminates the need to hold the state of lastDragStartDetails
      
      * make a generic baselongpressgesturerecognizer
      
      * Revert "make a generic baselongpressgesturerecognizer"
      
      This reverts commit aad8f7433bd01e4cd016d527af832c3b1f15fac5.
      
      * rename tap_and_drag to selection_recognizers
      
      * add mixin for consecutivetap
      
      * tap and long press gesture recognizer
      
      * Revert "Revert "make a generic baselongpressgesturerecognizer""
      
      This reverts commit 181350c36718f644eada3e45c1b7b5939f90a340.
      
      * Revert "Revert "Revert "make a generic baselongpressgesturerecognizer"""
      
      This reverts commit 4d69775967858dfd66dd9429e1713da598908a85.
      
      * Add support for secondary button clicks on drag gesture recognizer and separate drag end and tap up callback
      
      * get test running
      
      * rename tapCount to consecutiveTapCount
      
      * dispose timer properly
      
      * add some comments to tests
      
      * Add comments
      
      * Make ConsecutiveTapMixin private and move logic to increment tap count into mixin
      
      * stop tracking pointer when gesture is rejected and detect drags on touch devices
      
      * onCancel for TapAndDrag
      
      * have the TapAndDragGestureRecognizer handle tap downs and tap ups on touch and mouse devices
      
      * add drag to move cursor for android and iOS, and pointer device kind to DragUpdateDetails
      
      * get tests running
      
      * refactor TapAndDragGestureRecognizer moving some logic into _check methods
      
      * Handle cancel properly on TapAndDragGestureRecognizer, having both onTapCancel and onDragCancel, also fix tests
      
      * Fix test mouse drag selects and cannot drag cursor, save _initialPosition based on dragStartBehavior (either on tapDown or dragStart)
      
      * determine if drag has a sufficient global distance to accept and fix some cancel behavior, making _checkCancel clearer
      
      * give up pointer on drag end
      
      * properly stop tracking pointer, fixes test for right click on Apple and non-apple platforms
      
      * clean up some comments from last commit
      
      * remove drag on touch for now
      
      * fix Can select text by dragging with a mouse due to dragStart only being fired on the first PointerMoveEvent, the previous pan gesture recognizer would fire both dragStart and dragUpdate
      
      * Revert "fix Can select text by dragging with a mouse due to dragStart only being fired on the first PointerMoveEvent, the previous pan gesture recognizer would fire both dragStart and dragUpdate"
      
      This reverts commit 124dc79bc3389672c76d7c014ce04edab297abc6.
      
      * correctly use _initialPosition for checkStart and call _checkUpdate after _checkStart if localDelta is not zero
      
      * updates
      
      * fix double tap chains
      
      * Add docs
      
      * Address analyzer
      
      * more analyzer, only issues left are with print statements
      
      * add deadlineTimer to fix conflict with ForcePressGestureRecognizer
      
      * Revert "add deadlineTimer to fix conflict with ForcePressGestureRecognizer"
      
      This reverts commit 3b29ddfff4cde4845edd481ecefb789fea2a0781.
      
      * remove unecessary changes to tests
      
      * secondaryButton should not drag
      
      * Revert "Revert "add deadlineTimer to fix conflict with ForcePressGestureRecognizer""
      
      This reverts commit 0a008f029f5796acd48c17c1897c0b700d5ef3a7.
      
      * updates
      
      * Revert "updates"
      
      This reverts commit 4803b8443a2b67f0b8d29e9a01f712dfcb0f588c.
      
      * Revert "Revert "Revert "add deadlineTimer to fix conflict with ForcePressGestureRecognizer"""
      
      This reverts commit 79251a7af88d5dbb1460a960afc77e65dea18bff.
      
      * fix shift + tap + drag tests, this was happening because a double tap + drag was being registered and not a single tap, added a duration to pumpAndSettle to fix this
      
      * remove TapAndLongPressGestureRecognizer
      
      * fix cupertino text field tests related to shift + tap + drag
      
      * deadline timer try 2
      
      * more logs
      
      * Should reset taps when tap cancel is called, and should wait until gesture is accepted to initiate a drag
      
      * should clear _down and _up when gesture is rejected
      
      * remove erroneous log
      
      * fix selectable text double tap chains test
      
      * dont restart timer until tap up
      
      * reset consecutiveTapCount on drag end
      
      * fix selectableText test
      
      * fix material text field tests
      
      * reject TapAndDragGestureRecognizer when it is neither a tap nor a drag
      
      * remove prints
      
      * clean up
      
      * shift aware
      
      * clean up
      
      * fix cupertino test
      
      * fix text field focus tests
      
      * Add 100ms delay to cupertino test, to prevent a double tap
      
      * clean up test comments
      
      * add comment to test
      
      * uncomment test
      
      * remove longpress changes
      
      * Fix drag on mobile
      
      * remove debug
      
      * Fix drag to move cursor on iOS
      
      * left over from drag fix
      
      * add tests for drag on touch devices
      
      * add test for double tap + drag mouse devices
      
      * add tests
      
      * Fix bug where initialPosition was used before it was set
      
      * Address some review comments and fix issue where if double tap was held too long then long press gesture recognizer would take over
      
      * remove _isDoubleTap flag since it is no longer needed due to previous commit
      
      * Add docs for onTapCancel and onDragCancel
      
      * analyzer fixes
      
      * Do not test selection handles on macOS, since macOS does not support touch
      
      * Add assert for dragStartBehavior
      
      * add double tap + drag tests to cupertino
      
      * use kDoubleTapTimeout instead of const Duration(milliseconds: 300) for readability
      
      * analyzer issues
      
      * update docs
      
      * update more docs
      
      * address comments
      
      * more doc updates
      
      * fix docs
      
      * unused import
      
      * fix docs
      
      * Add more tests
      
      * Add more tests and reject a tap up if we have exceeded the tap tolerance
      
      * updates
      
      * Address comments
      
      * fix test naming
      
      * update documentation
      
      * move selection_recognizers to selection_gestures
      
      * fix analyzer
      
      * fix analyzer
      
      * keysPressedOnDown instead of isShiftPressed
      
      * update docs
      
      * update docs
      
      * Add drag update throttle to TapAndDragGestureRecognizer
      
      * update comments
      
      * missed from merge
      
      * Replace _ConsecutiveTapMixin with _TapStatusTrackerMixin
      
      * updates
      
      * correctly cancel tap when when past tap tolerance with new implementation
      
      * Should call tap and drag cancel if we are giving up a pointer without succesfully tracking a PointerUpEvent
      
      * comments
      
      * move pastTapTolerance to tap tracker
      
      * move pastTapTolerance to tap tracker
      
      * clean up check for nulls and remove use of consecutiveTapCountWhileDragging
      
      * move call to super.acceptGesture to top
      
      * remove print
      
      * clean up
      
      * Fix tests where both PanGestureRecognizer and TapAndDragGestureRecognizer lost
      
      * clean up
      
      * _GestureState -> _DragState
      
      * more docs clean up
      
      * more clean up
      
      * Add onSecondaryTapCancel
      
      * Add docs
      
      * more docs
      
      * Fix broken isPointerAllowed when attempting a right click drag - the _initialButtons is never reset
      
      * revert debug flag
      
      * make primaryPointer private
      
      * Add support for upper count limit in TapAndDragGestureRecognizer, the tap counter should not be allowed to grow infinitely unless that is desired
      
      * fix analyzer
      
      * Use new TapDrag details objects and callbacks
      
      * clean up docs
      
      * clean up and add test for upperLimit
      
      * Add docs for TapAndDragGestureRecognizer and remove some ambiguity of onStart onUpdate and onEnd parameters
      
      * Address review comments
      
      * analyzer fixes
      
      * Call cancel before rejecting the gesture so we can still access _initialButtons
      
      * Recognizer should reject any pointer differing from the original
      
      * Revert "Recognizer should reject any pointer differing from the original"
      
      This reverts commit afd9807480bd11e119bdd2b7d520631511973bab.
      
      * Address reviewer comments
      
      * Correct cancel behavior
      
      * Fix consecutive tap + drag because _dragStart state was not being set when consecutive tap is greater than one
      
      * Add more tests
      
      * Add documentation on behavior with TapGestureRecognizer and DragGestureRecognizer
      
      * more docs
      
      * more docs
      
      * remove comments
      
      * updates
      
      * fix multiple pointer behavior
      
      * only handle the primary pointer
      
      * Clean up dangerous assumptions in gesture details objects
      
      * forgot from rebase
      
      * update docs
      
      * updates
      
      * Clean up some redundant code
      
      * remove whitespace
      
      * fix tests as a result of #115849
      
      * update test docs
      
      * Fix same test from last commit for material variants
      
      * More clean up of redundant code and update docs
      
      * Clean up didStopTrackingLastPointer and untie TapAndDragGestureRecognizer cancel behavior from TapStatusTrackerMixin.currentUp state
      
      * untie pastTapTolerance
      
      * updates
      
      * Add slopTolerance
      
      * update docs
      
      * Have secondary tap handled by TapGestureRecognizer
      
      * update docs
      
      * fix analyzer and address comments
      
      * Add more docs
      
      * Update cancel behavior tol not call on tap cancel when a drag has been accepted
      
      * Change cancel behavior to only cancel if the tap down callback has been sent and merge tapcancel and dragcancel
      
      * update docs;
      
      * Rename selection_gestures to tap_and_drag_gestures
      
      * Address some reviewer comments
      
      * make deadline and slopTolerance private
      
      * updates
      
      * updates
      
      * Address review comments
      
      * remove _initialButtons
      
      * fix docs
      
      * trackTrap -> trackTap
      
      * fix analyzer
      
      * Add test to verify that tap up is called when recognizer accepts before handleEvent is called
      
      * implement Diagnosticable for Details objects;
      
      * sentTapDown == wonArenaForPrimaryPointer, so the implementation now only uses sentTapDown
      
      * Count user tap up immediately and do not wait to win the arena
      
      * Do not need to call super from TapAndDragGestureRecognizer.acceptGesture anymore because mixin implementation is gone
      
      * Do not start selection drag on Android, iOS, and Fuchshsia touch devices if renderEditable does not have focus, this fixes many scubas
      
      * Address reviewer comments
      
      * fix test
      
      * TapAndDragGestureRecognizer should wait for other recognizer to lose before winning the arena
      
      * Address review comments
      
      * Dont check for drag if the start was already found
      
      * Only check for a drag if it has not already been found"
      
      * fix from rebase
      Co-authored-by: 's avatarRenzo Olivares <roliv@google.com>
      cd0f15a7
  8. 09 Dec, 2022 1 commit
  9. 28 Oct, 2022 1 commit
    • Justin McCandless's avatar
      Context Menus (#107193) · 0b451b6d
      Justin McCandless authored
      * Can show context menus anywhere in the app, not just on text.
      * Unifies all desktop/mobile context menus to go through one class (ContextMenuController).
      * All context menus are now just plain widgets that can be fully customized.
      * Existing default context menus can be customized and reused.
      0b451b6d
  10. 05 Oct, 2022 1 commit
  11. 07 Sep, 2022 1 commit
  12. 10 Aug, 2022 2 commits
  13. 02 Aug, 2022 1 commit
  14. 26 Jul, 2022 1 commit
  15. 06 Jul, 2022 1 commit
  16. 25 May, 2022 1 commit
  17. 15 Apr, 2022 1 commit
  18. 14 Apr, 2022 2 commits
  19. 13 Apr, 2022 1 commit
  20. 03 Dec, 2021 1 commit
  21. 01 Dec, 2021 1 commit
  22. 25 Oct, 2021 1 commit
  23. 20 Sep, 2021 1 commit
  24. 15 Sep, 2021 1 commit
    • Pierre-Louis's avatar
      Add `semanticsLabel` to `SelectableText` (#89369) · b129fffa
      Pierre-Louis authored
      * add `semanticsLabel` to `SelectableText`
      
      * remove unused vars
      
      * Squashed commit of the following:
      
      commit 3e687a9f
      Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
      Date:   Tue Sep 14 17:42:05 2021 -0400
      
          Roll Plugins from 4a98e239b131 to b85edebe7134 (2 revisions) (#90083)
      
      commit ad936b4e
      Author: Christopher Fujino <christopherfujino@gmail.com>
      Date:   Tue Sep 14 14:39:17 2021 -0700
      
          [flutter_conductor] Support initial stable release version (#89775)
      
      commit ff5dd54c
      Author: Ian Hickson <ian@hixie.ch>
      Date:   Tue Sep 14 13:02:04 2021 -0700
      
          Mention the ToS on our README (#89765)
      
      commit 8587b609
      Author: Kate Lovett <katelovett@google.com>
      Date:   Tue Sep 14 14:53:33 2021 -0500
      
          Update local gold api (#90072)
      
      commit 7d368dcf
      Author: Justin McCandless <jmccandless@google.com>
      Date:   Tue Sep 14 12:39:19 2021 -0700
      
          InteractiveViewer with a child of zero size (#90012)
      
          Asserts that the InteractiveViewer child can't have zero size.
      
      commit 2b4ef184
      Author: Akira Aratani <developer.a.akira@gmail.com>
      Date:   Wed Sep 15 03:30:50 2021 +0900
      
          Fix document of the switch. (#89641)
      
      commit a2cd16ba
      Author: Christopher Fujino <christopherfujino@gmail.com>
      Date:   Tue Sep 14 11:22:02 2021 -0700
      
          use test logger, which does not allow colors (#90010)
      
      commit 0f0613c0
      Author: Varun Sharma <varunsh@stepsecurity.io>
      Date:   Tue Sep 14 11:17:03 2021 -0700
      
          Add specific permissions to .github/workflows/lock.yaml (#89820)
      
      commit 2866f79c
      Author: Jason Simmons <jason-simmons@users.noreply.github.com>
      Date:   Tue Sep 14 10:46:35 2021 -0700
      
          Initialize all bindings before starting the text_editing_action_target test suite (#90067)
      
          Fixes https://github.com/flutter/flutter/issues/90057
      
      commit b8899159
      Author: Michael Thomsen <mit@google.com>
      Date:   Tue Sep 14 14:08:36 2021 +0200
      
          Change min Dart SDK constraint to track actual version (#88743)
      
      commit 3b7adb98
      Author: godofredoc <54371434+godofredoc@users.noreply.github.com>
      Date:   Mon Sep 13 21:32:04 2021 -0700
      
          Lock only issues. (#90023)
      
      commit 528f77dc
      Author: Dan Field <dnfield@google.com>
      Date:   Mon Sep 13 19:10:15 2021 -0700
      
          Opacity fix (#90017)
      
          * Make sure Opacity widgets/layers do not drop the offset
      
      commit 2470f63e
      Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
      Date:   Mon Sep 13 22:07:02 2021 -0400
      
          4a98e239b [flutter_plugin_tools] Make no unit tests fatal for iOS/macOS (flutter/plugins#4341) (#90016)
      
      commit a01e4733
      Author: stuartmorgan <stuartmorgan@google.com>
      Date:   Mon Sep 13 20:57:05 2021 -0400
      
          Re-enable plugin analysis test (#89856)
      
      commit cdad35f2
      Author: Aneesh Rao <sidrao2006@gmail.com>
      Date:   Tue Sep 14 05:17:04 2021 +0530
      
          Fix path in example (#84707)
      
      commit 576aab08
      Author: Christopher Fujino <christopherfujino@gmail.com>
      Date:   Mon Sep 13 15:47:03 2021 -0700
      
          add analysis_options.yaml to dev/conductor (#90005)
      
      commit fad5e4cf
      Author: Jason Simmons <jason-simmons@users.noreply.github.com>
      Date:   Mon Sep 13 13:37:07 2021 -0700
      
          Remove a redundant test case in the flutter_tools create_test (#89872)
      
      commit 738430ca
      Author: Darren Austin <darrenaustin@google.com>
      Date:   Mon Sep 13 13:33:48 2021 -0700
      
          Revert "Removed default page transitions for desktop and web platforms. (#82596)" (#89997)
      
          This reverts commit 43e31977
      
      commit 9db9256b
      Author: Dan Field <dnfield@google.com>
      Date:   Mon Sep 13 13:15:19 2021 -0700
      
          Revert "Make sure Opacity widgets/layers do not drop the offset (#89264)" (#89999)
      
          This reverts commit 0d0f7a4f.
      
      commit 00f78cf2
      Author: keyonghan <54558023+keyonghan@users.noreply.github.com>
      Date:   Mon Sep 13 13:04:01 2021 -0700
      
          renew cirrus key (#89988)
      
      commit 826da7f8
      Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
      Date:   Mon Sep 13 15:52:03 2021 -0400
      
          cfc8a20a1 renew cirrus key (flutter/plugins#4340) (#89996)
      
      commit cd112e55
      Author: Anna Gringauze <annagrin@google.com>
      Date:   Mon Sep 13 12:13:42 2021 -0700
      
          Update all packages (#89797)
      b129fffa
  25. 05 Sep, 2021 1 commit
  26. 01 Jul, 2021 1 commit
  27. 28 Jun, 2021 1 commit
  28. 21 May, 2021 1 commit
  29. 19 May, 2021 1 commit
  30. 10 May, 2021 1 commit
  31. 21 Apr, 2021 1 commit
  32. 31 Mar, 2021 1 commit
  33. 25 Mar, 2021 1 commit
  34. 12 Mar, 2021 2 commits
  35. 02 Mar, 2021 1 commit
  36. 23 Feb, 2021 1 commit