- 28 Feb, 2024 1 commit
-
-
Qun Cheng authored
-
- 27 Feb, 2024 2 commits
-
-
auto-submit[bot] authored
Reverts "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (#144001)" (#144262) Reverts flutter/flutter#144001 Initiated by: Piinks Reason for reverting: Failing goldens at the tip of tree Original PR Author: QuncCccccc Reviewed By: {HansMuller} This change reverts the following previous change: Original Description: Reverts flutter/flutter#143973 This is a reland for #138521 with an updated g3fix(cl/605555997). Local test: cl/609608958.
-
Qun Cheng authored
Reverts flutter/flutter#143973 This is a reland for #138521 with an updated g3fix(cl/605555997). Local test: cl/609608958.
-
- 22 Feb, 2024 1 commit
-
-
Qun Cheng authored
Reverts flutter/flutter#138521
-
- 20 Feb, 2024 1 commit
-
-
Qun Cheng authored
This PR is to introduce 19 new color roles and deprecate 3 color roles in `ColorScheme`. **Tone-based surface colors** (7 colors): * surfaceBright * surfaceDim * surfaceContainer * surfaceContainerLowest * surfaceContainerLow * surfaceContainerHigh * surfaceContainerHighest **Accent color add-ons** (12 colors): * primary/secondary/tertiary-Fixed * primary/secondary/tertiary-FixedDim * onPrimary/onSecondary/onTertiary-Fixed * onPrimary/onSecondary/onTertiary-FixedVariant **Deprecated colors**: * background -> replaced with surface * onBackground -> replaced with onSurface * surfaceVariant -> replaced with surfaceContainerHighest Please checkout this [design doc](https://docs.google.com/document/d/1ODqivpM_6c490T4j5XIiWCDKo5YqHy78YEFqDm4S8h4/edit?usp=sharing) for more information:) ![Screenshot 2024-01-08 at 4 56 51â¯PM](https://github.com/flutter/flutter/assets/36861262/353cdb4c-6ba9-4435-a518-fd3f67e415f0)
-
- 24 Jan, 2024 1 commit
-
-
Jesús S Guerrero authored
Revert "[web] - Fix broken `TextField` in semantics mode when it's a sibling of `Navigator`" (#142129) Reverts flutter/flutter#138446 b/322136071
-
- 22 Jan, 2024 1 commit
-
-
Hassan Toor authored
When a `TextField` is rendered before a `Navigator`, it breaks in semantics mode. This is because the framework generates the incorrect semantics tree (excludes the TextField) and when that tree gets sent to the engine, we don't get the signal to create the corresponding `<input>` element. This happens for a few reasons: * `ModalBarrier` uses `BlockSemantics` to drop the semantics of routes beneath the current route in `Navigator` * `ModalBarrier` mistakenly recognizes the widget outside of the `Navigator` to be its sibling * So we end up dropping the semantics node of the `TextField` rendered before it. The fix is to let `Navigator` generate a semantics node so that `ModalBarrier` doesn't mistakenly think widgets outside of `Navigator` are its siblings. `Navigator` doesn't currently do this, which causes all the nodes generated from its widget subtree to be directly attached to the parent semantics node above `Navigator` - since this is also the parent of `TextField`, it considers them siblings. Fixes https://github.com/flutter/flutter/issues/129324
-
- 19 Jan, 2024 1 commit
-
-
Qun Cheng authored
-
- 15 Dec, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 03 Nov, 2023 1 commit
-
-
Michael Goderbauer authored
Fixes https://github.com/flutter/flutter/issues/137424. The generic type argument was unused.
-
- 26 Oct, 2023 1 commit
-
-
Kostia Sokolovskyi authored
-
- 09 Oct, 2023 1 commit
-
-
Bruno Leroux authored
This PR updates unit tests from bottom sheet tests for M3 migration. More info in https://github.com/flutter/flutter/issues/127064 It also contains in bottom_sheet.dart where a default value took precedence over a theme attribute.
-
- 13 Sep, 2023 1 commit
-
-
hangyu authored
-
- 11 Sep, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 29 Aug, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 25 Jul, 2023 1 commit
-
-
Alex Li authored
Adding the `scrollControlDisabledMaxHeightRatio` parameter for modal bottom sheet widgets, and using the default value `9.0 / 16.0` to avoid breaking. Resolves #129690.
-
- 13 Jun, 2023 1 commit
-
-
Qun Cheng authored
Updates most of the unit tests in the packages/flutter/test/material folder so that they'll pass if ThemeData.useMaterial3 defaults to true. All of the tests have wired useMaterial3 to false and will need to be updated with a M3 version. related to #127064
-
- 09 Jun, 2023 1 commit
-
-
Taha Tesser authored
fixes https://github.com/flutter/flutter/issues/128465
-
- 31 May, 2023 1 commit
-
-
Renzo Olivares authored
This fixes an issue where the bottom sheet would rebuild when `enableDrag` is set to true on every tap. This is because `DragGestureRecognizer` would win the arena by default and dispatch the `drag` callbacks (in `acceptGesture`) even though it had not met the drag threshold. This changes keep the default behavior of `DragGestureRecognizer` the same, but adds a parameter `onlyAcceptDragOnThreshold` that a user can use to stop drag callbacks from being fired when the drag threshold has not been met. Fixes #126833
-
- 23 May, 2023 1 commit
-
-
NikolajHarderNota authored
Adds barrierLabel as optional param in showModalBottomSheet Fixes #83180
-
- 27 Apr, 2023 1 commit
-
-
Pierre-Louis authored
This PR constrains M3 bottom sheets to 640dp max width by default. `constraints` can be used to provide different `minWidth` and `maxWidth`. This is not a breaking change per the breaking change policy. Part of https://github.com/flutter/flutter/issues/118619 Part of https://github.com/flutter/flutter/issues/111448 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
- 19 Mar, 2023 1 commit
-
-
hangyu authored
* M3 bottomsheet * Update bottom_sheet.dart * Update bottom_sheet.dart * Update bottom_sheet.dart * Update bottom_sheet.dart * Update bottom_sheet.dart * Update bottom_sheet.dart * Update bottom_sheet.dart * Update bottom_sheet.dart * Update bottom_sheet.dart * Update bottom_sheet.dart * Update packages/flutter/lib/src/material/bottom_sheet.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * Update packages/flutter/lib/src/material/bottom_sheet.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * Update packages/flutter/lib/src/material/bottom_sheet.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * Update packages/flutter/lib/src/material/bottom_sheet.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * Update packages/flutter/lib/src/material/bottom_sheet.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * Update packages/flutter/lib/src/material/bottom_sheet.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * Update bottom_sheet.dart Update bottom_sheet_test.dart Update bottom_sheet.dart * showDragHandle defaults to false * fix test --------- Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>
-
- 08 Mar, 2023 1 commit
-
-
Chris Bobbe authored
ModalBottomSheetRoute: Remove gap at screen bottom with `useSafeArea: true`
-
- 06 Mar, 2023 1 commit
-
-
Eilidh Southren authored
* add shadowColor property * add to bottom app bar * add test * update m2/m3 diffs * reorder debug test * finalize * remove crswap * update doc comments * add m2 shadow back * add const * update docs * update docs * comment replies * make param non-null * indentation fix * doc fix
-
- 24 Feb, 2023 1 commit
-
-
Bruno Leroux authored
Remove accessibleNavigation reference from BottomSheet
-
- 11 Feb, 2023 1 commit
-
-
Casey Hillers authored
This reverts commit 0a97ef85.
-
- 08 Feb, 2023 1 commit
-
-
Eilidh Southren authored
* remove m3 shadows * fix * fix that test over there
-
- 20 Dec, 2022 1 commit
-
-
harperl-lgtm authored
* Implemented Scrim Focus for BottomSheet so that assistive technology users can focus and tap on the scrim to close the BottomSheet, which they could not do before the change . The Scrim Focus's size changes to avoid overlapping the BottomSheet.
-
- 13 Oct, 2022 1 commit
-
-
Gregor Weber authored
-
- 11 Oct, 2022 1 commit
-
-
hangyu authored
-
- 09 Aug, 2022 1 commit
-
-
xubaolin authored
-
- 19 Jul, 2022 1 commit
-
-
Bruno Leroux authored
-
- 13 May, 2022 1 commit
-
-
- 27 Apr, 2022 1 commit
-
-
Phil Quitslund authored
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 22 Mar, 2022 1 commit
-
-
xubaolin authored
-
- 08 Mar, 2022 1 commit
-
-
Andrei Diaconu authored
-
- 08 Dec, 2021 1 commit
-
-
Markus Aksli authored
-
- 01 Dec, 2021 1 commit
-
-
sanlittt authored
-
- 11 Nov, 2021 1 commit
-
-
Michael Goderbauer authored
-