- 20 Feb, 2024 1 commit
-
-
xubaolin authored
Fixes https://github.com/flutter/flutter/issues/138912 Change `ItemExtentBuilder`'s return value nullable, it should return null if asked to build an item extent with a greater index than exists.
-
- 13 Feb, 2024 1 commit
-
-
Nate authored
This PR is the 7áµÊ° step in the journey to solve issue #136139 and make the entire Flutter repo more readable. (previous pull requests: #139048, #139882, #141591, #142279, #142634, #142793) This pull request covers everything in `packages/flutter/lib/src/widgets/`. Most of it should be really straightforward, but there was some refactoring in the `getOffsetToReveal()` function in `two_dimensional_viewport.dart`. I'll add some comments to describe those changes.
-
- 08 Feb, 2024 1 commit
-
-
Michael Goderbauer authored
Fixes https://github.com/flutter/flutter/issues/141678.
-
- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the widgets library. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 13 Sep, 2023 1 commit
-
-
Kate Lovett authored
-
- 12 Sep, 2023 1 commit
-
-
Kate Lovett authored
Fixes https://github.com/flutter/flutter/issues/134142 The description for the SliverList.list example was just wrong, describing something other than the sample. ð Tweaked some of the language on the others while I was here.
-
- 07 Aug, 2023 1 commit
-
-
chunhtai authored
migration guide update https://github.com/flutter/website/pull/9124 fixes the concerns in https://github.com/flutter/flutter/pull/120619
-
- 16 Jun, 2023 1 commit
-
-
Michael Goderbauer authored
It's time to say good bye to an old friend. It has outlived its usefulness. Farewell, AbstractNode! ð«¡
-
- 08 Jun, 2023 1 commit
-
-
Tae Hyung Kim authored
This widget implements the ability to place slivers one after another in a single ScrollView in a way that all child slivers are drawn within the bounds of the group itself (i.e. SliverPersistentHeaders aren't drawn outside of the scroll extent provided by all of the child slivers). The design document for SliverMainAxisGroup can be found [here](https://docs.google.com/document/d/1e2bdLSYV_Dq2h8aHpF8mda67aOmZocPiMyjCcTTZhTg/edit?resourcekey=0-Xj2X2XA3CAFae22Sv3hAiA). Fixes https://github.com/flutter/flutter/issues/33137. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat --------- Co-authored-by:
Kate Lovett <katelovett@google.com>
-
- 28 Apr, 2023 1 commit
-
-
Tae Hyung Kim authored
This widget implements the ability to place slivers side by side in a single ScrollView so that they scroll together. The design document for `SliverCrossAxisGroup` can be found [here](https://docs.google.com/document/d/1e2bdLSYV_Dq2h8aHpF8mda67aOmZocPiMyjCcTTZhTg/edit?resourcekey=0-Xj2X2XA3CAFae22Sv3hAiA). Fixes #56756.
-
- 24 Apr, 2023 1 commit
-
-
Tae Hyung Kim authored
Reimplements what we reverted here: #125233.
-
- 20 Apr, 2023 1 commit
-
-
Tae Hyung Kim authored
Going to make some changes to the implementation so I'll revert in the meantime. Reverts flutter/flutter#124337
-
- 10 Apr, 2023 1 commit
-
-
Tae Hyung Kim authored
Sliver Constrained Cross Axis
-
- 07 Apr, 2023 1 commit
-
-
chunhtai authored
Fixes IgnorePointer and AbsorbPointer to only block user interactionsâ¦
-
- 23 Mar, 2023 1 commit
-
-
Kate Lovett authored
Clean up scrolling delegate code for 2D
-
- 22 Mar, 2023 2 commits
-
-
Michael Goderbauer authored
Remove 1745 decorative breaks
-
Ian Hickson authored
Documentation improvements
-
- 24 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes
-
- 03 Jan, 2023 1 commit
-
-
Tae Hyung Kim authored
* init * lint * add the other two slivers * fix lint * add test for sliverlist.separated * add3 more * fix lint and tests * remove trailing spaces * remove trailing spaces 2 * fix lint * fix lint again
-
- 11 Dec, 2022 1 commit
-
-
Ian Hickson authored
-
- 07 Oct, 2022 2 commits
-
-
Greg Spencer authored
-
Greg Spencer authored
-
- 27 Sep, 2022 1 commit
-
-
Jonah Williams authored
-
- 10 Aug, 2022 1 commit
-
-
Ian Hickson authored
-
- 29 Jul, 2022 1 commit
-
-
Youssef Attia authored
-
- 18 Jul, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 07 Jun, 2022 1 commit
-
-
xubaolin authored
-
- 06 Jun, 2022 1 commit
-
-
Nils Reichardt authored
-
- 26 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `widgets` * fix comments * fix comments
-
- 24 May, 2022 1 commit
-
-
chunhtai authored
* Support global selection * addressing comments * add new test * Addressing review comments * update * addressing comments * addressing comments * Addressing comments * fix build
-
- 20 May, 2022 1 commit
-
-
Casey Hillers authored
-
- 19 May, 2022 1 commit
-
-
Jonah Williams authored
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 25 Mar, 2022 1 commit
-
-
xubaolin authored
* ++ * ++ * ++ * ++ * codereview feedback * ++
-
- 21 Mar, 2022 1 commit
-
-
Pierre-Louis authored
* fix deprecated_new_in_comment_reference for `material` library in a future version of the SDK, these will be flagged, fix them now * Update pubspec.yaml
-
- 08 Feb, 2022 1 commit
-
-
Jonah Williams authored
-
- 03 Feb, 2022 1 commit
-
-
Kate Lovett authored
-
- 07 Dec, 2021 1 commit
-
-
Dan Field authored
-
- 15 Oct, 2021 1 commit
-
-
Ian Hickson authored
-
- 08 Oct, 2021 1 commit
-
-
ka_sh authored
-