- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the widgets library. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 05 Sep, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 25 Aug, 2023 1 commit
-
-
Tomasz Gucio authored
-
- 19 May, 2023 1 commit
-
-
chunhtai authored
fixes https://github.com/flutter/flutter/issues/126100
-
- 22 Mar, 2023 1 commit
-
-
Michael Goderbauer authored
Remove 1745 decorative breaks
-
- 24 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes
-
- 13 Jun, 2022 1 commit
-
-
Youssef Attia authored
-
- 26 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `widgets` * fix comments * fix comments
-
- 30 Apr, 2022 1 commit
-
-
Todd Volkert authored
-
- 29 Apr, 2022 1 commit
-
-
Taha Tesser authored
-
- 26 Apr, 2022 1 commit
-
-
Jonah Williams authored
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 22 Feb, 2022 1 commit
-
-
Tomasz Gucio authored
-
- 16 Feb, 2022 1 commit
-
-
Mateus Felipe C. C. Pinto authored
-
- 03 Feb, 2022 1 commit
-
-
Ian Hickson authored
-
- 04 Oct, 2021 1 commit
-
-
Greg Spencer authored
This does a cleanup of the examples, removing all of the "section" markers and extra comments that we don't need anymore now that the samples are no longer in the source code. It also removes the --template arguments from the {@tool dartpad} and {@tool sample} directives, since those are no longer used. It converts two examples that I discovered were still embedded into linked examples in the examples folder. I didn't delete the templates from the snippets config folder yet, because there are still embedded samples in the dart:ui package from the engine that use them. Once dart:ui no longer uses the templates, they can be removed. I bumped the version of the snippets package to pick up a change that allows removal of the --template argument.
-
- 29 Sep, 2021 1 commit
-
-
nt4f04uNd authored
-
- 28 Sep, 2021 1 commit
-
-
Greg Spencer authored
This adds a smoke test for every single API example. It also fixes 17 tests that had bugs in them, or were otherwise broken, and even fixes one actual bug in the framework, and one limitation in the framework. The bug in the framework is that NetworkImage's _loadAsync method had await response.drain<List<int>>();, but if the response is null, it will throw a cryptic exception saying that Null can't be assigned to List<int>. The fix was just to use await response.drain<void>(); instead. The limitation is that RelativePositionedTransition takes an Animation<Rect> rect parameter, and if you want to use a RectTween with it, the value emitted there is Rect?, and one of the examples was just casting from Animation<Rect> to Animation<Rect?>, which is invalid, so I modified RelativePositionedTransition to take a Rect? and just use Rect.zero if the rect is null.
-
- 25 Aug, 2021 1 commit
-
-
Greg Spencer authored
This extracts the sample code out from the API doc comments, and places them in separate files on disk, allowing running of the examples locally, testing them, and building of slightly larger examples.
-
- 15 Jul, 2021 1 commit
-
- 14 Jul, 2021 3 commits
-
-
Ian Hickson authored
-
Zachary Anderson authored
This reverts commit 31de052e.
-
Ian Hickson authored
-
- 13 Jul, 2021 2 commits
-
-
Ian Hickson authored
This reverts commit e2490f29.
-
Ian Hickson authored
-
- 02 Jun, 2021 1 commit
-
-
Anis Alibegić authored
-
- 10 May, 2021 1 commit
-
-
Michael Goderbauer authored
-
- 22 Apr, 2021 1 commit
-
- 21 Apr, 2021 1 commit
-
-
xubaolin authored
-
- 31 Mar, 2021 2 commits
-
-
Alexandre Ardhuin authored
-
Alexandre Ardhuin authored
-
- 12 Mar, 2021 1 commit
-
-
Greg Spencer authored
Update samples to use repo analysis options, Fix sample templates and a ton of analyzer issues (#77868)
-
- 09 Mar, 2021 1 commit
-
-
LongCatIsLooong authored
-
- 06 Mar, 2021 1 commit
-
-
Michael Goderbauer authored
-
- 17 Feb, 2021 1 commit
-
-
Abhishek Ghaskata authored
-
- 04 Feb, 2021 1 commit
-
-
Abhishek Ghaskata authored
-
- 30 Dec, 2020 1 commit
-
-
LongCatIsLooong authored
-
- 02 Nov, 2020 1 commit
-
-
Greg Spencer authored
-
- 31 Oct, 2020 1 commit
-
-
najeira authored
-
- 26 Oct, 2020 1 commit
-
-
Michael Goderbauer authored
-