1. 04 Oct, 2019 1 commit
  2. 02 Oct, 2019 1 commit
    • Greg Spencer's avatar
      Add an ActivateAction to controls that use InkWell. (#41220) · 4512a1c1
      Greg Spencer authored
      Adds an ActivateAction to controls that use InkWell. Make InkWell host the Focus for those controls, and add the top level binding to the ENTER key. This will make it possible to trigger a button using the enter key, and to get an ink response when the button is triggered.
      
      This is a breaking change because it moves the Focus widget into the InkWell. If you have a component that uses the InkWell directly and you used to wrap that InkWell in a Focus widget to give it its notion of focus, it will now not look for that Focus ancestor for its focus state anymore. In order to control focus on the InkWell, you need to give it a FocusNode directly, via the new focusNode parameter. This should not affect users of widgets like OutlineButton or FloatingActionButton and the like, since those have been modified in this PR.
      4512a1c1
  3. 24 Sep, 2019 1 commit
  4. 17 Sep, 2019 1 commit
  5. 16 Sep, 2019 1 commit
  6. 03 Sep, 2019 1 commit
    • Greg Spencer's avatar
      Make disabled buttons/chips/text fields not be focusable. (#38726) · 8daa165d
      Greg Spencer authored
      This changes the behavior of text fields, Material buttons, and Chips so that if they are disabled they lose focus. Before this change, it was possible to disable a control and then use focus traversal to reach it anyhow, and in the case of text fields, enter text into a disabled field.
      
      Fixes #33985
      8daa165d
  7. 23 Aug, 2019 1 commit
    • Greg Spencer's avatar
      Normalize assert checking of clipBehavior (#38568) · 365f577c
      Greg Spencer authored
      I noticed that we were pretty inconsistent with the way that we checked the value of clipBehavior in the framework, so I normalized the usages and updated docs where necessary.
      
      This is a breaking change if you used to pass null explicitly to FlatButton, OutlineButton or RaisedButton constructors, expecting to get Clip.none. It will now assert if you do that. Existing implementations that pass null implicitly by not specifying clipBehavior won't need to change their call sites. It always implicitly defaulted to Clip.none before, and it will continue to do that, it's only places where it was explicitly set to null in order to get the implicit default that it will fail.
      365f577c
  8. 15 Aug, 2019 1 commit
  9. 13 Aug, 2019 1 commit
  10. 08 Aug, 2019 1 commit
  11. 03 Aug, 2019 1 commit
  12. 25 Jun, 2019 1 commit
  13. 09 May, 2019 1 commit
  14. 01 May, 2019 1 commit
  15. 16 Mar, 2019 1 commit
  16. 01 Mar, 2019 1 commit
  17. 28 Feb, 2019 1 commit
    • Greg Spencer's avatar
      Fix spelling errors. (#28657) · ccdd5057
      Greg Spencer authored
      Fix the spelling errors in the dartdocs for the framework.
      
      There are no functionality changes here, just documentation fixes.
      ccdd5057
  18. 22 Feb, 2019 1 commit
  19. 21 Feb, 2019 1 commit
  20. 15 Feb, 2019 1 commit
    • Greg Spencer's avatar
      Remove remaining "## Sample code" segments, and fix the snippet generator. (#27793) · 262f12b4
      Greg Spencer authored
      This converts all remaining "## Sample code" segments into snippets, and fixes
      the snippet generator to handle multiple snippets in the same dartdoc block
      properly.
      
      I also generated, compiled, and ran each of the existing application samples,
      and fixed them up to be more useful and/or just run without errors.
      
      This PR fixes these problems with examples:
      
      1. Switching tabs in a snippet now works if there is more than one snippet in
         a single dartdoc block.
      2. Generation of snippet code now works if there is more than one snippet.
      3. Contrast of text and links in the code sample block has been improved to
         recommended levels.
      4. Added five new snippet templates, including a "freeform" template to make
         it possible to show examples that need to change the app instantiation.
      5. Fixed several examples to run properly, a couple by adding the "Scaffold"
         widget to the template, a couple by just fixing their code.
      6. Fixed visual look of some of the samples when they run by placing many
         samples inside of a Scaffold.
      7. In order to make it easier to run locally, changed the sample analyzer to
         remove the contents of the supplied temp directory before running, since
         having files that hang around is problematic (only a problem when running
         locally with the `--temp` argument).
      8. Added a `SampleCheckerException` class, and handle sample checking
         exceptions more gracefully.
      9. Deprecated the old "## Sample code" designation, and added enforcement for
         the deprecation.
      10. Removed unnecessary `new` from templates (although they never appeared in
         the samples thanks to dartfmt, but still).
      
      Fixes #26398
      Fixes #27411
      262f12b4
  21. 08 Feb, 2019 1 commit
    • Greg Spencer's avatar
      Adding support for logical and physical key events (#27627) · 431cfdaf
      Greg Spencer authored
      This adds support for logical and physical key information inside of RawKeyEvent. This allows developers to differentiate keys in a platform-agnostic way. They are able to tell the physical location of a key (PhysicalKeyboardKey) and a logical meaning of the key (LogicalKeyboardKey), as well as get notified of the character generated by the keypress. All of which is useful for handling keyboard shortcuts.
      
      This PR builds on the previous PR (#27620) which generated the key code mappings and definitions.
      431cfdaf
  22. 01 Feb, 2019 3 commits
  23. 29 Jan, 2019 1 commit
  24. 08 Jan, 2019 1 commit
  25. 18 Dec, 2018 2 commits
  26. 08 Nov, 2018 1 commit
  27. 23 Oct, 2018 1 commit
    • Greg Spencer's avatar
      Dartdoc snippet extension to inject full featured code snippets in to API docs. (#23281) · 65d3ddd5
      Greg Spencer authored
      This creates a custom dartdoc tool that will generate snippet blocks in our API docs that allow the user to copy easily to the clipboard, and will also embed the snippet code into a template to show it in a larger context with an app.
      
      This PR adds the snippet tool, a template, and a couple of HTML skeleton files, one for snippets that are designed to be in an application setting, and one where it simply puts a nice container around existing snippets, making them easier to copy to the clipboard.
      65d3ddd5
  28. 03 Oct, 2018 1 commit
  29. 28 Sep, 2018 1 commit
  30. 23 Sep, 2018 1 commit
  31. 13 Sep, 2018 1 commit
  32. 12 Sep, 2018 2 commits
  33. 07 Sep, 2018 1 commit
  34. 31 Aug, 2018 1 commit
  35. 02 Aug, 2018 1 commit
  36. 27 Jul, 2018 1 commit