- 20 Jul, 2023 1 commit
-
-
Bruno Leroux authored
## Description This PR adds a call to dispose the internal `MaterialStatesController` instantiated by `_SelectableIconButtonState`. I found this memory leak while working on M2/M3 test update for `about_test.dart`. This memory leak only happens when using M3 because `IconButton` relies on `_SelectableIconButton` only when useMaterial3 is true: https://github.com/flutter/flutter/blob/3a1190a5a85c3e6a0cf3a9c30f34548fdd48ac1e/packages/flutter/lib/src/material/icon_button.dart#L671-L721 ## Related Issue Fixes https://github.com/flutter/flutter/issues/130708 ## Tests Adds 1 test.
-
- 18 Jul, 2023 1 commit
-
-
Taha Tesser authored
fixes [[Material3] AppBar does not respect `foregroundColor` or `iconTheme` for leading and actions in some cases](https://github.com/flutter/flutter/issues/130485) ### Description - Fix `Colors.white` not applied in dark mode - Add regression tests - make `iconStyle` private for consistency ### Before  ### After 
-
- 09 Jun, 2023 2 commits
-
-
hangyu authored
fixes: #127145 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat --------- Co-authored-by:
Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
-
Pierre-Louis authored
## Description This improves defaults generation with logging, stats, and token validation. This PR includes these changes: * introduce `TokenLogger`, with a verbose mode * prints versions and tokens usage to the console * outputs `generated/used_tokens.csv`, a list of all used tokens, for use by Google * find token files in `data` automatically * hide tokens `Map` * tokens can be obtained using existing resolvers (e.g. `color`, `shape`), or directly through `getToken`. * tokens can be checked for existence with `tokenAvailable` * remove version from template, since the tokens are aggregated and multiple versions are possible (as is the case currently), it does not make sense to attribute a single version * improve documentation ## Related Issues - Fixes https://github.com/flutter/flutter/issues/122602 ## Tests - Added tests for `TokenLogger` - Regenerated tokens, no-op except version removal ## Future work A future PR should replace or remove the following invalid tokens usages <img width="578" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b6f9e5a7-523f-4f72-94f9-1b0bf4cc9f00">
-
- 11 May, 2023 1 commit
-
-
Qun Cheng authored
Fixes #122250. This PR is to make sure all the MaterialStateProperty defaults are able to correctly resolve different states. * When a widget is pressed, it is also hovered, so we need to put the `MaterialState.pressed` check before `MaterialState.hovered`. * When a widget is focused, the widget should still be able to be hovered, so we should check `MaterialState.hovered` before `MaterialState.focused`. * There are also cases like in _InputDecoratorDefaultsM3, the `MaterialState.disabled` should be checked before `MaterialState.error`. the order should be disabled, (error), pressed, hovered, focused.
-
- 24 Apr, 2023 1 commit
-
-
Taha Tesser authored
Fix `OutlinedButton`, `TextButton`, and `IconButton` throw exception when passing only one cursor to `styleFrom` (#125204) fixes https://github.com/flutter/flutter/issues/118071
-
- 15 Mar, 2023 1 commit
-
-
Qun Cheng authored
* Run dart command to update widget defaults * Revert the tokens and the template --------- Co-authored-by:
Qun Cheng <quncheng@google.com>
-
- 13 Mar, 2023 1 commit
-
-
Pierre-Louis authored
Update Material tokens to 0.162
-
- 04 Mar, 2023 1 commit
-
-
Qun Cheng authored
-
- 07 Feb, 2023 1 commit
-
-
Qun Cheng authored
* Update to v0.158 of the token database. * Update checkbox template * Fix DatePickerTheme test --------- Co-authored-by:
Qun Cheng <quncheng@google.com>
-
- 24 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes
-
- 17 Jan, 2023 1 commit
-
-
Darren Austin authored
-
- 03 Jan, 2023 1 commit
-
-
Darren Austin authored
* Updated to tokens v0.150. * Updated with a reverted list_tile.dart.
-
- 28 Dec, 2022 1 commit
-
-
Eilidh Southren authored
* Bottom App Bar M3 background color fix * update test * test update * remove whitespace * Update IconButton unselected focused opacity * Delete generated_plugins.cmake
-
- 28 Nov, 2022 1 commit
-
-
Darren Austin authored
-
- 15 Nov, 2022 1 commit
-
-
Darren Austin authored
-
- 24 Oct, 2022 1 commit
-
-
Darren Austin authored
-
- 19 Sep, 2022 1 commit
-
-
Qun Cheng authored
-
- 14 Sep, 2022 1 commit
-
-
Qun Cheng authored
-
- 12 Sep, 2022 1 commit
-
-
Greg Spencer authored
-
- 06 Sep, 2022 1 commit
-
-
Darren Austin authored
* Added support for surfaceTintColor and shadowColor to the Dialog widgets. * Updated the defaults for Material.shadowColor and Material.surfaceTint to allow turning off the features with a transparent color. * Added support for shadowColor and surfaceTintColor for Drawer widget.
-
- 01 Sep, 2022 1 commit
-
-
Qun Cheng authored
-
- 23 Aug, 2022 1 commit
-
- 18 Aug, 2022 1 commit
-
-
Qun Cheng authored
* Revert "Revert "Set `IconButton.visualDensity` default to `VisualDensity.standard` (#109349)" (#109421)" Co-authored-by:
Qun Cheng <quncheng@google.com>
-
- 11 Aug, 2022 2 commits
-
-
Qun Cheng authored
* Set IconButton's visualDensity to standard Co-authored-by:
Qun Cheng <quncheng@google.com>
- 10 Aug, 2022 1 commit
-
-
Ian Hickson authored
-
- 03 Aug, 2022 1 commit
-
-
Qun Cheng authored
* Created IconButtonTheme and apply it to IconButton
-
- 19 Jul, 2022 1 commit
-
-
Valentin Vignal authored
-
- 11 Jul, 2022 1 commit
-
-
Darren Austin authored
Refactor gen_defaults to support multiple generated code blocks in the same file independently. (#107278)
-
- 06 Jul, 2022 1 commit
-
-
Qun Cheng authored
-
- 15 Jun, 2022 1 commit
-
-
Darren Austin authored
-
- 10 Jun, 2022 1 commit
-
-
cedvdb authored
-
- 07 Jun, 2022 2 commits
-
-
Darren Austin authored
-
Qun Cheng authored
* Added standard IconButton for M3 with new ButtonStyle field * Added IconButton examples for standard, filled, filled_tonal, and outlined types Co-authored-by:
Qun Cheng <quncheng@google.com>
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `material` * include test/material * add back removed comments
-
- 27 Apr, 2022 1 commit
-
-
Pierre-Louis authored
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 14 Jan, 2022 1 commit
-
-
Hans Muller authored
-
- 01 Dec, 2021 1 commit
-
-
Taha Tesser authored
-