1. 21 Mar, 2022 1 commit
  2. 28 Feb, 2022 1 commit
  3. 16 Feb, 2022 1 commit
  4. 09 Feb, 2022 1 commit
  5. 21 Jan, 2022 1 commit
  6. 12 Dec, 2021 1 commit
  7. 01 Jul, 2021 1 commit
  8. 15 Apr, 2021 1 commit
  9. 14 Apr, 2021 1 commit
  10. 30 Mar, 2021 1 commit
  11. 19 Oct, 2020 1 commit
    • Greg Spencer's avatar
      Mark keys that match a shortcut, but have no action defined as "not handled". (#67359) · 8c03ff8c
      Greg Spencer authored
      - - When I added notification of key events before processing them as text, it made it so that shortcut key bindings like the spacebar would prevent spaces from being inserted into text fields, which is obviously not desirable (and so that change was reverted). At the same time, we do want to make it possible to override key events so that they can do things like intercept a tab key or arrow keys that change the focus.
      
      This PR changes the behavior of the Shortcuts widget so that if it has a shortcut defined, but no action is bound to the intent, then instead of responding that the key is "handled", it responds as if nothing handled it. This allows the engine to continue to process the key as text entry.
      
      This PR includes:
      
      - Modification of the callback type for key handlers to return a KeyEventResult instead of a bool, so that we can return more information (i.e. the extra state of "stop propagation").
      - Modification of the ActionDispatcher.invokeAction contract to require that Action.isEnabled return true before calling it. It will now assert if the action isn't enabled when invokeAction is called. This is to allow optimization of the number of calls to isEnabled, since the shortcuts widget now wants to know if the action was enabled before deciding to either handle the key or to return ignored.
      - Modification to ShortcutManager.handleKeypress to return KeyEventResult.ignored for keys which don't have an enabled action associated with them.
      - Adds an attribute to DoNothingAction that allows it to mark a key as not handled, even though it does have an action associated with it. This will allow disabling of a shortcut for a subtree.
      8c03ff8c
  12. 26 Aug, 2020 1 commit
  13. 23 Jul, 2020 1 commit
  14. 15 Jul, 2020 1 commit
  15. 11 Jun, 2020 1 commit
  16. 07 Apr, 2020 1 commit
    • Greg Spencer's avatar
      Revise Action API (#42940) · 0f68b46f
      Greg Spencer authored
      This updates the Action API in accordance with the design doc for the changes: flutter.dev/go/actions-and-shortcuts-design-revision
      
      Fixes #53276
      0f68b46f
  17. 10 Mar, 2020 1 commit
  18. 20 Feb, 2020 1 commit
  19. 07 Jan, 2020 1 commit
  20. 27 Nov, 2019 1 commit
    • Ian Hickson's avatar
      License update (#45373) · 449f4a66
      Ian Hickson authored
      * Update project.pbxproj files to say Flutter rather than Chromium
      
      Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
      
      * Update the copyright notice checker to require a standard notice on all files
      
      * Update copyrights on Dart files. (This was a mechanical commit.)
      
      * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
      
      Some were already marked "The Flutter Authors", not clear why. Their
      dates have been normalized. Some were missing the blank line after the
      license. Some were randomly different in trivial ways for no apparent
      reason (e.g. missing the trailing period).
      
      * Clean up the copyrights in non-Dart files. (Manual edits.)
      
      Also, make sure templates don't have copyrights.
      
      * Fix some more ORGANIZATIONNAMEs
      449f4a66
  21. 28 Oct, 2019 1 commit
  22. 01 May, 2019 1 commit
  23. 04 Apr, 2019 1 commit
  24. 20 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      some spaces formatting (#29452) · a6af4228
      Alexandre Ardhuin authored
      * some space formattings
      
      * always use blocks in if-else if a block is used
      
      * format spaces in for and while
      
      * allow multiline if conditions
      
      * fix missing space
      a6af4228
  25. 01 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      Add missing trailing commas (#28673) · 387f8854
      Alexandre Ardhuin authored
      * add trailing commas on list/map/parameters
      
      * add trailing commas on Invocation with nb of arg>1
      
      * add commas for widget containing widgets
      
      * add trailing commas if instantiation contains trailing comma
      
      * revert bad change
      387f8854
  26. 30 Jan, 2019 1 commit
  27. 10 Jan, 2019 1 commit
  28. 18 Dec, 2018 1 commit
  29. 30 Oct, 2018 1 commit
    • Ian Hickson's avatar
      Allow ChangeNotifier to be mixed in again (#23631) · c319b890
      Ian Hickson authored
      Luckily this class didn't actually need to extend its superclass, it
      only implements the interface. So we can change `extends` to
      `implements` and that's close enough, while allowing the class to be
      mixed in again.
      c319b890
  30. 27 Oct, 2018 1 commit
  31. 12 Sep, 2018 1 commit
  32. 01 Mar, 2018 1 commit
  33. 19 Jan, 2018 1 commit
  34. 17 Nov, 2017 1 commit
    • Greg Spencer's avatar
      Fix spelling errors in all the dartdocs. (#13061) · 0259be90
      Greg Spencer authored
      I got tired of drive-by spelling fixes, so I figured I'd just take care of them all at once.
      
      This only corrects errors in the dartdocs, not regular comments, and I skipped any sample code in the dartdocs. It doesn't touch any identifiers in the dartdocs either. No code changes, just comments.
      0259be90
  35. 21 Sep, 2017 1 commit
  36. 03 Aug, 2017 1 commit
  37. 21 Jun, 2017 3 commits
  38. 09 Jun, 2017 1 commit