- 22 Oct, 2015 1 commit
-
-
Adam Barth authored
Now you don't need to pass the navigator around everywhere.
-
- 21 Oct, 2015 1 commit
-
-
Hixie authored
Assert at build time that PageRoute route builders do not return null widget trees. Also very minor new code comments and code reorg to help make the heroes patch easier to review. (These are changes that are unrelated to Heroes but that were part of the Heroes patch.)
-
- 20 Oct, 2015 1 commit
-
-
Adam Barth authored
-
- 16 Oct, 2015 1 commit
-
-
Hixie authored
(These are all the debugging-related fixes and trivial typo fixes that I extracted out of my heroes branch.) Fix rendering.dart import order. Introduce a debugLabel for Performances so that when you create a performance, you can tag it so that if later you print it out, you can figure out which performance it is. Allow the progress of a PerformanceView to be determined (but not set). Allow subclasses of PerformanceView that are constants to be created by defining a constant constructor for PerformanceView. Introduce a debugPrint() method that throttles its output. This is a test to see if it resolves the problems people have been having with debugDumpRenderTree() et al having their output corrupted on Android. It turns out (according to some things I read On The Internets) that Android only has a 64KB kernel buffer for its logs and and if you output to it too fast, it'll drop data on the floor. If this does in fact reliably resolve this problem, we should probably move the fix over to C++ land (where "print" is implemented) so that any use of print is handled (avoiding the interleaving problem we have now if you use both debugPrint() and print()). Fix a bug with the debugging code for "size". In the specific case of a RenderBox having a parent that doesn't set parentUsesSize, then later the parent setting parentUsesSize but the child having its layout short-circuited (e.g. because the constraints didn't change), we didn't update the _DebugSize object to know that now it's ok that the size be used by the parent, and we'd assert. Also, allow a _DebugSize to be used to set the size of yourself. Previously you could only set your size from a regular Size or from your child's _DebugSize. Add more debugging information to various Widgets where it might be helpful. Make GlobalKey's toString() include the runtimeType so that when subclassing it the new class doesn't claim to be a GlobalKey instance. Include the Widget's key in the Element's description since we don't include it in the detailed description normally (it's in the name part). Fix a test that was returning null from a route.
-
- 12 Oct, 2015 1 commit
-
-
Hixie authored
Add type annotations in many places. Fix some identifiers to have more lint-satisfying names. Make all operator==s consistent in style. Reorder some functions for consistency. Make ParentData no longer dynamic, and fix all the code around that.
-
- 10 Oct, 2015 1 commit
-
-
Adam Barth authored
-
- 09 Oct, 2015 2 commits
-
-
Adam Barth authored
-
Adam Barth authored
These are now part of material.dart.
-
- 08 Oct, 2015 2 commits
-
-
Hixie authored
-
Adam Barth authored
Now with more clear ownership over the Performance.
-
- 05 Oct, 2015 4 commits
-
-
Hixie authored
(These are changes cherry-picked from in-flight branches since they are more independent and could be helpful even without those changes.) - Change RouteBuilder's signature to take a single argument in which the other fields are placed, so that we can keep iterating on those arguments without having to break compatibility each time. Also, this makes defining route builders much simpler (only one argument to ignore rather than a variable number). - Expose the next performance to RouteBuilders, since sometimes the route itself might not be where it's used. - Allow BuildContext to be used to walk children, just like it can for ancestors - Allow BuildContext to be used to get the Widget of the current BuildContext - Allow StatefulComponentElement to be referenced with a type specialisation so that you don't have to cast when you know what the type you're dealing with actually is.
-
Hixie authored
Ensure that if a route's performance is dismissed before the route is popped, that we pop the route.
-
Adam Barth authored
Fixes #1170
-
Adam Barth authored
This patch converts drawer to using the "openDialog" pattern for managing its state. Currently, the drawer entrance and exit animation aren't integrated with the navigator's animation system because the drawer's animations can be stopped and reversed, which the navigator can't yet understand. That means dismissing the drawer via the system back button causes the drawer to be removed instanteously. Fixes #715 Fixes #1187
-
- 02 Oct, 2015 1 commit
-
-
Adam Barth authored
This widget is used in Material and Drawer. We don't currently support animating towards null, but we can add that in a future patch.
-
- 01 Oct, 2015 2 commits
-
-
Hixie authored
...for consistency with the other Route subclasses: ``` dialog.dart: class DialogRoute extends Route drag_target.dart: class DragRoute extends Route navigator.dart: class PageRoute extends Route navigator.dart: class StateRoute extends Route popup_menu.dart: class MenuRoute extends Route ```
-
Adam Barth authored
-
- 18 Sep, 2015 2 commits
-
-
Hixie authored
This fixes #1103.
-
Adam Barth authored
Also, introduce Colors and Typography to hold the material colors and the typography declarations. Previously we expected clients of these libraries to import them into a namespace, but that doesn't play nice with re-exporting them from material.dart.
-
- 17 Sep, 2015 1 commit
-
-
Adam Barth authored
This patch is part of a sequence of patches towards fewer top-level libraries. In this patch, the gesture libraries are combined into one gestures.dart library.
-
- 16 Sep, 2015 2 commits
-
-
Adam Barth authored
-
Adam Barth authored
This fixes an issue in the stocks app in horizontal mode where you could both scroll and drag the drawer at the same time.
-
- 08 Sep, 2015 1 commit
-
-
Adam Barth authored
Move the animation libraries into src/animation and change importers to use package:sky/animation.dart. Also, move scheduler.dart into the animation library so that the animation library can be self-contained.
-
- 02 Sep, 2015 1 commit
-
-
Adam Barth authored
Code outside of package:sky should import this code using package:sky/rendering.dart package:sky/widgets.dart Moving this code into the "src" directory is a convention that signifies that and it cleans up the generated dartdoc because the libraries in the src directory aren't included in the generated documentation. Instead, the classes are documented in the widgets.dart and rendering.dart libraries.
-
- 28 Aug, 2015 2 commits
-
-
Hixie authored
Stop exporting framework.dart from basic.dart, since we now have widgets.dart exporting all of framework.dart.
-
Adam Barth authored
We're now using it at the widget layer for everything except scrolling and flinging.
-
- 22 Aug, 2015 1 commit
-
-
Adam Barth authored
-
- 21 Aug, 2015 1 commit
-
-
Adam Barth authored
Block -> BlockBody ScrollableBlock -> Block FixedHeightScrollable -> ScrollableWidgetList VariableHeightScrollable -> ScrollableMixedWidgetList BlockViewport -> MixedViewport
-
- 20 Aug, 2015 1 commit
-
-
Hans Muller authored
-
- 13 Aug, 2015 1 commit
-
-
Matt Perry authored
1. We would assert if you tried to start an animation from within an animation status callback. This is a common pattern, so I fixed this assert (in Ticker._tick). 2. We would assert for animations with duration under a millisecond. Fixed. Also removed the workarounds assocated with #1.
-
- 10 Aug, 2015 1 commit
-
-
Matt Perry authored
Just infer it from the sign of the velocity. That's what odeon does.
-
- 06 Aug, 2015 1 commit
-
-
Matt Perry authored
We only use them for the transition to dismissed.
-
- 04 Aug, 2015 1 commit
-
-
James Robinson authored
This introduces the notion of event disposition and allows event targets (widgets and render objects) to consume events that should not be processed further. This is needed by the Switch component in the Drawer in the stocks example. The Switch is embedded in a DrawerItem. The Switch handles the gesture tap event to toggle its state and should handle pointer events to allow swiping and draw its own radial reaction. The DrawerItem also handles gesture taps to allow toggling the switch value when tapping anywhere on the drawer and to draw its own ink splash. When tapping on the switch, both the switch's render object and the DrawerItem's listener are in the event dispatch path. The Switch needs to signal in some fashion that it consumed the event so the DrawerItem does not also try to toggle the switch's state.
-
- 03 Aug, 2015 2 commits
-
-
Matt Perry authored
* Intentions => Behaviors * SlideIn => SlideTransition * FadeIn => FadeTransition * removed unused AnimatedContainer intentions
-
Adam Barth authored
- Center the labels on the tabs - Make the drawer's mask visible
-
- 02 Aug, 2015 1 commit
-
-
Adam Barth authored
-
- 31 Jul, 2015 1 commit
-
-
Matt Perry authored
Use those in SnackBar, Drawer, navigator instead of AnimatedContainer's intentions.
-
- 30 Jul, 2015 2 commits
-
-
Adam Barth authored
We ended up with a bunch of different scrollable widgets and it was confusing. This CL moves them all into one library to make them easier to find.
-
Matt Perry authored
This required some changes to AnimationPerformance to better understand animating with forces.
-
- 28 Jul, 2015 1 commit
-
-
Matt Perry authored
SnackBar, and PopupMenu instead of custom statuses.
-