Commits · f5b0f0a2b62f464e444762990932122d99e39a3c · abdullh.alsoleman / Front-End

19 Apr, 2023 20 commits

Report web compiler used with `buildEventSettings` (#125092) · f5b0f0a2
Kevin Moore authored Apr 19, 2023
```
Fixes https://github.com/flutter/flutter/issues/125085
```
f5b0f0a2
[flutter_tools] bump min sdk version from 3.0.0-0 to 3.0.0 (#125158) · c74cf4ba
Andrew Kolos authored Apr 19, 2023
```
Allows use of APIs such as `Iterable.firstOrNull`.
```
c74cf4ba
[flutter_tools] add todo for userMessages (#125156) · fa43a93b
Andrew Kolos authored Apr 19, 2023
```
Adds `todo` link in code for #125155.
```
fa43a93b
fix DropdownMenu crash when resize window during menu showing (#124855) · 73f7945b
xubaolin authored Apr 19, 2023

73f7945b

Roll Flutter Engine from 0a53cf6f7a4e to d726345bf230 (2 revisions) (#125157) · ea34f7df

engine-flutter-autoroll authored Apr 19, 2023

https://github.com/flutter/engine/compare/0a53cf6f7a4e...d726345bf230

2023-04-19 bdero@google.com [Impeller] Comprehensively label snapshots (flutter/engine#41325)
2023-04-19 bdero@google.com [Impeller] Fix transform regressions for chained filters (flutter/engine#41332)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ea34f7df

Use term wireless instead of network (#124232) · 48bb3c0b

Victoria Ashworth authored Apr 19, 2023

Rename variables, update comments, etc from `network` to `wireless` to keep it more uniform.

Also, move non-overriden messages related to device selection into the file they're used.

Part 7 in breakdown of https://github.com/flutter/flutter/pull/121262.

48bb3c0b

Revert selectable update back to be a postframecallback or microtask (#125140) · 14e191fa

chunhtai authored Apr 19, 2023

The regression was caused by the previous pr https://github.com/flutter/flutter/pull/124624 changes postframecallback to scheduleframecallback. The reason is that if a new postframecallback was scheduled when running a postframecallback. The newly added postframecallback will be execute on the next frame. However, adding postframecallback will not schedule a new frame. So if there isn't other widget that schedule a new frame, the newly added postframecallback will never gets run.

After changing to scheduleframecallback, it causes an issue that transient callback may be called when rendering tree contains dirty layout information that are waiting to be rebuilt.

Therefore, I use microtask to get around of the postframecallback issue instead of scheduleframecallback.

fixes https://github.com/flutter/flutter/issues/125065

14e191fa

Roll Packages from faf53fb3998c to 88591becfb3f (6 revisions) (#125153) · 898767f9

engine-flutter-autoroll authored Apr 19, 2023

https://github.com/flutter/packages/compare/faf53fb3998c...88591becfb3f

2023-04-19 engine-flutter-autoroll@skia.org Roll Flutter from 42fb0b23 to 3476b966 (20 revisions) (flutter/packages#3760)
2023-04-19 49699333+dependabot[bot]@users.noreply.github.com Bump cirrusci/flutter from `794fbbc` to `d99b1ba` in /.ci (flutter/packages#3724)
2023-04-18 10687576+bparrishMines@users.noreply.github.com [webview_flutter] Adds support to listen to url changes (flutter/packages#3313)
2023-04-18 engine-flutter-autoroll@skia.org Roll Flutter from 15cb1f84 to 42fb0b23 (19 revisions) (flutter/packages#3756)
2023-04-18 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump com.android.tools.build:gradle from 7.2.2 to 8.0.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#3739)
2023-04-18 stuartmorgan@google.com [local_auth] Convert Android to Pigeon (flutter/packages#3748)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

898767f9

Roll Flutter Engine from d626f16cb9a3 to 0a53cf6f7a4e (1 revision) (#125152) · 481ac3ce

engine-flutter-autoroll authored Apr 19, 2023

https://github.com/flutter/engine/compare/d626f16cb9a3...0a53cf6f7a4e

2023-04-19 chinmaygarde@google.com [Impeller] Make //impeller/display_list TU naming consistent. (flutter/engine#41174)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

481ac3ce

[reland] Update helper message for `--suppress-analytics` (#125145) · ca3a900d

Elias Yishak authored Apr 19, 2023

Relanding: https://github.com/flutter/flutter/pull/124810

Fixes: https://github.com/flutter/flutter/issues/124808

ca3a900d

Dismiss the docked search view when the window size is changed (#125071) · 4c6929d4
Qun Cheng authored Apr 19, 2023

4c6929d4

Roll Flutter Engine from 609f9d536494 to d626f16cb9a3 (9 revisions) (#125150) · 44738995

engine-flutter-autoroll authored Apr 19, 2023

https://github.com/flutter/engine/compare/609f9d536494...d626f16cb9a3

2023-04-19 mdebbar@google.com [web] Remove non-ShadowDom mode (flutter/engine#39915)
2023-04-19 30870216+gaaclarke@users.noreply.github.com [impeller] added moltenvk notice (flutter/engine#41317)
2023-04-19 skia-flutter-autoroll@skia.org Roll Skia from 8af1dd9659f0 to ad90b6bd4760 (3 revisions) (flutter/engine#41337)
2023-04-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 27e71f19c144 to fe8bb0565a30 (2 revisions) (flutter/engine#41336)
2023-04-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from yD5a3QBJHUFM4nVou... to suSuT9F8zuP-pBg-E... (flutter/engine#41334)
2023-04-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Cy5LG4U2InaFLkJGz... to Tun7i4VLz6ncx8JJJ... (flutter/engine#41331)
2023-04-19 skia-flutter-autoroll@skia.org Roll Skia from 85d9e67653b1 to 8af1dd9659f0 (1 revision) (flutter/engine#41333)
2023-04-19 skia-flutter-autoroll@skia.org Roll Skia from 5a718d9e9c06 to 85d9e67653b1 (4 revisions) (flutter/engine#41330)
2023-04-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 1f224df52bee to 27e71f19c144 (3 revisions) (flutter/engine#41329)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Cy5LG4U2InaF to Tun7i4VLz6nc
fuchsia/sdk/core/mac-amd64 from yD5a3QBJHUFM to suSuT9F8zuP-

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

44738995

Refactor Flutter Gradle Plugin so it can be applied using the declarative... · 51251f2e

Bartek Pacia authored Apr 19, 2023

Refactor Flutter Gradle Plugin so it can be applied using the declarative `plugins {}` block (#123511)

This PR aims to resolve #121552.

Resources used:
- [Developing Plugins](https://docs.gradle.org/current/userguide/custom_plugins.html)
- [Using Gradle Plugins](https://docs.gradle.org/current/userguide/plugins.html#sec:plugins_block)
- [Composite Builds Plugin Development Sample](https://docs.gradle.org/current/samples/sample_composite_builds_plugin_development.html)

This PR also paves way for #121541, because apps will no longer have:

```groovy
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"
```

hardcoded. Instead, they'll use:

```groovy
plugins {
    // ...
    id "dev.flutter.flutter-gradle-plugin" // the exact name is tentative
}
```

51251f2e

fix SliverReorderableList test to use correct custom action id (#125144) · 122dacfa

chunhtai authored Apr 19, 2023

as title

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

122dacfa

Revert "Update helper message for `--suppress-analytics`" (#125141) · 03d72562
godofredoc authored Apr 19, 2023
```
Reverts flutter/flutter#124810
```
03d72562
Update helper message for `--suppress-analytics` (#124810) · 3476b966
Elias Yishak authored Apr 19, 2023
```
Fixes: https://github.com/flutter/flutter/issues/124808
```
3476b966

Roll Flutter Engine from 8b7cdb02f7f3 to 609f9d536494 (1 revision) (#125097) · 59230759

engine-flutter-autoroll authored Apr 19, 2023

https://github.com/flutter/engine/compare/8b7cdb02f7f3...609f9d536494

2023-04-19 bdero@google.com [Impeller] Add buffer-to-texture blit capability check; fix GL+VK playgrounds on macOS (flutter/engine#41320)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

59230759

Roll Flutter Engine from 099ed6c62d04 to 8b7cdb02f7f3 (6 revisions) (#125094) · ade9487d

engine-flutter-autoroll authored Apr 19, 2023

https://github.com/flutter/engine/compare/099ed6c62d04...8b7cdb02f7f3

2023-04-19 aam@google.com Roll dart, zlib, emscripten, tweak license script for rolled zlib (flutter/engine#41299)
2023-04-19 skia-flutter-autoroll@skia.org Roll Skia from 84630c3c18b2 to 5a718d9e9c06 (3 revisions) (flutter/engine#41318)
2023-04-19 bdero@google.com [Impeller] Provide an opaque interface for color sources in Aiks (flutter/engine#41315)
2023-04-18 yjbanov@google.com [web:canvaskit] remove unnecessary instrumentation from picture (flutter/engine#41313)
2023-04-18 skia-flutter-autoroll@skia.org Roll Skia from 476ee3fd54cc to 84630c3c18b2 (5 revisions) (flutter/engine#41316)
2023-04-18 godofredoc@google.com Double zip FlutterMacOS.framework.zip. (flutter/engine#41306)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ade9487d

Roll Flutter Engine from 5fcc7b719029 to 099ed6c62d04 (3 revisions) (#125078) · d9392f2e

engine-flutter-autoroll authored Apr 19, 2023

https://github.com/flutter/engine/compare/5fcc7b719029...099ed6c62d04

2023-04-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from qZHSvkpAU1-YYGvYc... to yD5a3QBJHUFM4nVou... (flutter/engine#41314)
2023-04-18 yjbanov@google.com [web:canvaskit] clean up the rest of skia_object_cache usages (flutter/engine#41259)
2023-04-18 skia-flutter-autoroll@skia.org Roll Skia from f80ee1088861 to 476ee3fd54cc (2 revisions) (flutter/engine#41309)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from qZHSvkpAU1-Y to yD5a3QBJHUFM

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d9392f2e

Disableable ContextMenuButtonItems (#124253) · 3128df83

Justin McCandless authored Apr 19, 2023

Fixes https://github.com/flutter/flutter/issues/124247

| Native | Flutter before | Flutter after |
| --- | --- | --- |
| <img width="248" alt="Screenshot 2023-04-05 at 9 26 16 AM" src="https://user-images.githubusercontent.com/389558/230177116-154999e8-eef3-441d-9fe9-7063839a6b99.png"> | <img width="240" alt="Screenshot 2023-04-05 at 11 18 01 AM" src="https://user-images.githubusercontent.com/389558/230177125-1680e851-223e-4956-b5b6-1a24e11dc22a.png"> | <img width="226" alt="Screenshot 2023-04-05 at 11 17 36 AM" src="https://user-images.githubusercontent.com/389558/230177123-bde82134-67e1-4ce2-8eec-719eeb779bf4.png"> |

Also, it's now possible for anyone to create disabled buttons like this by setting ContextMenuButtonItem.onPressed to `null`.

3128df83

18 Apr, 2023 20 commits

Adaptive alert dialog (#124336) · bd2617ec

Mitchell Goodwin authored Apr 18, 2023

Fixes #102811. Adds an adaptive constructor to AlertDialog, along with the adaptive function showAdaptiveDialog.

<img width="357" alt="Screenshot 2023-04-06 at 10 40 18 AM" src="https://user-images.githubusercontent.com/58190796/230455412-31100922-cfc5-4252-b8c6-6f076353f29e.png">
<img width="350" alt="Screenshot 2023-04-06 at 10 42 50 AM" src="https://user-images.githubusercontent.com/58190796/230455454-363dd37e-c44e-4aca-b6a0-cfa1d959f606.png">

bd2617ec

Roll Flutter Engine from 6d263ea56a62 to 5fcc7b719029 (4 revisions) (#125069) · c05bc400

engine-flutter-autoroll authored Apr 18, 2023

https://github.com/flutter/engine/compare/6d263ea56a62...5fcc7b719029

2023-04-18 dnfield@google.com [Impeller] Gpu model information to Skia gold (flutter/engine#41216)
2023-04-18 30870216+gaaclarke@users.noreply.github.com [Impeller] faster glyph atlas generation by removing data copies (flutter/engine#41290)
2023-04-18 godofredoc@google.com Migrate android AOT to engine_v2. (flutter/engine#41229)
2023-04-18 skia-flutter-autoroll@skia.org Roll Skia from 5bd4bdc0d8e2 to f80ee1088861 (8 revisions) (flutter/engine#41302)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c05bc400

Remove package:js/dart:js_interop conflicts (#124879) · 6edbc195

Srujan Gaddam authored Apr 18, 2023

dart:js_interop and package:js will start conflicting, since they both have an `@JS` annotation. Until we're ready to only use dart:js_interop (which will require updating the SDK constraints of every package), we should hide the `@JS` annotation from dart:js_interop. Due to shadowing, this is the behavior today, so there should be no functional change.

Unblocks https://dart-review.googlesource.com/c/sdk/+/294130/8 and prevents confusing shadowing of dart:js_interop annotations like we do today.

- [Mentioned CL that is unblocked] I listed at least one issue that this PR fixes in the description above.
- [Need test-exemption] I added new tests to check the change I am making, or this PR is [test-exempt].
- [Need to run] All existing and new tests are passing.

6edbc195

Remove double.fromEnvironment from dart-define doc (#124102) · 81c3bc56

Samuel Abada authored Apr 18, 2023

Remove double.fromEnvironment from dart-define doc.

Fixes #124665 

The current dart-define docs reads:

```
Additional key-value pairs that will be available as constants from the String.fromEnvironment, bool.fromEnvironment, int.fromEnvironment, and
double.fromEnvironment constructors.
```
while dart-define-from-file reads:

```
The path of a json format file where flutter define a global constant pool. 
Json entry will be available as constants from the String.fromEnvironment, bool.fromEnvironment, int.fromEnvironment, 
and double.fromEnvironment constructors; the key and field are json values
```

<img width="1440" alt="Screenshot 2023-04-03 at 19 31 34" src="https://user-images.githubusercontent.com/31275429/229720102-2020e1a9-c1fb-470b-89e6-ffb84096a51b.png">

However, there is no fromEnvironment constructor for double. The aim of this PR is to address this by removing double.fromEnvironment from help docs as stated in

81c3bc56

Update to add Kim Jiun to `AUTHORS` (#125026) · e2a20460

Kim Jiun authored Apr 18, 2023

Adding my name (Kim Jiun) to Authors.

REF : https://github.com/flutter/flutter/pull/91496
Thanks!

e2a20460

Add controller argument to SubmenuButton (#125000) · 4b39f071

Greg Spencer authored Apr 18, 2023

## Description

This adds an optional argument to the `SubmenuButton` that allows the creator to supply a `MenuController` for controlling the menu.

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/124988

## Tests
 - Added tests for new argument.

4b39f071

Roll Flutter Engine from 879308a52228 to 6d263ea56a62 (1 revision) (#125060) · 98dfdf1b

engine-flutter-autoroll authored Apr 18, 2023

https://github.com/flutter/engine/compare/879308a52228...6d263ea56a62

2023-04-18 gspencergoog@users.noreply.github.com Some minor doc typo and diagnostic fixes. (flutter/engine#40982)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

98dfdf1b

Limit the number of Material spell check suggestions to 3 (#124899) · f04a5afb
Justin McCandless authored Apr 18, 2023
```
Fixes a bug where the spell check menu could overflow.
```
f04a5afb

Remove impeller testowners (#125056) · 0ea2f3b5

Jenn Magder authored Apr 18, 2023

Remove TESTOWNERS matching the removed impeller tests in https://github.com/flutter/flutter/pull/125044.

Filed https://github.com/flutter/flutter/issues/125055 since I believe the mismatch should have been caught in that PR.

0ea2f3b5

[web] - Clean up skipped tests (#124981) · cb90ae4d

htoor3 authored Apr 18, 2023

Fixes https://github.com/flutter/flutter/issues/124174
Fixes https://github.com/flutter/flutter/issues/124980

cb90ae4d

Roll Flutter Engine from 72b68622fffa to 879308a52228 (1 revision) (#125057) · ad784bf8

engine-flutter-autoroll authored Apr 18, 2023

https://github.com/flutter/engine/compare/72b68622fffa...879308a52228

2023-04-18 30870216+gaaclarke@users.noreply.github.com [Impeller] Turned on wide gamut support by default. (flutter/engine#39801)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ad784bf8

Remove unused getRootRenderObject and getSelectedRenderObject service extensions (#124805) · df811c6d

Michael Goderbauer authored Apr 18, 2023

These are currently unused and will not work in a multi-view environment where we will have multiple render trees.

Work towards https://github.com/flutter/flutter/issues/121573.

df811c6d

l10n.yaml's nullable-getter option should default to true (#124353) · b6c7df44

Tae Hyung Kim authored Apr 18, 2023

Currently, nullable-getter defaults to false when l10n.yaml is not present, which is not the same behavior as when an l10n.yaml file is present and nullable-getter is not set.

Fixes #120457.

b6c7df44

Roll Flutter Engine from 55bb065c607b to 72b68622fffa (1 revision) (#125053) · 9b530298

engine-flutter-autoroll authored Apr 18, 2023

https://github.com/flutter/engine/compare/55bb065c607b...72b68622fffa

2023-04-18 skia-flutter-autoroll@skia.org Manual roll Skia from d9e216e62223 to 5bd4bdc0d8e2 (12 revisions) (flutter/engine#41286)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9b530298

Add vmservice for android build options (#123034) · 55502fc3
chunhtai authored Apr 18, 2023
```
https://github.com/flutter/flutter/issues/120408
```
55502fc3

Fix text theme dart fix cases (#125052) · 42fb0b23

Kate Lovett authored Apr 18, 2023

Fixes https://github.com/flutter/flutter/issues/125049

This is blocking the dart roll, dart fix will now fix some invalid code that was in these test cases. These test case files are un-analyzed intentionally because they are by nature samples of broken code.

42fb0b23

Update the copy icon in snippets and samples to use the standard one (#123651) · d4e1209c

Greg Spencer authored Apr 18, 2023

## Description

This updates the copy icon for copying sample code to use `content_copy` instead of `assignment`.
Before:
<img width="369" alt="223876418-2470c4c5-abfc-4511-9762-1fd0b6e05903" src="https://user-images.githubusercontent.com/8867023/228396142-450125ee-d8cf-4ede-8545-5920eb0da99d.png">

After:
<img width="408" alt="image" src="https://user-images.githubusercontent.com/8867023/228395959-8531704a-77aa-43af-9dcf-7456bb2ed090.png">

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/122246

## Tests
 - No tests needed.

d4e1209c

Remove unused context parameter (#124254) · 9d688313
Justin McCandless authored Apr 18, 2023
```
Tidying up the spell check API.
```
9d688313
iOS spell check cursor placement (#124875) · 39becb77
Justin McCandless authored Apr 18, 2023
```
Fixes the cursor location after selecting a spell check result on iOS.
```
39becb77

Roll Flutter Engine from d2973619074e to 55bb065c607b (1 revision) (#125047) · f7245b64

engine-flutter-autoroll authored Apr 18, 2023

https://github.com/flutter/engine/compare/d2973619074e...55bb065c607b

2023-04-18 10456171+caroqliu@users.noreply.github.com [fuchsia] migrate touch-input integration tests to gfx scene manager test ui stack (flutter/engine#41118)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f7245b64