- 19 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so must not be null" or "so-and-so must be non-null" from the cases where those values are defines as non-nullable values. This PR removes them from the library in the repo that don't have anything to do with the framework. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 ## Tests - Documentation only change.
-
- 15 Aug, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 16 Mar, 2023 3 commits
-
-
Ian Hickson authored
Assert that runApp is called in the same zone as binding.ensureInitialized
-
yaakovschectman authored
Revert "Assert that runApp is called in the same zone as binding.ensureInitialized (#117113)" (#122830) Revert "Assert that runApp is called in the same zone as binding.ensureInitialized"
-
Ian Hickson authored
Assert that runApp is called in the same zone as binding.ensureInitialized
-
- 17 Feb, 2023 1 commit
-
-
Ian Hickson authored
* lerp documentation * Remove Note, Note That from repo * Improve BorderSide documentation. * apply review comments
-
- 10 Feb, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 20 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 23 Jul, 2022 1 commit
-
-
Yegor authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `packages/flutter_driver` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens_client` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_localizations` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_test` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_web_plugins` * fix comments * Use `curly_braces_in_flow_control_structures` for `packages/integration_test` * fix indentation
-
- 03 Feb, 2022 1 commit
-
-
Ian Hickson authored
-
- 04 Dec, 2021 1 commit
-
-
Yegor authored
-
- 11 Aug, 2021 1 commit
-
-
Greg Spencer authored
-
- 15 Jul, 2021 1 commit
-
- 14 Jul, 2021 3 commits
-
-
Ian Hickson authored
-
Zachary Anderson authored
This reverts commit 31de052e.
-
Ian Hickson authored
-
- 13 Jul, 2021 2 commits
-
-
Ian Hickson authored
This reverts commit e2490f29.
-
Ian Hickson authored
-
- 21 May, 2021 1 commit
-
-
Ian Hickson authored
-
- 14 May, 2021 1 commit
-
-
Ian Hickson authored
-
- 13 May, 2021 1 commit
-
-
Ian Hickson authored
-
- 04 May, 2021 2 commits
-
-
Ian Hickson authored
- 26 Apr, 2021 1 commit
-
- 23 Apr, 2021 1 commit
-
-
Ian Hickson authored
* Migrate to ChannelBuffers.push * Move TestDefaultBinaryMessenger to its own file * Apply deprecations and fix usages
-
- 19 Mar, 2021 1 commit
-
-
Michael Goderbauer authored
-
- 17 Feb, 2021 1 commit
-
-
Sam Rawlins authored
-
- 03 Feb, 2021 1 commit
-
-
Michael Goderbauer authored
-
- 16 Dec, 2020 1 commit
-
-
voobel authored
-
- 17 Oct, 2020 1 commit
-
-
Marcin Jeleński authored
-
- 09 Oct, 2020 2 commits
-
-
Marcin Jeleński authored
Reland "Flutter Driver - Create widget finders from serialized finders extensions" with null safety (#67711) * Flutter Driver - Create widget finders from serialized finders extensions
-
Jonah Williams authored
-
- 08 Oct, 2020 3 commits
-
-
Jonah Williams authored
Revert "Flutter Driver - Create widget finders from serialized finders extensions (#67456)" (#67687) This reverts commit 74f6fa45.
-
Marcin Jeleński authored
-
Alexandre Ardhuin authored
-
- 07 Oct, 2020 1 commit
-
- 06 Oct, 2020 3 commits
-
-
Jonah Williams authored
Reland: #67155 Fixes analysis error caused by landing of material migration, and g3 error caused by moving of fuchsia lib.
-
Jonah Williams authored
This reverts commit e826442e.
-
Jonah Williams authored
Ensures all of the libraries that the application side code import are migrated to null safety. full null safety migration is blocked by json rpc 2 and a breaking change to vm service client.
-