Commits · f5050cf4a4772cc7e8d0122840e03c147605d4b4 · abdullh.alsoleman / Front-End

14 Dec, 2023 10 commits

Reverts "Roll Flutter Engine from 9f7004e3e30e to 45b95f264d63 (1 revision)" (#140123) · f5050cf4

auto-submit[bot] authored Dec 14, 2023

Reverts flutter/flutter#140108
Initiated by: loic-sharma
This change reverts the following previous change:
Original Description:

https://github.com/flutter/engine/compare/9f7004e3e30e...45b95f264d63

2023-12-13 737941+loic-sharma@users.noreply.github.com [Windows] Move to `FlutterCompositor` for rendering (flutter/engine#48849)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f5050cf4

[deps] update Android SDK to 34 (#138183) · 3b370c85

Daco Harkes authored Dec 14, 2023

Update Android SDK from 33 to 34.

Following the engine update:

* https://github.com/flutter/engine/pull/47839

3b370c85

Roll Flutter Engine from 9f7004e3e30e to 45b95f264d63 (1 revision) (#140108) · 1ff76863

engine-flutter-autoroll authored Dec 14, 2023

https://github.com/flutter/engine/compare/9f7004e3e30e...45b95f264d63

2023-12-13 737941+loic-sharma@users.noreply.github.com [Windows] Move to `FlutterCompositor` for rendering (flutter/engine#48849)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1ff76863

Catch `Stopwatch` with static analysis (#140019) · f2c6f03c

LongCatIsLooong authored Dec 14, 2023

I did not include the `'// flutter_ignore_for_file: stopwatch (see analyze.dart)'` directive since it's currently not used, and adding that shouldn't be too difficult.

f2c6f03c

Overlay supports unconstrained environments (#139513) · 41622725

Michael Goderbauer authored Dec 14, 2023

Fixes https://github.com/flutter/flutter/issues/137875.

Unfortunately, we cannot auto-detect which OverlayEntry should be sizing the Overlay in unconstrained environment. So, this PR adds a special flag to annotate the Overlay Entry that should be used.

41622725

Bump github/codeql-action from 2.22.10 to 3.22.11 (#140087) · cea2726b

dependabot[bot] authored Dec 14, 2023

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.10 to 3.22.11.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.22.11 - 13 Dec 2023</h2>
<ul>
<li>[v3+ only] The CodeQL Action now runs on Node.js v20. <a href="https://redirect.github.com/github/codeql-action/pull/2006">#2006</a></li>
</ul>
<h2>2.22.10 - 12 Dec 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.4. <a href="https://redirect.github.com/github/codeql-action/pull/2016">#2016</a></li>
</ul>
<h2>2.22.9 - 07 Dec 2023</h2>
<p>No user facing changes.</p>
<h2>2.22.8 - 23 Nov 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.3. <a href="https://redirect.github.com/github/codeql-action/pull/2001">#2001</a></li>
</ul>
<h2>2.22.7 - 16 Nov 2023</h2>
<ul>
<li>Add a deprecation warning for customers using CodeQL version 2.11.5 and earlier. These versions of CodeQL were discontinued on 8 November 2023 alongside GitHub Enterprise Server 3.7, and will be unsupported by CodeQL Action v2.23.0 and later. <a href="https://redirect.github.com/github/codeql-action/pull/1993">#1993</a>
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.11.6 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.10.5 and 2.11.5, you can replace <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.22.7</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
</ul>
<h2>2.22.6 - 14 Nov 2023</h2>
<ul>
<li>Customers running Python analysis on macOS using version 2.14.6 or earlier of the CodeQL CLI should upgrade to CodeQL CLI version 2.15.0 or later. If you do not wish to upgrade the CodeQL CLI, ensure that you are using Python version 3.11 or earlier, as CodeQL version 2.14.6 and earlier do not support Python 3.12. You can achieve this by adding a <a href="https://github.com/actions/setup-python"><code>setup-python</code></a> step to your code scanning workflow before the step that invokes <code>github/codeql-action/init</code>.</li>
<li>Update default CodeQL bundle version to 2.15.2. <a href="https://redirect.github.com/github/codeql-action/pull/1978">#1978</a></li>
</ul>
<h2>2.22.5 - 27 Oct 2023</h2>
<p>No user facing changes.</p>
<h2>2.22.4 - 20 Oct 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.1. <a href="https://redirect.github.com/github/codeql-action/pull/1953">#1953</a></li>
<li>Users will begin to see warnings on Node.js 16 deprecation in their Actions logs on code scanning runs starting October 23, 2023.
<ul>
<li>All code scanning workflows should continue to succeed regardless of the warning.</li>
<li>The team at GitHub maintaining the CodeQL Action is aware of the deprecation timeline and actively working on creating another version of the CodeQL Action, v3, that will bump us to Node 20.</li>
<li>For more information, and to communicate with the maintaining team, please use <a href="https://redirect.github.com/github/codeql-action/issues/1959">this issue</a>.</li>
</ul>
</li>
</ul>
<h2>2.22.3 - 13 Oct 2023</h2>
<ul>
<li>Provide an authentication token when downloading the CodeQL Bundle from the API of a GitHub Enterprise Server instance. <a href="https://redirect.github.com/github/codeql-action/pull/1945">#1945</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/b374143c1149a9115d881581d29b8390bbcbb59c"><code>b374143</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2034">#2034</a> from github/update-v3.22.11-64e61baea</li>
<li><a href="https://github.com/github/codeql-action/commit/e2b5cc75ce46a4a33dbafa57e19019d6bd5a67be"><code>e2b5cc7</code></a> Update changelog for v3.22.11</li>
<li><a href="https://github.com/github/codeql-action/commit/64e61baeac852f409b48440cebec029a2d978f90"><code>64e61ba</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2006">#2006</a> from github/nickfyson/node-20</li>
<li><a href="https://github.com/github/codeql-action/commit/c757f9f6de6bebddbc274b26f9282d0199ab0512"><code>c757f9f</code></a> Apply suggestions from code review</li>
<li><a href="https://github.com/github/codeql-action/commit/7898bc2041d7b0bc5e6f97169b127ff75eee02f2"><code>7898bc2</code></a> add pr check for node version consistency</li>
<li><a href="https://github.com/github/codeql-action/commit/6b5b95806324a3ee7e164709fbfc152595556fe9"><code>6b5b958</code></a> remove dedundant single quotes from node version strings</li>
<li><a href="https://github.com/github/codeql-action/commit/ea1e72c6697fe8b190253b561a93508e587ea209"><code>ea1e72c</code></a> Update .github/workflows/pr-checks.yml</li>
<li><a href="https://github.com/github/codeql-action/commit/b974542e9f06e790793093fb5d47fc462c0d20bf"><code>b974542</code></a> Merge branch 'main' into nickfyson/node-20</li>
<li><a href="https://github.com/github/codeql-action/commit/b995212303c9b90cac695cf6c0b558f54fb613f6"><code>b995212</code></a> Bump the actions group with 2 updates (<a href="https://redirect.github.com/github/codeql-action/issues/2024">#2024</a>)</li>
<li><a href="https://github.com/github/codeql-action/commit/3c1878d8f9d642687f3f2ba76af5406aa16ce232"><code>3c1878d</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2029">#2029</a> from github/mergeback/v2.22.10-to-main-305f6546</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/305f6546310b9203e892c28c1484e82977f4f63d...b374143c1149a9115d881581d29b8390bbcbb59c">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.22.10&new-version=3.22.11)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

cea2726b

Remove deprecated `ThemeData.selectedRowColor` (#139080) · 5be1918b
Renzo Olivares authored Dec 14, 2023
```
Part of: https://github.com/flutter/flutter/issues/139243
```
5be1918b

Unpin mac_toolchain version (#139938) · 0c280d47

Victoria Ashworth authored Dec 14, 2023

mac_toolchain has been updated to no longer have 2 minute slowdown (https://github.com/flutter/flutter/issues/138109), so unpin to use the latest version.

0c280d47

Optimize file transfer when using proxied devices. (#139968) · c1caa24a

Lau Ching Jun authored Dec 14, 2023

List of changes:
1. Optimizations in FileTransfer. a. Use `stream.forEach` instead of `await for`. b. Type cast `List<int>` to `Uint8List` instead of using `Uint8List.fromList` results in (presumably) fewer copy and faster execution. c. Iterate through `Uint8List` with regular for loop instead of for-in loop.
2. Precache the block hashes of a file, and reuse it on subsequent runs.

c1caa24a

Add commonly used parameter names (#140027) · a9c40a2a

hgraceb authored Dec 14, 2023

## Description

Similar to #119877, but with more cases that I could find in `packages/flutter`. 

Although there is already a [proposal](https://github.com/dart-lang/linter/issues/4102), it is uncertain how long it will take to be implemented.

![[image-20200711205959042](https://user-images.githubusercontent.com/72788825/216486897-b56453d2-b309-47ea-885b-b0ec6ed1b648.png)](https://user-images.githubusercontent.com/72788825/216486897-b56453d2-b309-47ea-885b-b0ec6ed1b648.png)

a9c40a2a

13 Dec, 2023 12 commits

Roll Flutter Engine from fc3267724e1b to 9f7004e3e30e (4 revisions) (#140090) · 0926a553

engine-flutter-autoroll authored Dec 13, 2023

https://github.com/flutter/engine/compare/fc3267724e1b...9f7004e3e30e

2023-12-13 30870216+gaaclarke@users.noreply.github.com [Impeller] Made the new blur work on devices without the decal address mode (flutter/engine#48899)
2023-12-13 15619084+vashworth@users.noreply.github.com Allow tests to run on macOS 13 (flutter/engine#48894)
2023-12-13 jonahwilliams@google.com [Impeller] Compute ContextContentOptions key via bit manipulating (instead of hashing each property). (flutter/engine#48902)
2023-12-13 skia-flutter-autoroll@skia.org Roll Skia from f3401c6186c1 to 69c02c9d56b2 (1 revision) (flutter/engine#48992)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0926a553

[Windows] Remove header guard from generated key map (#140082) · 51e60708

Loïc Sharma authored Dec 13, 2023

The generated file is a `.cc` file that does not need header guards. This change updates the template that's used to generate that `.cc` file.

No tests as this is a refactoring with no semantic changes.

The generated `.cc` file in the engine will be updated by https://github.com/flutter/engine/pull/48993

51e60708

Do not use project in do last (#139325) · 3c80cc7e

Reid Baker authored Dec 13, 2023

- Use copy task that branches for 8.3 and above to avoid using project.exec in a dolast block. 

part 1/n for flutter/flutter/issues/138523 

This PR does not test the 8.3 branch but instead builds the ability to write a branching gradle test. 
After fixing this project.exec action there I discovered a second that needs to be removed or migrated in order for the build to work. 

Related reading https://docs.gradle.org/8.0/userguide/configuration_cache.html#config_cache:requirements
https://docs.gradle.org/current/javadoc/org/gradle/process/ExecOperations.html (not used but considered) 
https://docs.gradle.org/8.2/dsl/org.gradle.api.tasks.Copy.html#org.gradle.api.tasks.Copy:fileMode

3c80cc7e

Roll pub packages (#140024) · 8791b0ea
flutter-pub-roller-bot authored Dec 13, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
8791b0ea

Reverts "Warn when Gradle plugins are applied using the legacy "apply script method" way" (#140102) · 625bc50c

auto-submit[bot] authored Dec 13, 2023

Reverts flutter/flutter#139690
Initiated by: hellohuanlin
This change reverts the following previous change:
Original Description:
This PR adds a deprecation message when Android build is using the legacy "apply script method" way of applying Flutter's Gradle plugins (that is: [`flutter.gradle`](https://github.com/flutter/flutter/blob/3.16.0/packages/flutter_tools/gradle/flutter.gradle) and [`app_plugin_loader.gradle`](https://github.com/flutter/flutter/blob/3.16.0/packages/flutter_tools/gradle/app_plugin_loader.gradle)).

See also:
- #121541
  - in particular https://github.com/flutter/flutter/issues/121541#issuecomment-1836947311
- #135392
  - and PR that add the migration guide: [#9857](https://github.com/flutter/website/pull/9857)

- I think either `logger.error` or `logger.quiet` must be used, because all other error levels are not shown during `flutter build apk` (and that's what most people use).

625bc50c

Swap iOS back button icon in Material app bar (#134754) · c7813026

Mitchell Goodwin authored Dec 13, 2023

Fixes #128555.

Changes the back icon for the Material app bar when running on Apple devices from `arrow_back_ios` to `arrow_back_ios_new_rounded`, as the old version of the icon wasn't centered (https://github.com/google/material-design-icons/issues/824) and the native back icon, as well as the one in Cupertino, are rounded.

| Before | After |
| ------------- | ------------- |
| <img width="295" alt="Screenshot 2023-09-14 at 11 24 10 AM" src="https://github.com/flutter/flutter/assets/58190796/242e5fae-1107-4e1d-9749-a988462e7767"> | <img width="285" alt="Screenshot 2023-09-14 at 11 23 50 AM" src="https://github.com/flutter/flutter/assets/58190796/4df1ecaa-4313-4eb3-9cf3-335a777e133f"> |

New icon works as expected with RTL:

<img width="283" alt="Screenshot 2023-09-14 at 10 57 34 AM" src="https://github.com/flutter/flutter/assets/58190796/ae92fb35-40fd-4ee0-be60-cd452f16b2e3">

c7813026

Roll Packages from 80aa46a5a73d to b5958e2a8b49 (10 revisions) (#140069) · 37510051

engine-flutter-autoroll authored Dec 13, 2023

https://github.com/flutter/packages/compare/80aa46a5a73d...b5958e2a8b49

2023-12-13 43054281+camsim99@users.noreply.github.com [camera, camera_android] Re-enable passing integration tests (flutter/packages#5658)
2023-12-13 engine-flutter-autoroll@skia.org Roll Flutter from 97190973 to 11a9cb70 (32 revisions) (flutter/packages#5665)
2023-12-13 stuartmorgan@google.com [url_launcher] Return false on Windows when there is no handler (flutter/packages#5359)
2023-12-13 stuartmorgan@google.com [url_launcher] Simplify Linux implementation (flutter/packages#5376)
2023-12-12 49699333+dependabot[bot]@users.noreply.github.com [local_auth]: Bump androidx.fragment:fragment from 1.6.1 to 1.6.2 in /packages/local_auth/local_auth_android/android (flutter/packages#5332)
2023-12-12 tarrinneal@gmail.com [pigeon] Adds @CanIgnoreReturnValue annotation (flutter/packages#5601)
2023-12-12 tarrinneal@gmail.com [image_picker] updates to resize logic. (flutter/packages#5527)
2023-12-12 stuartmorgan@google.com [various] Update examples using video_player (flutter/packages#5653)
2023-12-12 louisehsu@google.com [tools] Validate pubspec topic format (flutter/packages#5565)
2023-12-12 nathan2000@outlook.com [pigeon] Fix Kotlin generator to use provided errorClassName (flutter/packages#5480)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

37510051

Roll Flutter Engine from 9039ac78cf03 to fc3267724e1b (26 revisions) (#140084) · c735739a

engine-flutter-autoroll authored Dec 13, 2023

https://github.com/flutter/engine/compare/9039ac78cf03...fc3267724e1b

2023-12-13 jason-simmons@users.noreply.github.com Revert Dart SDK back to 3.3.0-219.0.dev (flutter/engine#48990)
2023-12-13 flar@google.com [Impeller] Use direct tessellation geometry for simple clip shapes (flutter/engine#48959)
2023-12-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Android] Re-land "Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34"" (flutter/engine#48988)
2023-12-13 31859944+LongCatIsLooong@users.noreply.github.com Add a constructor for `GlyphInfo`. (flutter/engine#48971)
2023-12-13 737941+loic-sharma@users.noreply.github.com [Windows] Refactor surface manager mocking (flutter/engine#48953)
2023-12-13 skia-flutter-autoroll@skia.org Roll Skia from 6e5bd9b1d91d to f3401c6186c1 (2 revisions) (flutter/engine#48981)
2023-12-13 skia-flutter-autoroll@skia.org Roll Skia from 1e63c048ded7 to 6e5bd9b1d91d (1 revision) (flutter/engine#48973)
2023-12-13 skia-flutter-autoroll@skia.org Roll Skia from 927f20598b11 to 1e63c048ded7 (1 revision) (flutter/engine#48968)
2023-12-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 17143c130ab3 to 114f2e8de3e5 (1 revision) (flutter/engine#48969)
2023-12-13 jason-simmons@users.noreply.github.com Workarounds for clang-tidy warnings in the next roll of Clang (flutter/engine#48963)
2023-12-13 matanlurey@users.noreply.github.com Migrate `impeller/**.h` to header guards. (flutter/engine#48962)
2023-12-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 02f28120470f to 17143c130ab3 (1 revision) (flutter/engine#48961)
2023-12-13 43054281+camsim99@users.noreply.github.com [Android] Re-land "Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34" (flutter/engine#48936)
2023-12-13 skia-flutter-autoroll@skia.org Roll Skia from 49e32eb178a7 to 927f20598b11 (3 revisions) (flutter/engine#48956)
2023-12-13 1961493+harryterkelsen@users.noreply.github.com [web:multiview] Make CanvasKitRenderer listen for view creation/disposal events (flutter/engine#48812)
2023-12-12 matanlurey@users.noreply.github.com Move `third_party/swiftshader`, roll buildroot `DEPS`. (flutter/engine#48946)
2023-12-12 flar@google.com [Impeller] Direct tessellation of simple filled round rects (flutter/engine#48919)
2023-12-12 skia-flutter-autoroll@skia.org Roll Skia from 8e8d92ac1536 to 49e32eb178a7 (1 revision) (flutter/engine#48949)
2023-12-12 skia-flutter-autoroll@skia.org Roll Dart SDK from a677378ae254 to 02f28120470f (1 revision) (flutter/engine#48945)
2023-12-12 skia-flutter-autoroll@skia.org Roll Skia from 43a400456ab4 to 8e8d92ac1536 (1 revision) (flutter/engine#48941)
2023-12-12 skia-flutter-autoroll@skia.org Roll Skia from 3678212a85b8 to 43a400456ab4 (2 revisions) (flutter/engine#48939)
2023-12-12 matanlurey@users.noreply.github.com Roll `buildroot` and delete `libxml`. (flutter/engine#48906)
2023-12-12 skia-flutter-autoroll@skia.org Roll Skia from 16298087c277 to 3678212a85b8 (2 revisions) (flutter/engine#48934)
2023-12-12 jason-simmons@users.noreply.github.com Manual roll of Dart SDK from 82c4571bb2de to a677378ae254 (flutter/engine#48933)
2023-12-12 skia-flutter-autoroll@skia.org Roll Skia from 7685acfb6221 to 16298087c277 (1 revision) (flutter/engine#48931)
2023-12-12 mdebbar@google.com [web] Handle resizes at the view level (flutter/engine#48892)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c735739a

Warn when Gradle plugins are applied using the legacy "apply script method" way (#139690) · 4aef59be

Bartek Pacia authored Dec 13, 2023

This PR adds a deprecation message when Android build is using the legacy "apply script method" way of applying Flutter's Gradle plugins (that is: [`flutter.gradle`](https://github.com/flutter/flutter/blob/3.16.0/packages/flutter_tools/gradle/flutter.gradle) and [`app_plugin_loader.gradle`](https://github.com/flutter/flutter/blob/3.16.0/packages/flutter_tools/gradle/app_plugin_loader.gradle)).

See also:
- #121541
  - in particular https://github.com/flutter/flutter/issues/121541#issuecomment-1836947311
- #135392
  - and PR that add the migration guide: [#9857](https://github.com/flutter/website/pull/9857)

- I think either `logger.error` or `logger.quiet` must be used, because all other error levels are not shown during `flutter build apk` (and that's what most people use).

4aef59be

Add self as bundler dependabot reviewer (#140081) · 7f0504d9
Jenn Magder authored Dec 13, 2023
```
Take back bundler/gem reviewership from @vashworth (thanks for covering!)
```
7f0504d9

Reverts "Make tests more resilient to Skia gold failures and refactor... · 91877c63

auto-submit[bot] authored Dec 13, 2023

Reverts "Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal" (#140085)

Reverts flutter/flutter#139549
Initiated by: Piinks
This change reverts the following previous change:
Original Description:
* Remove all use of global variables.
* Always pass in all dependencies, only create them in main or in tests.
* Pass in the "print" primitive.
* Make all network traffic retry (except when run locally, when it just auto-passes).
* Enable tests to be run in random order.

91877c63

Make tests more resilient to Skia gold failures and refactor flutter_goldens... · 11a9cb70

Ian Hickson authored Dec 13, 2023

Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal (#139549)

* Remove all use of global variables.
* Always pass in all dependencies, only create them in main or in tests.
* Pass in the "print" primitive.
* Make all network traffic retry (except when run locally, when it just auto-passes).
* Enable tests to be run in random order.

11a9cb70

12 Dec, 2023 18 commits

Bump github/codeql-action from 2.22.9 to 2.22.10 (#140003) · 3da9bc16

dependabot[bot] authored Dec 12, 2023

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.9 to 2.22.10.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>2.22.10 - 12 Dec 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.4. <a href="https://redirect.github.com/github/codeql-action/pull/2016">#2016</a></li>
</ul>
<h2>2.22.9 - 07 Dec 2023</h2>
<p>No user facing changes.</p>
<h2>2.22.8 - 23 Nov 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.3. <a href="https://redirect.github.com/github/codeql-action/pull/2001">#2001</a></li>
</ul>
<h2>2.22.7 - 16 Nov 2023</h2>
<ul>
<li>Add a deprecation warning for customers using CodeQL version 2.11.5 and earlier. These versions of CodeQL were discontinued on 8 November 2023 alongside GitHub Enterprise Server 3.7, and will be unsupported by CodeQL Action v2.23.0 and later. <a href="https://redirect.github.com/github/codeql-action/pull/1993">#1993</a>
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.11.6 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.10.5 and 2.11.5, you can replace <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.22.7</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
</ul>
<h2>2.22.6 - 14 Nov 2023</h2>
<ul>
<li>Customers running Python analysis on macOS using version 2.14.6 or earlier of the CodeQL CLI should upgrade to CodeQL CLI version 2.15.0 or later. If you do not wish to upgrade the CodeQL CLI, ensure that you are using Python version 3.11 or earlier, as CodeQL version 2.14.6 and earlier do not support Python 3.12. You can achieve this by adding a <a href="https://github.com/actions/setup-python"><code>setup-python</code></a> step to your code scanning workflow before the step that invokes <code>github/codeql-action/init</code>.</li>
<li>Update default CodeQL bundle version to 2.15.2. <a href="https://redirect.github.com/github/codeql-action/pull/1978">#1978</a></li>
</ul>
<h2>2.22.5 - 27 Oct 2023</h2>
<p>No user facing changes.</p>
<h2>2.22.4 - 20 Oct 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.1. <a href="https://redirect.github.com/github/codeql-action/pull/1953">#1953</a></li>
<li>Users will begin to see warnings on Node.js 16 deprecation in their Actions logs on code scanning runs starting October 23, 2023.
<ul>
<li>All code scanning workflows should continue to succeed regardless of the warning.</li>
<li>The team at GitHub maintaining the CodeQL Action is aware of the deprecation timeline and actively working on creating another version of the CodeQL Action, v3, that will bump us to Node 20.</li>
<li>For more information, and to communicate with the maintaining team, please use <a href="https://redirect.github.com/github/codeql-action/issues/1959">this issue</a>.</li>
</ul>
</li>
</ul>
<h2>2.22.3 - 13 Oct 2023</h2>
<ul>
<li>Provide an authentication token when downloading the CodeQL Bundle from the API of a GitHub Enterprise Server instance. <a href="https://redirect.github.com/github/codeql-action/pull/1945">#1945</a></li>
</ul>
<h2>2.22.2 - 12 Oct 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.0. <a href="https://redirect.github.com/github/codeql-action/pull/1938">#1938</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/305f6546310b9203e892c28c1484e82977f4f63d"><code>305f654</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2028">#2028</a> from github/update-v2.22.10-fe23b5a3e</li>
<li><a href="https://github.com/github/codeql-action/commit/31e94d8cb16220f5617d878dad8d698487b2bb49"><code>31e94d8</code></a> Update changelog for v2.22.10</li>
<li><a href="https://github.com/github/codeql-action/commit/fe23b5a3e1de4ae7f64965059233ee74e959035e"><code>fe23b5a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2016">#2016</a> from github/update-bundle/codeql-bundle-v2.15.4</li>
<li><a href="https://github.com/github/codeql-action/commit/183559cea87c163bb01e99e0a15fd5500b23307f"><code>183559c</code></a> Merge branch 'main' into update-bundle/codeql-bundle-v2.15.4</li>
<li><a href="https://github.com/github/codeql-action/commit/382a50a0284c0de445104889a9d6003acb4b3c1d"><code>382a50a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2021">#2021</a> from github/mergeback/v2.22.9-to-main-c0d1daa7</li>
<li><a href="https://github.com/github/codeql-action/commit/458b4226ad8e38f90ff6a4ad1e18ab2593e7e3dc"><code>458b422</code></a> Update checked-in dependencies</li>
<li><a href="https://github.com/github/codeql-action/commit/5e0f9dbc48f564b68392e465dcdacd74eab63e25"><code>5e0f9db</code></a> Update changelog and version after v2.22.9</li>
<li><a href="https://github.com/github/codeql-action/commit/b6dc4ba94b60904bd83cc6e9186e94a7e55366a0"><code>b6dc4ba</code></a> Add changelog note</li>
<li><a href="https://github.com/github/codeql-action/commit/1c3b8c867ba7d8de952a0d8522ca6e125fa18034"><code>1c3b8c8</code></a> Update default bundle to codeql-bundle-v2.15.4</li>
<li>See full diff in <a href="https://github.com/github/codeql-action/compare/c0d1daa7f7e14667747d73a7dbbe8c074bc8bfe2...305f6546310b9203e892c28c1484e82977f4f63d">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.22.9&new-version=2.22.10)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

3da9bc16

Allow plugins to use compileSdkPreview (#131901) · 9a72e1c6

Gray Mackall authored Dec 12, 2023

Fixes https://github.com/flutter/flutter/issues/124748

Based (heavily) off https://github.com/flutter/flutter/pull/104662

9a72e1c6

Roll pub packages (#139995) · eb0890c9
flutter-pub-roller-bot authored Dec 12, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
eb0890c9

Select simulator runtime for tests based on Xcode's preferred runtime build (#139919) · 410af14f

Victoria Ashworth authored Dec 12, 2023

When creating a simulator for a test, select the runtime based on the selected Xcode's preferred build. This is to prevent it from using a runtime greater than its greatest supported version.

Fixes https://github.com/flutter/flutter/issues/139917.

Example test with both iOS 16 and 17 available: https://chromium-swarm.appspot.com/task?id=6672aca184395a10

410af14f

Roll Flutter Engine from 0c527aa1a215 to 9039ac78cf03 (1 revision) (#139992) · da202622

engine-flutter-autoroll authored Dec 12, 2023

https://github.com/flutter/engine/compare/0c527aa1a215...9039ac78cf03

2023-12-12 skia-flutter-autoroll@skia.org Roll Skia from 053490edfa70 to 7685acfb6221 (1 revision) (flutter/engine#48929)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

da202622

[Docs] Added missing `CupertinoApp.showSemanticsDebugger` (#139913) · 87b8bf64
Tirth authored Dec 12, 2023
```
Added missing reference to `CupertinoApp.showSemanticsDebugger`.

Fixes #139897
```
87b8bf64

Roll Flutter Engine from 444281eb5c7c to 0c527aa1a215 (2 revisions) (#139985) · 64c098c3

engine-flutter-autoroll authored Dec 12, 2023

https://github.com/flutter/engine/compare/444281eb5c7c...0c527aa1a215

2023-12-12 skia-flutter-autoroll@skia.org Roll Skia from e1b4c6d9bc8d to 053490edfa70 (1 revision) (flutter/engine#48925)
2023-12-12 skia-flutter-autoroll@skia.org Roll Skia from fe04635b125f to e1b4c6d9bc8d (1 revision) (flutter/engine#48922)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

64c098c3

Update Gallery lockfiles for the new version of the video_player plugin (#139832) · da891d64
Jason Simmons authored Dec 12, 2023
```
The video_player plugin was rolled in https://github.com/flutter/flutter/pull/139203 and the lockfiles need to be updated to match
```
da891d64

Roll Packages from cb6dbcdd2305 to 80aa46a5a73d (5 revisions) (#139982) · 2ff8f795

engine-flutter-autoroll authored Dec 12, 2023

https://github.com/flutter/packages/compare/cb6dbcdd2305...80aa46a5a73d

2023-12-12 engine-flutter-autoroll@skia.org Manual roll Flutter from c642f4e0 to 97190973 (25 revisions) (flutter/packages#5648)
2023-12-12 43759233+kenzieschmoll@users.noreply.github.com [web_benchmarks] Add support for analyzing benchmark results (flutter/packages#5630)
2023-12-11 louisehsu@google.com [pointer_interceptor] Fully publish pointer_interceptor package (flutter/packages#5640)
2023-12-11 43054281+camsim99@users.noreply.github.com Manually roll Flutter (stable) from db7ef5bf9f59 to b0366e0a3f08 (8 revisions) (flutter/packages#5632)
2023-12-11 43054281+camsim99@users.noreply.github.com Manually roll Flutter from f35d049e to c642f4e0 (92 revisions) (flutter/packages#5631)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2ff8f795

Roll Flutter Engine from 3b77b1b7b42f to 444281eb5c7c (1 revision) (#139979) · 872f375b

engine-flutter-autoroll authored Dec 12, 2023

https://github.com/flutter/engine/compare/3b77b1b7b42f...444281eb5c7c

2023-12-12 skia-flutter-autoroll@skia.org Roll Skia from 3bbb159b476f to fe04635b125f (1 revision) (flutter/engine#48920)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

872f375b

Roll Flutter Engine from f8e87ed193f5 to 3b77b1b7b42f (1 revision) (#139977) · 31abc0a4

engine-flutter-autoroll authored Dec 12, 2023

https://github.com/flutter/engine/compare/f8e87ed193f5...3b77b1b7b42f

2023-12-12 skia-flutter-autoroll@skia.org Roll Skia from 9ee61bf39374 to 3bbb159b476f (1 revision) (flutter/engine#48917)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

31abc0a4

Roll pub packages (#139969) · e278279a
flutter-pub-roller-bot authored Dec 12, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
e278279a

Roll Flutter Engine from 4102c7daf1d3 to f8e87ed193f5 (3 revisions) (#139963) · 27eabd61

engine-flutter-autoroll authored Dec 12, 2023

https://github.com/flutter/engine/compare/4102c7daf1d3...f8e87ed193f5

2023-12-12 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-python from 4.7.1 to 5.0.0 (flutter/engine#48916)
2023-12-12 skia-flutter-autoroll@skia.org Roll Skia from 0b3bebcd0907 to 9ee61bf39374 (1 revision) (flutter/engine#48915)
2023-12-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 9113869cad5f to 82c4571bb2de (1 revision) (flutter/engine#48914)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

27eabd61

Roll Flutter Engine from 95dfb1d4ac75 to 4102c7daf1d3 (1 revision) (#139961) · bf660493

engine-flutter-autoroll authored Dec 12, 2023

https://github.com/flutter/engine/compare/95dfb1d4ac75...4102c7daf1d3

2023-12-12 skia-flutter-autoroll@skia.org Roll Skia from f436b5ea0e62 to 0b3bebcd0907 (1 revision) (flutter/engine#48912)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bf660493

Roll Flutter Engine from 40bfd2dc1519 to 95dfb1d4ac75 (1 revision) (#139959) · 2edb08b0

engine-flutter-autoroll authored Dec 12, 2023

https://github.com/flutter/engine/compare/40bfd2dc1519...95dfb1d4ac75

2023-12-12 skia-flutter-autoroll@skia.org Roll Skia from 6e3dca50f506 to f436b5ea0e62 (5 revisions) (flutter/engine#48911)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2edb08b0

Roll Flutter Engine from 061ae7023f10 to 40bfd2dc1519 (2 revisions) (#139958) · 3640b21b

engine-flutter-autoroll authored Dec 12, 2023

https://github.com/flutter/engine/compare/061ae7023f10...40bfd2dc1519

2023-12-12 skia-flutter-autoroll@skia.org Roll Skia from 3b1f4839952f to 6e3dca50f506 (3 revisions) (flutter/engine#48910)
2023-12-12 skia-flutter-autoroll@skia.org Roll Skia from 50346ff52bbb to 3b1f4839952f (1 revision) (flutter/engine#48908)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3640b21b

Roll Flutter Engine from 75cfb050cd9a to 061ae7023f10 (1 revision) (#139955) · 2b55ae3b

engine-flutter-autoroll authored Dec 12, 2023

https://github.com/flutter/engine/compare/75cfb050cd9a...061ae7023f10

2023-12-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 53dfedb82222 to 9113869cad5f (1 revision) (flutter/engine#48905)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2b55ae3b

Roll Flutter Engine from 362d0cb3ab27 to 75cfb050cd9a (1 revision) (#139954) · 88704800

engine-flutter-autoroll authored Dec 12, 2023

https://github.com/flutter/engine/compare/362d0cb3ab27...75cfb050cd9a

2023-12-12 skia-flutter-autoroll@skia.org Roll Skia from 461256aac224 to 50346ff52bbb (1 revision) (flutter/engine#48900)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

88704800