Commits · f4da9f72ebf2060a0c2e638bff6c3384adea778f · abdullh.alsoleman / Front-End

09 Nov, 2019 2 commits

Deprecation cleanup in flutter_tools (#44469) · f4da9f72

Ian Hickson authored Nov 09, 2019

One deprecated member was no longer used; removed it.

The other probably shouldn't be deprecated, because it's not the
parser that's deprecated so much as the format it's parsing. The code
itself will live on until we decide to stop supporting the format,
it's not like people calling the member should use something else.

f4da9f72

Add macOS fn key support. (#44410) · c921c5ae

Greg Spencer authored Nov 09, 2019

This adds support for the fn key on macOS. It adds it to the key mappings as a supplemental mapping that overwrites the one from the Chrome headers, since the chrome headers have a TODO, but no implementation of the key.

Also, ignore the fn key entirely on macOS. This is because On macOS laptop keyboards, the fn key is used to generate home/end and f1-f12, but it ALSO generates a separate down/up event for the fn key itself. Other platforms hide the fn key, and just produce the key that it is combined with, so to keep it possible to write cross platform code that looks at which keys are pressed, the fn key is ignored.

c921c5ae

08 Nov, 2019 18 commits

fix test for null flutter root (#44468) · 9fa0f3b2
Jonah Williams authored Nov 08, 2019

9fa0f3b2

Re-enable docs uploading (#44454) · 03ac37af

Collin Jackson authored Nov 08, 2019

* Revert "Turn off docs upload temporarily (#44365) (#44413)"

This reverts commit 8f2ea9d0.

* Re enables docs upload

03ac37af

Revert "Demonstrate that artifact invalidation works (#44312)" (#44463) · eeb88f43
Jonah Williams authored Nov 08, 2019
```
This reverts commit c1d029b8.
```
eeb88f43
switch web test to macOS (#44421) · 69a783b8
Jonah Williams authored Nov 08, 2019

69a783b8

Refactor flutter.gradle to use assemble directly (#43876) · 978fada3

Jonah Williams authored Nov 08, 2019

Removes multiple re-entrant calls of bundle and aot and replaces them with a single call to assemble. This restores full caching and will allow follow-up performance improvements when building multiple ABIs

978fada3

Demonstrate that artifact invalidation works (#44312) · c1d029b8
Jonah Williams authored Nov 08, 2019

c1d029b8
Segmented control quick double tap fix (#44391) · 09c80aa4
LongCatIsLooong authored Nov 08, 2019

09c80aa4
Adding subtitle to ExpansionTile (#43946) · d961ae85
Luiz França authored Nov 08, 2019
```
* Adding subtitle to expansion_tile
```
d961ae85

Roll engine 6a1f093398c6..5f5713e33971 (5 commits) (#44448) · dd597395

engine-flutter-autoroll authored Nov 08, 2019

git@github.com:flutter/engine.git/compare/6a1f093398c6...5f5713e33971

git log 6a1f093398c6..5f5713e33971 --no-merges --oneline
2019-11-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia 99b558b594a1..8c1e265f6f81 (1 commits) (flutter/engine#13751)
2019-11-08 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from H_5HL... to KRali... (flutter/engine#13750)
2019-11-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia 3fd426d19df3..99b558b594a1 (1 commits) (flutter/engine#13749)
2019-11-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia 76eaab6b8cef..3fd426d19df3 (1 commits) (flutter/engine#13746)
2019-11-08 chinmaygarde@google.com Create a new picture recorder even when the embedder supplied render target is recycled. (flutter/engine#13744)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

dd597395

Make selected item get focus when dropdown is opened (#43722) · 19778f9e

Greg Spencer authored Nov 08, 2019

As it stands, dropdowns currently do not focus the item that is selected, so if you select something on a dropdown, and then close it, and re-open it, then the new item is not auto-focused. This PR changes that so that selected value is focused by default when the dropdown is re-opened.

19778f9e

Roll engine 7ed9c9fc5885..6a1f093398c6 (5 commits) (#44419) · 4cc8ce06

engine-flutter-autoroll authored Nov 08, 2019

git@github.com:flutter/engine.git/compare/7ed9c9fc5885...6a1f093398c6

git log 7ed9c9fc5885..6a1f093398c6 --no-merges --oneline
2019-11-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia 345a2735e2c8..76eaab6b8cef (18 commits) (flutter/engine#13745)
2019-11-08 gw280@google.com Only specify --no-link-platform when not specifying --aot, roll dart-lang sdk (flutter/engine#13742)
2019-11-08 ferhat@gmail.com Don't run engine tests under vm (causing warnings) (flutter/engine#13737)
2019-11-07 christopherfujino@gmail.com Switch to Cirrus Dockerfile as CI (flutter/engine#13440)
2019-11-07 matthew-carroll@users.noreply.github.com Removed scary experimental warnings for new embedding. (#44314) (flutter/engine#13738)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

4cc8ce06

Roll engine 629930e8887c..7ed9c9fc5885 (2 commits) (#44401) · ff95b14a

engine-flutter-autoroll authored Nov 08, 2019

git@github.com:flutter/engine.git/compare/629930e8887c...7ed9c9fc5885

git log 629930e8887c..7ed9c9fc5885 --no-merges --oneline
2019-11-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia f66ec5d69d04..345a2735e2c8 (1 commits) (flutter/engine#13732)
2019-11-07 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from r1tS4... to H_5HL... (flutter/engine#13734)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

ff95b14a

Reland: enable usage of experimental web compiler (#44400) · cc51ad5d
Jonah Williams authored Nov 08, 2019

cc51ad5d
Turn off docs upload temporarily (#44365) (#44413) · 8f2ea9d0
Jenn Magder authored Nov 08, 2019

8f2ea9d0
fixing todo comments in flutter tests to include url link. (#42691) · 6a9b72c1
chunhtai authored Nov 08, 2019

6a9b72c1

629930e88 Prefer SchedulerBinding.addTimingsCallback (flutter/engine#13728) (#44388) · d3c40321

engine-flutter-autoroll authored Nov 08, 2019


git@github.com:flutter/engine.git/compare/ddceed5f7af1...629930e8887c

git log ddceed5f7af1..629930e8887c --no-merges --oneline
2019-11-07 liyuqian@google.com Prefer SchedulerBinding.addTimingsCallback (flutter/engine#13728)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

d3c40321

Revert "Enable usage of experimental incremental compiler for web (#43576)" (#44396) · 7535ef73
Jonah Williams authored Nov 08, 2019
```
This reverts commit e5d6d924.
```
7535ef73
Enable usage of experimental incremental compiler for web (#43576) · e5d6d924
Jonah Williams authored Nov 08, 2019

e5d6d924

07 Nov, 2019 19 commits

Roll engine c448d39d5307..ddceed5f7af1 (2 commits) (#44380) · 99f2b940

engine-flutter-autoroll authored Nov 07, 2019

git@github.com:flutter/engine.git/compare/c448d39d5307...ddceed5f7af1

git log c448d39d5307..ddceed5f7af1 --no-merges --oneline
2019-11-07 alexmarkov@google.com Cleanup obsolete --strong option of front-end server (flutter/engine#13735)
2019-11-07 bkonyi@google.com Roll src/third_party/dart bdd9e74afc..4b9638aaa1 (7 commits)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

99f2b940

Revert "Turn off docs upload temporarily (#44365)" (#44371) · 62b7ce30

Collin Jackson authored Nov 07, 2019

* Revert "Turn off docs upload temporarily (#44365)"

This reverts commit 3dd67410.

* show contents of firebase-debug.log

62b7ce30

Flip enable-android-embedding-v2 flag (#44369) · 2c80bc97
Emmanuel Garcia authored Nov 07, 2019

2c80bc97
Remove TODO that's done (#44318) · cc9e9ce2
liyuqian authored Nov 07, 2019
```
See https://github.com/flutter/engine/pull/13728
```
cc9e9ce2
Re-enable Pesto in profile/release mode (#44299) · 2eb8caf1
liyuqian authored Nov 07, 2019
```
See https://github.com/flutter/flutter/issues/9257#issuecomment-550503833
```
2eb8caf1
[flutter_tool] Stream artifact downloads to files (#44360) · 12c190f7
Zachary Anderson authored Nov 07, 2019

12c190f7
Update packages to get latest dwds (#44344) · b10a5d68
Danny Tuppeny authored Nov 07, 2019

b10a5d68
CupertinoDynamicColor improvements (#44317) · 62db22d1
LongCatIsLooong authored Nov 07, 2019

62db22d1
Add more flutter build ios-framework tests before the impending jonahpocalypse (#44308) · 604f1761
xster authored Nov 07, 2019

604f1761
Fixing local golden output flake (#44307) · dfbbfcd3
Kate Lovett authored Nov 07, 2019

dfbbfcd3

Turn off docs upload temporarily (#44365) · 3dd67410

Greg Spencer authored Nov 07, 2019

Turning off Docs upload temporarily until Firebase outage is over.
Landing on red to fix the build.

3dd67410

Don't print how to consume AARs when building plugins as AARs (#44301) · b0ad6072
Emmanuel Garcia authored Nov 07, 2019

b0ad6072
Update create.dart (#43764) · 9492dcc7
Afzaal Ahmad Zeeshan authored Nov 07, 2019
```
Changed the placements of the operands to make it more readable.
```
9492dcc7
Fix v1 embedding support heuristic for plugins (#44214) · cb614d13
Emmanuel Garcia authored Nov 07, 2019

cb614d13

c448d39d5 Roll src/third_party/skia 714f8cc3ff4b..f66ec5d69d04 (3 commits)... · e3742b6e

engine-flutter-autoroll authored Nov 07, 2019

c448d39d5 Roll src/third_party/skia 714f8cc3ff4b..f66ec5d69d04 (3 commits) (flutter/engine#13729) (#44321)

git@github.com:flutter/engine.git/compare/d68c00947e6e...c448d39d5307

git log d68c00947e6e..c448d39d5307 --no-merges --oneline
2019-11-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia 714f8cc3ff4b..f66ec5d69d04 (3 commits) (flutter/engine#13729)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

e3742b6e

d68c00947 Roll fuchsia/sdk/core/mac-amd64 from 6Du8E... to r1tS4... (flutter/engine#13726) (#44319) · 106ef35e

engine-flutter-autoroll authored Nov 07, 2019


git@github.com:flutter/engine.git/compare/34a40cfbfd36...d68c00947e6e

git log 34a40cfbfd36..d68c00947e6e --no-merges --oneline
2019-11-07 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from 6Du8E... to r1tS4... (flutter/engine#13726)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

106ef35e

l10n tool improvements, stocks app refresh (#44313) · b883624c
Shi-Hao Hong authored Nov 07, 2019
```
* Add pubspec.yaml comment

* Add --help flag
```
b883624c

Roll engine abaa85a394c8..34a40cfbfd36 (2 commits) (#44315) · 798e4272

engine-flutter-autoroll authored Nov 07, 2019

git@github.com:flutter/engine.git/compare/abaa85a394c8...34a40cfbfd36

git log abaa85a394c8..34a40cfbfd36 --no-merges --oneline
2019-11-07 bkonyi@google.com Roll src/third_party/dart c154677699..bdd9e74afc (3 commits)
2019-11-06 skia-flutter-autoroll@skia.org Roll src/third_party/skia 6790423f84ef..714f8cc3ff4b (8 commits) (flutter/engine#13724)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

798e4272

abaa85a39 [web] Proper support for text field's obscureText (flutter/engine#13722) (#44311) · 369860bc

engine-flutter-autoroll authored Nov 07, 2019


git@github.com:flutter/engine.git/compare/2a8f6dca6006...abaa85a394c8

git log 2a8f6dca6006..abaa85a394c8 --no-merges --oneline
2019-11-06 mouad.debbar@gmail.com [web] Proper support for text field's obscureText (flutter/engine#13722)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

369860bc

06 Nov, 2019 1 commit

Roll engine 8ebb31840134..2a8f6dca6006 (2 commits) (#44303) · 4853c240

engine-flutter-autoroll authored Nov 06, 2019

git@github.com:flutter/engine.git/compare/8ebb31840134...2a8f6dca6006

git log 8ebb31840134..2a8f6dca6006 --no-merges --oneline
2019-11-06 bkonyi@google.com Roll src/third_party/dart 462a448ac8..c154677699 (2 commits)
2019-11-06 gw280@google.com Package fml_unittests in a .far file for fml unit tests on Fuchsia (flutter/engine#13471)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

4853c240