- 10 Jan, 2019 1 commit
-
-
Michael Goderbauer authored
-
- 23 Dec, 2018 1 commit
-
-
Ian Hickson authored
-
- 21 Dec, 2018 1 commit
-
-
Stanislav Baranov authored
* Switch over to the new name for compilation trace native function. Also see: https://github.com/flutter/engine/pull/7256 * rename * roll the engine
-
- 18 Dec, 2018 2 commits
-
-
Alexandre Ardhuin authored
-
Alexandre Ardhuin authored
-
- 15 Dec, 2018 1 commit
-
-
Stanislav Baranov authored
-
- 11 Dec, 2018 1 commit
-
-
Michael Goderbauer authored
-
- 30 Nov, 2018 1 commit
-
-
Ian Hickson authored
-
- 08 Nov, 2018 2 commits
-
-
Greg Spencer authored
This converts existing ## Sample code samples to {@tool sample}...{@end-tool} form. Also: 1. Fixed a minor bug in analyze-sample-code.dart 2. Made the snippet tool only insert descriptions if the description is non-empty. 3. Moved the Card diagram to before the code sample.
-
Ian Hickson authored
We have templates now.
-
- 05 Nov, 2018 1 commit
-
-
Greg Spencer authored
This rewrites the sample code analysis script to be a little less of a hack (but still not pretty), and to handle snippets as well. It also changes the semantics of how sample code is handled: the namespace for the sample code is now limited to the file that it appears in, so some additional "Examples can assume:" blocks were added. The upside of this is that there will be far fewer name collisions. I fixed the output too: no longer will you get 4000 lines of numbered output with the error at the top and have to grep for the actual problem. It gives the filename and line number of the original location of the code (in the comment in the tree), and prints out the source code on the line that caused the problem along with the error. For snippets, it prints out the location of the start of the snippet and the source code line that causes the problem. It can't print out the original line, because snippets get formatted when they are written, so the line might not be in the same place.
-
- 31 Oct, 2018 1 commit
-
-
Michael Goderbauer authored
-
- 30 Oct, 2018 1 commit
-
-
Ian Hickson authored
Luckily this class didn't actually need to extend its superclass, it only implements the interface. So we can change `extends` to `implements` and that's close enough, while allowing the class to be mixed in again.
-
- 27 Oct, 2018 1 commit
-
-
Ian Hickson authored
* Created a variant of InheritedWidget specifically for Listenables * Add more documentation per review comments
-
- 26 Oct, 2018 1 commit
-
-
Ian Hickson authored
* Improve documentation * Potential performance win in hit testing Rather than copying the list every time we access `path`, this just exposes it as an `Iterable`. People who want to copy it can use `toList()`. (This isn't a breaking change since code that expects a `List` is still going to get one.) * Enforce the Oxford Comma.
-
- 23 Oct, 2018 1 commit
-
-
Michael Goderbauer authored
-
- 19 Oct, 2018 1 commit
-
-
Michael Goderbauer authored
This reverts commit 8e2ca93f. Fixes https://github.com/flutter/flutter/issues/23172
-
- 17 Oct, 2018 2 commits
-
-
Alexandre Ardhuin authored
* enable lint prefer_void_to_null * replace last Null by void
- 16 Oct, 2018 2 commits
-
-
Alexandre Ardhuin authored
* Future<void> main * Future<void>.delayed * prefer_void_to_Null * address review comments
-
Amir Hardon authored
Before this PR AndroidView's gestureRecognizers field was a list of gesture recognizers. This was problematic as when the widget was rebuilt with the same gesture recognizer instances we would try to re-join the recognizers to a gesture arena team and crash (as a OneSeqeunceGestureRecognizer team can only be set once). With this change, we instead take a set of factories. This allows AndroidView to create the gesture recognizers just before adding them to the team, and thus be sure that they are only added once to a team. The factories are identified by the type of the object they create, this allows AndroidView to know when it is given an equivalent set of gesture recognizer factories, and do nothing in that case.
-
- 13 Oct, 2018 1 commit
-
-
Michael Goderbauer authored
Service extensions can only be activated in debug or profile mode, their code should never be included in release mode. This PR adds guards around all service extension registration calls that enable Dart's tree shaker to remove the extension's code in release mode, which reduces our binary size: Android Snapshot (uncompressed): minus 127,384 Bytes (-124.40KB) APK (compressed): minus 38,136 Bytes (-37.24KB) iOS Snapshot (App.framework, uncompressed): 264,304 Bytes(-258.10KB) For details: https://docs.google.com/document/d/13JlgvliCn5sWwT2K2SfDwD1NhEfxpJH9DCf22gZZru8/edit **Benchmark Regressions:** This PR may cause benchmarks to regress because it may change the timing of GC. If you notice a benchmark regression **please note down the exact set of benchmarks that regressed on this PR** and then feel free to revert. I will follow-up with a PR that forces a GC before the effected benchmarks run to get a clean baseline before re-applying this PR.
-
- 05 Oct, 2018 2 commits
-
-
Yegor authored
* first pass * revert WidgetsBindingObserver * disable prefer_mixin * docs and more mixins * newer engine; binding fixes * upgrade dependencies * fix test binding * remove whitespace * remove the obsolete `enableSuperMixins: true` * upgrade dartdoc to 0.22.0 * temporarily use git version of dartdoc * fix pub global activate syntax * use dartdoc 0.23.0
- 04 Oct, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 01 Oct, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 24 Sep, 2018 1 commit
-
-
Michael Klimushyn authored
-
- 14 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint unnecessary_new * fix tests * fix tests * fix tests
-
- 07 Sep, 2018 2 commits
-
-
Alexandre Ardhuin authored
* lint unnecessary_new on samples * fix tests
-
Alexandre Ardhuin authored
-
- 18 Aug, 2018 1 commit
-
-
Ian Hickson authored
* Fixes resulting from audit of issues links I looked at every link to GitHub in our repo. For cases where we had a TODO that was waiting for a bug to be fixed, and the bug has now been fixed, I applied the pending change. For cases where the link was out of date, I updated the link. * Update run_test.dart skip this test again since it failed on linux and macos bots
-
- 10 Aug, 2018 1 commit
-
-
Mikkel Nygaard Ravn authored
-
- 03 Aug, 2018 1 commit
-
-
Ian Hickson authored
The following changes are made by this PR: * Translation bundles now implement MaterialLocalizations directly, and are public so that they can be directly extended. * The list of supported languages is now a generated constant. * The icuShortTimePattern/TimeOfDayFormat values are now pre-parsed. * Various other changes for consistency with the style guide and the rest of the codebase, e.g. the class names don't use `_`, the `path` library is imported as such, more dartdocs, fewer `// ignore`s, validation using exceptions. This reduces our technical debt benchmark.
-
- 02 Aug, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 27 Jul, 2018 1 commit
-
-
Todd Volkert authored
It was causing problems rolling Flutter into Fuchsia
-
- 23 Jul, 2018 1 commit
-
-
Alexandre Ardhuin authored
* re-enable lint unnecessary_const * remove trailling whitespaces * remove unnecessary const (after merge)
-
- 20 Jul, 2018 1 commit
-
-
Greg Spencer authored
-
- 16 Jul, 2018 2 commits
-
-
Ian Hickson authored
This reverts commit cc1cf13e.
-
Alexandre Ardhuin authored
-