1. 10 Jan, 2019 1 commit
  2. 23 Dec, 2018 1 commit
  3. 21 Dec, 2018 1 commit
  4. 18 Dec, 2018 2 commits
  5. 15 Dec, 2018 1 commit
  6. 11 Dec, 2018 1 commit
  7. 30 Nov, 2018 1 commit
  8. 08 Nov, 2018 2 commits
  9. 05 Nov, 2018 1 commit
    • Greg Spencer's avatar
      Rewrite the analyze-sample-code script to also analyze snippets (#23893) · 202b045b
      Greg Spencer authored
      This rewrites the sample code analysis script to be a little less of a hack (but still not pretty), and to handle snippets as well.
      
      It also changes the semantics of how sample code is handled: the namespace for the sample code is now limited to the file that it appears in, so some additional "Examples can assume:" blocks were added. The upside of this is that there will be far fewer name collisions.
      
      I fixed the output too: no longer will you get 4000 lines of numbered output with the error at the top and have to grep for the actual problem. It gives the filename and line number of the original location of the code (in the comment in the tree), and prints out the source code on the line that caused the problem along with the error.
      
      For snippets, it prints out the location of the start of the snippet and the source code line that causes the problem. It can't print out the original line, because snippets get formatted when they are written, so the line might not be in the same place.
      202b045b
  10. 31 Oct, 2018 1 commit
  11. 30 Oct, 2018 1 commit
    • Ian Hickson's avatar
      Allow ChangeNotifier to be mixed in again (#23631) · c319b890
      Ian Hickson authored
      Luckily this class didn't actually need to extend its superclass, it
      only implements the interface. So we can change `extends` to
      `implements` and that's close enough, while allowing the class to be
      mixed in again.
      c319b890
  12. 27 Oct, 2018 1 commit
  13. 26 Oct, 2018 1 commit
    • Ian Hickson's avatar
      [O] Cleanup (#23530) · 48a5804d
      Ian Hickson authored
      * Improve documentation
      
      * Potential performance win in hit testing
      
      Rather than copying the list every time we access `path`, this just
      exposes it as an `Iterable`. People who want to copy it can use
      `toList()`.
      
      (This isn't a breaking change since code that expects a `List` is
      still going to get one.)
      
      * Enforce the Oxford Comma.
      48a5804d
  14. 23 Oct, 2018 1 commit
  15. 19 Oct, 2018 1 commit
  16. 17 Oct, 2018 2 commits
  17. 16 Oct, 2018 2 commits
    • Alexandre Ardhuin's avatar
      Prefer void to null (#22977) · 0fb84e96
      Alexandre Ardhuin authored
      * Future<void> main
      
      * Future<void>.delayed
      
      * prefer_void_to_Null
      
      * address review comments
      0fb84e96
    • Amir Hardon's avatar
      Make AndroidView take gesture recognizer factories. (#21657) · 707eaf5e
      Amir Hardon authored
      Before this PR AndroidView's gestureRecognizers field was a list of
      gesture recognizers. This was problematic as when the widget was rebuilt
      with the same gesture recognizer instances we would try to re-join the
      recognizers to a gesture arena team and crash (as a OneSeqeunceGestureRecognizer
      team can only be set once).
      
      With this change, we instead take a set of factories.
      This allows AndroidView to create the gesture recognizers just before
      adding them to the team, and thus be sure that they are only added once to a
      team.
      
      The factories are identified by the type of the object they create, this
      allows AndroidView to know when it is given an equivalent set of gesture
      recognizer factories, and do nothing in that case.
      707eaf5e
  18. 13 Oct, 2018 1 commit
    • Michael Goderbauer's avatar
      Remove all service extensions from release mode (#23038) · 8e2ca93f
      Michael Goderbauer authored
      Service extensions can only be activated in debug or profile mode, their code should never be included in release mode. This PR adds guards around all service extension registration calls that enable Dart's tree shaker to remove the extension's code in release mode, which reduces our binary size:
      
      Android Snapshot (uncompressed): minus 127,384 Bytes (-124.40KB)
      APK (compressed): minus 38,136 Bytes (-37.24KB)
      iOS Snapshot (App.framework, uncompressed): 264,304 Bytes(-258.10KB)
      
      For details: https://docs.google.com/document/d/13JlgvliCn5sWwT2K2SfDwD1NhEfxpJH9DCf22gZZru8/edit
      
      **Benchmark Regressions:** This PR may cause benchmarks to regress because it may change the timing of GC. If you notice a benchmark regression **please note down the exact set of benchmarks that regressed on this PR** and then feel free to revert. I will follow-up with a PR that forces a GC before the effected benchmarks run to get a clean baseline before re-applying this PR.
      8e2ca93f
  19. 05 Oct, 2018 2 commits
  20. 04 Oct, 2018 1 commit
  21. 01 Oct, 2018 1 commit
  22. 24 Sep, 2018 1 commit
  23. 14 Sep, 2018 1 commit
  24. 12 Sep, 2018 1 commit
  25. 07 Sep, 2018 2 commits
  26. 18 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Fixes resulting from audit of issues links (#20772) · 8c79f40d
      Ian Hickson authored
      * Fixes resulting from audit of issues links
      
      I looked at every link to GitHub in our repo. For cases where we had a TODO that was waiting for a bug to be fixed, and the bug has now been fixed, I applied the pending change. For cases where the link was out of date, I updated the link.
      
      * Update run_test.dart
      
      skip this test again since it failed on linux and macos bots
      8c79f40d
  27. 10 Aug, 2018 1 commit
  28. 03 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Cleanup in localizations code (#20018) · 75960f35
      Ian Hickson authored
      The following changes are made by this PR:
      
       * Translation bundles now implement MaterialLocalizations directly,
         and are public so that they can be directly extended.
      
       * The list of supported languages is now a generated constant.
      
       * The icuShortTimePattern/TimeOfDayFormat values are now pre-parsed.
      
       * Various other changes for consistency with the style guide and the
         rest of the codebase, e.g. the class names don't use `_`, the
         `path` library is imported as such, more dartdocs, fewer `//
         ignore`s, validation using exceptions.
      
      This reduces our technical debt benchmark.
      75960f35
  29. 02 Aug, 2018 1 commit
  30. 27 Jul, 2018 1 commit
  31. 23 Jul, 2018 1 commit
  32. 20 Jul, 2018 1 commit
  33. 16 Jul, 2018 2 commits