Commits · f3e367bed7231686c8c54f9772daeef2919bc247 · abdullh.alsoleman / Front-End

10 Feb, 2024 4 commits

Roll Flutter Engine from 1b8f23bbd099 to e08b6c899c42 (2 revisions) (#143264) · f3e367be

engine-flutter-autoroll authored Feb 10, 2024

https://github.com/flutter/engine/compare/1b8f23bbd099...e08b6c899c42

2024-02-10 dnfield@google.com Clean up additional NDK helper related code (flutter/engine#50518)
2024-02-09 tugorez@users.noreply.github.com Make the web engine publish view forward focus and unfocus events (flutter/engine#50177)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f3e367be

Roll Flutter Engine from 41daa5b913b9 to 1b8f23bbd099 (2 revisions) (#143261) · ee8d3f5e

engine-flutter-autoroll authored Feb 10, 2024

https://github.com/flutter/engine/compare/41daa5b913b9...1b8f23bbd099

2024-02-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from RK2irywND2DKT4l6C... to H1cNBBNhq0bEpcyPs... (flutter/engine#50517)
2024-02-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 444f7a422da4 to 10ca8dc7d2b4 (1 revision) (flutter/engine#50516)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from RK2irywND2DK to H1cNBBNhq0bE

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ee8d3f5e

Roll Flutter Engine from f969c52f133a to 41daa5b913b9 (1 revision) (#143258) · 923c6ed3

engine-flutter-autoroll authored Feb 10, 2024

https://github.com/flutter/engine/compare/f969c52f133a...41daa5b913b9

2024-02-09 chinmaygarde@google.com [Impeller] Add --enable-impeller-vulkan-playgrounds to ./flutter/tools/gn (flutter/engine#50477)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

923c6ed3

Roll Flutter Engine from 6a3b0216ff5b to f969c52f133a (3 revisions) (#143256) · e38e7d78

engine-flutter-autoroll authored Feb 10, 2024

https://github.com/flutter/engine/compare/6a3b0216ff5b...f969c52f133a

2024-02-09 jason-simmons@users.noreply.github.com [Impeller] Remove the unused Vulkan queue submit task runner (flutter/engine#50511)
2024-02-09 zanderso@users.noreply.github.com Make .style.yapf and .pylintrc agree on line length (flutter/engine#50510)
2024-02-09 jason-simmons@users.noreply.github.com [Impeller] Call vkQueuePresentKHR through the ContextVK's synchronized graphics queue wrapper (flutter/engine#50509)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e38e7d78

09 Feb, 2024 23 commits

Roll Flutter Engine from 8c521eb24171 to 6a3b0216ff5b (4 revisions) (#143251) · d385d027

engine-flutter-autoroll authored Feb 09, 2024

https://github.com/flutter/engine/compare/8c521eb24171...6a3b0216ff5b

2024-02-09 30870216+gaaclarke@users.noreply.github.com [Impeller] cleaned up StrokePathGeometry and removed runtime polymorphism (flutter/engine#50506)
2024-02-09 ditman@gmail.com [web] Fix HtmlViewEmbedder.dispose (flutter/engine#50482)
2024-02-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 03130d49f214 to 444f7a422da4 (6 revisions) (flutter/engine#50502)
2024-02-09 jonahwilliams@google.com [Impeller] improve performance of polyline and stroke generation by reducing allocation and lambda usage. (flutter/engine#50379)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d385d027

Upgrade leak_tracker. (#143236) · b48dfca3
Polina Cherkasova authored Feb 09, 2024

b48dfca3

Fix: performance improvement on golden test comparison (#142913) · 2f117c54

Kris Pypen authored Feb 09, 2024

During golden test image comparison 2 lists of a different type are compared with the method "identical", so this will never be true. The test image is a _Uint8ArrayView while the master image is an Uint8List. So that results in always a heavy computation to get the difference between the test and the master image.

When you run this test snippet I go from 51 seconds to 14 seconds:
```dart
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';

void main() {
  for (int i = 0; i < 100; i++) {
    testWidgets('Small test', (WidgetTester tester) async {
      await tester.pumpWidget(Directionality(textDirection: TextDirection.ltr, child: Text('jo')));
      await expectLater(find.byType(Text), matchesGoldenFile('main.png'));
    });
  }
}
```

2f117c54

Implementing `switch` expressions in `lib/src/material/` (#142793) · 1887bc41

Nate authored Feb 09, 2024

This PR is the 6áµÊ° step in the journey to solve issue #136139 and make the entire Flutter repo more readable.

(previous pull requests: #139048, #139882, #141591, #142279, #142634)

The current focus is on `packages/flutter/lib/src/material/`. The previous 2 PRs covered files in this directory starting with letters `a-m`; this one takes care of everything else.

1887bc41

Add position data to `OnDragEnd` callback (#140378) · fa71e802

Henry Riehl authored Feb 09, 2024

This PR adds localPosition/globalPosition data to the `DragEndDetails`
argument of the `onDragEnd` callback.

fa71e802

Roll Flutter Engine from 1232d598f7c4 to 8c521eb24171 (2 revisions) (#143237) · ed02cf2f

engine-flutter-autoroll authored Feb 09, 2024

https://github.com/flutter/engine/compare/1232d598f7c4...8c521eb24171

2024-02-09 skia-flutter-autoroll@skia.org Roll Skia from fbe1d2265637 to 4081496b7693 (1 revision) (flutter/engine#50499)
2024-02-09 zanderso@users.noreply.github.com Supports building with RBE on a Windows host. (flutter/engine#49877)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ed02cf2f

Roll Flutter Engine from 7a5390c6b3bd to 1232d598f7c4 (1 revision) (#143235) · 2edf7d7b

engine-flutter-autoroll authored Feb 09, 2024

https://github.com/flutter/engine/compare/7a5390c6b3bd...1232d598f7c4

2024-02-09 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 452dd17120b7 to 03130d49f214 (4 revisions) (flutter/engine#50494)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2edf7d7b

Set plugin template minimum iOS version to 12.0 (#143167) · 2fc19619

Jenn Magder authored Feb 09, 2024

Fixes https://github.com/flutter/flutter/issues/140474

See https://github.com/flutter/flutter/pull/122625 where this was done 11->12.

2fc19619

Roll Flutter Engine from 7a241130fcf8 to 7a5390c6b3bd (1 revision) (#143231) · 2207a307

engine-flutter-autoroll authored Feb 09, 2024

https://github.com/flutter/engine/compare/7a241130fcf8...7a5390c6b3bd

2024-02-09 skia-flutter-autoroll@skia.org Roll Skia from 14ee546dcfe8 to fbe1d2265637 (2 revisions) (flutter/engine#50495)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2207a307

Migrate integration_test plugin to Gradle Kotlin DSL (#142008) · 60f30a65

Bartek Pacia authored Feb 09, 2024

We already have a simple app in this repo that fully uses Gradle Kotlin DSL (see #141541). The next small step is to have at least one plugin that also uses Gradle Kotlin DSL. Let's use `integration_test` for that, since it's versioned with Flutter SDK.

60f30a65

Roll Flutter Engine from dcac9863a1fc to 7a241130fcf8 (1 revision) (#143222) · 445b0868

engine-flutter-autoroll authored Feb 09, 2024

https://github.com/flutter/engine/compare/dcac9863a1fc...7a241130fcf8

2024-02-09 skia-flutter-autoroll@skia.org Roll Skia from 68cb550de88d to 14ee546dcfe8 (1 revision) (flutter/engine#50493)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

445b0868

Roll Flutter Engine from 1508b11bf791 to dcac9863a1fc (1 revision) (#143220) · 2174915c

engine-flutter-autoroll authored Feb 09, 2024

https://github.com/flutter/engine/compare/1508b11bf791...dcac9863a1fc

2024-02-09 jason-simmons@users.noreply.github.com [Impeller] Remove the Vulkan queue submit thread and always present Vulkan images on the raster thread (flutter/engine#50484)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2174915c

Roll Packages from 29d8cc006b0e to 11152d2bc8f3 (4 revisions) (#143217) · 03891a45

engine-flutter-autoroll authored Feb 09, 2024

https://github.com/flutter/packages/compare/29d8cc006b0e...11152d2bc8f3

2024-02-09 jsharp83@gmail.com [webview_flutter] Add interface for showing javascript dialog message (flutter/packages#4704)
2024-02-09 32931186+erdzan12@users.noreply.github.com [pigeon] Implement Screaming Snake Case Conversion for Kotlin Enum Cases (flutter/packages#5918)
2024-02-09 43054281+camsim99@users.noreply.github.com [camerax] Small fixes to starting/stopping video capture (flutter/packages#6068)
2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter from 8431cae8 to eb5d0a43 (33 revisions) (flutter/packages#6079)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

03891a45

Roll Flutter Engine from 350dc662e5af to 1508b11bf791 (1 revision) (#143214) · 5f89a503

engine-flutter-autoroll authored Feb 09, 2024

https://github.com/flutter/engine/compare/350dc662e5af...1508b11bf791

2024-02-09 skia-flutter-autoroll@skia.org Roll Skia from 64a25300fe1c to 68cb550de88d (2 revisions) (flutter/engine#50491)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5f89a503

barrierColor property in DialogTheme (#142490) · f0bb9d57
David Martos authored Feb 09, 2024

f0bb9d57

Roll Flutter Engine from f6dddb257a4f to 350dc662e5af (1 revision) (#143208) · 8b228b9e

engine-flutter-autoroll authored Feb 09, 2024

https://github.com/flutter/engine/compare/f6dddb257a4f...350dc662e5af

2024-02-09 skia-flutter-autoroll@skia.org Roll Skia from 9bcc54924128 to 64a25300fe1c (3 revisions) (flutter/engine#50489)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8b228b9e

Roll Flutter Engine from 377f1b068541 to f6dddb257a4f (1 revision) (#143207) · 950e0025

engine-flutter-autoroll authored Feb 09, 2024

https://github.com/flutter/engine/compare/377f1b068541...f6dddb257a4f

2024-02-09 skia-flutter-autoroll@skia.org Roll Skia from c36362d95df0 to 9bcc54924128 (1 revision) (flutter/engine#50488)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

950e0025

Roll Flutter Engine from 1f3b15738adb to 377f1b068541 (1 revision) (#143204) · 88dead01

engine-flutter-autoroll authored Feb 09, 2024

https://github.com/flutter/engine/compare/1f3b15738adb...377f1b068541

2024-02-09 skia-flutter-autoroll@skia.org Roll Skia from 672bb50b6d8f to c36362d95df0 (3 revisions) (flutter/engine#50485)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

88dead01

Roll Flutter Engine from f9a169e0e0c1 to 1f3b15738adb (1 revision) (#143201) · 189fe6b7

engine-flutter-autoroll authored Feb 09, 2024

https://github.com/flutter/engine/compare/f9a169e0e0c1...1f3b15738adb

2024-02-09 dnfield@google.com [Impeller] Move impeller/image to impeller/playground/image (flutter/engine#50480)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

189fe6b7

Roll Flutter Engine from 7b579dc30979 to f9a169e0e0c1 (2 revisions) (#143199) · 34585771

engine-flutter-autoroll authored Feb 09, 2024

https://github.com/flutter/engine/compare/7b579dc30979...f9a169e0e0c1

2024-02-09 chinmaygarde@google.com Sever the //flutter/vulkan dependency in Flutter in the Android embedder. (flutter/engine#50472)
2024-02-08 skia-flutter-autoroll@skia.org Roll Skia from 59943f4e92b9 to 672bb50b6d8f (3 revisions) (flutter/engine#50476)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

34585771

Layout animated GIFs only once (#143188) · 0aa9b5e1

Michael Goderbauer authored Feb 09, 2024

Fixes https://github.com/flutter/flutter/issues/138610.

When `RenderImage` receives a new `Image` it only needs to fire up the layout machinery when the dimensions of the image have changed compared to the previous image. If the dimensions are the same, a repaint is sufficient.

0aa9b5e1

Roll Flutter Engine from 95feed196aab to 7b579dc30979 (1 revision) (#143195) · 5f1a3c16

engine-flutter-autoroll authored Feb 09, 2024

https://github.com/flutter/engine/compare/95feed196aab...7b579dc30979

2024-02-08 ditman@gmail.com Reland "[web] Fix Scene clip bounds. Trigger resize on DPR Change." (flutter/engine#50457)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5f1a3c16

Roll Flutter Engine from eabac2fa7a26 to 95feed196aab (2 revisions) (#143192) · 808588c7

engine-flutter-autoroll authored Feb 09, 2024

https://github.com/flutter/engine/compare/eabac2fa7a26...95feed196aab

2024-02-08 chinmaygarde@google.com [Impeller] Delete the archivist framework. (flutter/engine#50474)
2024-02-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from CPiPDUwCrjHYf_lAR... to RK2irywND2DKT4l6C... (flutter/engine#50473)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from CPiPDUwCrjHY to RK2irywND2DK

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

808588c7

08 Feb, 2024 13 commits

Roll Flutter Engine from 9b37c68b4069 to eabac2fa7a26 (2 revisions) (#143190) · ebeba8f0

engine-flutter-autoroll authored Feb 08, 2024

https://github.com/flutter/engine/compare/9b37c68b4069...eabac2fa7a26

2024-02-08 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.0 to 4.3.1 (flutter/engine#50388)
2024-02-08 chinmaygarde@google.com Sever the //flutter/vulkan dependency in Flutter tester. (flutter/engine#50454)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ebeba8f0

Roll Flutter Engine from 6f5b6a37107b to 9b37c68b4069 (2 revisions) (#143189) · 87dd27cf

engine-flutter-autoroll authored Feb 08, 2024

https://github.com/flutter/engine/compare/6f5b6a37107b...9b37c68b4069

2024-02-08 30870216+gaaclarke@users.noreply.github.com Updated CONTRIBUTING.md to have a testing section (flutter/engine#50469)
2024-02-08 26625149+0xZOne@users.noreply.github.com Fix Core Foundation object leaks. (flutter/engine#50460)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

87dd27cf

Set default flutter source directory for gradle builds (#142934) · 2299ec78

Gustl22 authored Feb 08, 2024

See [#142498](https://github.com/flutter/flutter/pull/142498#discussion_r1478602032)
See this discussion: https://discord.com/channels/608014603317936148/1186378330178601000

2299ec78

[Re-land] Enforce a policy on supported Gradle, Java, AGP, and KGP versions (#143132) · 4b0abc77

Gray Mackall authored Feb 08, 2024

Re land of https://github.com/flutter/flutter/pull/142000. 
Differences:
1. Fixed the test that was failing in postsubmit. The reason was that the Flutter Gradle Plugin was being applied after KGP in that test, so we couldn't find the KGP version. This caused a log, and the test expects no logs. I moved FGP to after KGP
2. Added to the logs for when we can't find AGP. Change is from
>  "Warning: unable to detect project AGP version. Skipping version checking."

to 
> ~"Warning: unable to detect project AGP version. Skipping version checking. \nThis may be because you have applied the Flutter Gradle Plugin after AGP."~

update: the above is wrong, changed to 
> "Warning: unable to detect project KGP version. Skipping version checking. \nThis may be because you have applied AGP after the Flutter Gradle Plugin."

3. Added a note to the app-level build.gradle templates that FGP must go last
> // The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugin.

4b0abc77

Roll Flutter Engine from fb99a84de07e to 6f5b6a37107b (2 revisions) (#143183) · d1d69027

engine-flutter-autoroll authored Feb 08, 2024

https://github.com/flutter/engine/compare/fb99a84de07e...6f5b6a37107b

2024-02-08 110993981+htoor3@users.noreply.github.com [web] - Fix `inputmode` on Android Firefox (flutter/engine#46901)
2024-02-08 bdero@google.com [Impeller] Vulkan: Don't fail initialization if stencil-only textures aren't supported. (flutter/engine#50455)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d1d69027

Revert Dual Web Compile changes (#143175) · 2efeeb47

Jackson Gardner authored Feb 08, 2024

Dual Web Compile has had some issues where `flutter test` is not respecting the `--web-renderer` flag for some reason. I haven't gotten entirely to the bottom of the issue, but for now we need to rever these changes while I investigate. This reverts the following PRs:

https://github.com/flutter/flutter/pull/143128
https://github.com/flutter/flutter/pull/141396

While doing this revert, I had a few merge conflicts with https://github.com/flutter/flutter/pull/142760, and I tried to resolve the merge conflicts within the spirit of that PR's change, but @chingjun I might need your input on whether the imports I have modified are okay with regards to the change you were making.

2efeeb47

Cross-link SliverFixedExtentList/SliverPrototypeExtentList/SliverVariedExtentList (#143184) · 8d3c7b6f
Michael Goderbauer authored Feb 08, 2024
```
Fixes https://github.com/flutter/flutter/issues/141678.
```
8d3c7b6f

[flutter_tool] Retry a gradle build on connection timeout (#143084) · fbc9f2d5

Zachary Anderson authored Feb 08, 2024

This PR will likely not help with the issue on our CI discussed in
https://github.com/flutter/flutter/issues/142637, but will do one retry
for our users if they hit the same issue.

fbc9f2d5

Correct menu position when menu is constrained (#143121) · cc4abe92

Qun Cheng authored Feb 08, 2024

Fixes #142896

The original code below is to always place the selected item above(overlap) the popup button so that the selected item can always be visible: https://github.com/flutter/flutter/blob/f8a77225f360556322934a9a831ffc9c9f3125da/packages/flutter/lib/src/material/popup_menu.dart#L723-L732

But when menu height is constrained and the menu itself is super long, the selected item still assumes there is enough space to push up all the items whose index is smaller than the selected index. As a result, every time when the menu is open, the calculation provides a different result to be the offset for the selected index, and then with a constrained height, the menu looks jumping all over the place based on the different selected index.

https://github.com/flutter/flutter/assets/36861262/ad761f95-0ff5-4311-a81d-dac56df879c5

Even though the original calculation is to make the selected item visible when open the menu, the menu doesn't auto scroll and only expands itself as much as possible to show the selected one. In this case, if the screen it too small to show the selected item, we still cannot see it. This can be fixed by using `Scrollable.ensureVisible()`(#143118).

So we remove the calculation in this PR and the menu will always show up based on the top left of the anchor(button).

https://github.com/flutter/flutter/assets/36861262/03272f26-9440-4ac4-a701-9a0b41776ff9

cc4abe92

Enable the whole logcat log (#143119) · e64a372d
keyonghan authored Feb 08, 2024
```
Help with https://github.com/flutter/flutter/issues/142572.
```
e64a372d

Roll Flutter Engine from 3fb60b8f37c3 to fb99a84de07e (1 revision) (#143169) · aed2ae54

engine-flutter-autoroll authored Feb 08, 2024

https://github.com/flutter/engine/compare/3fb60b8f37c3...fb99a84de07e

2024-02-08 jonahwilliams@google.com [Impeller] remove extra buffer usage in compute. (flutter/engine#50415)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

aed2ae54

Roll Flutter Engine from f53fbd8393ce to 3fb60b8f37c3 (1 revision) (#143165) · efd1d1f5

engine-flutter-autoroll authored Feb 08, 2024

https://github.com/flutter/engine/compare/f53fbd8393ce...3fb60b8f37c3

2024-02-08 30870216+gaaclarke@users.noreply.github.com [Impeller] blur: drop eighth downsample barrier (flutter/engine#50405)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

efd1d1f5

Reland "Move native assets to `isolated/` directory" (#143055) · 4e70bfae

Daco Harkes authored Feb 08, 2024

Reland of https://github.com/flutter/flutter/pull/142709.

The revert of the revert is in the first commit, the fix in the commit on top.

The move of the fakes for packages/flutter_tools/test/general.shard/resident_runner_test.dart was erroneous before, as it was trying to use setters instead of a private field. This PR changes the private `_devFS` field in the fake to be a public `fakeDevFS` in line with other fakes.

## Original PR description

Native assets in other build systems are not built with `package:native_assets_builder` invoking `build.dart` scripts. Instead all packages have their own blaze rules. Therefore we'd like to not depend on `package:native_assets_builder` from flutter tools in g3 at all.

This PR aims to move the imports of `native_assets_builder` and `native_assets_cli` into the `isolated/` directory and into the files with a `main` function that are not used in with other build systems.

In order to be able to remove all imports in files used by other build systems, two new interfaces are added `HotRunnerNativeAssetsBuilder` and `TestCompilerNativeAssetsBuilder`. New parameters are then piped all the way through from the entry points:

* bin/fuchsia_tester.dart
* lib/executable.dart

The build_system/targets dir is already excluded in other build systems.

So, after this PR only the two above files and build_system/targets import from `isolated/native_assets/` and only `isolated/native_assets/` import `package:native_assets_cli` and `package:native_assets_builder`.

Context:

* https://github.com/flutter/flutter/issues/142041

4e70bfae