- 10 Jan, 2018 1 commit
-
-
Ian Hickson authored
Fixes https://github.com/flutter/flutter/issues/12553 The root cause of https://github.com/flutter/flutter/issues/12553 was that when the refresh indicator went away, which happened after the avatars had started their image loads but before the avatars had loaded, the DecoratedBoxes, along with the rest of the list, got GlobalKey-reparented, which caused the RenderDecoratedBox objects to unregister from the DecorationImagePainters, but they never re-registered since the whole subtree was in a RepaintBoundary and was therefore not explicitly repainted when the tree got reattached. This fixes the bug by explicitly requiring any RenderDecoratedBox to repaint when it's reattached. This is probably a little more aggressive than required; we could probably expose a flag on Decoration that says whether or not the onChanged handler will ever be invoked, and only call markNeedsPaint if that's true, but we'll do that if it turns out that there's a performance issue here. (This patch also introduces a bunch of improved debugging information that I used to track down the bug.)
-
- 14 Dec, 2017 1 commit
-
-
xster authored
-
- 07 Dec, 2017 1 commit
-
-
Ian Hickson authored
This allows the scheduler library to depend on the services library and the painting library to depend on the scheduler library without the services library having to depend on the scheduler library. While I was at it I also cleaned up some of the binding logic: the licenses logic can now be overridden (and the test library does so), and the image cache can now be overridden as well.
-
- 17 Nov, 2017 1 commit
-
-
Greg Spencer authored
I got tired of drive-by spelling fixes, so I figured I'd just take care of them all at once. This only corrects errors in the dartdocs, not regular comments, and I skipped any sample code in the dartdocs. It doesn't touch any identifiers in the dartdocs either. No code changes, just comments.
-
- 01 Nov, 2017 1 commit
-
-
Ian Hickson authored
Various improvements (in particular a new painting fuzzer) to the text manual test. Some additional documentation. A fix to Stack to remove an LTR bias: make unpositioned children apply "alignment". Some more debugging information on RichText and Text. A fix to the flutter tool to not crash when an RPC call throws an exception.
-
- 20 Oct, 2017 1 commit
-
-
Ian Hickson authored
This avoids some code duplication that existed before and will make further modifications easier.
-
- 02 Oct, 2017 1 commit
-
-
Adam Barth authored
Unlike FractionalOffset, Alignment uses the center as the zero of the coordinate system, which makes the RTL math work out much cleaner. Also, make FractionalOffset into a subclass of Alignment so that clients can continue to use FractionalOffset.
-
- 24 Sep, 2017 1 commit
-
-
Ian Hickson authored
-
- 23 Sep, 2017 1 commit
-
-
Ian Hickson authored
After all my recent refactorings, some of the names were not really reasonable any more.
-
- 21 Sep, 2017 1 commit
-
-
Ian Hickson authored
To make it cleaner when we RTLify these.
-