- 20 Mar, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 21 Sep, 2017 1 commit
-
-
Alexandre Ardhuin authored
-
- 03 Aug, 2017 1 commit
-
-
Jacob Richman authored
Add Diagnosticable base class and documentation
-
- 27 Jul, 2017 1 commit
-
-
Ian Hickson authored
It was 8.0. It's now arbitrarily 18.0. Changing this required adjusting some tests. Adjusting the tests required debugging the tests. Debugging the tests required some tools to help debugging gesture recognizers and gesture arenas, so I added some. It also required updating some toString() methods which resulted in some changes to the tree diagnostics logic. Also I cleaned up some docs while I was at it.
-
- 21 Jun, 2017 3 commits
-
-
Jacob Richman authored
* Revert "Revert "Change all ocurrences of '$runtimeType#$hashCode' to use the idAndType method. (#10871)" (#10880)" This reverts commit ceb814aa.
-
Jacob Richman authored
Revert "Change all ocurrences of '$runtimeType#$hashCode' to use the idAndType method. (#10871)" (#10880) This reverts commit d46e208b.
-
Jacob Richman authored
* Change all instances of '$runtimeType#$hashCode' to use the describeIdentity method. The describeIdentity method generates a shorter description with a consistent length consisting of the runtime type and the a 5 hex character long truncated version of the hash code.
-
- 16 Jun, 2017 1 commit
-
-
Ian Hickson authored
-
- 12 Jun, 2017 1 commit
-
-
Ian Hickson authored
- How do you handle a tap on text? - Why is AnimatedOpacity expensive? - Why would you use a gesture arena team? ...and other minor fixes
-
- 19 May, 2017 1 commit
-
-
Ian Hickson authored
-
- 12 Apr, 2017 1 commit
-
-
Ian Hickson authored
* Manually fix every use of Point.x and Point.y Some of these were moved to dx/dy, but not all. * Manually convert uses of the old gradient API * Remove old reference to Point. * Mechanical changes I applied the following at the root of the Flutter repository: git ls-files -z | xargs -0 sed -i 's/\bPoint[.]origin\b/Offset.zero/g' git ls-files -z | xargs -0 sed -i 's/\bPoint[.]lerp\b/Offset.lerp/g' git ls-files -z | xargs -0 sed -i 's/\bnew Point\b/new Offset/g' git ls-files -z | xargs -0 sed -i 's/\bconst Point\b/const Offset/g' git ls-files -z | xargs -0 sed -i 's/\bstatic Point /static Offset /g' git ls-files -z | xargs -0 sed -i 's/\bfinal Point /final Offset /g' git ls-files -z | xargs -0 sed -i 's/^\( *\)Point /\1Offset /g' git ls-files -z | xargs -0 sed -i 's/ui[.]Point\b/ui.Offset/g' git ls-files -z | xargs -0 sed -i 's/(Point\b/(Offset/g' git ls-files -z | xargs -0 sed -i 's/\([[{,]\) Point\b/\1 Offset/g' git ls-files -z | xargs -0 sed -i 's/@required Point\b/@required Offset/g' git ls-files -z | xargs -0 sed -i 's/<Point>/<Offset>/g' git ls-files -z | xargs -0 sed -i 's/[.]toOffset()//g' git ls-files -z | xargs -0 sed -i 's/[.]toPoint()//g' git ls-files -z | xargs -0 sed -i 's/\bshow Point, /show /g' git ls-files -z | xargs -0 sed -i 's/\bshow Point;/show Offset;/g' * Mechanical changes - dartdocs I applied the following at the root of the Flutter repository: git ls-files -z | xargs -0 sed -i 's/\ba \[Point\]/an [Offset]/g' git ls-files -z | xargs -0 sed -i 's/\[Point\]/[Offset]/g' * Further improvements and a test * Fix minor errors from rebasing... * Roll engine
-
- 04 Mar, 2017 1 commit
-
-
Chris Bracken authored
Covers lib/ in package:flutter.
-
- 22 Jan, 2017 1 commit
-
-
Ian Hickson authored
-
- 13 Jan, 2017 1 commit
-
-
Adam Barth authored
Previously, the Slider used a drag gesture recognizer to move the head of the slider, but when the slider was in a vertical scroller, the recognizer would wait until the user moved the pointer by enough pixels to disambiguate between sliding the slider and scrolling the scroller. That worked fine for actual drags, but the slider should also move when the user taps the track. This patch introduces a tap recognizer to handle that behavior. To avoid the slider's drag and tap recognizers from competing with each other in the arena, this patch introduces the notion of a GestureArenaTeam, which lets several recognizers combine to form one entry in the arena. If that entry wins, the team picks the first of its recognizers as the winner, avoiding latency. Fixes #7454
-
- 06 Jan, 2017 1 commit
-
-
Ian Hickson authored
- more dartdocs for the drag typedefs - more toStrings to aid debugging - require the position for DragUpdateDetails since we were omitting it in some places - add the primaryVelocity to DragEndDetails so that consumers don't have to themselves track the axis in question - fix the velocity tracker so that it doesn't walk the null data. Previously, near time t=0 (which pretty much only matters in tests, but it does matter there) we would walk the velocity data and then also walk missing data, treating it as Point.zero with t=0. - simplify some of the velocity tracker; e.g. instead of trying (and failing?) to clear the velocity tracker when the pointer stalls, just drop the data before a stall during the velocity estimation (where we redundantly had another bigger horizon anyway).
-
- 19 Nov, 2016 1 commit
-
-
Ian Hickson authored
-
- 01 Nov, 2016 1 commit
-
-
Chris Bracken authored
-
- 28 Oct, 2016 1 commit
-
-
Jason Simmons authored
If a recognizer is interrupted by an exception from a callback, it could be left in an inconsistent state and be unable to process future events
-
- 17 Oct, 2016 1 commit
-
-
Adam Barth authored
Previously, we were nulling out the ArenaEntry in MultiDragPointerState too early, which was prevent MultiDragPointerState from rejecting the gesture in `dispose` if we hadn't accepted by the time the pointer went up. Now we properly reject the gesture, which causes the tap gesture to win during `sweep` in the arena. Also, add a bunch of docs and annotations based on information I learned while studying this issue. Finally, rename a private member of tap recognizer to a name that would have confused me less in my investigation. Fixes #1186
-
- 07 Jul, 2016 1 commit
-
-
Adam Barth authored
Fixes #4761
-
- 07 Jun, 2016 1 commit
-
-
Adam Barth authored
We were trying to unregister the pointer route twice. Now we only unregister it once. Fixes #4341
-
- 01 Jun, 2016 1 commit
-
-
Adam Barth authored
This patch starts using the mustCallSuper annotation for several of the key lifecycle callbacks in the framework. I haven't added it to didUpdateConfig because there are a large number of non-compliant overrides. We should discuss whether we want to use it there.
-
- 18 May, 2016 1 commit
-
-
Adam Barth authored
Also, make some previously private classes public for better documentation.
-
- 17 May, 2016 1 commit
-
-
Adam Barth authored
-
- 26 Apr, 2016 1 commit
-
-
Adam Barth authored
Wait until the end of the microtask to tell gesture recognizers that they've won in the gesture arena. This lets recognizers dispose reject themselves at arbitrary times without triggering gestures in awkward call stacks. Fixes #3183
-
- 22 Apr, 2016 1 commit
-
-
Ian Hickson authored
The old names were getting silly and started stepping on valuable namespace. The new names are consistent and clear.
-
- 15 Mar, 2016 1 commit
-
-
Adam Barth authored
The problem was we were using a tap gesture to stop the motion of the drawer and a drag gesture to settle it. That can cause a broken lifecycle. Now we use a single drag recognizer to drive the whole lifecycle. Fixes #775 Fixes #1276
-
- 14 Mar, 2016 1 commit
-
-
Hixie authored
-
- 12 Mar, 2016 1 commit
-
-
Adam Barth authored
Also, change the keys to be explicitly pointer ids. Fixes #202
-
- 25 Feb, 2016 2 commits
-
-
Adam Barth authored
There's no reason to make clients supply a PointerRounter and a GestureArena when constructing gesture recognizers. These objects are statics and the gesture recognizers can just grab them directly. Also, remove the callback constructor arguments. Almost no code used them. Instead, people seem to prefer using the `..` operator to set callbacks on the recognizers. Removing the arguments removes a bunch of boilerplate.
-
Hixie authored
This allows us to adjust exactly which gestures we're listening for during layout, which I'll use to kill a SizeObserver.
-
- 11 Feb, 2016 1 commit
-
-
Hixie authored
This lets it cooperate with other gestures like tap. The way I implemented this was to refactor the entire Draggable gesture logic to use a new kind of gesture detector called MultiDragGestureRecognizer. It works a bit like MultiTapGestureRecognizer but for drags. Also some tweaks to the velocity estimator.
-
- 24 Jan, 2016 1 commit
-
-
Ian Hickson authored
-
- 14 Dec, 2015 1 commit
-
-
Ian Hickson authored
-
- 10 Dec, 2015 1 commit
-
-
Florian Loitsch authored
-
- 05 Dec, 2015 1 commit
-
-
Ian Hickson authored
Instead of PointerInputEvent having a "type" field, we now have a different class for each pointer type. This has ripple effects throughout the system. I also did code cleanup in affected files while I was there.
-
- 13 Nov, 2015 1 commit
-
-
Ian Hickson authored
Make sure to send tapcancel when the primary pointer fails because of slop, even if the gesture won by default. Also, minor cleanup and clarification of an invariant.
-
- 05 Nov, 2015 1 commit
-
-
Hixie authored
Draggable is now itself a gesture arena member. This means it won't conflict with other gesture recognisers in the same path. This also allows variants of Draggable that are triggered by other gestures. Also, some cleanup of DoubleTapGestureRecognizer, GestureDetector, and PrimaryPointerGestureRecognizer. Also, make MultiTapGestureRecognizer support a timeout for longpress. Also, make Draggable data be typed. Also, hide warnings about constructor warnings for now. Analyzer doesn't support them yet. (Have to do this on a per-line basis) Directions for future research: - animating the avatar (enter/exit transitions) - interaction with the navigator (canceling a drag on page navigation, etc) - double-tap draggable
-
- 04 Nov, 2015 1 commit
-
-
Hixie authored
Make all the *GestureRecognizer classes inherit from a class called GestureRecognizer. Give the old GestureRecognizer a name that is more precise about its purpose. Remove the members of GestureArenaMember that aren't used by GestureArenas.
-
- 03 Nov, 2015 1 commit
-
-
Hixie authored
Turns out there were no uses of GestureArenaMember other than those that use DisposableArenaMember.
-