1. 30 Aug, 2023 1 commit
  2. 28 Aug, 2023 1 commit
  3. 24 Aug, 2023 1 commit
  4. 24 Jul, 2023 1 commit
  5. 15 Apr, 2023 1 commit
  6. 23 Feb, 2023 1 commit
  7. 03 Feb, 2023 1 commit
  8. 20 Jan, 2023 1 commit
  9. 18 Jan, 2023 1 commit
    • Paul Berry's avatar
      Fix applyBoxFit's handling of fitWidth and fitHeight. (#117185) · 997d4361
      Paul Berry authored
      * Fix applyBoxFit's handling of fitWidth and fitHeight.
      
      Previously, in `fitWidth` mode, if the input size had a wider aspect
      ratio than the output size, `applyBoxFit` would make the source rect
      taller than the input size in order to match the aspect ratio of the
      destination rect.  Similarly, in `fitHeight` mode, if the input size
      had a taller aspect ratio than the output size, `applyBoxFit` would
      make the source rect wider than the input size in to match the aspect
      ratio of the destination rect.  This is in contrast to all the other
      modes, which never output a source rect that's larger than the input
      size.
      
      Most of the time this worked as intended (since attempting to blit
      pixels that are outside the source image has no effect), however it
      meant that if a user attempted to create a `BoxDecoration` that used
      both `fitWidth` and `repeatY` (e.g. in an attempt to tile a background
      image), the image would not actually appear to repeat, since the logic
      in `paintImage` for determining the proper tiling stride is based on
      the destination image size, meaning that the entire destination rect
      would be covered in a single tile.
      
      This change modifies `applyBoxFit` so that in `fitWidth` mode, if the
      input size has a wider aspect ratio than the output size, it uses
      formulas that are equivalent to `contain`, whereas if the input size
      has a taller aspect ratio than the output size, it uses formulas that
      are equivalent to `cover`.  And vice versa for `fitHeight` mode.  This
      produces source and destination rects that match the behaviour
      specified in https://api.flutter.dev/flutter/painting/BoxFit.html.
      
      * Apply suggestions from code review
      Co-authored-by: 's avatarMichael Goderbauer <goderbauer@google.com>
      997d4361
  10. 18 Jul, 2022 1 commit
  11. 08 Jun, 2022 1 commit
  12. 27 Apr, 2022 1 commit
  13. 03 Feb, 2022 1 commit
  14. 08 Oct, 2021 3 commits
  15. 26 Aug, 2021 1 commit
  16. 03 Aug, 2021 1 commit
  17. 23 Jun, 2021 1 commit
  18. 23 Apr, 2021 1 commit
  19. 21 Apr, 2021 1 commit
  20. 16 Mar, 2021 2 commits
  21. 15 Mar, 2021 1 commit
  22. 18 Nov, 2020 1 commit
  23. 14 Oct, 2020 1 commit
  24. 08 Oct, 2020 1 commit
  25. 05 Oct, 2020 1 commit
  26. 03 Oct, 2020 2 commits
  27. 01 Oct, 2020 2 commits
    • Dan Field's avatar
      Revert dispose images when done (#67100) · 473358d9
      Dan Field authored
      * Revert "docs for image disposal (#67066)"
      
      This reverts commit bcb2ac5a.
      
      * Revert "Dispose of images after using them (#66688)"
      
      This reverts commit a7954691.
      473358d9
    • Dan Field's avatar
      Dispose of images after using them (#66688) · a7954691
      Dan Field authored
      * Dispose of images after using them
      Adds ImageInfo.clone, ImageInfo.dispose, and ImageInfo.isCloneOf.
      Makes all stateful holders of ui.Image objects properly clone and dispose of them.
      Behavior change for ImageStreamCompleter: Removing the last listener after registering at least one listener results in the object being disposed, and new listeners cannot be added, unless a keepAlive handle is created.
      Makes all non-stateful holders of ui.Image (i.e. paintImage and RawImage) assert that whoever gave the image to them has not disposed it on them.
      a7954691
  28. 22 Sep, 2020 1 commit
  29. 04 Aug, 2020 1 commit
  30. 16 Jul, 2020 1 commit
  31. 11 Jun, 2020 2 commits
  32. 18 Apr, 2020 1 commit
  33. 26 Mar, 2020 1 commit
  34. 10 Feb, 2020 1 commit