- 30 Aug, 2023 1 commit
-
-
LongCatIsLooong authored
Reland "Remove ImageProvider.load, DecoderCallback and `PaintingBinding.instantiateImageCodec` (#132679) (reverted in #133482) (#133605) Relanding the commit per https://github.com/flutter/flutter/pull/133482#issuecomment-1698030976 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
- 28 Aug, 2023 1 commit
-
-
Zachary Anderson authored
…inding.instantiateImageCodec` (#132679)" This reverts commit b4f4ece4. Trial revert for https://github.com/flutter/flutter/issues/133398Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>
-
- 24 Aug, 2023 1 commit
-
-
LongCatIsLooong authored
Remove `ImageProvider.load`, `DecoderCallback` and `PaintingBinding.instantiateImageCodec` (#132679) ~The failing plugin tests should pass once https://github.com/flutter/packages/pull/4725 lands and rolls into flutter/flutter~ google tests are migrated. Part of https://github.com/flutter/flutter/issues/133171 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
- 24 Jul, 2023 1 commit
-
-
Ian Hickson authored
This makes the output less sensitive on JS int vs double shenanigans.
-
- 15 Apr, 2023 1 commit
-
-
Jonah Williams authored
Reverts flutter/flutter#119495 We'll managed to optimize almost all of the cases that made this slow. Actually, it will soon be harder to optimize shader tiling...
-
- 23 Feb, 2023 1 commit
-
-
Hans Muller authored
-
- 03 Feb, 2023 1 commit
-
-
Jonah Williams authored
* [framework] use shader tiling instead of repeated calls to drawImage * ++ * ++ * review and test updates * ++ * Update decoration_image.dart * Update decoration_image.dart * ++ * ++ * ++ * ++ * ++ * Update painting.dart * Update decoration_test.dart
-
- 20 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 18 Jan, 2023 1 commit
-
-
Paul Berry authored
* Fix applyBoxFit's handling of fitWidth and fitHeight. Previously, in `fitWidth` mode, if the input size had a wider aspect ratio than the output size, `applyBoxFit` would make the source rect taller than the input size in order to match the aspect ratio of the destination rect. Similarly, in `fitHeight` mode, if the input size had a taller aspect ratio than the output size, `applyBoxFit` would make the source rect wider than the input size in to match the aspect ratio of the destination rect. This is in contrast to all the other modes, which never output a source rect that's larger than the input size. Most of the time this worked as intended (since attempting to blit pixels that are outside the source image has no effect), however it meant that if a user attempted to create a `BoxDecoration` that used both `fitWidth` and `repeatY` (e.g. in an attempt to tile a background image), the image would not actually appear to repeat, since the logic in `paintImage` for determining the proper tiling stride is based on the destination image size, meaning that the entire destination rect would be covered in a single tile. This change modifies `applyBoxFit` so that in `fitWidth` mode, if the input size has a wider aspect ratio than the output size, it uses formulas that are equivalent to `contain`, whereas if the input size has a taller aspect ratio than the output size, it uses formulas that are equivalent to `cover`. And vice versa for `fitHeight` mode. This produces source and destination rects that match the behaviour specified in https://api.flutter.dev/flutter/painting/BoxFit.html. * Apply suggestions from code review Co-authored-by: Michael Goderbauer <goderbauer@google.com>
-
- 18 Jul, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 08 Jun, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 27 Apr, 2022 1 commit
-
-
Phil Quitslund authored
-
- 03 Feb, 2022 1 commit
-
-
Ian Hickson authored
-
- 08 Oct, 2021 3 commits
-
-
Ian Hickson authored
-
Zachary Anderson authored
This reverts commit 5fd259be.
-
Ian Hickson authored
-
- 26 Aug, 2021 1 commit
-
-
nt4f04uNd authored
* Add missing parameters to DecorationImage * tune docs * fix test
-
- 03 Aug, 2021 1 commit
-
-
Darren Austin authored
-
- 23 Jun, 2021 1 commit
-
-
Greg Spencer authored
-
- 23 Apr, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 21 Apr, 2021 1 commit
-
-
Phil Quitslund authored
-
- 16 Mar, 2021 2 commits
-
-
Ian Hickson authored
-
Zachary Anderson authored
This reverts commit 0cbe5975.
-
- 15 Mar, 2021 1 commit
-
-
Ian Hickson authored
-
- 18 Nov, 2020 1 commit
-
-
Jonah Williams authored
-
- 14 Oct, 2020 1 commit
-
-
HeavenOSK authored
* modify: add prefix `Alignment.` for toString of Alignment
-
- 08 Oct, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 05 Oct, 2020 1 commit
-
-
Dan Field authored
* Reland dispose images when done (#67100) Changes since last time: - Test for CanvasKit image rendering (https://github.com/flutter/flutter/pull/67176) - Fix CanvasKit dispose impl (https://github.com/flutter/engine/pull/21555) - Update internal google3 customer with a problematic ImageStream Listener impl (cl/335091311, cl/335459002) This reverts commit 473358d9.
-
- 03 Oct, 2020 2 commits
-
-
Michael Goderbauer authored
-
Michael Goderbauer authored
-
- 01 Oct, 2020 2 commits
-
-
Dan Field authored
* Dispose of images after using them Adds ImageInfo.clone, ImageInfo.dispose, and ImageInfo.isCloneOf. Makes all stateful holders of ui.Image objects properly clone and dispose of them. Behavior change for ImageStreamCompleter: Removing the last listener after registering at least one listener results in the object being disposed, and new listeners cannot be added, unless a keepAlive handle is created. Makes all non-stateful holders of ui.Image (i.e. paintImage and RawImage) assert that whoever gave the image to them has not disposed it on them.
- 22 Sep, 2020 1 commit
-
-
Dan Field authored
Remove fake image implementations, add createTestImage to flutter_test
-
- 04 Aug, 2020 1 commit
-
-
Jonah Williams authored
-
- 16 Jul, 2020 1 commit
-
-
Bogdan Lukin authored
-
- 11 Jun, 2020 2 commits
-
-
Alexandre Ardhuin authored
* add language version 2.8 in packages/flutter * enable non-nullable analyzer flag
-
Darren Austin authored
-
- 18 Apr, 2020 1 commit
-
-
Ayush Bherwani authored
-
- 26 Mar, 2020 1 commit
-
-
Dan Field authored
-
- 10 Feb, 2020 1 commit
-
-
Michael Goderbauer authored
-