- 09 Feb, 2024 1 commit
-
-
Kris Pypen authored
During golden test image comparison 2 lists of a different type are compared with the method "identical", so this will never be true. The test image is a _Uint8ArrayView while the master image is an Uint8List. So that results in always a heavy computation to get the difference between the test and the master image. When you run this test snippet I go from 51 seconds to 14 seconds: ```dart import 'package:flutter/material.dart'; import 'package:flutter_test/flutter_test.dart'; void main() { for (int i = 0; i < 100; i++) { testWidgets('Small test', (WidgetTester tester) async { await tester.pumpWidget(Directionality(textDirection: TextDirection.ltr, child: Text('jo'))); await expectLater(find.byType(Text), matchesGoldenFile('main.png')); }); } } ```
-
- 07 Feb, 2024 2 commits
-
-
Valentin Vignal authored
Fixes https://github.com/flutter/flutter/issues/141036
-
Andrew Brampton authored
Update the `matchesGoldenFile()` / `LocalComparisonOutput` code to generate failure images for golden tests that fail when the image sizes do not match. This can make it far quicker to identify what is wrong with the test image. Fixes https://github.com/flutter/flutter/issues/141488 - [ x I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
-
- 20 Oct, 2023 1 commit
-
-
Harry Terkelsen authored
Relands https://github.com/flutter/flutter/pull/135249 A golden test was failing in post submit in the previous PR
-
- 19 Oct, 2023 1 commit
-
-
auto-submit[bot] authored
Reverts flutter/flutter#135249 Initiated by: zanderso This change reverts the following previous change: Original Description: Changes golden tests on CanvasKit to use Layer.toImage instead of browser APIs for screenshots. This brings it more in line with other platforms and should also fix some async timing bugs with tests.
-
- 18 Oct, 2023 1 commit
-
-
Harry Terkelsen authored
Changes golden tests on CanvasKit to use Layer.toImage instead of browser APIs for screenshots. This brings it more in line with other platforms and should also fix some async timing bugs with tests. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
- 17 Oct, 2023 1 commit
-
-
Kostia Sokolovskyi authored
-
- 08 May, 2023 1 commit
-
-
Michael Goderbauer authored
Fixes https://github.com/flutter/flutter/issues/126096. Fixes https://github.com/flutter/flutter/issues/126097. Fixes https://github.com/flutter/flutter/issues/126102. Fixes https://github.com/flutter/flutter/issues/126098. Fixes https://github.com/flutter/flutter/issues/126147. Work towards https://github.com/flutter/flutter/issues/126100. Does not fix the OverlyEntry/ModalRoute leak (https://github.com/flutter/flutter/issues/126100).
-
- 20 Apr, 2023 1 commit
-
-
Nate Bosch authored
Most of these imports were never appropriate. The `test_api` package was never intended for use in `_test.dart` files. Where possible move imports to `matcher`, otherwise move them to `test` or `flutter_test`. Leave uses of `test_api` from `flutter_test` library code.
-
- 08 Jun, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `packages/flutter_driver` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens_client` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_localizations` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_test` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_web_plugins` * fix comments * Use `curly_braces_in_flow_control_structures` for `packages/integration_test` * fix indentation
-
- 20 Jan, 2022 1 commit
-
-
Alberto authored
-
- 11 Oct, 2021 1 commit
-
-
Ian Hickson authored
-
- 17 Aug, 2021 1 commit
-
-
Jonah Williams authored
-
- 01 Jun, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 Mar, 2021 1 commit
-
-
Michael Goderbauer authored
-
- 10 Mar, 2021 1 commit
-
-
Kate Lovett authored
-
- 02 Mar, 2021 1 commit
-
-
Kate Lovett authored
-
- 01 Oct, 2020 2 commits
-
-
Kate Lovett authored
-
Michael Goderbauer authored
-
- 24 Aug, 2020 1 commit
-
-
Jonah Williams authored
-
- 14 Jul, 2020 1 commit
-
-
Jason Simmons authored
-
- 09 Apr, 2020 1 commit
-
-
Jacob MacDonald authored
-
- 19 Mar, 2020 1 commit
-
-
Chris Yang authored
-
- 07 Feb, 2020 1 commit
-
-
Emmanuel Garcia authored
-
- 04 Feb, 2020 1 commit
-
-
Emmanuel Garcia authored
This reverts commit e03f4391.
-
- 31 Jan, 2020 3 commits
-
-
Emmanuel Garcia authored
-
Emmanuel Garcia authored
-
Emmanuel Garcia authored
-
- 19 Dec, 2019 1 commit
-
-
Kate Lovett authored
-
- 06 Dec, 2019 1 commit
-
-
Lau Ching Jun authored
-
- 27 Nov, 2019 1 commit
-
-
Ian Hickson authored
* Update project.pbxproj files to say Flutter rather than Chromium Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright. * Update the copyright notice checker to require a standard notice on all files * Update copyrights on Dart files. (This was a mechanical commit.) * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine. Some were already marked "The Flutter Authors", not clear why. Their dates have been normalized. Some were missing the blank line after the license. Some were randomly different in trivial ways for no apparent reason (e.g. missing the trailing period). * Clean up the copyrights in non-Dart files. (Manual edits.) Also, make sure templates don't have copyrights. * Fix some more ORGANIZATIONNAMEs
-
- 19 Nov, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 14 Nov, 2019 1 commit
-
-
Jonah Williams authored
-
- 25 Oct, 2019 1 commit
-
-
Kate Lovett authored
-
- 22 Oct, 2019 1 commit
-
-
Kate Lovett authored
This reverts commit 8df0d655.
-
- 21 Oct, 2019 1 commit
-
-
Kate Lovett authored
-
- 16 Sep, 2019 1 commit
-
-
Kate Lovett authored
* Fixing LocalFileComparator output * Fixing path separators for windows failures * Windows path issues * Testing * ++ * ++ * Fixing base directory - windows * Clean up
-
- 11 Sep, 2019 1 commit
-
-
Jonah Williams authored
-