Commits · f0e616e2b1c820bfc82d07417c484fccd1c18e6c · abdullh.alsoleman / Front-End

03 Jan, 2024 31 commits

[github actions] refactor and fix cherry pick actions (#140499) · f0e616e2

Xilai Zhang authored Jan 03, 2024

This PR makes the following changes:

1. Remove dependency on [peters/evans package](https://github.com/marketplace/actions/create-pull-request)<br>
The market place action introduces overheads that don't properly consume tokens. e.g. :[failed workflow that says token is not supplied](https://github.com/flutter/flutter/actions/runs/7282529195/job/19845096943)
This PR changes the market place action to git commands that we have full control over, provides better error msg for debug, and properly consumes token.

2. Align usage of tokens:<br>
All tokens in the workflow now uses flutter actions bot PAT token. From experiments, a mixed usage of different tokens in different steps sometimes cause the workflow to fail on authentication.

Tested: Tested with [a similar workflow on my personal repository](https://github.com/XilaiZhang/miscellaneous-side-project/blob/master/.github/workflows/easy-cp.yml), and it produces the [expected cherry pick PR as end result](https://github.com/flutter/flutter/pull/140497)

f0e616e2

Migrate Xcode projects last version checks to Xcode 15.1 (#140256) · 076cb8a3

Jenn Magder authored Jan 03, 2024

Change the following in the `flutter create` templates. I didn't make any auto-migrations for existing apps because none seem that critical:
1. Turn on `ASSETCATALOG_COMPILER_GENERATE_SWIFT_ASSET_SYMBOL_EXTENSIONS` in iOS and macOS.
1. Turn on `BuildIndependentTargetsInParallel` in macOS template. https://github.com/flutter/flutter/pull/125827/files#r1181817619
1. Turn on `DEAD_CODE_STRIPPING` in macOS template.
1. Set `ENABLE_USER_SCRIPT_SANDBOXING=NO` in iOS and macOS template. `flutter` scripts don't work with this on. This might require a migration in the future to explicitly turn this one off. However at least for now if the setting isn't present it defaults to `NO`.

Add migration for `LastUpgradeVersion` so users won't see these validation issues in Xcode.

Run migrator on all the example apps. A few aren't Flutter apps so I edited them in Xcode.

Fixes https://github.com/flutter/flutter/issues/140253
See also https://github.com/flutter/flutter/issues/125817 and https://github.com/flutter/flutter/pull/90304.

076cb8a3

Roll Flutter Engine from bf232c4da241 to 7c2adb811059 (3 revisions) (#140920) · d0f3777f

engine-flutter-autoroll authored Jan 03, 2024

https://github.com/flutter/engine/compare/bf232c4da241...7c2adb811059

2024-01-03 skia-flutter-autoroll@skia.org Roll Skia from 063e339bedfc to 1ce1aa1f90fa (6 revisions) (flutter/engine#49503)
2024-01-03 30870216+gaaclarke@users.noreply.github.com [Impeller] new blur: limit uvs to blur region (flutter/engine#49299)
2024-01-03 skia-flutter-autoroll@skia.org Roll Skia from 1144b7950404 to 063e339bedfc (7 revisions) (flutter/engine#49500)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d0f3777f

fix typo and reflow (#140925) · ae4fb0ca
Michael Goderbauer authored Jan 03, 2024
```
Fixes "differenet" => "different" and reflows the doc to 80 char line length.
```
ae4fb0ca

Reverts "Re-land integrate testWidgets with leak tracking." (#140926) · 253dc6f8

auto-submit[bot] authored Jan 03, 2024

Reverts flutter/flutter#140521
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
Original PR: https://github.com/flutter/flutter/pull/138057
Revert: https://github.com/flutter/flutter/pull/140502
Issue: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20flutter_test_performance/12787/overview
Exception: flutter test rendered unexpected output (1 bad lines)
Explanation: leak tracker adds tear down even when there is no leak tracking, because at the moment of adding tear down it is unclear if leak tracking will be used for some tests.
Fix: add enabling flag for leak tracker and make creation of tear down conditional.
Prerequisites:

253dc6f8

Roll Flutter Engine from bf979d220283 to bf232c4da241 (1 revision) (#140915) · d9024dc0

engine-flutter-autoroll authored Jan 03, 2024

https://github.com/flutter/engine/compare/bf979d220283...bf232c4da241

2024-01-03 30870216+gaaclarke@users.noreply.github.com [Impeller] pulled out the path unit tests to their own file (flutter/engine#49499)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d9024dc0

Changes the regular cursor to a floating cursor when a long press occurs. (#138479) · 0d4eb5ea
yim authored Jan 03, 2024
```
This PR changes the regular cursor to a floating cursor when a long press occurs.

This is a new feature. Fixes  #89228
```
0d4eb5ea

Add `SegmentedButton.styleFrom` (#137542) · 83ac7605

Furkan Acar authored Jan 03, 2024

fixes https://github.com/flutter/flutter/issues/138289

---

SegmentedButtom.styleFrom has been added to the segment button, so there is no longer any need to the button style from the beginning. It works like ElevatedButton.styleFrom only I added selectedForegroundColor, selectedBackgroundColor. In this way, the user will be able to change the color first without checking the MaterialState states. I added tests of the same controls.

#129215 I opened this problem myself, but I was rejected because I handled too many items in a PR. For now, I wrote a structure that only handles MaterialStates instead of users.

old (still avaliable)
<img width="626" alt="image" src="https://github.com/flutter/flutter/assets/65075121/9446b13b-c355-4d20-bda2-c47a23d42d4f">

new (just an option for developer)
<img width="483" alt="image" src="https://github.com/flutter/flutter/assets/65075121/0a645257-4c83-4029-9484-bd746c02265f">

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

/// Flutter code sample for [SegmentedButton].

void main() {
  runApp(const SegmentedButtonApp());
}

enum Calendar { day, week, month, year }

class SegmentedButtonApp extends StatefulWidget {
  const SegmentedButtonApp({super.key});

  @override
  State<SegmentedButtonApp> createState() => _SegmentedButtonAppState();
}

class _SegmentedButtonAppState extends State<SegmentedButtonApp> {
  Calendar calendarView = Calendar.day;

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(useMaterial3: true),
      home: Scaffold(
        body: Center(
          child: SegmentedButton<Calendar>(
            style: SegmentedButton.styleFrom(
              foregroundColor: Colors.amber,
              visualDensity: VisualDensity.comfortable,
            ),
            // style: const ButtonStyle(
            //   foregroundColor: MaterialStatePropertyAll<Color>(Colors.deepPurple),
            //   visualDensity: VisualDensity.comfortable,
            // ),
            segments: const <ButtonSegment<Calendar>>[
              ButtonSegment<Calendar>(
                  value: Calendar.day,
                  label: Text('Day'),
                  icon: Icon(Icons.calendar_view_day)),
              ButtonSegment<Calendar>(
                  value: Calendar.week,
                  label: Text('Week'),
                  icon: Icon(Icons.calendar_view_week)),
              ButtonSegment<Calendar>(
                  value: Calendar.month,
                  label: Text('Month'),
                  icon: Icon(Icons.calendar_view_month)),
              ButtonSegment<Calendar>(
                  value: Calendar.year,
                  label: Text('Year'),
                  icon: Icon(Icons.calendar_today)),
            ],
            selected: <Calendar>{calendarView},
            onSelectionChanged: (Set<Calendar> newSelection) {
              setState(() {
                calendarView = newSelection.first;
              });
            },
          ),
        ),
      ),
    );
  }
}

```

</details>

83ac7605

Roll Flutter Engine from c62bcff5b809 to bf979d220283 (1 revision) (#140910) · e64e7d9c

engine-flutter-autoroll authored Jan 03, 2024

https://github.com/flutter/engine/compare/c62bcff5b809...bf979d220283

2024-01-03 john@johnmccutchan.com Fix a crash in the new SurfaceProducer external texture (flutter/engine#49496)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e64e7d9c

Re-land integrate testWidgets with leak tracking. (#140521) · baf6ba13
Polina Cherkasova authored Jan 03, 2024

baf6ba13

Roll Flutter Engine from 98b72c7ffe71 to c62bcff5b809 (2 revisions) (#140905) · eb195da7

engine-flutter-autoroll authored Jan 03, 2024

https://github.com/flutter/engine/compare/98b72c7ffe71...c62bcff5b809

2024-01-03 jonahwilliams@google.com [Impeller] Disable compute for Vulkan. (flutter/engine#49463)
2024-01-03 dkwingsmt@users.noreply.github.com Revert skiping illegal render in Dart (flutter/engine#49473)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

eb195da7

[flutter_tools] add support for --enable-impeller to test device. (#140899) · 0d378ed5
Jonah Williams authored Jan 03, 2024
```
This allows unit tests to use the impeller backend, which can be useful for Scubas/golden tests.
```
0d378ed5

Roll Flutter Engine from cf7536964a2f to 98b72c7ffe71 (1 revision) (#140897) · 0e11246b

engine-flutter-autoroll authored Jan 03, 2024

https://github.com/flutter/engine/compare/cf7536964a2f...98b72c7ffe71

2024-01-03 skia-flutter-autoroll@skia.org Roll Skia from 9e8069bba51d to 1144b7950404 (1 revision) (flutter/engine#49494)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0e11246b

Handle KEYCODE_DPAD_CENTER and KEYCODE_ENTER (#140808) · 743cdd68

Ann Marie Mossman authored Jan 03, 2024

https://github.com/flutter/flutter/issues/1670

Note: This PR replaces the the original PR (https://github.com/flutter/flutter/pull/138240) that got into a state where a rebase was not possible and made it difficult to determine what was causing unrelated test failures.

743cdd68

Add Lucas Saudon to AUTHORS (#139965) · d46a8afc

lsaudon authored Jan 03, 2024

Reference: [author:lsaudon](https://github.com/flutter/flutter/issues?q=author%3Alsaudon)

d46a8afc

Link to wiki page about updating dependencies in each `pubspec.yaml` file (#140826) · 55ba27d3

Elliott Brooks authored Jan 03, 2024

Added a minimal wiki page about how to use the `update-packages` tool: https://github.com/flutter/flutter/wiki/Updating-dependencies-in-Flutter

This PR adds a link to that wiki page at the top of each pubspec.yaml file

55ba27d3

Marks Linux_pixel_7pro native_assets_android to be unflaky (#140866) · bfcf0c58

Flutter GitHub Bot authored Jan 03, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_pixel_7pro native_assets_android"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20native_assets_android%22).
This test can be marked as unflaky.

bfcf0c58

Roll Flutter Engine from 3b6edee0f8f7 to cf7536964a2f (1 revision) (#140889) · e213dbe8

engine-flutter-autoroll authored Jan 03, 2024

https://github.com/flutter/engine/compare/3b6edee0f8f7...cf7536964a2f

2024-01-03 skia-flutter-autoroll@skia.org Roll Skia from a9db1213b179 to 9e8069bba51d (18 revisions) (flutter/engine#49490)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e213dbe8

Roll Packages from fa74d3e1e71a to bbb41347518e (4 revisions) (#140885) · 4d624cde

engine-flutter-autoroll authored Jan 03, 2024

https://github.com/flutter/packages/compare/fa74d3e1e71a...bbb41347518e

2024-01-02 43054281+camsim99@users.noreply.github.com [camerax] Implement `lockCaptureOrientation` & `unlockCaptureOrientation` (flutter/packages#5285)
2024-01-02 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.22.11 to 3.22.12 (flutter/packages#5738)
2024-01-02 chillers@google.com Add Flutter CI Status badge to README (flutter/packages#5733)
2023-12-26 49699333+dependabot[bot]@users.noreply.github.com [path_provider]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/path_provider/path_provider_android/android (flutter/packages#5709)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4d624cde

Roll Flutter Engine from 3a7aa01b0a7d to 3b6edee0f8f7 (4 revisions) (#140884) · 6bf9d938

engine-flutter-autoroll authored Jan 03, 2024

https://github.com/flutter/engine/compare/3a7aa01b0a7d...3b6edee0f8f7

2024-01-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 7e9f7eab80d3 to c5a75ac9057c (1 revision)" (flutter/engine#49491)
2024-01-03 skia-flutter-autoroll@skia.org Roll Skia from 4b16117e94b2 to a9db1213b179 (1 revision) (flutter/engine#49487)
2024-01-03 dnfield@google.com [Impeller] Allow multiple --runtime-stage-* parameters to impellerc (flutter/engine#49475)
2024-01-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 7e9f7eab80d3 to c5a75ac9057c (1 revision) (flutter/engine#49478)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6bf9d938

Add key to BottomNavigationBarItem (#139617) · f4cb3d21

Jack Gibbons authored Jan 03, 2024

Pass key into _BottomNavigationTile

Adding a optional key parameter to BottomNavigationBarItem to be passed through to _BottomNavigationTile.
This will allow easier testing in some scenarios, and fix the splash appearing on the wrong tile.

https://github.com/flutter/flutter/issues/139615
https://github.com/flutter/flutter/issues/34833

f4cb3d21

Marks Linux_android hybrid_android_views_integration_test to be unflaky (#140865) · 70386a61

Flutter GitHub Bot authored Jan 03, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_android hybrid_android_views_integration_test"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android%20hybrid_android_views_integration_test%22).
This test can be marked as unflaky.

70386a61

Roll Flutter Engine from e95e12368a42 to 3a7aa01b0a7d (1 revision) (#140846) · 37d11ed8

engine-flutter-autoroll authored Jan 03, 2024

https://github.com/flutter/engine/compare/e95e12368a42...3a7aa01b0a7d

2024-01-02 jonahwilliams@google.com [Impeller] add doc on iOS flamegraph capture. (flutter/engine#49469)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

37d11ed8

fix: cannot input new line using custom input control (#140356) · c033b08d

Satsrag authored Jan 03, 2024

For https://github.com/flutter/flutter/issues/125875 and https://github.com/flutter/engine/pull/45522

According to [this discussion](https://github.com/flutter/flutter/pull/139446#discussion_r1424776370), Just added `forceMultiline` to JSON on `_configurationToJson`. @LongCatIsLooong @Renzo-Olivares

c033b08d

Roll Flutter Engine from b5e79bd249b8 to e95e12368a42 (1 revision) (#140840) · 01c057cd

engine-flutter-autoroll authored Jan 03, 2024

https://github.com/flutter/engine/compare/b5e79bd249b8...e95e12368a42

2024-01-02 737941+loic-sharma@users.noreply.github.com Revert "Reland "[Windows] Move to FlutterCompositor for rendering" (flutter/engine#49461)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

01c057cd

Verified input test take 2 (#140836) · dcc2c914

John McCutchan authored Jan 03, 2024

This is a reland of https://github.com/flutter/flutter/pull/140806 which had an issue with package versions.

dcc2c914

Set template and migrate apps to iOS 12 minimum (#140823) · b08fc600

Jenn Magder authored Jan 03, 2024

Reland https://github.com/flutter/flutter/pull/140478 with `ios_content_validation_test` test fix.
```
[ios_content_validation_test] Process terminated with exit code 0.
Task result:
{
  "success": true,
  "data": null,
  "detailFiles": [],
  "benchmarkScoreKeys": [],
  "reason": "success"
}

```

__________

1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0.
2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'`
3. Compile with `-miphoneos-version-min=12.0`
4. Run the migrator on all example apps and integration tests.

See also https://github.com/flutter/flutter/pull/62902 and https://github.com/flutter/flutter/pull/85174 and https://github.com/flutter/flutter/pull/101963

Fixes https://github.com/flutter/flutter/issues/136060

b08fc600

[flutter] Allow ViewCollection to start empty. (#140532) · 6b4f0d57
David Iglesias authored Jan 03, 2024
```
This enables multi-view apps to start with zero views.
```
6b4f0d57

Fix setup race in asset bundle tests (#140832) · 3ac2dba5

Andrew Kolos authored Jan 03, 2024

Fixes https://github.com/flutter/flutter/issues/140665 by replacing use of `setUpAll` and `teardownAll` with `setUp` and `teardown` respectively.

My theory has to how this issue happened (and how this PR fixes it) is that `setUpAll` is not guaranteed to run after any `setUp` in any parent test groups. However, `setUp` is guaranteed to run after any set-up callbacks in parent groups. From the [documentation](https://api.flutter.dev/flutter/flutter_test/setUp.html): 

> If this is called within a test group, it applies only to tests in that group. The body will be run after any set-up callbacks in parent groups or at the top level.

Meanwhile, [`setUpAll`](https://api.flutter.dev/flutter/flutter_test/setUpAll.html) has a weaker documented guarantee that applies only to other `setUpAll` calls:

> If this is called within a test group, The body will run before all tests in that group. It will be run after any [setUpAll](https://api.flutter.dev/flutter/flutter_test/setUpAll.html) callbacks in parent groups or at the top level. It won't be run if none of the tests in the group are run.

3ac2dba5

Fix 139196 selection OOB (#140300) · f3b6505f
LongCatIsLooong authored Jan 03, 2024
```
Fixes #139196
```
f3b6505f

Roll Flutter Engine from b02d59a2a607 to b5e79bd249b8 (3 revisions) (#140839) · 530b766f

engine-flutter-autoroll authored Jan 03, 2024

https://github.com/flutter/engine/compare/b02d59a2a607...b5e79bd249b8

2024-01-02 dnfield@google.com Start wiring up fragment program for OpenGLES (flutter/engine#49347)
2024-01-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 014514e3e5b9 to 7e9f7eab80d3 (2 revisions) (flutter/engine#49471)
2024-01-02 yjbanov@google.com [web] make TextStyle implementations consistent (flutter/engine#49465)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

530b766f

02 Jan, 2024 9 commits

Reverts "Verified input integration test" (#140833) · 8e431e10

auto-submit[bot] authored Jan 02, 2024

Reverts flutter/flutter#140806
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
This is an integration test associated with https://github.com/flutter/engine/pull/49268

8e431e10

Verified input integration test (#140806) · ac9a8eb6
John McCutchan authored Jan 02, 2024
```
This is an integration test associated with
https://github.com/flutter/engine/pull/49268
```
ac9a8eb6

Roll Flutter Engine from 9d89f8727976 to b02d59a2a607 (1 revision) (#140824) · ba578c77

engine-flutter-autoroll authored Jan 02, 2024

https://github.com/flutter/engine/compare/9d89f8727976...b02d59a2a607

2024-01-02 john@johnmccutchan.com Android Platform Views support Verified Input Events (flutter/engine#49268)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ba578c77

Roll Flutter Engine from a06926d05d2b to 9d89f8727976 (1 revision) (#140818) · b62bb518

engine-flutter-autoroll authored Jan 02, 2024

https://github.com/flutter/engine/compare/a06926d05d2b...9d89f8727976

2024-01-02 30870216+gaaclarke@users.noreply.github.com [Impeller] new blur: implemented ping ponging (flutter/engine#49252)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b62bb518

Upgrade leak_tracker. (#140758) · 45c611f0
Polina Cherkasova authored Jan 02, 2024

45c611f0

Reverts "Set template and migrate apps to iOS 12 minimum" (#140822) · bd634f32

auto-submit[bot] authored Jan 02, 2024

Reverts flutter/flutter#140478
Initiated by: loic-sharma
This change reverts the following previous change:
Original Description:
1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0.
2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'`
3. Compile with `-miphoneos-version-min=12.0`
4. Run the migrator on all example apps and integration tests.

See also https://github.com/flutter/flutter/pull/62902 and https://github.com/flutter/flutter/pull/85174 and https://github.com/flutter/flutter/pull/101963

Fixes https://github.com/flutter/flutter/issues/136060

bd634f32

Reland "Make `TextSpan` hit testing precise." (#140468) (#140621) · 5883a6ca

LongCatIsLooong authored Jan 02, 2024

Fixes https://github.com/flutter/flutter/issues/131435, https://github.com/flutter/flutter/issues/104594, https://github.com/flutter/flutter/issues/43400

Currently the method we use for text span hit testing `TextPainter.getPositionForOffset` always returns the closest `TextPosition`, even when the given offset is far away from the text.

The new TextPaintes method tells you the layout bounds `(width = letterspacing / 2 + x_advance + letterspacing / 2, height = font ascent + font descent)` of a character, the PR changes the hit testing implementation such that a TextSpan is only considered hit if the point-down event landed in one of its character's layout bounds.

Potential issues:

In theory since the text is baseline aligned, we should use the max ascent and max descent of each character to calculate the height of the text span's hit-test region, in case some characters in the span have to fall back to a different font, but that will be slower and it typically doesn't make a huge difference.
This is a breaking change.

5883a6ca

Update dependencies with `flutter update-packages --force-upgrade` (#140810) · cb07292f
Elliott Brooks authored Jan 02, 2024

cb07292f

Roll Flutter Engine from 194d90de78cc to a06926d05d2b (3 revisions) (#140815) · babf0865

engine-flutter-autoroll authored Jan 02, 2024

https://github.com/flutter/engine/compare/194d90de78cc...a06926d05d2b

2024-01-02 dnfield@google.com Make sure to finish the suite if all tests are skipped (flutter/engine#49339)
2024-01-02 26625149+0xZOne@users.noreply.github.com Fix NPE when platform plugin delegate is null (flutter/engine#49391)
2024-01-02 26625149+0xZOne@users.noreply.github.com Add try-with-resource support to TraceSection (flutter/engine#49445)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

babf0865