1. 14 Feb, 2024 1 commit
  2. 09 Feb, 2024 1 commit
  3. 08 Feb, 2024 1 commit
  4. 07 Feb, 2024 2 commits
    • Gray Mackall's avatar
      Restore log dumps for gradle OOM crashes, and set a value for `MaxMetaspaceSize` (#143085) · 120a01cc
      Gray Mackall authored
      Re-sets two jvmargs that were getting cleared because we set a value for `-Xmx`. Could help with https://github.com/flutter/flutter/issues/142957. Copied from comment here https://github.com/flutter/flutter/issues/142957:
      >Two random things I ran into while looking into this that might help:
      >
      >1. Gradle has defaults for a couple of the jvmargs, and setting any one of them clears those defaults for the others (bug here https://github.com/gradle/gradle/issues/19750). This can cause the "Gradle daemon to consume more and more native memory until it crashes", though the bug typically has a different associated error. It seems worth it to re-set those defaults.
      >2. There is a property we can set that will give us a heap dump on OOM ([-XX:HeapDumpOnOutOfMemoryError](https://docs.oracle.com/javase/8/docs/technotes/guides/troubleshoot/clopts001.html))
      
      Mostly just a find and replace from `find . -name gradle.properties -exec sed -i '' 's/\-Xmx4G/-Xmx4G\ \-XX:MaxMetaspaceSize=2G\ \-XX:+HeapDumpOnOutOfMemoryError/g' {} \;`, with the templates and the one test that writes from a string replaced by hand. I didn't set a value for `MaxMetaspaceSize` in the template files because I want to make sure this value doesn't cause problems in ci first (changes to the templates are essentially un-revertable for those who `flutter create` while the changes exist).
      Unverified
      120a01cc
    • Chris Bracken's avatar
      [Windows] Fix signed/unsigned int comparison (#142341) · 9f8fe3f0
      Chris Bracken authored
      Previously, we were comparing the signed int `target_length` (returned by WideCharToMultiByte) to a size_t string length, resulting in a signed/unsigned comparison warning as follows:
      
      ```
      windows\runner\utils.cpp(54,43): warning C4018:  '>': signed/unsigned mismatch
      ```
      
      WideCharToMultiByte returns:
      * 0 on error
      * the number of bytes written to the buffer pointed to by its fifth parameter, lpMultiByteStr, on success.
      
      As a result it's safe to store the return value in an unsigned int, which eliminates the warning.
      
      No changes to tests since this is dependent on end-user project settings/modifications and does not trigger a warning with default project settings.
      
      Fixes: https://github.com/flutter/flutter/issues/134227
      Unverified
      9f8fe3f0
  5. 04 Feb, 2024 2 commits
  6. 01 Feb, 2024 1 commit
  7. 24 Jan, 2024 1 commit
  8. 16 Jan, 2024 1 commit
  9. 09 Jan, 2024 1 commit
  10. 03 Jan, 2024 2 commits
  11. 02 Jan, 2024 3 commits
  12. 20 Dec, 2023 1 commit
  13. 19 Dec, 2023 1 commit
  14. 15 Dec, 2023 3 commits
  15. 07 Dec, 2023 1 commit
  16. 06 Dec, 2023 1 commit
  17. 05 Dec, 2023 1 commit
  18. 28 Nov, 2023 1 commit
    • Nate's avatar
      Implement `switch` expressions in `dev/` (#139048) · 3267fbc0
      Nate authored
      I previously made a PR (#136140) that used `switch` expressions to make some parts of the Flutter codebase easier to understand. It was assigned to the framework team, and @christopherfujino let me know that it was too large to effectively review and recommended breaking it up into smaller pull requests.
      
      Here's a PR that only targets files in the `dev/` directory. Hopefully this will be easier to work with!
      
      (solves issue https://github.com/flutter/flutter/issues/136139)
      Unverified
      3267fbc0
  19. 15 Nov, 2023 1 commit
    • Srujan Gaddam's avatar
      Pin package:web 0.4.0 (#138428) · d8ffc739
      Srujan Gaddam authored
      This version is needed so that dart:js_interop can move to extension
      types. Also adds some code to handle some breaking changes:
      
      - Body -> Response. Body was an IDL interface mixin type we exposed in
      dart:html. Going forward, users should either use Request or Response.
      - Casts to JSAny. These are temporary until we move package:web types to
      extension types. Currently, package:web types can't implement JSObject
      as JSObject will move to be an extension type itself.
      Co-authored-by: 's avatarKevin Moore <kevmoo@users.noreply.github.com>
      Unverified
      d8ffc739
  20. 13 Nov, 2023 1 commit
  21. 10 Nov, 2023 1 commit
  22. 09 Nov, 2023 1 commit
  23. 03 Nov, 2023 2 commits
  24. 02 Nov, 2023 1 commit
  25. 01 Nov, 2023 1 commit
  26. 31 Oct, 2023 1 commit
  27. 25 Oct, 2023 2 commits
  28. 24 Oct, 2023 1 commit
  29. 14 Oct, 2023 1 commit
  30. 11 Oct, 2023 1 commit
  31. 29 Sep, 2023 1 commit