Commits · efee280cfa93314eb32550197b08cda32cee196d · abdullh.alsoleman / Front-End

22 Feb, 2024 3 commits

Roll Flutter Engine from bf5c003085fd to 7eeb697687d5 (16 revisions) (#143911) · efee280c

engine-flutter-autoroll authored Feb 22, 2024

https://github.com/flutter/engine/compare/bf5c003085fd...7eeb697687d5

2024-02-22 tugorez@users.noreply.github.com Add view focus direction detection to flutter web. (flutter/engine#50843)
2024-02-22 matanlurey@users.noreply.github.com Add a similar `runIf` guard to `web_engine` as web framework. (flutter/engine#50846)
2024-02-22 dkwingsmt@users.noreply.github.com Add scheduleWarmUpFrame (flutter/engine#50570)
2024-02-22 matanlurey@users.noreply.github.com Remove/reduce unused or private methods and add tests to `SkiaGoldClient` (flutter/engine#50844)
2024-02-22 matanlurey@users.noreply.github.com Clean up contributing formatting, add a Skia gold callout (flutter/engine#50828)
2024-02-21 34871572+gmackall@users.noreply.github.com Make Android Studio be able to run android embedding unit tests out of the box (flutter/engine#50840)
2024-02-21 zanderso@users.noreply.github.com Shift some deps to //flutter/third_party (flutter/engine#50830)
2024-02-21 tugorez@users.noreply.github.com Make the view focus binding report focus transitions across elements. (flutter/engine#50610)
2024-02-21 chris@bracken.jp [macOS] Wrap FlutterEngineTest in autoreleasepool (flutter/engine#50832)
2024-02-21 jason-simmons@users.noreply.github.com Update the vulkan_glfw sample for the latest roll of vulkan-deps (flutter/engine#50839)
2024-02-21 skia-flutter-autoroll@skia.org Roll Skia from 8fa858855820 to 57490c8d257e (6 revisions) (flutter/engine#50833)
2024-02-21 zanderso@users.noreply.github.com Starts a .ci.yaml parser (flutter/engine#50783)
2024-02-21 skia-flutter-autoroll@skia.org Roll Dart SDK from f344e2266468 to 0f0f7400c38a (6 revisions) (flutter/engine#50837)
2024-02-21 737941+loic-sharma@users.noreply.github.com [Windows] Fix top-level message procedure order (flutter/engine#50797)
2024-02-21 john@johnmccutchan.com Tweak verbose log messages in ImageReaderSurfaceProducer (flutter/engine#50831)
2024-02-21 matanlurey@users.noreply.github.com Add a throw statement for imgtestAdd non 0 exit codes. (flutter/engine#50829)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

efee280c

Update PR template for dart fix (#143879) · de97a050

Kate Lovett authored Feb 22, 2024

I don't know if this is feasible, but figured it was worth seeing.
Often times dart fixes are forgotten as part of the code review process.
I know some people ignore the PR template, but considered maybe a mention was warranted.

I've made the change reflected below:

de97a050

Re-use methods to calculate leading and trailing garbage in RenderSliverMultiBoxAdaptor (#143884) · f97978f9

Kate Lovett authored Feb 22, 2024

My RenderSliverMultiBoxAdaptor/RenderSliverFixedExtentList/RenderSliverVariedExtentList yak shave continues.

I've been subclassing RenderSliverVariedExtentList for SliverTree and have found some opportunities for clean up.
There is a larger clean up I'd like to do, but this week SliverTree comes first.

I noticed these methods were getting repeated ð, and I was about to repeat them again ð for the tree, so I figured bumping them up to the base class was better than continuing to copy-paste the same methods.

f97978f9

21 Feb, 2024 24 commits

Reverts "[Impeller] Make impeller goldens test blocking. (#143864)" (#143896) · c3e786f3

auto-submit[bot] authored Feb 21, 2024

Reverts flutter/flutter#143864

Initiated by: goderbauer

Reason for reverting: The test is consistently failing in post-submit, e.g. https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8755443299639610049/+/u/run_test.dart_for_framework_tests_shard_and_subshard_impeller/stdout

Original PR Author: jonahwilliams

Reviewed By: {matanlurey}

This change reverts the following previous change:
Original Description:
Part of https://github.com/flutter/flutter/issues/143616

Without this these tests only run on postsubmit which means we can't get gold results on PRs.

c3e786f3

[Impeller] Make impeller goldens test blocking. (#143864) · 0be66684

Jonah Williams authored Feb 21, 2024

Part of https://github.com/flutter/flutter/issues/143616

Without this these tests only run on postsubmit which means we can't get gold results on PRs.

0be66684

Disable color filter sepia test for Impeller. (#143861) · d699bcb4
Jonah Williams authored Feb 21, 2024
```
This test is still unstable with the debug banner disabled. the Icon in the FAB appears to be shifting.
```
d699bcb4

Roll Flutter Engine from 52ffcaadea41 to bf5c003085fd (12 revisions) (#143875) · 9ed5496c

engine-flutter-autoroll authored Feb 21, 2024

https://github.com/flutter/engine/compare/52ffcaadea41...bf5c003085fd

2024-02-21 skia-flutter-autoroll@skia.org Roll Skia from 9d86359b5fe8 to 8fa858855820 (15 revisions) (flutter/engine#50827)
2024-02-21 matanlurey@users.noreply.github.com Add the `scenario_app` `'solid_blue'` golden to the Android test suite (flutter/engine#50801)
2024-02-21 matanlurey@users.noreply.github.com Ignore EOF newline characters and added tests to `dir_contents_diff` tool (flutter/engine#50805)
2024-02-21 jason-simmons@users.noreply.github.com Make the GL context current in EmbedderSurfaceGLImpeller before creating the GPU surface (flutter/engine#50807)
2024-02-21 matanlurey@users.noreply.github.com Fail engine post-submit on skia-gold comparions. (flutter/engine#50826)
2024-02-21 34871572+gmackall@users.noreply.github.com Remove WindowManager reflection in SingleViewPresentation.java (flutter/engine#49996)
2024-02-21 30870216+gaaclarke@users.noreply.github.com [Impeller] applied the lerp hack to blur (roughly 2x speedup?) (flutter/engine#50790)
2024-02-21 jason-simmons@users.noreply.github.com Migrate the Fuchsia embedder to the Dart_RecordTimelineEvent API (flutter/engine#50823)
2024-02-21 john@johnmccutchan.com Hook ImageReaderSurfaceProducer to the onTrimMemory listener interface (flutter/engine#50792)
2024-02-21 matanlurey@users.noreply.github.com Fix the local-only lint errors due to an unexpected `GeneratedPluginRegistrant.java` (flutter/engine#50795)
2024-02-21 jonahwilliams@google.com [Impeller] cache onscreen render targets. (flutter/engine#50751)
2024-02-21 zanderso@users.noreply.github.com Use 'et format' in CI. Check formatting of all files in CI (flutter/engine#50810)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9ed5496c

Roll Flutter Engine from 4128895d79a1 to 52ffcaadea41 (1 revision) (#143862) · c1a1c47c

engine-flutter-autoroll authored Feb 21, 2024

https://github.com/flutter/engine/compare/4128895d79a1...52ffcaadea41

2024-02-21 jonahwilliams@google.com [Impeller] force bootstrap render pass. (flutter/engine#50749)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c1a1c47c

Deprecate redundant itemExtent in RenderSliverFixedExtentBoxAdaptor methods (#143412) · 09e0e1b8

Kate Lovett authored Feb 21, 2024

Multiple methods in `RenderSliverFixedExtentBoxAdaptor` pass a `double itemExtent` for computing things like what children will be laid out, what the max scroll offset will be, and how the children will be laid out.

Since `RenderSliverFixedExtentBoxAdaptor` was further subclassed to support a `itemExtentBuider` in `RenderSliverVariedExtentList`, these itemExtent parameters became useless when using that RenderObject. Reading through `RenderSliverFixedExtentBoxAdaptor.performLayout`, the remaining artifacts of passing around itemExtent make it hard to follow when it is irrelevant. 

`RenderSliverFixedExtentBoxAdaptor.itemExtent` is available from these methods, so it does not need to pass it. It is redundant API.

Plus, if a bogus itemExtent is passed for some reason, errors will ensue and the layout will be incorrect. ð£ ð¥ 

Deprecating so we can remove these for a cleaner API. Unfortunately this is not supported by dart fix, but the fact that these methods are protected means usage outside of the framework is likely minimal.

09e0e1b8

Add aab as alias for appbundle (#143855) · b09a015f
Reid Baker authored Feb 21, 2024
```
- **Fix #143778 add aab as alias to appbundle**

Fixes #143778
```
b09a015f

Roll Flutter Engine from e16f43eeaaa4 to 4128895d79a1 (1 revision) (#143856) · bfeaf5a7

engine-flutter-autoroll authored Feb 21, 2024

https://github.com/flutter/engine/compare/e16f43eeaaa4...4128895d79a1

2024-02-21 matanlurey@users.noreply.github.com Disallow files additional named `GeneratedPluginRegistrant.java`. (flutter/engine#50796)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bfeaf5a7

Roll Packages from 8bba41b0c046 to 48048f6bc779 (2 revisions) (#143853) · 4aecbf91

engine-flutter-autoroll authored Feb 21, 2024

https://github.com/flutter/packages/compare/8bba41b0c046...48048f6bc779

2024-02-20 ditman@gmail.com [google_sign_in_web] Updates package:web dependency to 0.5.0. (flutter/packages#6167)
2024-02-20 kevmoo@users.noreply.github.com [web] Updates package:web dependency to ^0.5.0. (flutter/packages#5791)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4aecbf91

Update `hourMinuteTextStyle` defaults for Material 3 Time Picker (#143749) · 3403ca41

Taha Tesser authored Feb 21, 2024

fixes [`hourMinuteTextStyle` Material 3 default doesn't match the specs](https://github.com/flutter/flutter/issues/143748)

This updates `hourMinuteTextStyle` defaults to match Material 3 specs. `hourMinuteTextStyle` should use different font style for different entry modes based on the specs.

### Specs
![Screenshot 2024-02-20 at 15 06 40](https://github.com/flutter/flutter/assets/48603081/5198a5da-314d-401e-8d7f-d4a68b86e43c)
![Screenshot 2024-02-20 at 15 07 22](https://github.com/flutter/flutter/assets/48603081/79436ce4-fef6-480a-bc43-b628497e860f)

### Before
```dart
 return _textTheme.displayMedium!.copyWith(color: _hourMinuteTextColor.resolve(states));
```
### After 
```dart
      return entryMode == TimePickerEntryMode.dial
        ? _textTheme.displayLarge!.copyWith(color: _hourMinuteTextColor.resolve(states))
        : _textTheme.displayMedium!.copyWith(color: _hourMinuteTextColor.resolve(states));
```

3403ca41

Roll Flutter Engine from 93063f61943a to e16f43eeaaa4 (2 revisions) (#143827) · 35fd7062

engine-flutter-autoroll authored Feb 21, 2024

https://github.com/flutter/engine/compare/93063f61943a...e16f43eeaaa4

2024-02-21 bdero@google.com [Impeller] Add GeometryResult enum with StC modes. (flutter/engine#50816)
2024-02-21 bdero@google.com Update impeller-cmake-example (flutter/engine#50808)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

35fd7062

Roll Flutter Engine from ed49634486e9 to 93063f61943a (1 revision) (#143826) · ca05958f

engine-flutter-autoroll authored Feb 21, 2024

https://github.com/flutter/engine/compare/ed49634486e9...93063f61943a

2024-02-21 bdero@google.com [Impeller] Remove non-Flutter fill types from impeller::Path. (flutter/engine#50814)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ca05958f

`CalendarDatePicker` doesn't announce selected date on desktop (#143583) · 5d2353c1

Taha Tesser authored Feb 21, 2024

fixes [Screen reader is not announcing the selected date as selected on DatePicker](https://github.com/flutter/flutter/issues/143439)

### Descriptions
- This fixes an issue where `CalendarDatePicker` doesn't announce selected date on desktop.
- Add semantic label to describe the selected date is indeed "Selected".

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  MyHomePageState createState() => MyHomePageState();
}

class MyHomePageState extends State<MyHomePage> {
  void _showDatePicker() async {
    await showDatePicker(
      context: context,
      initialDate: DateTime.now(),
      firstDate: DateTime(1900),
      lastDate: DateTime(2200),
    );
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title,
            style: const TextStyle(fontFamily: 'ProductSans')),
      ),
      body: const Center(
        child: Text('Click the button to show date picker.'),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _showDatePicker,
        tooltip: 'Show date picker',
        child: const Icon(Icons.edit_calendar),
      ),
    );
  }
}

// import 'package:flutter/material.dart';

// void main() => runApp(const MyApp());

// class MyApp extends StatelessWidget {
//   const MyApp({super.key});

//   @override
//   Widget build(BuildContext context) {
//     return MaterialApp(
//       debugShowCheckedModeBanner: false,
//       home: Scaffold(
//         body: Center(
//           child: CalendarDatePicker(
//             initialDate: DateTime.now(),
//             firstDate: DateTime(2020),
//             lastDate: DateTime(2050),
//             onDateChanged: (date) {
//               print(date);
//             },
//           ),
//         ),
//       ),
//     );
//   }
// }
```

</details>

### Before

https://github.com/flutter/flutter/assets/48603081/c82e1f15-f067-4865-8a5a-1f3c0c8d91da

### After

https://github.com/flutter/flutter/assets/48603081/193d9e26-df9e-4d89-97ce-265c3d564607

5d2353c1

Roll Flutter Engine from 9100d326475a to ed49634486e9 (2 revisions) (#143824) · a41868e5

engine-flutter-autoroll authored Feb 21, 2024

https://github.com/flutter/engine/compare/9100d326475a...ed49634486e9

2024-02-21 bdero@google.com [Impeller] Apply Entity depth in filter shaders that may render directly to an EntityPass. (flutter/engine#50742)
2024-02-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from gKg6HlBeR52y-cMhu... to dLhvv964txwnSlvNw... (flutter/engine#50813)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from gKg6HlBeR52y to dLhvv964txwn

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a41868e5

Add `timeSelectorSeparatorColor` and `timeSelectorSeparatorTextStyle` for... · 95cdebed

Taha Tesser authored Feb 21, 2024

Add `timeSelectorSeparatorColor` and `timeSelectorSeparatorTextStyle`  for Material 3 Time Picker (#143739)

fixes [`Time selector separator` in TimePicker is not centered vertically](https://github.com/flutter/flutter/issues/143691)

Separator currently `hourMinuteTextStyle` to style itself.

This introduces `timeSelectorSeparatorColor` and `timeSelectorSeparatorTextStyle` from Material 3 specs to correctly style  the separator. This also adds ability to change separator color without changing `hourMinuteTextColor`.

### Specs for the time selector separator
https://m3.material.io/components/time-pickers/specs
![image](https://github.com/flutter/flutter/assets/48603081/0c84f649-545d-441b-adbf-2b9ec872b14c)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(const App());
}

class App extends StatelessWidget {
  const App({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(
        // timePickerTheme: TimePickerThemeData(
        //   hourMinuteTextColor: Colors.amber,
        // )
      ),
      home: Scaffold(
        body: Center(
          child: Builder(builder: (context) {
            return ElevatedButton(
              onPressed: () async {
                await showTimePicker(
                  context: context,
                  initialTime: TimeOfDay.now(),
                );
              },
              child: const Text('Pick Time'),
            );
          }),
        ),
      ),
    );
  }
}

```

</details>

| Before | After |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/20beeba4-5cc2-49ee-bba8-1c552c0d1e44" /> | <img src="https://github.com/flutter/flutter/assets/48603081/24927187-aff7-4191-930c-bceab6a4b4c2" /> |

95cdebed

Roll Flutter Engine from efc69946cb1e to 9100d326475a (2 revisions) (#143820) · f9233756

engine-flutter-autoroll authored Feb 21, 2024

https://github.com/flutter/engine/compare/efc69946cb1e...9100d326475a

2024-02-21 leroux_bruno@yahoo.fr [Web] Update modifier state when Meta key is seen as Process key (flutter/engine#50779)
2024-02-21 jason-simmons@users.noreply.github.com Add pub.dev to the hosted package URIs checked by the pub_get_offline script (flutter/engine#50811)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f9233756

Roll Flutter Engine from 700250436e3f to efc69946cb1e (2 revisions) (#143816) · e9f3244e

engine-flutter-autoroll authored Feb 21, 2024

https://github.com/flutter/engine/compare/700250436e3f...efc69946cb1e

2024-02-21 zanderso@users.noreply.github.com Make global builds uniquely named per platform (flutter/engine#50764)
2024-02-21 zanderso@users.noreply.github.com [et] Adds a format command (flutter/engine#50747)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e9f3244e

Roll Flutter Engine from 3557277c575c to 700250436e3f (1 revision) (#143814) · 1f32b48c

engine-flutter-autoroll authored Feb 21, 2024

https://github.com/flutter/engine/compare/3557277c575c...700250436e3f

2024-02-21 bdero@google.com [Flutter GPU] Fix symbol export for windows. (flutter/engine#50755)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1f32b48c

more fixes to unstable impeller goldens. (#143811) · f58a162d
Jonah Williams authored Feb 21, 2024
```
Part of  https://github.com/flutter/flutter/issues/143616
```
f58a162d

Roll Flutter Engine from cb12a8cc97a1 to 3557277c575c (2 revisions) (#143807) · 35bdc94d

engine-flutter-autoroll authored Feb 21, 2024

https://github.com/flutter/engine/compare/cb12a8cc97a1...3557277c575c

2024-02-21 jonahwilliams@google.com Disable framework smoke tests. (flutter/engine#50800)
2024-02-20 jonahwilliams@google.com [Impeller] more nullchecks in image decoder. (flutter/engine#50787)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

35bdc94d

[flutter_tools] enable wasm compile on beta channel (#143779) · bc334396
Kevin Moore authored Feb 21, 2024
```
Wasm compilation is now available on `master` and `beta` channels.
```
bc334396

Fix initialization of time in repeat on AnimationController (#142887) · 6c78e36c

Simon Friis Vindum authored Feb 21, 2024

This PR fixes #142885.

The issue is that in `_RepeatingSimulation` the initial time is calculated as follows:

```
(initialValue / (max - min)) * (period.inMicroseconds / Duration.microsecondsPerSecond)
```

This calculation does not work in general. For instance, if `max` is 300, `min` is 100, and `initialValue` is 100 then `initialValue / (max - min)` is 1/2 when it should be 0

The current tests work by happenstance because the numbers used happen to work. To reveal the bug I've added some more tests similar to the existing ones but with different numbers.

A "side-effect" of the incorrect calculation is that if `initialValue` is 0, then the animation will always start from `min` no matter what. For instance, in one of the tests, an `AnimationController` with the value 0 is told to `repeat` between 0.5 and 1.0, and this starts the animation from 0.5. To preserve this behavior, and to more generally handle the case where the initial value is out of bounds, this PR clamps the initial value to be within the lower and upper bounds of the repetition.

Just for reference, this calculation was introduced at https://github.com/flutter/flutter/pull/25125.

6c78e36c

Disable debug banner to stabilize impeller goldens. (#143794) · 1e822ca2

Jonah Williams authored Feb 21, 2024

Fixes some of https://github.com/flutter/flutter/issues/143616 by disabling the debug banner, which does not appear to be a critical part of the golden.

1e822ca2

Reverts "Changing `TextPainter.getOffsetForCaret` implementation to remove the... · f9b3b84d

auto-submit[bot] authored Feb 21, 2024

Reverts "Changing `TextPainter.getOffsetForCaret` implementation to remove the logarithmic search (#143281)" (#143801)

Reverts flutter/flutter#143281

Initiated by: LongCatIsLooong

Reason for reverting: https://github.com/flutter/flutter/issues/143797

Original PR Author: LongCatIsLooong

Reviewed By: {justinmc, jason-simmons}

This change reverts the following previous change:
Original Description:
The behavior largely remains the same, except:

1. The EOT cursor `(textLength, downstream)` for text ending in the opposite writing direction as the paragraph is now placed at the visual end of the last line. 
  For example, in a LTR paragraph, the EOT cursor for `aA` (lowercase for LTR and uppercase for RTL) is placed to the right of the line: `aA|` (it was `a|A` before). 
  This matches the behavior of most applications that do logical order arrow key navigation instead of visual order navigation. 
  And it makes the navigation order consistent for `aA\naA`:
```
  |aA    =>  aA|  => aA|  => aA  => aA   => aA 
   aA        aA      aA     |aA     aA|     aA|     
   (1)       (2)     (3)    (4)    (5)      (6)
```
This is indeed still pretty confusing as (2) and (3), as well as (5) and (6) are hard to distinguish (when the I beam has a large width they are actually visually distinguishable -- they use the same anchor but one gets painted to the left and the other to the right. I noticed that emacs does the same). 
But logical order navigation will always be confusing in bidi text, in one way or another.

Interestingly there are 3 different behaviors I've observed in chrome:
- the chrome download dialog (which I think uses GTK text widgets but not sure which version) gives me 2 cursors when navigating bidi text, and 
- its HTML fields only show one, and presumably they place the I beam at the **trailing edge** of the character (which makes more sense for backspacing I guess). 
- On the other hand, its (new) omnibar seems to use visual order arrow navigation

Side note: we may need to update the "tap to place the caret here" logic to handle the case where the tap lands outside of the text and the text ends in the opposite writing direction. 

2. Removed the logarithmic search. The same could be done using the characters package but when glyphInfo tells you about the baseline location in the future we probably don't need the `getBoxesForRange` call. This should fix https://github.com/flutter/flutter/issues/123424.

## Internal Tests

This is going to change the image output of some internal golden tests. I'm planning to merge https://github.com/flutter/flutter/pull/143281 before this to avoid updating the same golden files twice for invalid selections.

f9b3b84d

20 Feb, 2024 13 commits

Reverts "Add UI Benchmarks (#143542)" (#143798) · 84b5e799

auto-submit[bot] authored Feb 20, 2024

Reverts flutter/flutter#143542

Initiated by: goderbauer

Reason for reverting: Failing post-submit, see https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8755531866181499153/+/u/run_microbenchmarks/stdout

Original PR Author: bernaferrari

Reviewed By: {goderbauer}

This change reverts the following previous change:
Original Description:
Part 1 of https://github.com/flutter/flutter/pull/138481

Cherry picking @ignatz work.

84b5e799

Avoid applying partial dartfixes on CI (#143551) · 174e5869

LongCatIsLooong authored Feb 20, 2024

Unblocks https://github.com/flutter/tests/pull/345

Add `bulkApply: false` to partial fixes so they don't automatically get applied on registered tests.

174e5869

Add UI Benchmarks (#143542) · 74a2e0d1

Bernardo Ferrari authored Feb 20, 2024

Part 1 of https://github.com/flutter/flutter/pull/138481

Cherry picking @ignatz work.

74a2e0d1

Roll Flutter Engine from 1ae2c10e8071 to cb12a8cc97a1 (1 revision) (#143791) · 0bd7d316

engine-flutter-autoroll authored Feb 20, 2024

https://github.com/flutter/engine/compare/1ae2c10e8071...cb12a8cc97a1

2024-02-20 737941+loic-sharma@users.noreply.github.com [Windows] Add ID to views (flutter/engine#50788)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0bd7d316

Implement `_suspendedNode` fix (#143556) · fc07b241

Nate authored Feb 20, 2024

Previously we merged #142930, to solve issue #87061.

Since then, I discovered that the keyboard input wasn't being captured after the app had been paused and resumed. After some digging, I realized that the problem was due to [a line in editable_text.dart](https://github.com/flutter/flutter/blob/d4b1b6e744ba6196e14fb49904f07a4aea4d5869/packages/flutter/lib/src/widgets/editable_text.dart#L3589) that called the `focusNode.consumeKeyboardToken()` method.

Luckily, it's a very easy fix: we just use `requestFocus()` instead of `applyFocusChangesIfNeeded()`. @gspencergoog could you take a look when you have a chance?

fc07b241

Change `ItemExtentBuilder`'s return value nullable (#142428) · 6707f5ef

xubaolin authored Feb 20, 2024

Fixes https://github.com/flutter/flutter/issues/138912

Change `ItemExtentBuilder`'s return value nullable, it should return null if asked to build an item extent with a greater index than exists.

6707f5ef

Roll Flutter Engine from 27828054f07a to 1ae2c10e8071 (6 revisions) (#143783) · bb1271d4

engine-flutter-autoroll authored Feb 20, 2024

https://github.com/flutter/engine/compare/27828054f07a...1ae2c10e8071

2024-02-20 matanlurey@users.noreply.github.com Move the `scenario_app` running Impeller+OpenGLES to `bringup: triue` (flutter/engine#50789)
2024-02-20 jason-simmons@users.noreply.github.com Implement the render_to_surface flag in GPUSurfaceGLImpeller (flutter/engine#50669)
2024-02-20 zanderso@users.noreply.github.com [et] Adds a .bat entrypoint for Windows (flutter/engine#50784)
2024-02-20 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Create dedicated testers to run tests and deprecate femu_test (flutter/engine#50697)
2024-02-20 skia-flutter-autoroll@skia.org Roll Skia from 50e1b709781c to 9d86359b5fe8 (2 revisions) (flutter/engine#50786)
2024-02-20 skia-flutter-autoroll@skia.org Roll Skia from 2dc00a705f1c to 50e1b709781c (5 revisions) (flutter/engine#50785)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bb1271d4

Roll Flutter Engine from e16a260265ad to 27828054f07a (1 revision) (#143769) · 64c63d35

engine-flutter-autoroll authored Feb 20, 2024

https://github.com/flutter/engine/compare/e16a260265ad...27828054f07a

2024-02-20 jonahwilliams@google.com [Impeller] add missing std::move in setup depth stencil. (flutter/engine#50750)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

64c63d35

[gold] Always provide host ABI to gold config (#143621) · 4c0b5cce

Jonah Williams authored Feb 20, 2024

This can help us split goldens that are different due to arm non-arm mac, et cetera.

Part of https://github.com/flutter/flutter/issues/143616

4c0b5cce

instead of exiting the tool, print a warning when using --flavor with an... · b491f16d

Andrew Kolos authored Feb 20, 2024

instead of exiting the tool, print a warning when using --flavor with an incompatible device (#143735)

Fixes https://github.com/flutter/flutter/issues/143574 by printing a warning (instead of exiting) when `--flavor` is used with a target platform that doesn't have flavors support.

b491f16d

Implementing `switch` expressions: everything in `flutter/lib/src/` (#143634) · 7a4c2465

Nate authored Feb 20, 2024

This PR is the 9áµÊ° step in the journey to solve issue #136139 and make the entire Flutter repo more readable.

(previous pull requests: #139048, #139882, #141591, #142279, #142634, #142793, #143293, #143496)

I did a pass through all of `packages/flutter/lib/src/` and found an abundance of `switch` statements to improve. Whereas #143496 focused on in-depth refactoring, this PR is full of simple, straightforward changes. (I ended up making some more complicated changes in `rendering/` and will file those separately after this PR is done.)

7a4c2465

Changing `TextPainter.getOffsetForCaret` implementation to remove the logarithmic search (#143281) · 3538e4c7

LongCatIsLooong authored Feb 20, 2024

The behavior largely remains the same, except:

1. The EOT cursor `(textLength, downstream)` for text ending in the opposite writing direction as the paragraph is now placed at the visual end of the last line. 
  For example, in a LTR paragraph, the EOT cursor for `aA` (lowercase for LTR and uppercase for RTL) is placed to the right of the line: `aA|` (it was `a|A` before). 
  This matches the behavior of most applications that do logical order arrow key navigation instead of visual order navigation. 
  And it makes the navigation order consistent for `aA\naA`:
```
  |aA    =>  aA|  => aA|  => aA  => aA   => aA 
   aA        aA      aA     |aA     aA|     aA|     
   (1)       (2)     (3)    (4)    (5)      (6)
```
This is indeed still pretty confusing as (2) and (3), as well as (5) and (6) are hard to distinguish (when the I beam has a large width they are actually visually distinguishable -- they use the same anchor but one gets painted to the left and the other to the right. I noticed that emacs does the same). 
But logical order navigation will always be confusing in bidi text, in one way or another.

Interestingly there are 3 different behaviors I've observed in chrome:
- the chrome download dialog (which I think uses GTK text widgets but not sure which version) gives me 2 cursors when navigating bidi text, and 
- its HTML fields only show one, and presumably they place the I beam at the **trailing edge** of the character (which makes more sense for backspacing I guess). 
- On the other hand, its (new) omnibar seems to use visual order arrow navigation

Side note: we may need to update the "tap to place the caret here" logic to handle the case where the tap lands outside of the text and the text ends in the opposite writing direction. 

2. Removed the logarithmic search. The same could be done using the characters package but when glyphInfo tells you about the baseline location in the future we probably don't need the `getBoxesForRange` call. This should fix https://github.com/flutter/flutter/issues/123424.

## Internal Tests

This is going to change the image output of some internal golden tests. I'm planning to merge https://github.com/flutter/flutter/pull/143281 before this to avoid updating the same golden files twice for invalid selections.

3538e4c7

Delete local.properties that shouldn't have been pushed (#143774) · 3ae71f5c

Gray Mackall authored Feb 20, 2024

This file shouldn't be in version control

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/ChatCo-authored-by: Gray Mackall <mackall@google.com>

3ae71f5c