- 22 Oct, 2023 1 commit
-
-
Todd Volkert authored
Before this change, long-running post-frame callbacks wouldn't show up in the timeline at all. This adds a timeline event for post-frame callbacks, with a debug flag that will add timeline events for each individual callback. #testexempt -- we have no way to test calls to the timeline.
-
- 14 Oct, 2023 1 commit
-
-
Kostia Sokolovskyi authored
### Description - Fixes https://github.com/flutter/flutter/issues/134205. ### Tests - Removes ignoring the `_RestorableRouteInformation` leak from `cupertino/app_test.dart`; - Removes ignoring the `_RestorableRouteInformation` leak from `material/app_test.dart`; - Removes ignoring the `_RestorableRouteInformation` leak from `widgets/app_test.dart`; - Removes ignoring the `_RestorableRouteInformation` leak from `widgets/route_notification_messages_test.dart`; - Removes ignoring the `_RestorableRouteInformation` leak from `widgets/router_restoration_test.dart`; - Updates `widgets/router_test.dart` to use `testWidgetsWithLeakTracking`.
-
- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the widgets library. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 19 Sep, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 18 Sep, 2023 3 commits
-
-
Zachary Anderson authored
Reverts flutter/flutter#134953 Several failures on CI
-
Polina Cherkasova authored
-
Michael Goderbauer authored
New feature in upcoming Dart 3.2. See https://github.com/dart-lang/language/issues/2020. Feature is enabled by bumping the min SDK version to 3.2. Part of https://github.com/flutter/flutter/issues/134476.
-
- 28 Aug, 2023 3 commits
-
-
Polina Cherkasova authored
-
Victoria Ashworth authored
Reverts flutter/flutter#133353 Tree is failing on Mac and Linux customer_testing on this PR. https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20customer_testing/14646/overview https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20customer_testing/14974/overview
-
Polina Cherkasova authored
-
- 13 Jul, 2023 1 commit
-
-
chunhtai authored
â¦ameter is semanticsally the same The URI compare does not taking into account that query parameter may or may not be encoded, or the parameters' order can be different. However, they are all semantically the same. This pr makes PlatformRouteInformationProvider to take those into account when deciding whether it should push/replace the browser history entry.
-
- 24 Apr, 2023 1 commit
-
-
chunhtai authored
Related https://github.com/flutter/flutter/issues/100624 The goal is to make sure the engine can send a location string in either the existing format or a complete uri string to the framework, and the framework will still work as usual.
-
- 24 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes
-
- 07 Sep, 2022 1 commit
-
-
Greg Spencer authored
-
- 02 Sep, 2022 1 commit
-
-
Pierre-Louis authored
-
- 26 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `widgets` * fix comments * fix comments
-
- 30 Apr, 2022 1 commit
-
-
chunhtai authored
-
- 29 Apr, 2022 1 commit
-
-
chunhtai authored
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 04 Apr, 2022 1 commit
-
-
chunhtai authored
* Fix crashes when current route parsing transactions are discarded * refactor * update
-
- 04 Mar, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 03 Feb, 2022 1 commit
-
-
Ian Hickson authored
-
- 25 Jan, 2022 1 commit
-
-
chunhtai authored
-
- 21 Jan, 2022 1 commit
-
-
Alberto authored
-
- 12 Dec, 2021 1 commit
-
-
Dan Field authored
-
- 18 Aug, 2021 1 commit
-
-
chunhtai authored
-
- 04 Aug, 2021 1 commit
-
-
chunhtai authored
-
- 15 Jul, 2021 1 commit
-
- 14 Jul, 2021 3 commits
-
-
Ian Hickson authored
-
Zachary Anderson authored
This reverts commit 31de052e.
-
Ian Hickson authored
-
- 13 Jul, 2021 2 commits
-
-
Ian Hickson authored
This reverts commit e2490f29.
-
Ian Hickson authored
-
- 25 May, 2021 1 commit
-
-
chunhtai authored
* Make RouteInformationProvider value non nullable * fix more lint
-
- 20 May, 2021 1 commit
-
-
Ian Hickson authored
-
- 19 May, 2021 1 commit
-
-
Michael Goderbauer authored
-
- 13 May, 2021 1 commit
-
-
Jan Mewes authored
-
- 10 May, 2021 1 commit
-
-
Michael Goderbauer authored
-
- 17 Apr, 2021 1 commit
-
-
Amine Dakhli authored
-
- 15 Apr, 2021 1 commit
-
-
Michael Goderbauer authored
-