1. 22 Oct, 2023 1 commit
    • Todd Volkert's avatar
      Add timeline events for post frame callbacks (#136435) · cb9a3f69
      Todd Volkert authored
      Before this change, long-running post-frame callbacks wouldn't show up in the timeline at all.  This adds a timeline event for post-frame callbacks, with a debug flag that will add timeline events for each individual callback.
      
      #testexempt -- we have no way to test calls to the timeline.
      cb9a3f69
  2. 14 Oct, 2023 1 commit
    • Kostia Sokolovskyi's avatar
      _RouterState should dispose created _RestorableRouteInformation. (#136556) · 2c3db435
      Kostia Sokolovskyi authored
      ### Description
      - Fixes https://github.com/flutter/flutter/issues/134205.
      
      ### Tests
      - Removes ignoring the `_RestorableRouteInformation` leak from `cupertino/app_test.dart`;
      - Removes ignoring the `_RestorableRouteInformation` leak from `material/app_test.dart`;
      - Removes ignoring the `_RestorableRouteInformation` leak from `widgets/app_test.dart`;
      - Removes ignoring the `_RestorableRouteInformation` leak from `widgets/route_notification_messages_test.dart`;
      - Removes ignoring the `_RestorableRouteInformation` leak from `widgets/router_restoration_test.dart`;
      - Updates `widgets/router_test.dart` to use `testWidgetsWithLeakTracking`.
      2c3db435
  3. 20 Sep, 2023 1 commit
    • Greg Spencer's avatar
      Remove 'must be non-null' and 'must not be null' comments in widgets library (#134992) · 6e5134b0
      Greg Spencer authored
      ## Description
      
      This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values.
      
      This PR removes them from the widgets library.
      
      This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.
      
      In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.
      
      This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases.  I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).
      
      ## Related PRs
      - https://github.com/flutter/flutter/pull/134984
      - https://github.com/flutter/flutter/pull/134991
      - https://github.com/flutter/flutter/pull/134993
      - https://github.com/flutter/flutter/pull/134994
      
      ## Tests
       - Documentation only change.
      6e5134b0
  4. 19 Sep, 2023 1 commit
  5. 18 Sep, 2023 3 commits
  6. 28 Aug, 2023 3 commits
  7. 13 Jul, 2023 1 commit
    • chunhtai's avatar
      PlatformRouteInformationProvider does not push new entry if query par… (#130457) · 315ebafe
      chunhtai authored
      …ameter is semanticsally the same
      
      The URI compare does not taking into account that query parameter may or may not be encoded, or the parameters' order can be different. However, they are all semantically the same. 
      
      This pr makes PlatformRouteInformationProvider to take those into account when deciding whether it should push/replace the browser history entry.
      315ebafe
  8. 24 Apr, 2023 1 commit
  9. 24 Jan, 2023 1 commit
  10. 07 Sep, 2022 1 commit
  11. 02 Sep, 2022 1 commit
  12. 26 May, 2022 1 commit
  13. 30 Apr, 2022 1 commit
  14. 29 Apr, 2022 1 commit
  15. 14 Apr, 2022 1 commit
  16. 04 Apr, 2022 1 commit
  17. 04 Mar, 2022 1 commit
  18. 03 Feb, 2022 1 commit
  19. 25 Jan, 2022 1 commit
  20. 21 Jan, 2022 1 commit
  21. 12 Dec, 2021 1 commit
  22. 18 Aug, 2021 1 commit
  23. 04 Aug, 2021 1 commit
  24. 15 Jul, 2021 1 commit
  25. 14 Jul, 2021 3 commits
  26. 13 Jul, 2021 2 commits
  27. 25 May, 2021 1 commit
  28. 20 May, 2021 1 commit
  29. 19 May, 2021 1 commit
  30. 13 May, 2021 1 commit
  31. 10 May, 2021 1 commit
  32. 17 Apr, 2021 1 commit
  33. 15 Apr, 2021 1 commit