- 29 Sep, 2017 1 commit
-
-
Chris Bracken authored
This patch fixes a collection of issues with widgets involved in text editing: * Fire widget.onChanged on EditableText value change: The value of an EditableText is composed of the text value as well as other editing-related data such as selection-related information. Previously, widget.onChanged() was only called for updates via updateEditingValue(). For pastes via a TextSelectionOverlay, updates are signalled via _handleSelectionOverlayChanged(), which only ever triggered widget.onSelectionChanged(), but not widget.onChanged(). Both updateEditingValue() and _handleSelectionOverlayChanged() perform the value update via _formatAndSetValue(), which is where this patch moves the widget.onChanged() call. * Correctly update TextFormField value on edits via controller: The textual value of a TextFormField exists in two locations: 1. FormField.value, as with all FormFields and subclasses. 2. TextEditingController.value associated with the TextField underlying the TextFormField. Previously, edits to the TextEditingController associated with a TextFormField resulted in updates to the rendered TextField widget, but did not update TextFormField.value. FormField.value is updated via FormField's onChanged function, which is called from the EditableText underlying the TextField underlying the TextFormField. EditableText only fires onChanged when it receives changes from the engine. It does not fire onChanged for changes made to the underlying TextController, since the owner of the TextController is the one making these changes and thus, already aware of them. FormField, however, *does* need to listen to these changes to update its value. * Adds an initialValue parameter to the TextFormField constructor: FormField's constructor already takes an initialValue parameter, which specifies the initial value in the field, which is also the value to which reset() returns the field. Previously, TextFormField took its initial value from the controller value (if a controller was passed in) or the empty string (if not). This had the undesirable effect that calling reset() always resets the value to the current value of the controller... i.e., does nothing. We now take an initial value explicitly.
-
- 21 Aug, 2017 1 commit
-
-
Chris Bracken authored
-
- 28 Jul, 2017 1 commit
-
-
Ian Hickson authored
...and break the navigator<->routes circular dependency. This is a step towards fixing https://github.com/flutter/flutter/issues/9577 but doesn't yet do so.
-
- 05 May, 2017 1 commit
-
-
Ian Hickson authored
-
- 23 Apr, 2017 1 commit
-
-
Alexandre Ardhuin authored
* more widget const constructors * prefer const constructors * address review comments
-
- 21 Apr, 2017 1 commit
-
-
Alexandre Ardhuin authored
* make @immutable const * fix build
-
- 14 Apr, 2017 1 commit
-
-
Adam Barth authored
There are more places we can use this annotation, but this patch just gets us started.
-
- 11 Apr, 2017 1 commit
-
-
xster authored
Rename State.config to State.widget Rename State.didUpdateConfig to State.didUpdateWidget Renamed all State subclasses' local variables named config to something else
-
- 08 Apr, 2017 1 commit
-
-
Kyle Bradshaw authored
Came across "can ve" while experimenting with Forms using VSCode and Dart Code. Glanced over the rest of the docs for typos while I was at it.
-
- 29 Mar, 2017 1 commit
-
-
Alexandre Ardhuin authored
-
- 15 Mar, 2017 1 commit
-
-
Adam Barth authored
Also, add a few other random dartdocs that I encountered along the way.
-
- 04 Mar, 2017 1 commit
-
-
Chris Bracken authored
Covers lib/ in package:flutter.
-
- 21 Feb, 2017 1 commit
-
-
Adam Barth authored
This functionality is independently useful. Fixes #8293
-
- 07 Feb, 2017 1 commit
-
-
Hans Muller authored
-
- 19 Jan, 2017 1 commit
-
-
Adam Barth authored
This patch is the first of a series to rationalize the names of the text-input related widgets. See #7031
-
- 18 Jan, 2017 1 commit
-
-
Hans Muller authored
-
- 16 Dec, 2016 1 commit
-
-
Matt Perry authored
Callers can manually validate by calling validate(), or tell the Form to validate on every change by setting the `autovalidate` parameter. Fixes https://github.com/flutter/flutter/issues/7219
-
- 12 Dec, 2016 1 commit
-
-
Matt Perry authored
Fixes https://github.com/flutter/flutter/issues/7017
-
- 19 Nov, 2016 1 commit
-
-
Ian Hickson authored
-
- 03 Nov, 2016 1 commit
-
-
Ian Hickson authored
-
- 02 Nov, 2016 1 commit
-
-
Matt Perry authored
FormField is now a widget that can contain any type of field. Input no longer has special code to handle form fields. Instead, there is a helper widget InputFormField for using an Input inside a FormField. Fixes https://github.com/flutter/flutter/issues/6097 and based on feedback from the same.
-
- 24 Oct, 2016 1 commit
-
-
Ian Hickson authored
-
- 06 Jun, 2016 1 commit
-
-
Adam Barth authored
Also, add more dartdoc to widgets.dart.
-
- 25 Mar, 2016 1 commit
-
-
Matt Perry authored
-