1. 29 Sep, 2017 1 commit
    • Chris Bracken's avatar
      Improved behaviour for text-editing widgets (#12273) · 85c425ac
      Chris Bracken authored
      This patch fixes a collection of issues with widgets involved in text
      editing:
      
        * Fire widget.onChanged on EditableText value change:
          The value of an EditableText is composed of the text value as well
          as other editing-related data such as selection-related information.
      
          Previously, widget.onChanged() was only called for updates via
          updateEditingValue(). For pastes via a TextSelectionOverlay, updates
          are signalled via _handleSelectionOverlayChanged(), which only ever
          triggered widget.onSelectionChanged(), but not widget.onChanged().
      
          Both updateEditingValue() and _handleSelectionOverlayChanged()
          perform the value update via _formatAndSetValue(), which is where
          this patch moves the widget.onChanged() call.
      
        * Correctly update TextFormField value on edits via controller:
          The textual value of a TextFormField exists in two locations:
            1. FormField.value, as with all FormFields and subclasses.
            2. TextEditingController.value associated with the TextField
               underlying the TextFormField.
      
          Previously, edits to the TextEditingController associated with a
          TextFormField resulted in updates to the rendered TextField widget,
          but did not update TextFormField.value. FormField.value is updated
          via FormField's onChanged function, which is called from the
          EditableText underlying the TextField underlying the TextFormField.
          EditableText only fires onChanged when it receives changes from the
          engine. It does not fire onChanged for changes made to the
          underlying TextController, since the owner of the TextController is
          the one making these changes and thus, already aware of them.
          FormField, however, *does* need to listen to these changes to update
          its value.
      
        * Adds an initialValue parameter to the TextFormField constructor:
          FormField's constructor already takes an initialValue parameter,
          which specifies the initial value in the field, which is also the
          value to which reset() returns the field.
      
          Previously, TextFormField took its initial value from the controller
          value (if a controller was passed in) or the empty string (if not).
          This had the undesirable effect that calling reset() always resets
          the value to the current value of the controller... i.e., does
          nothing.
      
          We now take an initial value explicitly.
      85c425ac
  2. 21 Aug, 2017 1 commit
  3. 28 Jul, 2017 1 commit
  4. 05 May, 2017 1 commit
  5. 23 Apr, 2017 1 commit
  6. 21 Apr, 2017 1 commit
  7. 14 Apr, 2017 1 commit
  8. 11 Apr, 2017 1 commit
    • xster's avatar
      Rename State.config to widget everywhere (#9273) · 89a7fdfc
      xster authored
      Rename State.config to State.widget
      Rename State.didUpdateConfig to State.didUpdateWidget
      Renamed all State subclasses' local variables named config to something else
      89a7fdfc
  9. 08 Apr, 2017 1 commit
    • Kyle Bradshaw's avatar
      Form.dart doc typo fixes (#9302) · 55e51e79
      Kyle Bradshaw authored
      Came across "can ve" while experimenting with Forms using VSCode and Dart Code. Glanced over the rest of the docs for typos while I was at it.
      55e51e79
  10. 29 Mar, 2017 1 commit
  11. 15 Mar, 2017 1 commit
  12. 04 Mar, 2017 1 commit
  13. 21 Feb, 2017 1 commit
  14. 07 Feb, 2017 1 commit
  15. 19 Jan, 2017 1 commit
  16. 18 Jan, 2017 1 commit
  17. 16 Dec, 2016 1 commit
  18. 12 Dec, 2016 1 commit
  19. 19 Nov, 2016 1 commit
  20. 03 Nov, 2016 1 commit
  21. 02 Nov, 2016 1 commit
  22. 24 Oct, 2016 1 commit
  23. 06 Jun, 2016 1 commit
  24. 25 Mar, 2016 1 commit