Commits · ebbb4b3887e54b171892e7872254bdf7990242c9 · abdullh.alsoleman / Front-End

07 Aug, 2023 12 commits

Android context menu theming and visual update (#131816) · ebbb4b38

Justin McCandless authored Aug 07, 2023

Fixes https://github.com/flutter/flutter/issues/89939 and updates the look of the Android context menu to match API 34.

## The problem
Before this PR, setting `surface` in the color scheme caused the background color of the Android context menu to change, but it wasn't possible to change the text color.

```dart
MaterialApp(
  theme: ThemeData(
    // Using a dark theme made the context menu text color be white.
    colorScheme: ThemeData.dark().colorScheme.copyWith(
      // Setting the surface here worked.
      surface: Colors.white,
      // But there was no way to set the text color. This didn't work.
      onSurface: Colors.black,
    ),
  ),
),
```

| Expected (after PR) | Actual (before PR) |
| --- | --- |
| <img width="239" alt="Screenshot 2023-08-07 at 11 45 37 AM" src="https://github.com/flutter/flutter/assets/389558/a9fb75e5-b6c3-4f8e-8c59-2021780c44a7"> | <img width="250" alt="Screenshot 2023-08-07 at 11 51 10 AM" src="https://github.com/flutter/flutter/assets/389558/a5abd2d2-49bb-47a0-836f-864d56af2f58"> |

## Other examples

<table>
<tr>
<th>Scenario</th>
<th>Result</th>
</tr>
<tr>
<td>

```dart
MaterialApp(
  theme: ThemeData(
    colorScheme: ThemeData.light(),
  ),
  ...
),
```

</td>
<td>
<img width="244" alt="Screenshot 2023-08-07 at 11 42 05 AM" src="https://github.com/flutter/flutter/assets/389558/74c6870b-5ff7-4b1a-9e0c-b2bb4809ef1e">
</td>
</tr>
<tr>
<td>

```dart
MaterialApp(
  theme: ThemeData(
    colorScheme: ThemeData.dark(),
  ),
  ...
),
```

</td>
<td>
<img width="239" alt="Screenshot 2023-08-07 at 11 42 23 AM" src="https://github.com/flutter/flutter/assets/389558/91fe32f8-bd62-4d9b-96e8-ae5a9a769745">
</td>
</tr>
<tr>
<td>

```dart
MaterialApp(
  theme: ThemeData(
    colorScheme: ThemeData.light().colorScheme.copyWith(
      surface: Colors.blue,
      onSurface: Colors.red,
    ),
  ),
  ...
),
```

</td>
<td>
<img width="240" alt="Screenshot 2023-08-07 at 11 43 06 AM" src="https://github.com/flutter/flutter/assets/389558/e5752f8b-3738-4391-9055-15c38bd4af21">
</td>
</tr>
<tr>
<td>

```dart
MaterialApp(
  theme: ThemeData(
    colorScheme: ThemeData.light().colorScheme.copyWith(
      surface: Colors.blue,
      onSurface: Colors.red,
    ),
  ),
  ...
),
```

</td>
<td>
<img width="244" alt="Screenshot 2023-08-07 at 11 42 47 AM" src="https://github.com/flutter/flutter/assets/389558/68cc68f0-b338-4d94-8810-d8e46fb1e48e">
</td>
</tr>
</table>

ebbb4b38

Roll Flutter Engine from 39ce1c097bce to 39a575f65d50 (2 revisions) (#132064) · 9cc4f943

engine-flutter-autoroll authored Aug 07, 2023

https://github.com/flutter/engine/compare/39ce1c097bce...39a575f65d50

2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from e327eb094605 to 359808ec2cb1 (2 revisions) (flutter/engine#44438)
2023-08-07 jason-simmons@users.noreply.github.com Do not log exceptions from JNI lookups of APIs that are known to be unavailable on older devices (flutter/engine#44357)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9cc4f943

CupertinoContextMenu improvement (#131030) · ff5b0e14
xhzq233 authored Aug 07, 2023
```
Fixes overlapping gestures in CupertinoContextMenu's subtree
```
ff5b0e14

Roll Flutter Engine from 5b47c0577060 to 39ce1c097bce (3 revisions) (#132057) · 1a31682e

engine-flutter-autoroll authored Aug 07, 2023

https://github.com/flutter/engine/compare/5b47c0577060...39ce1c097bce

2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from 7a98630e0de9 to e327eb094605 (2 revisions) (flutter/engine#44437)
2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from f4047f002891 to 7a98630e0de9 (1 revision) (flutter/engine#44436)
2023-08-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from zVfdIYcZ93Loob7VG... to 0Jd9VPJCX145RGnqr... (flutter/engine#44435)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from zVfdIYcZ93Lo to 0Jd9VPJCX145

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1a31682e

Slider should check `mounted` before start interaction (#132010) · 06ca902d

Mingyu authored Aug 07, 2023

This is a follow up to the following pull requests:
- https://github.com/flutter/flutter/pull/124514

I was finally able to reproduce this bug and found out why it was happening. Consider this code:

```dart
GestureDetector(
  behavior: HitTestBehavior.translucent,
  // Note: Make sure onTap is not null to ensure events
  // are captured by `GestureDetector`
  onTap: () {},
  child: _shouldShowSlider
    ? Slider(value: _value, onChanged: _handleSlide)
    : const SizedBox.shrink().
)
```

Runtime exception happens when:

1. User taps and holds the Slider (drag callback captured by `GestureDetector`)
2. `_shouldShowSlider` changes to false, Slider disappears and unmounts, and unregisters `_handleSlide`. But the callback is still registered by `GestureDetector`
3. Users moves finger as if Slider were still there
4. Drag callback is invoked, `_SliderState.showValueIndicator` is called
5. Exception - Slider is already disposed

This pull request fixes it by adding a mounted check inside `_SliderState.showValueIndicator` to ensure the Slider is actually mounted at the time of invoking drag event callback. I've added a unit test that will fail without this change.

The error stack trace is:

```
The following assertion was thrown while handling a gesture:
This widget has been unmounted, so the State no longer has a context (and should be considered
defunct).
Consider canceling any active work during "dispose" or using the "mounted" getter to determine if
the State is still active.

When the exception was thrown, this was the stack:
#0      State.context.<anonymous closure> (package:flutter/src/widgets/framework.dart:950:9)
#1      State.context (package:flutter/src/widgets/framework.dart:956:6)
#2      _SliderState.showValueIndicator (package:flutter/src/material/slider.dart:968:18)
#3      _RenderSlider._startInteraction (package:flutter/src/material/slider.dart:1487:12)
#4      _RenderSlider._handleDragStart (package:flutter/src/material/slider.dart:1541:5)
#5      DragGestureRecognizer._checkStart.<anonymous closure> (package:flutter/src/gestures/monodrag.dart:531:53)
#6      GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:275:24)
#7      DragGestureRecognizer._checkStart (package:flutter/src/gestures/monodrag.dart:531:7)
#8      DragGestureRecognizer._checkDrag (package:flutter/src/gestures/monodrag.dart:498:5)
#9      DragGestureRecognizer.acceptGesture (package:flutter/src/gestures/monodrag.dart:431:7)
#10     _CombiningGestureArenaMember.acceptGesture (package:flutter/src/gestures/team.dart:45:14)
#11     GestureArenaManager._resolveInFavorOf (package:flutter/src/gestures/arena.dart:281:12)
#12     GestureArenaManager._resolve (package:flutter/src/gestures/arena.dart:239:9)
#13     GestureArenaEntry.resolve (package:flutter/src/gestures/arena.dart:53:12)
#14     _CombiningGestureArenaMember._resolve (package:flutter/src/gestures/team.dart:85:15)
#15     _CombiningGestureArenaEntry.resolve (package:flutter/src/gestures/team.dart:19:15)
#16     OneSequenceGestureRecognizer.resolve (package:flutter/src/gestures/recognizer.dart:375:13)
#17     DragGestureRecognizer.handleEvent (package:flutter/src/gestures/monodrag.dart:414:13)
#18     PointerRouter._dispatch (package:flutter/src/gestures/pointer_router.dart:98:12)
#19     PointerRouter._dispatchEventToRoutes.<anonymous closure> (package:flutter/src/gestures/pointer_router.dart:143:9)
#20     _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:625:13)
#21     PointerRouter._dispatchEventToRoutes (package:flutter/src/gestures/pointer_router.dart:141:18)
#22     PointerRouter.route (package:flutter/src/gestures/pointer_router.dart:127:7)
#23     GestureBinding.handleEvent (package:flutter/src/gestures/binding.dart:488:19)
#24     GestureBinding.dispatchEvent (package:flutter/src/gestures/binding.dart:468:22)
#25     RendererBinding.dispatchEvent (package:flutter/src/rendering/binding.dart:439:11)
#26     GestureBinding._handlePointerEventImmediately (package:flutter/src/gestures/binding.dart:413:7)
#27     GestureBinding.handlePointerEvent (package:flutter/src/gestures/binding.dart:376:5)
#28     GestureBinding._flushPointerEventQueue (package:flutter/src/gestures/binding.dart:323:7)
#29     GestureBinding._handlePointerDataPacket (package:flutter/src/gestures/binding.dart:292:9)
#30     _invoke1 (dart:ui/hooks.dart:186:13)
#31     PlatformDispatcher._dispatchPointerDataPacket (dart:ui/platform_dispatcher.dart:433:7)
#32     _dispatchPointerDataPacket (dart:ui/hooks.dart:119:31)

Handler: "onStart"
Recognizer:
  HorizontalDragGestureRecognizer#a5df2
```

*List which issues are fixed by this PR. You must list at least one issue.*

Internal bug: b/273666179, b/192329942

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

06ca902d

Roll Packages from ce53da1bd741 to d7ee75ad59ad (7 revisions) (#132058) · 122c4295

engine-flutter-autoroll authored Aug 07, 2023

https://github.com/flutter/packages/compare/ce53da1bd741...d7ee75ad59ad

2023-08-05 stuartmorgan@google.com [tool] Skip pathified analysis on resolver errors (flutter/packages#4647)
2023-08-05 stuartmorgan@google.com [ci] Remove tools from Dockerfile (flutter/packages#4649)
2023-08-05 32242716+ricardoamador@users.noreply.github.com Update to not backfill the ci.yaml roller task. (flutter/packages#4651)
2023-08-04 stuartmorgan@google.com [pigeon] Consolidate mock handler tests (flutter/packages#4642)
2023-08-04 stuartmorgan@google.com [camera_web] Adopt code excerpts in README (flutter/packages#4584)
2023-08-04 stuartmorgan@google.com [image_picker] Allows 3.0 web implementation (flutter/packages#4648)
2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter from c00d2419 to 2ba9f7bd (25 revisions) (flutter/packages#4646)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

122c4295

Roll Flutter Engine from b10891e0d8d8 to 5b47c0577060 (1 revision) (#132040) · ad0aa8de

engine-flutter-autoroll authored Aug 07, 2023

https://github.com/flutter/engine/compare/b10891e0d8d8...5b47c0577060

2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from 558d9754241d to f4047f002891 (1 revision) (flutter/engine#44433)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ad0aa8de

Roll Flutter Engine from 4304d6180264 to b10891e0d8d8 (1 revision) (#132037) · c11ac7be

engine-flutter-autoroll authored Aug 07, 2023

https://github.com/flutter/engine/compare/4304d6180264...b10891e0d8d8

2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from b7a1f4fdedc1 to 558d9754241d (1 revision) (flutter/engine#44432)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c11ac7be

Roll Flutter Engine from eb91441398a1 to 4304d6180264 (1 revision) (#132031) · fd61c4a4

engine-flutter-autoroll authored Aug 07, 2023

https://github.com/flutter/engine/compare/eb91441398a1...4304d6180264

2023-08-07 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 9QyQ03F49oT_9slFF... to mlT1Bm0L9bVynvMFF... (flutter/engine#44431)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 9QyQ03F49oT_ to mlT1Bm0L9bVy

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fd61c4a4

Constrain _RenderScaledInlineWidget child size in computeDryLayout (#131765) · 55044a60
Tomasz Gucio authored Aug 07, 2023

55044a60

Roll Flutter Engine from 15b5707af406 to eb91441398a1 (1 revision) (#132025) · 7de053b2

engine-flutter-autoroll authored Aug 07, 2023

https://github.com/flutter/engine/compare/15b5707af406...eb91441398a1

2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from 9c4cfcd16529 to b7a1f4fdedc1 (2 revisions) (flutter/engine#44430)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7de053b2

Roll Flutter Engine from a1d513f78bbb to 15b5707af406 (2 revisions) (#132020) · bfbe79fe

engine-flutter-autoroll authored Aug 07, 2023

https://github.com/flutter/engine/compare/a1d513f78bbb...15b5707af406

2023-08-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from fwCoUCWKEqZSJGPE8... to zVfdIYcZ93Loob7VG... (flutter/engine#44428)
2023-08-06 skia-flutter-autoroll@skia.org Roll Skia from 72264deb9f05 to 9c4cfcd16529 (1 revision) (flutter/engine#44427)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from fwCoUCWKEqZS to zVfdIYcZ93Lo

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bfbe79fe

06 Aug, 2023 4 commits

Roll Flutter Engine from c9bd380ccbb0 to a1d513f78bbb (1 revision) (#132015) · ecef964a

engine-flutter-autoroll authored Aug 06, 2023

https://github.com/flutter/engine/compare/c9bd380ccbb0...a1d513f78bbb

2023-08-06 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from iY3v8FawLUo9HvTeR... to 9QyQ03F49oT_9slFF... (flutter/engine#44425)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from iY3v8FawLUo9 to 9QyQ03F49oT_

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ecef964a

Roll Flutter Engine from 060c95f94364 to c9bd380ccbb0 (1 revision) (#132008) · 310e9114

engine-flutter-autoroll authored Aug 06, 2023

https://github.com/flutter/engine/compare/060c95f94364...c9bd380ccbb0

2023-08-06 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from E0vw_CD-BaFAcSoH4... to fwCoUCWKEqZSJGPE8... (flutter/engine#44424)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from E0vw_CD-BaFA to fwCoUCWKEqZS

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

310e9114

Roll Flutter Engine from af7aaae2f1f9 to 060c95f94364 (1 revision) (#132006) · 11d98460

engine-flutter-autoroll authored Aug 06, 2023

https://github.com/flutter/engine/compare/af7aaae2f1f9...060c95f94364

2023-08-06 skia-flutter-autoroll@skia.org Roll Skia from 1d390344bfca to 72264deb9f05 (1 revision) (flutter/engine#44423)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

11d98460

Roll Flutter Engine from cdafc05a7217 to af7aaae2f1f9 (2 revisions) (#132004) · 91d64391

engine-flutter-autoroll authored Aug 06, 2023

https://github.com/flutter/engine/compare/cdafc05a7217...af7aaae2f1f9

2023-08-06 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 4pA5pP6XaVIJBXuq0... to iY3v8FawLUo9HvTeR... (flutter/engine#44422)
2023-08-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from QazMbN_0ttbJpf36s... to E0vw_CD-BaFAcSoH4... (flutter/engine#44421)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from QazMbN_0ttbJ to E0vw_CD-BaFA
fuchsia/sdk/core/mac-amd64 from 4pA5pP6XaVIJ to iY3v8FawLUo9

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

91d64391

05 Aug, 2023 12 commits

Roll Flutter Engine from b512df490c94 to cdafc05a7217 (1 revision) (#131996) · c09a9b4c

engine-flutter-autoroll authored Aug 05, 2023

https://github.com/flutter/engine/compare/b512df490c94...cdafc05a7217

2023-08-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from UpzOzWyiGYKrIuKmG... to 4pA5pP6XaVIJBXuq0... (flutter/engine#44420)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from UpzOzWyiGYKr to 4pA5pP6XaVIJ

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c09a9b4c

Take paint offset into account for inline children hit test in Editable (#131675) · bc4cacac
Tomasz Gucio authored Aug 05, 2023

bc4cacac

Roll Flutter Engine from d26b8c8fb60c to b512df490c94 (1 revision) (#131987) · 545ecd29

engine-flutter-autoroll authored Aug 05, 2023

https://github.com/flutter/engine/compare/d26b8c8fb60c...b512df490c94

2023-08-05 skia-flutter-autoroll@skia.org Roll Skia from 275bcb6d874d to 1d390344bfca (1 revision) (flutter/engine#44419)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

545ecd29

Roll Flutter Engine from 2ce2913acbe4 to d26b8c8fb60c (1 revision) (#131986) · 53609ef8

engine-flutter-autoroll authored Aug 05, 2023

https://github.com/flutter/engine/compare/2ce2913acbe4...d26b8c8fb60c

2023-08-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 3uzA1Z-yaMQE_Cz5f... to QazMbN_0ttbJpf36s... (flutter/engine#44418)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 3uzA1Z-yaMQE to QazMbN_0ttbJ

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

53609ef8

Roll Flutter Engine from 628b086265f2 to 2ce2913acbe4 (1 revision) (#131983) · e1f56f18

engine-flutter-autoroll authored Aug 05, 2023

https://github.com/flutter/engine/compare/628b086265f2...2ce2913acbe4

2023-08-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 8a3277696c52 to 0816d590a220 (1 revision) (flutter/engine#44415)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e1f56f18

Roll Flutter Engine from 7302a678e58e to 628b086265f2 (1 revision) (#131976) · 26c198c1

engine-flutter-autoroll authored Aug 05, 2023

https://github.com/flutter/engine/compare/7302a678e58e...628b086265f2

2023-08-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from jMLeVECzwzDoe9dYS... to UpzOzWyiGYKrIuKmG... (flutter/engine#44414)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from jMLeVECzwzDo to UpzOzWyiGYKr

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

26c198c1

Roll Flutter Engine from 138a1ea9a692 to 7302a678e58e (2 revisions) (#131975) · 317f788a

engine-flutter-autoroll authored Aug 05, 2023

https://github.com/flutter/engine/compare/138a1ea9a692...7302a678e58e

2023-08-05 skia-flutter-autoroll@skia.org Roll Skia from b2a0382bb587 to 275bcb6d874d (3 revisions) (flutter/engine#44413)
2023-08-05 32242716+ricardoamador@users.noreply.github.com Mark the ci.yaml roller task so it is not backfilled. (flutter/engine#44409)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

317f788a

Roll Flutter Engine from a0d650e37f5d to 138a1ea9a692 (2 revisions) (#131972) · 57ebf373

engine-flutter-autoroll authored Aug 05, 2023

https://github.com/flutter/engine/compare/a0d650e37f5d...138a1ea9a692

2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from 7cf7e2da3557 to b2a0382bb587 (1 revision) (flutter/engine#44407)
2023-08-04 chris@bracken.jp [Darwin] Move FlutterBinaryMessengerRelay to common (flutter/engine#44395)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

57ebf373

Add TODO to refactor error handling. (#131878) · d5f8ca72
Polina Cherkasova authored Aug 05, 2023

d5f8ca72

Manual roll Flutter Engine from 4f4734cd48da to a0d650e37f5d (3 revisions) (#131967) · 0da04797

engine-flutter-autoroll authored Aug 05, 2023

Manual roll requested by jacksongardner@google.com

Cannot build log URL because revision "a0d650e37f5d" is invalid: Luci builds of "Linux Web Framework tests" for a0d650e37f5d715468d8797519c622998ff5ab27 was FAILURE

2023-08-04 skia-flutter-autoroll@skia.org Roll Dart SDK from a0b59bac20fc to 8a3277696c52 (1 revision) (flutter/engine#44405)
2023-08-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ZvUiUZL9vUp2LcvHG... to 3uzA1Z-yaMQE_Cz5f... (flutter/engine#44403)
2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from 6dc76e862f90 to 7cf7e2da3557 (1 revision) (flutter/engine#44402)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ZvUiUZL9vUp2 to 3uzA1Z-yaMQE

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0da04797

Mark the ci_yaml roller task so that it is not backfilled. (#131966) · 45383def

Ricardo Amador authored Aug 05, 2023

In order to avoid new tasks from not being scheduled we are not going to backfill the autoroller because it can sometimes play transactions out of order causing issues with tasks that are scheduled but not known.

*List which issues are fixed by this PR. You must list at least one issue.*
Part of https://github.com/flutter/flutter/issues/127063

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

45383def

mark linux packages_autoroller flaky because of token issue (#131970) · a2fa60cc
Christopher Fujino authored Aug 05, 2023
```
unblock tree from https://github.com/flutter/flutter/issues/131968
```
a2fa60cc

04 Aug, 2023 12 commits

Sped up the time to find macrobenchmarks. (#131959) · 11025e4a

gaaclarke authored Aug 04, 2023

This reduce the execution time of macrobenchmarks driver tests.

I tried to find the exact size to scroll the screen but I couldn't find a way to do that with driver tests.

11025e4a

Roll Flutter Engine from c254deb8fbda to 4f4734cd48da (2 revisions) (#131955) · 53082f65

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/engine/compare/c254deb8fbda...4f4734cd48da

2023-08-04 chris@bracken.jp [Darwin] Enable ARC in darwin/common unit tests (flutter/engine#44396)
2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from 45c0a830d805 to 6dc76e862f90 (2 revisions) (flutter/engine#44399)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

53082f65

Roll Flutter Engine from a7bea8621f4b to c254deb8fbda (3 revisions) (#131950) · b7acafa0

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/engine/compare/a7bea8621f4b...c254deb8fbda

2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from 85938bb68e75 to 45c0a830d805 (3 revisions) (flutter/engine#44397)
2023-08-04 55360120+Matt2D@users.noreply.github.com Flutter iOS Interactive Keyboard: Take Screenshot and Handle Pointer Movement (flutter/engine#43972)
2023-08-04 skia-flutter-autoroll@skia.org Roll Dart SDK from b3372378e487 to a0b59bac20fc (1 revision) (flutter/engine#44393)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b7acafa0

Predictive back support for root routes (#120385) · dedd100e

Justin McCandless authored Aug 04, 2023

This PR aims to support Android's predictive back gesture when popping the entire Flutter app.  Predictive route transitions between routes inside of a Flutter app will come later.

<img width="200" src="https://user-images.githubusercontent.com/389558/217918109-945febaa-9086-41cc-a476-1a189c7831d8.gif" />

### Trying it out

If you want to try this feature yourself, here are the necessary steps:

  1. Run Android 33 or above.
  1. Enable the feature flag for predictive back on the device under "Developer
     options".
  1. Create a Flutter project, or clone [my example project](https://github.com/justinmc/flutter_predictive_back_examples).
  1. Set `android:enableOnBackInvokedCallback="true"` in
     android/app/src/main/AndroidManifest.xml (already done in the example project).
  1. Check out this branch.
  1. Run the app. Perform a back gesture (swipe from the left side of the
     screen).

You should see the predictive back animation like in the animation above and be able to commit or cancel it.

### go_router support

go_router works with predictive back out of the box because it uses a Navigator internally that dispatches NavigationNotifications!

~~go_router can be supported by adding a listener to the router and updating SystemNavigator.setFrameworkHandlesBack.~~

Similar to with nested Navigators, nested go_routers is supported by using a PopScope widget.

<details>

<summary>Full example of nested go_routers</summary>

```dart
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:go_router/go_router.dart';

import 'package:flutter/material.dart';
import 'package:flutter/scheduler.dart';

void main() => runApp(_MyApp());

class _MyApp extends StatelessWidget {
  final GoRouter router = GoRouter(
    routes: <RouteBase>[
      GoRoute(
        path: '/',
        builder: (BuildContext context, GoRouterState state) => _HomePage(),
      ),
      GoRoute(
        path: '/nested_navigators',
        builder: (BuildContext context, GoRouterState state) => _NestedGoRoutersPage(),
      ),
    ],
  );

  @override
  Widget build(BuildContext context) {
    return MaterialApp.router(
      routerConfig: router,
    );
  }
}

class _HomePage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Nested Navigators Example'),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            const Text('Home Page'),
            const Text('A system back gesture here will exit the app.'),
            const SizedBox(height: 20.0),
            ListTile(
              title: const Text('Nested go_router route'),
              subtitle: const Text('This route has another go_router in addition to the one used with MaterialApp above.'),
              onTap: () {
                context.push('/nested_navigators');
              },
            ),
          ],
        ),
      ),
    );
  }
}

class _NestedGoRoutersPage extends StatefulWidget {
  @override
  State<_NestedGoRoutersPage> createState() => _NestedGoRoutersPageState();
}

class _NestedGoRoutersPageState extends State<_NestedGoRoutersPage> {
  late final GoRouter _router;
  final GlobalKey<NavigatorState> _nestedNavigatorKey = GlobalKey<NavigatorState>();

  // If the nested navigator has routes that can be popped, then we want to
  // block the root navigator from handling the pop so that the nested navigator
  // can handle it instead.
  bool get _popEnabled {
    // canPop will throw an error if called before build. Is this the best way
    // to avoid that?
    return _nestedNavigatorKey.currentState == null ? true : !_router.canPop();
  }

  void _onRouterChanged() {
    // Here the _router reports the location correctly, but canPop is still out
    // of date.  Hence the post frame callback.
    SchedulerBinding.instance.addPostFrameCallback((Duration duration) {
      setState(() {});
    });
  }

  @override
  void initState() {
    super.initState();

    final BuildContext rootContext = context;
    _router = GoRouter(
      navigatorKey: _nestedNavigatorKey,
      routes: [
        GoRoute(
          path: '/',
          builder: (BuildContext context, GoRouterState state) => _LinksPage(
            title: 'Nested once - home route',
            backgroundColor: Colors.indigo,
            onBack: () {
              rootContext.pop();
            },
            buttons: <Widget>[
              TextButton(
                onPressed: () {
                  context.push('/two');
                },
                child: const Text('Go to another route in this nested Navigator'),
              ),
            ],
          ),
        ),
        GoRoute(
          path: '/two',
          builder: (BuildContext context, GoRouterState state) => _LinksPage(
            backgroundColor: Colors.indigo.withBlue(255),
            title: 'Nested once - page two',
          ),
        ),
      ],
    );

    _router.addListener(_onRouterChanged);
  }

  @override
  void dispose() {
    _router.removeListener(_onRouterChanged);
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return PopScope(
      popEnabled: _popEnabled,
      onPopped: (bool success) {
        if (success) {
          return;
        }
        _router.pop();
      },
      child: Router<Object>.withConfig(
        restorationScopeId: 'router-2',
        config: _router,
      ),
    );
  }
}

class _LinksPage extends StatelessWidget {
  const _LinksPage ({
    required this.backgroundColor,
    this.buttons = const <Widget>[],
    this.onBack,
    required this.title,
  });

  final Color backgroundColor;
  final List<Widget> buttons;
  final VoidCallback? onBack;
  final String title;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      backgroundColor: backgroundColor,
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            Text(title),
            //const Text('A system back here will go back to Nested Navigators Page One'),
            ...buttons,
            TextButton(
              onPressed: onBack ?? () {
                context.pop();
              },
              child: const Text('Go back'),
            ),
          ],
        ),
      ),
    );
  }
}
```

</details>

### Resources

Fixes https://github.com/flutter/flutter/issues/109513
Depends on engine PR https://github.com/flutter/engine/pull/39208 ✔ 
Design doc: https://docs.google.com/document/d/1BGCWy1_LRrXEB6qeqTAKlk-U2CZlKJ5xI97g45U7azk/edit#
Migration guide: https://github.com/flutter/website/pull/8952

dedd100e

Roll Flutter Engine from e9f80bff0703 to a7bea8621f4b (3 revisions) (#131948) · daf58279

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/engine/compare/e9f80bff0703...a7bea8621f4b

2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from 5eef2e2b94b4 to 85938bb68e75 (1 revision) (flutter/engine#44392)
2023-08-04 dnfield@google.com [Impeller] DlCanvas implementation wrapping Aiks canvas (flutter/engine#44248)
2023-08-04 30870216+gaaclarke@users.noreply.github.com [Impeller] Added a doc page to point out important impeller benchmarks (flutter/engine#44333)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

daf58279

Roll Flutter Engine from badca1f7f8c9 to e9f80bff0703 (6 revisions) (#131943) · ceb70d1a

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/engine/compare/badca1f7f8c9...e9f80bff0703

2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from c40343629a6b to 5eef2e2b94b4 (1 revision) (flutter/engine#44391)
2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from 03874e298589 to c40343629a6b (4 revisions) (flutter/engine#44389)
2023-08-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from FAGt3OEY8Yi1-SaFj... to jMLeVECzwzDoe9dYS... (flutter/engine#44388)
2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from 636077ca3a50 to 03874e298589 (1 revision) (flutter/engine#44386)
2023-08-04 vegorov@google.com Roll buildroot to a067408d923ccf80742571bb7a71705499f5779e (flutter/engine#44385)
2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from 100bf3248bf0 to 636077ca3a50 (1 revision) (flutter/engine#44384)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from FAGt3OEY8Yi1 to jMLeVECzwzDo

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ceb70d1a

Mention `showTimePicker` function be can be used to show dialog with the time... · 05f9a96e

Taha Tesser authored Aug 04, 2023

Mention `showTimePicker` function be can be used to show dialog with the time picker in the `TimePickerDialog` docs (#131932)

fixes https://github.com/flutter/flutter/issues/131931

Every time I search for the time picker in the API docs I end up in the `TimePickerDialog` docs.

We should link `showTimePicker` so it can be easier to reach it and mention it can be used directly to show a dialog with a time picker.

05f9a96e

Check for simulator runtime in flutter doctor (#131795) · b39604e0

Victoria Ashworth authored Aug 04, 2023

Redo of https://github.com/flutter/flutter/pull/130728 - code is the same as before. That PR was stuck in Google testing and then I messed up the rebase so started over.

----

Starting in Xcode 15, the simulator is no longer included in Xcode and must be downloaded and installed separately. This adds a validation to `flutter doctor` to warn when the needed simulator runtime is missing.

Validation message looks like:
```
[!] Xcode - develop for iOS and macOS (Xcode 15.0)
    ! iOS 17.0 Simulator not installed; this may be necessary for iOS and macOS development.
      To download and install the platform, open Xcode, select Xcode > Settings > Platforms,
      and click the GET button for the required platform.

      For more information, please visit:
        https://developer.apple.com/documentation/xcode/installing-additional-simulator-runtimes
```

It may also show an error like this when something goes wrong when checking for the simulator:
```
[!] Xcode - develop for iOS and macOS (Xcode 15.0)
    â Unable to find the iPhone Simulator SDK.
```

Note: I'm unsure of in the future if the SDK and the simulator runtime will need to match the exact version or just the major. For now, it only checks against the major version.

Part 3 of https://github.com/flutter/flutter/issues/129558.

b39604e0

Roll Packages from d00c1f9eb01c to ce53da1bd741 (3 revisions) (#131935) · 1cf39074

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/packages/compare/d00c1f9eb01c...ce53da1bd741

2023-08-04 ditman@gmail.com [image_picker_web] Listens to file input cancel event. (flutter/packages#4453)
2023-08-04 maurits@vnbskm.nl [in_app_purchase] Updates handling of subscription price changes in README. (flutter/packages#4643)
2023-08-03 stuartmorgan@google.com [pigeon] Consolidate main Dart unit tests (flutter/packages#4641)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1cf39074

Roll Flutter Engine from d15a02a8191c to badca1f7f8c9 (1 revision) (#131928) · 2ba9f7bd

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/engine/compare/d15a02a8191c...badca1f7f8c9

2023-08-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 6415ba55bf6a to b3372378e487 (1 revision) (flutter/engine#44383)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2ba9f7bd

Upgrade packages. (#131927) · 2c102959
Polina Cherkasova authored Aug 04, 2023

2c102959

Roll Flutter Engine from 0725a6f519d0 to d15a02a8191c (2 revisions) (#131924) · 6636b64c

engine-flutter-autoroll authored Aug 04, 2023

https://github.com/flutter/engine/compare/0725a6f519d0...d15a02a8191c

2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from 9e35fa235af9 to 100bf3248bf0 (1 revision) (flutter/engine#44381)
2023-08-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 5573a23b0312 to 6415ba55bf6a (1 revision) (flutter/engine#44380)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6636b64c