1. 23 Jun, 2017 1 commit
    • Ian Hickson's avatar
      Deep linking: automatically push the route hiearchy on load. (#10894) · 9adb4a78
      Ian Hickson authored
      The main purpose of this PR is to make it so that when you set the
      initial route and it's a hierarchical route (e.g. `/a/b/c`), it
      implies multiple pushes, one for each step of the route (so in that
      case, `/`, `/a`, `/a/b`, and `/a/b/c`, in that order). If any of those
      routes don't exist, it falls back to '/'.
      
      As part of doing that, I:
      
       * Changed the default for MaterialApp.initialRoute to honor the
         actual initial route.
      
       * Added a MaterialApp.onUnknownRoute for handling bad routes.
      
       * Added a feature to flutter_driver that allows the host test script
         and the device test app to communicate.
      
       * Added a test to make sure `flutter drive --route` works.
         (Hopefully that will also prove `flutter run --route` works, though
         this isn't testing the `flutter` tool's side of that. My main
         concern is over whether the engine side works.)
      
       * Fixed `flutter drive` to output the right target file name.
      
       * Changed how the stocks app represents its data, so that we can
         show a page for a stock before we know if it exists.
      
       * Made it possible to show a stock page that doesn't exist. It shows
         a progress indicator if we're loading the data, or else shows a
         message saying it doesn't exist.
      
       * Changed the pathing structure of routes in stocks to work more
         sanely.
      
       * Made search in the stocks app actually work (before it only worked
         if we happened to accidentally trigger a rebuild). Added a test.
      
       * Replaced some custom code in the stocks app with a BackButton.
      
       * Added a "color" feature to BackButton to support the stocks use case.
      
       * Spaced out the ErrorWidget text a bit more.
      
       * Added `RouteSettings.copyWith`, which I ended up not using.
      
       * Improved the error messages around routing.
      
      While I was in some files I made a few formatting fixes, fixed some
      code health issues, and also removed `flaky: true` from some devicelab
      tests that have been stable for a while. Also added some documentation
      here and there.
      9adb4a78
  2. 01 Jun, 2017 1 commit
  3. 12 May, 2017 1 commit
  4. 23 Apr, 2017 1 commit
  5. 21 Apr, 2017 1 commit
  6. 11 Apr, 2017 1 commit
    • xster's avatar
      Rename State.config to widget everywhere (#9273) · 89a7fdfc
      xster authored
      Rename State.config to State.widget
      Rename State.didUpdateConfig to State.didUpdateWidget
      Renamed all State subclasses' local variables named config to something else
      89a7fdfc
  7. 15 Mar, 2017 1 commit
  8. 04 Mar, 2017 1 commit
  9. 09 Feb, 2017 1 commit
    • Ian Hickson's avatar
      Port AppBar to Scrollable2 (#7996) · 83a4cf26
      Ian Hickson authored
      Move the back button and drawer opening logic into the app bar.
      
      Move the tap-status-bar-to-scroll-to-top logic to using
      ScrollControllers. Provide a PrimaryScrollController and a `primary`
      flag on scroll views.
      
      Make it possible to track when a route becomes or stops being poppable.
      83a4cf26
  10. 04 Feb, 2017 1 commit
  11. 02 Feb, 2017 1 commit
  12. 23 Jan, 2017 1 commit
  13. 18 Jan, 2017 1 commit
  14. 11 Jan, 2017 1 commit
  15. 19 Nov, 2016 1 commit
  16. 09 Nov, 2016 1 commit
  17. 03 Nov, 2016 1 commit
  18. 05 Oct, 2016 1 commit
  19. 20 Sep, 2016 1 commit
  20. 26 Aug, 2016 1 commit
  21. 27 Jun, 2016 1 commit
    • Adam Barth's avatar
      Change how navigator prevents redundant operations (#4769) · 2af668f8
      Adam Barth authored
      * Change how navigator prevents redundant operations
      
      Instead of requiring transactions, we now cancel all active pointers that are
      interacting with the navigator and absorb future pointers until we get a chance
      to build. This approach isn't perfect (e.g., events that trigger off the
      cancelled pointers could still interact with the navigator), but it should be
      better than the current transaction-based approach.
      
      Fixes #4716
      
      * Remove openTransaction
      
      * test
      
      * fixup
      2af668f8
  22. 20 Jun, 2016 1 commit
    • Todd Volkert's avatar
      System chrome overlay style fixes (#4627) · ef6a4faa
      Todd Volkert authored
      * System chrome overlay style fixes
      
      1) Add a cache to avoid superfluous calls to the embedder
      2) Coalesce calls to the embedder that are made in the same event loop
      3) Move call site to material's AppBar from Title widget
      
      #4461
      ef6a4faa
  23. 16 Jun, 2016 1 commit
    • Ian Hickson's avatar
      Refactor everything to do with images (#4583) · 2dfdc840
      Ian Hickson authored
      Overview
      ========
      
      This patch refactors images to achieve the following goals:
      
      * it allows references to unresolved assets to be passed
        around (previously, almost every layer of the system had to know about
        whether an image came from an asset bundle or the network or
        elsewhere, and had to manually interact with the image cache).
      
      * it allows decorations to use the same API for declaring images as the
        widget tree.
      
      It requires some minor changes to call sites that use images, as
      discussed below.
      
      Widgets
      -------
      
      Change this:
      
      ```dart
            child: new AssetImage(
              name: 'my_asset.png',
              ...
            )
      ```
      
      ...to this:
      
      ```dart
            child: new Image(
              image: new AssetImage('my_asset.png'),
              ...
            )
      ```
      
      Decorations
      -----------
      
      Change this:
      
      ```dart
            child: new DecoratedBox(
              decoration: new BoxDecoration(
                backgroundImage: new BackgroundImage(
                  image: DefaultAssetBundle.of(context).loadImage('my_asset.png'),
                  ...
                ),
                ...
              ),
              child: ...
            )
      ```
      
      ...to this:
      
      ```dart
            child: new DecoratedBox(
              decoration: new BoxDecoration(
                backgroundImage: new BackgroundImage(
                  image: new AssetImage('my_asset.png'),
                  ...
                ),
                ...
              ),
              child: ...
            )
      ```
      
      DETAILED CHANGE LOG
      ===================
      
      The following APIs have been replaced in this patch:
      
      * The `AssetImage` and `NetworkImage` widgets have been split in two,
        with identically-named `ImageProvider` subclasses providing the
        image-loading logic, and a single `Image` widget providing all the
        widget tree logic.
      
      * `ImageResource` is now `ImageStream`. Rather than configuring it with
        a `Future<ImageInfo>`, you complete it with an `ImageStreamCompleter`.
      
      * `ImageCache.load` and `ImageCache.loadProvider` are replaced by
        `ImageCache.putIfAbsent`.
      
      The following APIs have changed in this patch:
      
      * `ImageCache` works in terms of arbitrary keys and caches
        `ImageStreamCompleter` objects using those keys. With the new model,
        you should never need to interact with the cache directly.
      
      * `Decoration` can now be `const`. The state has moved to the
        `BoxPainter` class. Instead of a list of listeners, there's now just a
        single callback and a `dispose()` method on the painter. The callback
        is passed in to the `createBoxPainter()` method. When invoked, you
        should repaint the painter.
      
      The following new APIs are introduced:
      
      * `AssetBundle.loadStructuredData`.
      
      * `SynchronousFuture`, a variant of `Future` that calls the `then`
        callback synchronously. This enables the asynchronous and
        synchronous (in-the-cache) code paths to look identical yet for the
        latter to avoid returning to the event loop mid-paint.
      
      * `ExactAssetImage`, a variant of `AssetImage` that doesn't do anything clever.
      
      * `ImageConfiguration`, a class that describes parameters that configure
        the `AssetImage` resolver.
      
      The following APIs are entirely removed by this patch:
      
      * `AssetBundle.loadImage` is gone. Use an `AssetImage` instead.
      
      * `AssetVendor` is gone. `AssetImage` handles everything `AssetVendor`
        used to handle.
      
      * `RawImageResource` and `AsyncImage` are gone.
      
      The following code-level changes are performed:
      
      * `Image`, which replaces `AsyncImage`, `NetworkImage`, `AssetImage`,
        and `RawResourceImage`, lives in `image.dart`.
      
      * `DecoratedBox` and `Container` live in their own file now,
        `container.dart` (they reference `image.dart`).
      
      DIRECTIONS FOR FUTURE RESEARCH
      ==============================
      
      * The `ImageConfiguration` fields are mostly aspirational. Right now
        only `devicePixelRatio` and `bundle` are implemented. `locale` isn't
        even plumbed through, it will require work on the localisation logic.
      
      * We should go through and make `BoxDecoration`, `AssetImage`, and
        `NetworkImage` objects `const` where possible.
      
      * This patch makes supporting animated GIFs much easier.
      
      * This patch makes it possible to create an abstract concept of an
        "Icon" that could be either an image or a font-based glyph (using
        `IconData` or similar). (see
        https://github.com/flutter/flutter/issues/4494)
      
      RELATED ISSUES
      ==============
      
      Fixes https://github.com/flutter/flutter/issues/4500
      Fixes https://github.com/flutter/flutter/issues/4495
      Obsoletes https://github.com/flutter/flutter/issues/4496
      2dfdc840
  24. 07 Jun, 2016 1 commit
  25. 03 Jun, 2016 1 commit
  26. 25 May, 2016 1 commit
  27. 16 May, 2016 2 commits
  28. 28 Apr, 2016 1 commit
  29. 22 Apr, 2016 3 commits
  30. 21 Apr, 2016 2 commits
    • Ian Hickson's avatar
      Make the widgets binding reusable. (#3479) · 0e11b0e6
      Ian Hickson authored
      Previously the widgets layer only provided a concrete binding, which
      makes it awkward to extend it compared to other bindings. This moves
      widgets to the same style as the other layers.
      
      In a subsequent patch I'll use this to make the tests layer saner.
      0e11b0e6
    • Eric Seidel's avatar
      Add a service extension for toggling the PerformanceOverlay · 898b3ce8
      Eric Seidel authored
      This only works for apps which use WidgetsApp.  Apps which don't
      (like the game) could presumably read the static themselves
      off of WidgetsApp.
      
      @devoncarew @hixie
      898b3ce8
  31. 19 Apr, 2016 1 commit
    • Ian Hickson's avatar
      Make rootBundle handle the no-mojo case. (#3408) · 6dc440bd
      Ian Hickson authored
      The defaulting logic for bundles really belongs in the services layer,
      not the widgets layer. This way we can tell non-widget code just to use
      rootBundle if it just wants to read a JSON file or some such.
      6dc440bd
  32. 13 Apr, 2016 1 commit
  33. 25 Mar, 2016 1 commit
    • Adam Barth's avatar
      Add a default MediaQuery value · 3c6d4f66
      Adam Barth authored
      Now MediaQuery.of always returns a non-null value. By default, you get the
      values associated with the current ui.Window.
      
      Fixes #2894
      3c6d4f66
  34. 24 Mar, 2016 1 commit
  35. 19 Mar, 2016 1 commit
  36. 18 Mar, 2016 1 commit
    • Ian Hickson's avatar
      Fix WidgetsApp issues · d8c74736
      Ian Hickson authored
      - Make the textStyle optional
      - Remove routes
      - Make onGenerateRoute required
      - Add some dartdocs
      d8c74736