- 29 Sep, 2023 1 commit
-
-
Kate Lovett authored
Fixes https://github.com/flutter/flutter/issues/135574 This exposes the onAttach and onDetach callbacks of ScrollController in all of its subclasses.
-
- 19 Sep, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 18 Sep, 2023 2 commits
-
-
Zachary Anderson authored
Reverts flutter/flutter#134953 Several failures on CI
-
Polina Cherkasova authored
-
- 13 Sep, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 31 Aug, 2023 1 commit
-
-
Kostia Sokolovskyi authored
-
- 15 May, 2023 1 commit
-
-
Kate Lovett authored
Add ScrollController.onAttach & onDetach, samples/docs on listening/getting scrolling info (#124823) This PR does a couple of things! https://user-images.githubusercontent.com/16964204/231897483-416287f9-50ce-468d-a714-2a4bc0f2e011.mov ![Screenshot 2023-04-13 at 3 24 28 PM](https://user-images.githubusercontent.com/16964204/231897497-f5bee17d-43ed-46e5-acd7-e1bd64768274.png) Fixes #20819 Fixes #41910 Fixes #121419 ### Adds ScrollController.onAttach and ScrollController.onDetach This resolves a long held pain point for developers. When using a scroll controller, there is not scroll position until the scrollable widget is built, and almost all methods of notification are only triggered when scrolling happens. Adding these two methods will help developers gain access to the scroll position when it is created. A common workaround for this was using a post frame callback to access controller.position after the first frame, but this is ripe for issues such as having multiple positions attached to the controller, or the scrollable no longer existing after that post frame callback. I think this can also be helpful for folks to debug cases when the scroll controller has multiple positions attached. In particular, this also resolves this commented case: https://github.com/flutter/flutter/issues/20819#issuecomment-417784218 The isScrollingNotifier is hard for developers to access. ### Docs & samples I was surprised we did not have samples on scroll notification or scroll controller, so I overhauled it and added a lot of docs on all the different ways to access scrolling information, when it is available and how they differ.
-
- 24 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes
-
- 26 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `widgets` * fix comments * fix comments
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 07 Dec, 2021 1 commit
-
-
Dan Field authored
-
- 09 Aug, 2021 1 commit
-
- 03 Apr, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 18 Feb, 2021 1 commit
-
-
creativecreatorormaybenot authored
-
- 07 Jan, 2021 1 commit
-
-
Michael Goderbauer authored
-
- 11 Dec, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 16 Sep, 2020 1 commit
-
-
Michael R Fairhurst authored
-
- 15 Sep, 2020 1 commit
-
-
Alexandre Ardhuin authored
* Reland "Nnbd widgets (#64672)" This reverts commit 127e6790. * remove non-nullable enforcement on AsyncSnapshot * make data param non-nullable for AsyncSnapshot.withData * make some Text params non-nullable
-
- 09 Sep, 2020 2 commits
-
-
Michael Goderbauer authored
This reverts commit e682ec71.
-
Alexandre Ardhuin authored
* migrate widget to nullsafety * remove double blank line after license * address review comments in actions.dart * nullable ObjectKey.value * use local variable oldElement * make State.build non-nullable * make State.context non-nullable * newline at eof * make ProxyWidget.child non-nullable * make _InactiveElements.debugContains non-nullable * make Element.depth non-nullable * make ProxyElement.build non-nullable * make StatefulElement.state non-nullable * remove 'Notice that' * avoid cast of list in RenderObjectElement.updateChildren * make IndexedSlot.value non-nullable * avoid cast of list in MultiChildRenderObjectElement.mount * make some WidgetsApp parameters non-nullable * hitTest take non-nullable position * make ScrollableState.position non-nullable * use _pixels instead of pixels * make ViewportOffset.pixels non-nullable * make param and return type of IndexedWidgetBuilder non-nullable * unused_import * make context param non-nullable for Builder in animated_list.dart * make ScrollMetrics.viewportDimension non-nullable * make ScrollMetrics.{min,max}ScrollExtent non-nullable * make _Location.file non-nullable * _WidgetForTypeTests.createElement throw UnimplementedError * update _NullWidget.build error message * make _ShortcutsState.manager non-nullable * Fix childCount issues for NNBD * fix childCount computation on web * increase max value on js side to compute childCount * make aspect parameter of dependOnInheritedWidgetOfExactType nullable * merge has{min,max}ScrollExtent into hasScrollExtents * update focus_manager.dart * address review comments in icon.dart * address review comments in image.dart * address review comments in routes.dart * address review comments in scroll_activity.dart * update doc comments * make UserScrollNotification.direction non-nullable and required * rename hasScrollExtents to hasContentDimensions * unnecessary late Co-authored-by: Ian Hickson <ian@hixie.ch>
-
- 11 Jun, 2020 1 commit
-
-
Alexandre Ardhuin authored
* add language version 2.8 in packages/flutter * enable non-nullable analyzer flag
-
- 06 Feb, 2020 1 commit
-
-
David Shuckerow authored
-
- 08 Jan, 2020 1 commit
-
-
Greg Spencer authored
-
- 07 Jan, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 27 Nov, 2019 1 commit
-
-
Ian Hickson authored
* Update project.pbxproj files to say Flutter rather than Chromium Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright. * Update the copyright notice checker to require a standard notice on all files * Update copyrights on Dart files. (This was a mechanical commit.) * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine. Some were already marked "The Flutter Authors", not clear why. Their dates have been normalized. Some were missing the blank line after the license. Some were randomly different in trivial ways for no apparent reason (e.g. missing the trailing period). * Clean up the copyrights in non-Dart files. (Manual edits.) Also, make sure templates don't have copyrights. * Fix some more ORGANIZATIONNAMEs
-
- 21 Feb, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 23 Jan, 2019 1 commit
-
-
Alexandre Ardhuin authored
* fix some bad indentations * remove suspicious line
-
- 07 Jan, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 18 Dec, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 08 Nov, 2018 1 commit
-
-
Greg Spencer authored
This converts existing ## Sample code samples to {@tool sample}...{@end-tool} form. Also: 1. Fixed a minor bug in analyze-sample-code.dart 2. Made the snippet tool only insert descriptions if the description is non-empty. 3. Moved the Card diagram to before the code sample.
-
- 16 Oct, 2018 1 commit
-
-
Alexandre Ardhuin authored
* Future<void> main * Future<void>.delayed * prefer_void_to_Null * address review comments
-
- 01 Oct, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint unnecessary_new * fix tests * fix tests * fix tests
-
- 07 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* lint unnecessary_new on samples * fix tests
-
- 05 Jun, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 02 Mar, 2018 1 commit
-
-
Hans Muller authored
-
- 19 Jan, 2018 1 commit
-
-
Ian Hickson authored
* Fix the confusing-zero case with NestedScrollView. * Update mock_canvas.dart * Update tabs_demo.dart * more tweaks
-
- 03 Sep, 2017 1 commit
-
-
German Saprykin authored
* Fixed TrackingScrollController cleaning stored offset on position's detach * Fixed format. * Fixed format. * Fixed test with Directionality support.
-
- 01 Sep, 2017 2 commits
-
-
Ian Hickson authored
This reverts commit ec25f6bd.
-
German Saprykin authored
* Fixed TrackingScrollController cleaning stored offset on position's detach * Fixed format. * Fixed format.
-