- 22 Oct, 2023 1 commit
-
-
Todd Volkert authored
Before this change, long-running post-frame callbacks wouldn't show up in the timeline at all. This adds a timeline event for post-frame callbacks, with a debug flag that will add timeline events for each individual callback. #testexempt -- we have no way to test calls to the timeline.
-
- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the painting and rendering libraries. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 02 Aug, 2023 1 commit
-
-
Jonah Williams authored
Without a saveLayer, the BlendMode.plus will add itself to the backdrop and not just the previous image. Pushing without tests to see if existing goldens fail, but otherwise I have some good examples locally. This is necessary uncondtionally, and lerping lerped images has the same issue. Fixes https://github.com/flutter/flutter/issues/131617 ### Before ![flutter_02](https://github.com/flutter/flutter/assets/8975114/1e783285-2fc2-429f-9fd8-6d04d4a155e1) ### After ![flutter_03](https://github.com/flutter/flutter/assets/8975114/3d08b187-26aa-4471-926d-e9ed5946a206)
-
- 26 Jul, 2023 3 commits
-
-
Ian Hickson authored
This primarily implements DecorationImage.lerp(). It also makes some minor tweaks, the main one of which is defering to dart:ui for `clampDouble` instead of duplicating it in package:foundation. Fixes https://github.com/flutter/flutter/issues/12452 This was first landed in https://github.com/flutter/flutter/pull/130533 and reverted in https://github.com/flutter/flutter/pull/131347.
-
Ian Hickson authored
Reverts flutter/flutter#130533 Tree breakage.
-
Ian Hickson authored
This primarily implements DecorationImage.lerp(). It also makes some minor tweaks, the main one of which is defering to dart:ui for `clampDouble` instead of duplicating it in package:foundation. Fixes https://github.com/flutter/flutter/issues/12452
-
- 24 Jul, 2023 1 commit
-
-
Ian Hickson authored
This makes the output less sensitive on JS int vs double shenanigans.
-
- 26 May, 2023 1 commit
-
-
Phil Quitslund authored
The newly updated lint will soon flag for-each in collections. See discussion: https://github.com/dart-lang/linter/pull/4383 /cc @goderbauer
-
- 15 Apr, 2023 1 commit
-
-
Jonah Williams authored
Reverts flutter/flutter#119495 We'll managed to optimize almost all of the cases that made this slow. Actually, it will soon be harder to optimize shader tiling...
-
- 03 Feb, 2023 1 commit
-
-
Jonah Williams authored
* [framework] use shader tiling instead of repeated calls to drawImage * ++ * ++ * review and test updates * ++ * Update decoration_image.dart * Update decoration_image.dart * ++ * ++ * ++ * ++ * ++ * Update painting.dart * Update decoration_test.dart
-
- 25 Jan, 2023 1 commit
-
-
Todd Volkert authored
* Only emit image painting events in debug & profile modes. These events were being emitted in release mode, which was showing up in the profiler for my app as taking up a noticeable amount of build time (still well within the frame budget, but this code was near the top of the list). * Review comment
-
- 21 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 18 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* remove single-view assumption from paintImage * dpr * fix test for web
-
- 12 Sep, 2022 1 commit
-
-
Greg Spencer authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
Use `curly_braces_in_flow_control_structures` for `foundation`, `gestures`, `painting`, `physics` (#104610) * Use `curly_braces_in_flow_control_structures` for `foundation` * Use `curly_braces_in_flow_control_structures` for `gestures` * Use `curly_braces_in_flow_control_structures` for `painting` * Use `curly_braces_in_flow_control_structures` for `physics` * fix comments * remove trailing space * fix TODO style
-
- 18 May, 2022 1 commit
-
-
Bruno Leroux authored
-
- 01 Mar, 2022 1 commit
-
-
Viren Khatri authored
* migrates lib/foundation and lib/widgets * migrates lib/painting and lib/material * migrates lib/cupertino, lib/gestures, lib/services, lib/semantics and lib/rendering * fixes failing tests * migrates test/ * improves hashing of lists
-
- 03 Feb, 2022 1 commit
-
-
Ian Hickson authored
-
- 12 Dec, 2021 1 commit
-
-
Dan Field authored
-
- 26 Aug, 2021 1 commit
-
-
nt4f04uNd authored
* Add missing parameters to DecorationImage * tune docs * fix test
-
- 16 Aug, 2021 1 commit
-
-
Dan Field authored
-
- 15 Jul, 2021 1 commit
-
- 14 Jul, 2021 3 commits
-
-
Ian Hickson authored
-
Zachary Anderson authored
This reverts commit 31de052e.
-
Ian Hickson authored
-
- 13 Jul, 2021 2 commits
-
-
Ian Hickson authored
This reverts commit e2490f29.
-
Ian Hickson authored
-
- 01 Jun, 2021 1 commit
-
-
Dwayne Slater authored
-
- 31 Mar, 2021 2 commits
-
-
Alexandre Ardhuin authored
-
Alexandre Ardhuin authored
-
- 26 Mar, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 18 Feb, 2021 1 commit
-
-
fzyzcjy authored
-
- 29 Jan, 2021 1 commit
-
-
Yegor authored
-
- 23 Oct, 2020 1 commit
-
-
Cyp authored
-
- 05 Oct, 2020 1 commit
-
-
Dan Field authored
* Reland dispose images when done (#67100) Changes since last time: - Test for CanvasKit image rendering (https://github.com/flutter/flutter/pull/67176) - Fix CanvasKit dispose impl (https://github.com/flutter/engine/pull/21555) - Update internal google3 customer with a problematic ImageStream Listener impl (cl/335091311, cl/335459002) This reverts commit 473358d9.
-
- 01 Oct, 2020 2 commits
-
-
Dan Field authored
* Dispose of images after using them Adds ImageInfo.clone, ImageInfo.dispose, and ImageInfo.isCloneOf. Makes all stateful holders of ui.Image objects properly clone and dispose of them. Behavior change for ImageStreamCompleter: Removing the last listener after registering at least one listener results in the object being disposed, and new listeners cannot be added, unless a keepAlive handle is created. Makes all non-stateful holders of ui.Image (i.e. paintImage and RawImage) assert that whoever gave the image to them has not disposed it on them.
- 12 Aug, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 13 Jul, 2020 1 commit
-
-
Dan Field authored
* Optionally invert oversized images
-
- 26 Jun, 2020 1 commit
-
-
Dan Field authored
-