1. 20 Sep, 2023 1 commit
    • Greg Spencer's avatar
      Remove 'must be non-null' and 'must not be null' comments from material. (#134991) · a1e49be2
      Greg Spencer authored
      ## Description
      
      This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values.
      
      This PR removes them from the material library.
      
      This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.
      
      In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.
      
      This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases.  I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).
      
      ## Related PRs
      - https://github.com/flutter/flutter/pull/134984
      - https://github.com/flutter/flutter/pull/134992
      - https://github.com/flutter/flutter/pull/134993
      - https://github.com/flutter/flutter/pull/134994
      
      ## Tests
       - Documentation only change.
      a1e49be2
  2. 08 Aug, 2023 1 commit
    • Taha Tesser's avatar
      Add `PopupMenuButton.iconColor`, `PopupMenuTheme.iconSize` and fix button icon... · b77b149d
      Taha Tesser authored
      Add `PopupMenuButton.iconColor`, `PopupMenuTheme.iconSize` and fix button icon using unexpected color propert (#132054)
      
      fixes [PopupMenuButton uses color property for icon color](https://github.com/flutter/flutter/issues/127802) 
      fixes [`popup_menu_test.dart` lacks default icon color tests.](https://github.com/flutter/flutter/issues/132050) 
      
      ### Description
      - Add  `PopupMenuButton..iconColor` and fix the PopupMenu button icon using an unexpected color property.
      - Add the missing `PopupMenuTheme.iconSize`.
      - Clean up some tests and minor improvements.
      
      ### Code sample
      
      <details> 
      <summary>expand to view the code sample</summary> 
      
      ```dart
      import 'package:flutter/material.dart';
      
      /// Flutter code sample for [PopupMenuButton].
      
      // This is the type used by the popup menu below.
      enum SampleItem { itemOne, itemTwo, itemThree }
      
      void main() => runApp(const PopupMenuApp());
      
      class PopupMenuApp extends StatelessWidget {
        const PopupMenuApp({super.key});
      
        @override
        Widget build(BuildContext context) {
          return MaterialApp(
            theme: ThemeData(
              popupMenuTheme: PopupMenuThemeData(
                // iconSize: 75,
                // iconColor: Colors.amber,
                color: Colors.deepPurple[100],
              ),
            ),
            home: const PopupMenuExample(),
          );
        }
      }
      
      class PopupMenuExample extends StatefulWidget {
        const PopupMenuExample({super.key});
      
        @override
        State<PopupMenuExample> createState() => _PopupMenuExampleState();
      }
      
      class _PopupMenuExampleState extends State<PopupMenuExample> {
        SampleItem? selectedMenu;
      
        @override
        Widget build(BuildContext context) {
          return Scaffold(
            appBar: AppBar(title: const Text('PopupMenuButton')),
            body: Center(
              child: PopupMenuButton<SampleItem>(
                iconSize: 75,
                // iconColor: Colors.amber,
                color: Colors.deepPurple[100],
                initialValue: selectedMenu,
                // Callback that sets the selected popup menu item.
                onSelected: (SampleItem item) {
                  setState(() {
                    selectedMenu = item;
                  });
                },
                itemBuilder: (BuildContext context) => <PopupMenuEntry<SampleItem>>[
                  const PopupMenuItem<SampleItem>(
                    value: SampleItem.itemOne,
                    child: Text('Item 1'),
                  ),
                  const PopupMenuItem<SampleItem>(
                    value: SampleItem.itemTwo,
                    child: Text('Item 2'),
                  ),
                  const PopupMenuDivider(),
                  const CheckedPopupMenuItem<SampleItem>(
                    value: SampleItem.itemThree,
                    checked: true,
                    child: Text('Item 3'),
                  ),
                ],
              ),
            ),
          );
        }
      }
      
      ``` 
      	
      </details>
      
      ![Group 2](https://github.com/flutter/flutter/assets/48603081/eb5404ae-2a07-4374-9821-66a0bbea041e)
      
      ![Group 1](https://github.com/flutter/flutter/assets/48603081/464e3957-1afb-4118-abcc-aad12591dc51)
      b77b149d
  3. 16 Feb, 2023 1 commit
  4. 24 Jan, 2023 1 commit
  5. 24 Oct, 2022 1 commit
  6. 06 Sep, 2022 1 commit
  7. 10 Aug, 2022 1 commit
  8. 25 May, 2022 1 commit
  9. 14 Apr, 2022 1 commit
  10. 01 Mar, 2022 1 commit
  11. 19 Jan, 2022 1 commit
  12. 18 Jan, 2022 1 commit
  13. 14 Jan, 2022 2 commits
  14. 19 Nov, 2020 1 commit
  15. 02 Nov, 2020 1 commit
  16. 27 Oct, 2020 1 commit
  17. 06 Oct, 2020 1 commit
  18. 11 Jun, 2020 1 commit
  19. 06 Apr, 2020 1 commit
  20. 11 Mar, 2020 1 commit
    • Greg Spencer's avatar
      Convert Diagnosticable to a mixin (#51495) · 210f4d83
      Greg Spencer authored
      This converts Diagnosticable to be a mixin instead of an abstract class, so that it can be used to add diagnostics to classes which already have a base class.
      
      It leaves in place the DiagnosticableMixin mixin, since there are some plugins that are still using it, and removing it would mean that those plugins wouldn't work with master branch Flutter anymore. DiagnosticableMixin will be removed once this mixin version of Diagnosticable makes its way to the stable branch.
      210f4d83
  21. 13 Dec, 2019 1 commit
  22. 27 Nov, 2019 1 commit
    • Ian Hickson's avatar
      License update (#45373) · 449f4a66
      Ian Hickson authored
      * Update project.pbxproj files to say Flutter rather than Chromium
      
      Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
      
      * Update the copyright notice checker to require a standard notice on all files
      
      * Update copyrights on Dart files. (This was a mechanical commit.)
      
      * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
      
      Some were already marked "The Flutter Authors", not clear why. Their
      dates have been normalized. Some were missing the blank line after the
      license. Some were randomly different in trivial ways for no apparent
      reason (e.g. missing the trailing period).
      
      * Clean up the copyrights in non-Dart files. (Manual edits.)
      
      Also, make sure templates don't have copyrights.
      
      * Fix some more ORGANIZATIONNAMEs
      449f4a66
  23. 22 Nov, 2019 1 commit
    • Alexandre Ardhuin's avatar
      make some BuildContext methods generics (#44189) · fcb40a05
      Alexandre Ardhuin authored
      * make BuildContext.{ancestorStateOfType,ancestorRenderObjectOfType,rootAncestorStateOfType} generic
      
      * make BuildContext.inheritFromWidgetOfExactType generic
      
      * make BuildContext.ancestorInheritedElementForWidgetOfExactType generic
      
      * make BuildContext.ancestorWidgetOfExactType generic
      
      * fix snippet
      
      * bump scoped_model on temp version
      
      * update names
      
      * Revert "bump scoped_model on temp version"
      
      This reverts commit d1fcbba028cdb07f44738d1652391692d1ea5ec0.
      
      * address review comments
      
      * fix ci
      
      * address review comments
      
      * repeat the deprecation notice
      
      * fix uppercase
      
      * use of recommanded deprecation syntax
      
      * address review comment
      fcb40a05
  24. 21 Aug, 2019 1 commit
  25. 02 Aug, 2019 1 commit
  26. 26 Jul, 2019 1 commit
    • lisa-liao's avatar
      Add PopupMenuTheme to enable theming color, shape, elevation, text style of Menu (#36088) · 63992e4f
      lisa-liao authored
      * [Menu] Create Menu theme
      
      * [Menu] Create Menu theme
      
      * [Menu] Formatting changes for Menu theme
      
      * [Menu] Fix spacing difference in theme_data.dart.
      
      * [Menu] Fix spacing difference in theme_data.dart.
      
      * Specifying types
      
      * Formatting changes
      
      * Address PR feedback
      
      * Formatting changes
      
      * Address PR feedback
      
      * Add inherited widget
      
      * Add inherited widget
      
      * Address PR feedback and add inherited widget.
      
      * Formatting changes.
      
      * Address PR feedback
      
      * Address PR feedback
      
      * Address PR feedback
      
      * Address PR feedback
      63992e4f