1. 31 Jan, 2018 1 commit
  2. 25 Jan, 2018 1 commit
  3. 17 Jan, 2018 1 commit
  4. 09 Dec, 2017 1 commit
  5. 08 Dec, 2017 1 commit
    • Ian Hickson's avatar
      Fix tapping on a test in flutter run (#13397) · d25e0eb0
      Ian Hickson authored
      Also:
      
      * Remove find.byIcon since it's identical to find.icon. (I sent mail to flutter-dev about this.)
      
      * Fix IconData's operator== and hashCode, which had not been updated when we added fields.
      
      * Add the byTooltip finder to the list of suggested finders.
      
      * Make the suggested Key finder prettier.
      d25e0eb0
  6. 07 Dec, 2017 1 commit
    • Ian Hickson's avatar
      Move image logic from services/ to painting/. (#13409) · 44e228eb
      Ian Hickson authored
      This allows the scheduler library to depend on the services library
      and the painting library to depend on the scheduler library without
      the services library having to depend on the scheduler library.
      
      While I was at it I also cleaned up some of the binding logic: the
      licenses logic can now be overridden (and the test library does so),
      and the image cache can now be overridden as well.
      44e228eb
  7. 17 Nov, 2017 2 commits
  8. 26 Oct, 2017 2 commits
  9. 25 Oct, 2017 1 commit
  10. 22 Oct, 2017 1 commit
  11. 07 Oct, 2017 1 commit
  12. 07 Sep, 2017 1 commit
  13. 29 Aug, 2017 1 commit
    • Florian Loitsch's avatar
      Don't use `runBinaryGuarded`. (#11816) · 8d5fe6d4
      Florian Loitsch authored
      Since the called function can't throw, there is no need for the "guarded".
      Since the function returns something, running in guarded mode doesn't really work. The `uncaught` handler wouldn't know what to return (except for `null`).
      8d5fe6d4
  14. 28 Aug, 2017 1 commit
    • Ian Hickson's avatar
      RTL: Padding, Flex (#11709) · f235a2c1
      Ian Hickson authored
      * Introduce a Directionality inherited widget which sets the ambient LTR vs RTL mode (defaulting to null, which means you cannot use directionality-influenced values).
      
      * Make it possible to configure Padding (including Container.padding and Container.margin) using a directionality-agnostic EdgeInsets variant.
      
      * Provide textDirection and verticalDirection controls on Row and Column to make them RTL-aware.
      
      * Introduce a variant of FractionalOffset based on the EdgeInsets variant. Not yet actually used.
      
      * Fix all the tests that depended on Row defaulting to LTR.
      f235a2c1
  15. 27 Jul, 2017 1 commit
    • Ian Hickson's avatar
      Increase the touch slop. (#11419) · 87445e59
      Ian Hickson authored
      It was 8.0. It's now arbitrarily 18.0.
      
      Changing this required adjusting some tests. Adjusting the tests
      required debugging the tests. Debugging the tests required some tools
      to help debugging gesture recognizers and gesture arenas, so I added
      some. It also required updating some toString() methods which resulted
      in some changes to the tree diagnostics logic.
      
      Also I cleaned up some docs while I was at it.
      87445e59
  16. 24 Jul, 2017 1 commit
  17. 21 Jul, 2017 1 commit
    • Ian Hickson's avatar
      Add documentation and clean up code. (#11330) · 8f56f6fd
      Ian Hickson authored
      Mainly, this adds documentation to members that were previously
      lacking documentation.
      
      It also adds a big block of documentation about improving performance
      of widgets.
      
      This also removes some references to package:collection and adds
      global setEquals and listEquals methods in foundation that we can use.
      (setEquals in particular should be much faster than the
      package:collection equivalent, though both should be faster as they
      avoid allocating new objects.) All remaining references now qualify
      the import so we know what our remaining dependencies are.
      
      Also lots of code reordering in Flutter driver to make the code
      consistent and apply the style guide more thoroughly.
      8f56f6fd
  18. 16 Jun, 2017 1 commit
  19. 06 Jun, 2017 1 commit
  20. 06 May, 2017 1 commit
  21. 05 May, 2017 2 commits
  22. 02 May, 2017 1 commit
    • Ian Hickson's avatar
      Flush microtasks after transient callbacks are run. (#9702) · e8c46927
      Ian Hickson authored
      This splits the frame pipeline into two, beginFrame and drawFrame.
      
      As part of making this change I added some debugging hooks that helped
      debug the issues that came up:
      
       * I added debugPrintScheduleFrameStacks which prints a stack whenever
         a frame is actually scheduled, so you can see why frames are being
         scheduled.
      
       * I added some toString output to EditableText and RawKeyboardListener.
      
       * I added a scheduler_tester.dart library for scheduler library tests.
      
       * I changed the test framework to flush microtasks before pumping.
      
       * Some asserts that had the old string literal form were replaced by
         asserts with messages.
      
      I also fixed a few subtle bugs that this uncovered:
      
       * setState() now calls `ensureVisualUpdate`, rather than
         `scheduleFrame`. This means that calling it from an
         AnimationController callback does not actually schedule an extra
         redundant frame as it used to.
      
       * I corrected some documentation.
      e8c46927
  23. 19 Apr, 2017 1 commit
  24. 13 Apr, 2017 1 commit
  25. 12 Apr, 2017 2 commits
    • Ian Hickson's avatar
      Move Point to Offset (#9277) · bf017b79
      Ian Hickson authored
      * Manually fix every use of Point.x and Point.y
      
      Some of these were moved to dx/dy, but not all.
      
      * Manually convert uses of the old gradient API
      
      * Remove old reference to Point.
      
      * Mechanical changes
      
      I applied the following at the root of the Flutter repository:
      
      git ls-files -z | xargs -0 sed -i 's/\bPoint[.]origin\b/Offset.zero/g'
      git ls-files -z | xargs -0 sed -i 's/\bPoint[.]lerp\b/Offset.lerp/g'
      git ls-files -z | xargs -0 sed -i 's/\bnew Point\b/new Offset/g'
      git ls-files -z | xargs -0 sed -i 's/\bconst Point\b/const Offset/g'
      git ls-files -z | xargs -0 sed -i 's/\bstatic Point /static Offset /g'
      git ls-files -z | xargs -0 sed -i 's/\bfinal Point /final Offset /g'
      git ls-files -z | xargs -0 sed -i 's/^\( *\)Point /\1Offset /g'
      git ls-files -z | xargs -0 sed -i 's/ui[.]Point\b/ui.Offset/g'
      git ls-files -z | xargs -0 sed -i 's/(Point\b/(Offset/g'
      git ls-files -z | xargs -0 sed -i 's/\([[{,]\) Point\b/\1 Offset/g'
      git ls-files -z | xargs -0 sed -i 's/@required Point\b/@required Offset/g'
      git ls-files -z | xargs -0 sed -i 's/<Point>/<Offset>/g'
      git ls-files -z | xargs -0 sed -i 's/[.]toOffset()//g'
      git ls-files -z | xargs -0 sed -i 's/[.]toPoint()//g'
      git ls-files -z | xargs -0 sed -i 's/\bshow Point, /show /g'
      git ls-files -z | xargs -0 sed -i 's/\bshow Point;/show Offset;/g'
      
      * Mechanical changes - dartdocs
      
      I applied the following at the root of the Flutter repository:
      
      git ls-files -z | xargs -0 sed -i 's/\ba \[Point\]/an [Offset]/g'
      git ls-files -z | xargs -0 sed -i 's/\[Point\]/[Offset]/g'
      
      * Further improvements and a test
      
      * Fix minor errors from rebasing...
      
      * Roll engine
      bf017b79
    • Ian Hickson's avatar
      Fix tests to use Ahem, and helpful changes around that (#9332) · 2a545243
      Ian Hickson authored
      * Fix tests to use Ahem, and helpful changes around that
      
      - Fix fonts that had metric-specific behaviours.
      
      - LiveTestWidgetsFlutterBinding.allowAllFrames has been renamed
        to LiveTestWidgetsFlutterBinding.framePolicy.
      
      - LiveTestWidgetsFlutterBinding now defaults to using a frame policy
        that pumps slightly more frames, to animate the pointer crosshairs.
      
      - Added "flutter run --use-test-fonts" to enable Ahem on devices.
      
      - Changed how idle() works to be more effective in live mode.
      
      - Display the test name in live mode (unless ahem fonts are enabled).
      
      - Added a toString to TextSelectionPoint.
      
      - Style nit fixes.
      
      * Roll engine to get Ahem changes.
      
      * Update tests for dartdoc changes.
      
      * Fix flutter_tools tests
      2a545243
  26. 07 Apr, 2017 1 commit
  27. 05 Apr, 2017 1 commit
  28. 17 Mar, 2017 1 commit
  29. 15 Mar, 2017 2 commits
  30. 10 Mar, 2017 2 commits
  31. 08 Mar, 2017 2 commits
  32. 04 Mar, 2017 1 commit
  33. 21 Feb, 2017 1 commit