Commits · e9de4484209472079d3db1cc0dfd1fcf54570b65 · abdullh.alsoleman / Front-End

17 Nov, 2023 2 commits

Enable `flutter screenshot` outside Flutter project directory (#138160) · e9de4484

Victor Eronmosele authored Nov 17, 2023

This PR enables the `flutter screenshot` to work outside a Flutter project. 

This works by enabling `ScreenshotCommand` to find target devices not supported by the project. 

Before: 
```bash
$ cd $HOME # not a Flutter directory

$ flutter screenshot

No devices found yet. Checking for wireless devices...

No supported devices connected.

The following devices were found, but are not supported by this project:
sdk gphone64 arm64 (mobile) â¢ emulator-5554 â¢ android-arm64  â¢ Android 13 (API 33) (emulator)
macOS (desktop)             â¢ macos         â¢ darwin-arm64   â¢ macOS 13.3.1 22E772610a darwin-arm64
Chrome (web)                â¢ chrome        â¢ web-javascript â¢ Google Chrome 119.0.6045.105
If you would like your app to run on android or macos or web, consider running `flutter create .` to generate projects for these platforms.
Must have a connected device for screenshot type device
```

After: 

```bash
$ cd $HOME # not a Flutter directory

$ flutter_source screenshot

Screenshot written to flutter_01.png (313kB).
```

Fixes #115790

e9de4484

Roll Flutter Engine from aae07e989b0a to 5064aeff00de (2 revisions) (#138585) · 2e5990ca

engine-flutter-autoroll authored Nov 17, 2023

https://github.com/flutter/engine/compare/aae07e989b0a...5064aeff00de

2023-11-16 jonahwilliams@google.com [Impeller] Clang tidy even more (flutter/engine#48102)
2023-11-16 30870216+gaaclarke@users.noreply.github.com [Impeller] Implements gaussian blur that scales down before applying the blur (flutter/engine#47576)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2e5990ca

16 Nov, 2023 21 commits

Improves output file path logic in Android analyze (#136981) · d8a5f3d1
chunhtai authored Nov 16, 2023

d8a5f3d1
Turn off leak tracker in master to make found leaks not blocking. (#138567) · 2dc81113
Polina Cherkasova authored Nov 16, 2023

2dc81113

Roll Flutter Engine from 094a3383a406 to aae07e989b0a (2 revisions) (#138574) · 86a898e6

engine-flutter-autoroll authored Nov 16, 2023

https://github.com/flutter/engine/compare/094a3383a406...aae07e989b0a

2023-11-16 skia-flutter-autoroll@skia.org Roll Skia from 4c099aaa259f to 762d95ed65e0 (2 revisions) (flutter/engine#48140)
2023-11-16 matanlurey@users.noreply.github.com Re-land "Make `flow/embedded_views.h` compatible with `.clang_tidy`." (flutter/engine#48137)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

86a898e6

Enable the silent flag for invalid string exceptions when building a TextSpan (#138564) · d859865e

Jason Simmons authored Nov 16, 2023

This error can occur in a release app (for example, if the text comes from user input that is not valid UTF-16).  In that case, TextSpan will replace the invalid text with a placeholder character.

d859865e

Roll Flutter Engine from 22baa83db63b to 094a3383a406 (13 revisions) (#138568) · 61d37105

engine-flutter-autoroll authored Nov 16, 2023

https://github.com/flutter/engine/compare/22baa83db63b...094a3383a406

2023-11-16 skia-flutter-autoroll@skia.org Roll Skia from 297049bbfc0d to 4c099aaa259f (5 revisions) (flutter/engine#48138)
2023-11-16 skia-flutter-autoroll@skia.org Roll Dart SDK from b512191e9612 to 906f23c1cb20 (1 revision) (flutter/engine#48136)
2023-11-16 matanlurey@users.noreply.github.com Disable the `runIfNot` clauses in `.ci.yaml`, as they are unsafe. (flutter/engine#48132)
2023-11-16 15619084+vashworth@users.noreply.github.com Fix race condition in Unobstructed Platform View Scenario tests (flutter/engine#48096)
2023-11-16 jonahwilliams@google.com [Impeller] store all path point data in single buffer. (flutter/engine#47896)
2023-11-16 skia-flutter-autoroll@skia.org Roll Skia from b9ead4140f84 to 297049bbfc0d (2 revisions) (flutter/engine#48133)
2023-11-16 chris@bracken.jp [macOS] Replace pasteboard mock with fake (flutter/engine#48110)
2023-11-16 chinmaygarde@google.com [Impeller] Fix issue where the lock was not re-acquired when the wait exits on CV. (flutter/engine#48104)
2023-11-16 jonahwilliams@google.com [Impeller] Create a drawable backed TextureMTL. (flutter/engine#48049)
2023-11-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `flow/embedded_views.h` compatible with `.clang_tidy`." (flutter/engine#48130)
2023-11-16 chris@bracken.jp [macOS] Replace fixture subclasses with usings (flutter/engine#48111)
2023-11-16 matanlurey@users.noreply.github.com Make `flow/embedded_views.h` compatible with `.clang_tidy`. (flutter/engine#47994)
2023-11-16 matanlurey@users.noreply.github.com Make `flow/...` compatible with `.clang_tidy`. (flutter/engine#47995)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

61d37105

#60704: Pass cert for TLS localhost connection (#106635) · 428bff1d

Arpit Gandhi authored Nov 16, 2023

*Pass locally generated certificate via command line*

*Fixes: #60704*

Added ARGS: 

- web-tls-cert-path
- web-tls-cert-key-path

Passing the path of local certificate and the key to cert will allow flutter tool to create a secure debugging session on chrome

**Pre-launch Checklist**

â   I read the [Contributor Guide](https://github.com/flutter/flutter/wiki/Tree-hygiene#overview) and followed the process outlined there for submitting PRs.
â   I read the [Tree Hygiene](https://github.com/flutter/flutter/wiki/Tree-hygiene) wiki page, which explains my responsibilities.
â   I read and followed the [Flutter Style Guide](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo), including [Features we expect every widget to implement](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement).
â   I signed the [CLA](https://cla.developers.google.com/).
â   I listed at least one issue that this PR fixes in the description above.
â   I updated/added relevant documentation (doc comments with ///).
â   I added new tests to check the change I am making.
â   All existing and new tests are passing.

428bff1d

Bump cupertino_icons to 1.0.6 (#136962) · 9be8f4fd
lsaudon authored Nov 16, 2023
```
Bump cupertino_icons to 1.0.6
```
9be8f4fd

Fix sliver persistent header expand animation (#137913) · 27394f60

Fedor Blagodyr authored Nov 16, 2023

Added animation status check at showOnScreen method to prevent broken animation of expanding SliverAppBar when focusing EditableText

close #137901

27394f60

Reduce animations further when --no-cli-animations is set. (#133598) · 4d788b10
Ian Hickson authored Nov 16, 2023

4d788b10

Roll Flutter Engine from 0c57a50810e8 to 22baa83db63b (4 revisions) (#138560) · d8c98c11

engine-flutter-autoroll authored Nov 16, 2023

https://github.com/flutter/engine/compare/0c57a50810e8...22baa83db63b

2023-11-16 matanlurey@users.noreply.github.com Make `lib/ui/painting/...` compatible with `.clang_tidy`. (flutter/engine#47999)
2023-11-16 matanlurey@users.noreply.github.com Re-land "Make `lib/ui/{text|window}/...` compatible with `.ci.yaml`" (flutter/engine#48097)
2023-11-16 skia-flutter-autoroll@skia.org Roll Skia from bf1d6d84db73 to b9ead4140f84 (1 revision) (flutter/engine#48124)
2023-11-16 skia-flutter-autoroll@skia.org Roll Skia from 2fe70dd9cbf8 to bf1d6d84db73 (1 revision) (flutter/engine#48122)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d8c98c11

Introduce `AnimationStyle` (#137945) · 19e284f8

Taha Tesser authored Nov 16, 2023

This PR introduces `AnimationStyle`, it is used to override default animation curves and durations in several widgets.

fixes  [Add the ability to customize MaterialApp theme animation duration](https://github.com/flutter/flutter/issues/78372)
fixes [Allow customization of showMenu transition animation curves and duration](https://github.com/flutter/flutter/issues/135638)

Here is an example where popup menu curve and transition duration is overriden:

```dart
          popUpAnimationStyle: AnimationStyle(
            curve: Easing.emphasizedAccelerate,
            duration: Durations.medium4,
          ),
```

Set `AnimationStyle.noAnimation` to disable animation.
```dart
    return MaterialApp(
      themeAnimationStyle: AnimationStyle.noAnimation,
```

19e284f8

Just use string interpolation for ws url for tests (#138235) · c6c451ee
Dan Field authored Nov 16, 2023
```
Follows up on https://github.com/flutter/flutter/pull/137969 - we don't
need decodeComponent here
```
c6c451ee

Adding new packages to the first-party package issue template (#138540) · c245bd89

huycozy authored Nov 16, 2023

Closes https://github.com/flutter/flutter/issues/138539.

Adding `two_dimensional_scrollables`, `process`, `platform` to the first-party package issue template so user can file issues related to them.

c245bd89

Roll Packages from 0cd23780741d to 07b4b298face (3 revisions) (#138549) · 9e826464

engine-flutter-autoroll authored Nov 16, 2023

https://github.com/flutter/packages/compare/0cd23780741d...07b4b298face

2023-11-16 kevmoo@users.noreply.github.com [script] use dart:io support for forwarding stdout/stderr (flutter/packages#5410)
2023-11-15 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from d211f4286035 to db7ef5bf9f59 (1539 revisions) (flutter/packages#5409)
2023-11-15 ychris@google.com [in_app_purchase] add storefront in skpaymentqueuewrapper (flutter/packages#5348)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9e826464

Roll Flutter Engine from 2e9f0df868b3 to 0c57a50810e8 (1 revision) (#138546) · ac509213

engine-flutter-autoroll authored Nov 16, 2023

https://github.com/flutter/engine/compare/2e9f0df868b3...0c57a50810e8

2023-11-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 5cccc24d127f to b512191e9612 (1 revision) (flutter/engine#48120)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ac509213

Roll Flutter Engine from 8ab189b77b8d to 2e9f0df868b3 (1 revision) (#138543) · 53a57adc

engine-flutter-autoroll authored Nov 16, 2023

https://github.com/flutter/engine/compare/8ab189b77b8d...2e9f0df868b3

2023-11-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from AuDKY8ob6GrGwDlmk... to M0zM3CJLIrd5lb0u0... (flutter/engine#48115)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from AuDKY8ob6GrG to M0zM3CJLIrd5

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

53a57adc

Roll Flutter Engine from 622fa0614412 to 8ab189b77b8d (1 revision) (#138533) · 3b1b3cb3

engine-flutter-autoroll authored Nov 16, 2023

https://github.com/flutter/engine/compare/622fa0614412...8ab189b77b8d

2023-11-16 skia-flutter-autoroll@skia.org Roll Skia from 2642516e7de7 to 2fe70dd9cbf8 (1 revision) (flutter/engine#48114)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3b1b3cb3

[flutter_tools] - Add `queries` section to Android manifest file (#137207) · dcdf72a6

Bruno Leroux authored Nov 16, 2023

## Description

This PR adds a new section to the Android manifest file.
This section is required for https://github.com/flutter/engine/pull/44579 (because it uses `PackageManager.queryIntentActivities` API ), see:

1. https://developer.android.com/training/package-visibility?hl=en
2. https://developer.android.com/reference/android/content/Intent#ACTION_PROCESS_TEXT
3. https://developer.android.com/reference/android/content/pm/PackageManager?hl=en#queryIntentActivities(android.content.Intent,%20android.content.pm.PackageManager.ResolveInfoFlags)

## Related Issue

Android manifest update for https://github.com/flutter/flutter/issues/107603

## Tests

This PR updates the integration tests and examples Android manifest files, this will help catch error or warning related to this change.

dcdf72a6

Roll Flutter Engine from 8aff9c134b8f to 622fa0614412 (1 revision) (#138532) · 76f7d2d9

engine-flutter-autoroll authored Nov 16, 2023

https://github.com/flutter/engine/compare/8aff9c134b8f...622fa0614412

2023-11-16 skia-flutter-autoroll@skia.org Roll Skia from add865f891c8 to 2642516e7de7 (1 revision) (flutter/engine#48112)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

76f7d2d9

Roll Flutter Engine from 3cfcdebe8623 to 8aff9c134b8f (18 revisions) (#138529) · 396cd713

engine-flutter-autoroll authored Nov 16, 2023

https://github.com/flutter/engine/compare/3cfcdebe8623...8aff9c134b8f

2023-11-16 skia-flutter-autoroll@skia.org Roll Dart SDK from cc6acfd7d57c to 5cccc24d127f (1 revision) (flutter/engine#48109)
2023-11-16 skia-flutter-autoroll@skia.org Roll Skia from 5d6bdbf69dea to add865f891c8 (1 revision) (flutter/engine#48108)
2023-11-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 65819963fb17 to cc6acfd7d57c (5 revisions) (flutter/engine#48100)
2023-11-16 matanlurey@users.noreply.github.com Make `fml/status_or.h` compatible with `.clang_tidy`. (flutter/engine#48002)
2023-11-16 dnfield@google.com [Impeller] Gate Vulkan selection on API 29 (flutter/engine#48089)
2023-11-16 chris@bracken.jp [macOS] Clean up allocations in menu plugin test (flutter/engine#48093)
2023-11-16 matanlurey@users.noreply.github.com Re-land "Make `fml/...` compatible with `.clang_tidy` (flutter/engine#48030)
2023-11-15 ychris@google.com [ios] introduce weak_nsobject (flutter/engine#47947)
2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from e954d1a1972c to 5d6bdbf69dea (2 revisions) (flutter/engine#48094)
2023-11-15 jonahwilliams@google.com [Impeller] add async command submission for blit pass. (flutter/engine#48040)
2023-11-15 matanlurey@users.noreply.github.com Make `lib/ui/compositing/...` compatible with `.clang_tidy`. (flutter/engine#48001)
2023-11-15 godofredoc@google.com Remove the linux fuchsia v1 build. (flutter/engine#48085)
2023-11-15 mdebbar@google.com [web] Apply global styles before inserting the DOM element (flutter/engine#48027)
2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from b23074a79bda to e954d1a1972c (7 revisions) (flutter/engine#48092)
2023-11-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `lib/ui/{text|window}/...` compatible with `.clang_tidy`." (flutter/engine#48083)
2023-11-15 41930132+hellohuanlin@users.noreply.github.com [ios]fix ios 16 auto correction highlight showing on top left corner (flutter/engine#47279)
2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from c42226314a4f to b23074a79bda (3 revisions) (flutter/engine#48081)
2023-11-15 matanlurey@users.noreply.github.com Make `lib/ui/{text|window}/...` compatible with `.clang_tidy`. (flutter/engine#48000)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

396cd713

Roll Flutter Engine from 30327eae0802 to 3cfcdebe8623 (1 revision) (#138515) · 9baa5392
engine-flutter-autoroll authored Nov 16, 2023

9baa5392

15 Nov, 2023 17 commits

Catch error for missing directory in `FontConfigManager` (#138496) · 04afff38

Elias Yishak authored Nov 15, 2023

Closes:
- https://github.com/flutter/flutter/issues/138434

We will catch any errors while attempting to clear the temp directories that don't exist for the `FontConfigManager` class

04afff38

Make `UnderlineInputBorder` consistent (#124153) · 2afec776

Bernardo Ferrari authored Nov 15, 2023

This was easy to implement. I like the result, I think `borderRadius.zero` -> `borderRadius.circular` makes a nice transition, and many places (like macOS) use an effect similar to this PR, while Google doesn't use anywhere (yet). I'm curious if it is going to break goldens or google testing.

<img width="954" alt="ttt" src="https://user-images.githubusercontent.com/351125/229918871-9f2ab851-6b41-44f5-80b9-c7928a8c0014.png">

What do you think? cc @HansMuller @gspencergoog. Is this something you want, should I ask the community, or do you prefer the current one?

Side effects:
- This makes strokeAlign work with `UnderlineInputBorder` (TODO: fix `drawLine` when borderRadius is zero).
- This is faster than the current implementation (clip is slow on Skia). ð 
- We could just call `BoxBorder._paintNonUniformBorder` (if it weren't private). Single LOC implementation.
- Web does this by default:
![image](https://user-images.githubusercontent.com/351125/233448671-90ce62ff-be91-40ca-8007-e82b57f3272e.png)
- Apparently no tests fail and most usages around (via code search) seem to be without a borderRadius.

2afec776

Prepare `ShortcutActivator` and `ShortcutManager` to migrate to `KeyEvent`... · f796e62c
Greg Spencer authored Nov 15, 2023
```
Prepare `ShortcutActivator` and `ShortcutManager` to migrate to `KeyEvent` from `RawKeyEvent`. (#136854)
```
f796e62c

Pin package:web 0.4.0 (#138428) · d8ffc739

Srujan Gaddam authored Nov 15, 2023

This version is needed so that dart:js_interop can move to extension
types. Also adds some code to handle some breaking changes:

- Body -> Response. Body was an IDL interface mixin type we exposed in
dart:html. Going forward, users should either use Request or Response.
- Casts to JSAny. These are temporary until we move package:web types to
extension types. Currently, package:web types can't implement JSObject
as JSObject will move to be an extension type itself.
Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>

d8ffc739

Reverts "Reland VelocityTracker update (#132291)" (#138512) · 82a7a62b

auto-submit[bot] authored Nov 15, 2023

Reverts flutter/flutter#137381
Initiated by: Piinks
This change reverts the following previous change:
Original Description:
This updates the implementation to use the stopwatch from the Clock object and piping it through to the TestWidgetsFlutterBinding so it will be kept in sync with FakeAsync.

Relands #132291
Fixes https://github.com/flutter/flutter/issues/97761

The change was reverted due to flakiness it introduced in tests that use fling gestures.
* https://github.com/flutter/flutter/issues/135728

82a7a62b

[web] skip flaky overflow_clipbehavior_none.cupertino.0.png golden check (#138498) · 46528858

Yegor authored Nov 15, 2023

Skipping the test due to
https://github.com/flutter/flutter/issues/137669. It's not clear which
PR started it, so we can't revert anything, and the fix is not yet clear
either. However, the flakiness is very high and is disruptive to the
Flutter team.

46528858

Roll Flutter Engine from 7c2b8d520b3d to 30327eae0802 (2 revisions) (#138502) · ca31aa17

engine-flutter-autoroll authored Nov 15, 2023

https://github.com/flutter/engine/compare/7c2b8d520b3d...30327eae0802

2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from 1f23a0b74619 to c42226314a4f (2 revisions) (flutter/engine#48075)
2023-11-15 gspencergoog@users.noreply.github.com Update keycode output (flutter/engine#47988)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ca31aa17

Reland VelocityTracker update (#132291) (#137381) · 1ac73332

Kate Lovett authored Nov 15, 2023

This updates the implementation to use the stopwatch from the Clock object and piping it through to the TestWidgetsFlutterBinding so it will be kept in sync with FakeAsync.

Relands #132291
Fixes https://github.com/flutter/flutter/issues/97761

The change was reverted due to flakiness it introduced in tests that use fling gestures.
* https://github.com/flutter/flutter/issues/135728

1ac73332

Roll Flutter Engine from f58dac64ad1a to 7c2b8d520b3d (1 revision) (#138499) · 7f3f52f0

engine-flutter-autoroll authored Nov 15, 2023

https://github.com/flutter/engine/compare/f58dac64ad1a...7c2b8d520b3d

2023-11-15 jason-simmons@users.noreply.github.com In the scenario game loop test, cancel the results writer task if the activity has been destroyed (flutter/engine#48051)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7f3f52f0

Fix 2D tap to stop scrolling (#138442) · cf18d250

Kate Lovett authored Nov 15, 2023

Adopted from https://github.com/flutter/flutter/pull/133750
That PR was abandoned. This finishes it up so we can land it.
Fixes https://github.com/flutter/flutter/issues/133529

Moves the `PanGestureRecognizer` used to drag the content along both axis to the outer vertical `Scrollable` subclass instead of the inner horizontal `Scrollable` subclass.

- This solves the issue of the inner `Scrollable` gestures being disabled while the outer `Scrollable` is scrolling
- Enables the user to stop the scroll movement by dragging the content again

cf18d250

Roll Flutter Engine from d22d063ac9f6 to f58dac64ad1a (2 revisions) (#138494) · 47207506

engine-flutter-autoroll authored Nov 15, 2023

https://github.com/flutter/engine/compare/d22d063ac9f6...f58dac64ad1a

2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from 3b7a62e2ac3f to 1f23a0b74619 (1 revision) (flutter/engine#48074)
2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from 1abce6b0a763 to 3b7a62e2ac3f (2 revisions) (flutter/engine#48071)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

47207506

SemanticOwner should dispatch creation and disposal events (#138388) · 684980e9
Binni Goel authored Nov 15, 2023

684980e9

Roll Flutter Engine from ecaf9442034d to d22d063ac9f6 (5 revisions) (#138489) · 0f42d194

engine-flutter-autoroll authored Nov 15, 2023

https://github.com/flutter/engine/compare/ecaf9442034d...d22d063ac9f6

2023-11-15 zanderso@users.noreply.github.com Reverts Dart to 3.3.0-135.0.dev (flutter/engine#48070)
2023-11-15 mdebbar@google.com [web] Move `EmbeddingStrategy` and `DimensionsProvider` out of `FlutterViewEmbedder` (flutter/engine#48025)
2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from d0e4a53f56f5 to 1abce6b0a763 (3 revisions) (flutter/engine#48067)
2023-11-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 849fd6ccc339 to 002e66832465 (1 revision) (flutter/engine#48065)
2023-11-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 65819963fb17 to 849fd6ccc339 (1 revision) (flutter/engine#48060)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0f42d194

Roll Packages from 428ba3e24532 to 0cd23780741d (1 revision) (#138482) · cffa6549

engine-flutter-autoroll authored Nov 15, 2023

https://github.com/flutter/packages/compare/428ba3e24532...0cd23780741d

2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter from f6621502 to e8c2bb13 (66 revisions) (flutter/packages#5399)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cffa6549

Marks Mac_android hot_mode_dev_cycle__benchmark to be unflaky (#138472) · defa2b74

Flutter GitHub Bot authored Nov 15, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_android hot_mode_dev_cycle__benchmark"
}
-->
The issue https://github.com/flutter/flutter/issues/138072 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_android%20hot_mode_dev_cycle__benchmark%22).
This test can be marked as unflaky.

defa2b74

Roll Flutter Engine from a7a48a68e6f8 to ecaf9442034d (1 revision) (#138468) · bf389357

engine-flutter-autoroll authored Nov 15, 2023

https://github.com/flutter/engine/compare/a7a48a68e6f8...ecaf9442034d

2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from 2f2c74633e0f to d0e4a53f56f5 (1 revision) (flutter/engine#48059)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bf389357

Roll Flutter Engine from 976edd5192d1 to a7a48a68e6f8 (3 revisions) (#138463) · 35132072

engine-flutter-autoroll authored Nov 15, 2023

https://github.com/flutter/engine/compare/976edd5192d1...a7a48a68e6f8

2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from a701a64f1ba9 to 2f2c74633e0f (1 revision) (flutter/engine#48058)
2023-11-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 6f1322227bdf to 65819963fb17 (2 revisions) (flutter/engine#48056)
2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from 5778a54af88d to a701a64f1ba9 (1 revision) (flutter/engine#48055)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

35132072