- 15 Feb, 2019 1 commit
-
-
Greg Spencer authored
This converts all remaining "## Sample code" segments into snippets, and fixes the snippet generator to handle multiple snippets in the same dartdoc block properly. I also generated, compiled, and ran each of the existing application samples, and fixed them up to be more useful and/or just run without errors. This PR fixes these problems with examples: 1. Switching tabs in a snippet now works if there is more than one snippet in a single dartdoc block. 2. Generation of snippet code now works if there is more than one snippet. 3. Contrast of text and links in the code sample block has been improved to recommended levels. 4. Added five new snippet templates, including a "freeform" template to make it possible to show examples that need to change the app instantiation. 5. Fixed several examples to run properly, a couple by adding the "Scaffold" widget to the template, a couple by just fixing their code. 6. Fixed visual look of some of the samples when they run by placing many samples inside of a Scaffold. 7. In order to make it easier to run locally, changed the sample analyzer to remove the contents of the supplied temp directory before running, since having files that hang around is problematic (only a problem when running locally with the `--temp` argument). 8. Added a `SampleCheckerException` class, and handle sample checking exceptions more gracefully. 9. Deprecated the old "## Sample code" designation, and added enforcement for the deprecation. 10. Removed unnecessary `new` from templates (although they never appeared in the samples thanks to dartfmt, but still). Fixes #26398 Fixes #27411
-
- 08 Feb, 2019 1 commit
-
-
Kartik Sharma authored
-
- 01 Feb, 2019 1 commit
-
-
MhdHejazi authored
-
- 23 Jan, 2019 1 commit
-
-
Alexandre Ardhuin authored
* fix some bad indentations * remove suspicious line
-
- 15 Jan, 2019 1 commit
-
-
Ian Hickson authored
Previously, a disabled floating action button always had zero elevation, which looks dumb. This also fixes the issue whereby highlightElevation was not honoured on floating action buttons. This also fixes an issue I found during testing whereby setState was being called during build when onHighlightChanged fired due to onPressed becoming null while a gesture is ongoing (which triggers an onTapCancel synchronously during build).
-
- 18 Dec, 2018 1 commit
-
-
Michael Goderbauer authored
-
- 16 Oct, 2018 1 commit
-
- 12 Oct, 2018 2 commits
-
-
matthew-carroll authored
This reverts commit 80f80ab0.
-
matthew-carroll authored
For G3 Roll: * Revert "MaterialButton must honor its minWidth and height parameters (#22919)" This reverts commit a0233233. * Revert "Update uses of ButtonTheme.bar: pass along the current Theme's colorScheme (#22827)" This reverts commit 655bf6a2. * Revert "ButtonTheme.of().colorScheme defers to Theme (#22880)" This reverts commit a590940e. * Revert "Bring TextTheme into alignment with the current Material spec (#22330)" This reverts commit 8bfb4b3e. * Revert "Added ColorScheme, updated ThemeData, ButtonTheme, material buttons (#22013)" This reverts commit eea3465a. * Manual adjustments to fix reversion issues.
-
- 08 Oct, 2018 1 commit
-
-
liyuqian authored
We'll roll this back as soon as the Dart analyzer gets upgraded in Google3.
-
- 02 Oct, 2018 1 commit
-
-
Hans Muller authored
Introduce an overall material "color scheme" and to make it possible to redefine how a component's visual properties bind to the color scheme and to the existing material Theme.
-
- 12 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint unnecessary_new * fix tests * fix tests * fix tests
-
- 07 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* lint unnecessary_new on samples * fix tests
-
- 24 Aug, 2018 1 commit
-
-
liyuqian authored
This reverts commit 8de0e15e and updates the goldens versoin. This requires https://github.com/flutter/flutter/pull/20751 to land first.
-
- 15 Aug, 2018 1 commit
-
-
Jonah Williams authored
-
- 09 Aug, 2018 1 commit
-
-
liyuqian authored
This fixes https://github.com/flutter/flutter/issues/18057
-
- 09 Jul, 2018 1 commit
-
-
Jonah Williams authored
-
- 03 Jul, 2018 2 commits
-
-
Jonah Williams authored
This reverts commit 989f5741.
-
Jonah Williams authored
-
- 05 Jun, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 20 Mar, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 02 Mar, 2018 1 commit
-
-
Hans Muller authored
-
- 05 Feb, 2018 1 commit
-
-
Hans Muller authored
-
- 13 Oct, 2017 1 commit
-
-
Greg Spencer authored
This modifies the MaterialButton to expand vertically to fit the size of the contained child, no matter what the child widget is. It tries to be as close as possible to the minHeight constraint. Also updated some doc comments to have headers (extra blank line after first sentence), and to wrap at 80 cols. Addresses #12311
-
- 27 May, 2017 1 commit
-
-
Ian Hickson authored
Minor fixes throughout, e.g. removing trailing commas from the end of sample code expressions, changing headings to "sample code" more consistently, removing stale todos, fix typos in a private method name, minor grammar fixes, added some clarifications to CircularProgressIndicator, LinearProgressIndicator, CrossAxisAlignment, added some cross-references to various members, made it slightly clearer that layout algorithms are implementation details. Clarified "elevation" throughout. Added docs to InkResponse and InkWell. Added sample code for: SliverAppBar, Card, ListTile, EdgeInsets, Row, Column, CustomScrollView, ListView, SliverFixedExtentList, and SliverGrid. Fixes #10317. Fixes #10316. Fixes #10267. (sort of, see comment therein) Fixes #9331. (sort of, see comment therein) Fixes #9407. (sort of, see comment therein)
-
- 03 May, 2017 2 commits
-
-
Ian Hickson authored
-
Jason Simmons authored
Fixes https://github.com/flutter/flutter/issues/9342
-
- 21 Apr, 2017 1 commit
-
-
Alexandre Ardhuin authored
* make @immutable const * fix build
-
- 23 Mar, 2017 1 commit
-
-
Luke authored
* adds highlight + splash color properties to material button * add states to raised button + flat button * fixes an issue where the custom highlight would not be properly set * Add preliminary tests for theme highlight + splash and via theme * documentation changes. tweaks per code review feedback * comment out unused variable * remove unused import * documentation updates. removed commented code
-
- 21 Mar, 2017 1 commit
-
-
Alexandre Ardhuin authored
* use color.shadeXxx instead of color[Xxx] * remove calls to .shade500 on MaterialColor * remove calls to .shade200 on MaterialAccentColor * fix test
-
- 04 Mar, 2017 1 commit
-
-
Chris Bracken authored
Covers lib/ in package:flutter.
-
- 31 Jan, 2017 1 commit
-
-
Ian Hickson authored
-
- 20 Jan, 2017 1 commit
-
-
Michael Goderbauer authored
-
- 14 Jan, 2017 1 commit
-
-
Adam Barth authored
The demo of the SimpleDialog had some useful code that should really be part of the framework. This patch extracts it into a SimpleDialogOption widget. Remove debugCheckHasScaffold because it is unused. Also, add tests for InkWell, SimpleDialog, and other widgets.
-
- 19 Nov, 2016 1 commit
-
-
Ian Hickson authored
-
- 03 Nov, 2016 1 commit
-
-
Ian Hickson authored
Based on P5's experience
-
- 23 Oct, 2016 1 commit
-
-
Wyatt Arent authored
-
- 20 Oct, 2016 1 commit
-
-
Ian Hickson authored
Based on observations of usability study participant P1.
-
- 16 Sep, 2016 1 commit
-
-
Dragoș Tiselice authored
Fixes #3208.
-
- 14 Jun, 2016 1 commit
-
-
pq authored
-