1. 22 Jun, 2016 3 commits
    • Hans Muller's avatar
      Add AppBar iconTheme parameter (#4693) · bb2e7b52
      Hans Muller authored
      bb2e7b52
    • Ian Hickson's avatar
      About box API (#4677) · cd89e867
      Ian Hickson authored
      This API is the front-end part of the work on showing licenses.
      
      Future patches will:
      
      * Provide an API for registering what licenses should be shown here,
        which will be used by this feature to shown licenses but could also be
        used by custom code for showing licenses (e.g. for people not using
        the Material widgets).
      
      * Actually populate this license API from all the licenses we currently
        use in the engine, in the framework, and from any pub packages that
        are used (directly or indirectly) by the application.
      cd89e867
    • Adam Barth's avatar
      Restore SystemChrome.setEnabledSystemUIOverlays (#4680) · bf740cf4
      Adam Barth authored
      I erroneously removed this function in an earlier patch. Also, export
      SystemUiOverlayStyle because we expose that enum in the SystemChrome
      API.
      bf740cf4
  2. 21 Jun, 2016 7 commits
    • Adam Barth's avatar
      Update engine to include new version of Mojo (#4668) · a8f6f44a
      Adam Barth authored
      This required switching from the Future-based bindings to the callback-based
      bindings.
      a8f6f44a
    • Hans Muller's avatar
      DropdownButton layout (#4582) · b81229b5
      Hans Muller authored
      b81229b5
    • Hans Muller's avatar
    • Adam Barth's avatar
      Route.didMount should throw a useful error message (#4665) · 97c1f0b7
      Adam Barth authored
      The error code path wasn't actually getting the point where it would throw the
      useful error message. Also, fix error recovery when runApp fails.
      
      Fixes #4655
      97c1f0b7
    • Todd Volkert's avatar
      Simplify SystemChrome.setSystemUIOverlayStyle() (#4653) · 2e48c1a1
      Todd Volkert authored
      * Only schedule overlay style update microtask if needed
      
      * Simplify API
      2e48c1a1
    • Ian Hickson's avatar
      ImageIcon (#4649) · e502e9c8
      Ian Hickson authored
      Anywhere that accepted IconData now accepts either an Icon or an
      ImageIcon.
      
      Places that used to take an IconData in an `icon` argument, notably
      IconButton and DrawerItem, now take a Widget in that slot. You can wrap
      the value that used to be passed in in an Icon constructor to get the
      same result.
      
      Icon itself now takes the icon as a positional argument, for brevity.
      
      ThemeData now has an iconTheme as well as a primaryIconTheme, the same
      way it has had a textTheme and primaryTextTheme for a while.
      
      IconTheme.of() always returns a value now (though that value itself may
      have nulls in it). It defaults to the ThemeData.iconTheme.
      
      IconThemeData.fallback() is a new method that returns an icon theme data
      structure with all fields filled in.
      
      IconTheme.merge() is a new constructor that takes a context and creates
      a widget that mixes in the new values with the inherited values.
      
      Most places that introduced an IconTheme widget now use IconTheme.merge.
      
      IconThemeData.merge and IconThemeData.copyWith act in a way analogous to
      the similarly-named members of TextStyle.
      
      ImageIcon is introduced. It acts like Icon but takes an ImageProvider
      instead of an IconData.
      
      Also: Fix the analyzer to actually check the stocks app.
      e502e9c8
    • Adam Barth's avatar
      Nesting MaterialApps should not assert (#4636) · e071f0ba
      Adam Barth authored
      Turns out we weren't managing focus correct between navigator routes because we
      were missing a Focus widget above the routes. However, adding this widget
      caused us to explode at startup because the initial route was trying to move
      focus during the build phase.
      
      This patch teaches Focus to have an initiallyFocusedScope, which can be use to
      initialize the child focus scope.
      
      Fixes #4065
      e071f0ba
  3. 20 Jun, 2016 5 commits
  4. 17 Jun, 2016 3 commits
    • Ian Hickson's avatar
      Fix Switch (#4622) · 833b1216
      Ian Hickson authored
      I broke them when refactoring images. Oops.
      833b1216
    • Ali Ghassemi's avatar
      Few overscroll glow fixes. (#4610) · 94c4222f
      Ali Ghassemi authored
      Fixes #4169 and also now overscroll indicator is dismissed the moment
      user scrolls in the opposite direction (#4603) but the bounce overscroll
      that happens behind the scene and is clamped in the indicator is still
      problematic and needs to be fixed. However these fixes are orthogonal to that.
      
      Also closes #4127 as I verified the timeout feature (reduced the duration
      to 500ms to be closer to Android behaviour)
      94c4222f
    • Ian Hickson's avatar
  5. 16 Jun, 2016 6 commits
    • Ali Ghassemi's avatar
    • Hans Muller's avatar
      6ba5674d
    • Ian Hickson's avatar
      Update LayoutBuilder docs a bit (#4593) · e9edf7a0
      Ian Hickson authored
      e9edf7a0
    • Ian Hickson's avatar
      Refactor everything to do with images (#4583) · 2dfdc840
      Ian Hickson authored
      Overview
      ========
      
      This patch refactors images to achieve the following goals:
      
      * it allows references to unresolved assets to be passed
        around (previously, almost every layer of the system had to know about
        whether an image came from an asset bundle or the network or
        elsewhere, and had to manually interact with the image cache).
      
      * it allows decorations to use the same API for declaring images as the
        widget tree.
      
      It requires some minor changes to call sites that use images, as
      discussed below.
      
      Widgets
      -------
      
      Change this:
      
      ```dart
            child: new AssetImage(
              name: 'my_asset.png',
              ...
            )
      ```
      
      ...to this:
      
      ```dart
            child: new Image(
              image: new AssetImage('my_asset.png'),
              ...
            )
      ```
      
      Decorations
      -----------
      
      Change this:
      
      ```dart
            child: new DecoratedBox(
              decoration: new BoxDecoration(
                backgroundImage: new BackgroundImage(
                  image: DefaultAssetBundle.of(context).loadImage('my_asset.png'),
                  ...
                ),
                ...
              ),
              child: ...
            )
      ```
      
      ...to this:
      
      ```dart
            child: new DecoratedBox(
              decoration: new BoxDecoration(
                backgroundImage: new BackgroundImage(
                  image: new AssetImage('my_asset.png'),
                  ...
                ),
                ...
              ),
              child: ...
            )
      ```
      
      DETAILED CHANGE LOG
      ===================
      
      The following APIs have been replaced in this patch:
      
      * The `AssetImage` and `NetworkImage` widgets have been split in two,
        with identically-named `ImageProvider` subclasses providing the
        image-loading logic, and a single `Image` widget providing all the
        widget tree logic.
      
      * `ImageResource` is now `ImageStream`. Rather than configuring it with
        a `Future<ImageInfo>`, you complete it with an `ImageStreamCompleter`.
      
      * `ImageCache.load` and `ImageCache.loadProvider` are replaced by
        `ImageCache.putIfAbsent`.
      
      The following APIs have changed in this patch:
      
      * `ImageCache` works in terms of arbitrary keys and caches
        `ImageStreamCompleter` objects using those keys. With the new model,
        you should never need to interact with the cache directly.
      
      * `Decoration` can now be `const`. The state has moved to the
        `BoxPainter` class. Instead of a list of listeners, there's now just a
        single callback and a `dispose()` method on the painter. The callback
        is passed in to the `createBoxPainter()` method. When invoked, you
        should repaint the painter.
      
      The following new APIs are introduced:
      
      * `AssetBundle.loadStructuredData`.
      
      * `SynchronousFuture`, a variant of `Future` that calls the `then`
        callback synchronously. This enables the asynchronous and
        synchronous (in-the-cache) code paths to look identical yet for the
        latter to avoid returning to the event loop mid-paint.
      
      * `ExactAssetImage`, a variant of `AssetImage` that doesn't do anything clever.
      
      * `ImageConfiguration`, a class that describes parameters that configure
        the `AssetImage` resolver.
      
      The following APIs are entirely removed by this patch:
      
      * `AssetBundle.loadImage` is gone. Use an `AssetImage` instead.
      
      * `AssetVendor` is gone. `AssetImage` handles everything `AssetVendor`
        used to handle.
      
      * `RawImageResource` and `AsyncImage` are gone.
      
      The following code-level changes are performed:
      
      * `Image`, which replaces `AsyncImage`, `NetworkImage`, `AssetImage`,
        and `RawResourceImage`, lives in `image.dart`.
      
      * `DecoratedBox` and `Container` live in their own file now,
        `container.dart` (they reference `image.dart`).
      
      DIRECTIONS FOR FUTURE RESEARCH
      ==============================
      
      * The `ImageConfiguration` fields are mostly aspirational. Right now
        only `devicePixelRatio` and `bundle` are implemented. `locale` isn't
        even plumbed through, it will require work on the localisation logic.
      
      * We should go through and make `BoxDecoration`, `AssetImage`, and
        `NetworkImage` objects `const` where possible.
      
      * This patch makes supporting animated GIFs much easier.
      
      * This patch makes it possible to create an abstract concept of an
        "Icon" that could be either an image or a font-based glyph (using
        `IconData` or similar). (see
        https://github.com/flutter/flutter/issues/4494)
      
      RELATED ISSUES
      ==============
      
      Fixes https://github.com/flutter/flutter/issues/4500
      Fixes https://github.com/flutter/flutter/issues/4495
      Obsoletes https://github.com/flutter/flutter/issues/4496
      2dfdc840
    • pq's avatar
      Dead code and switch cleanup (continued). · 3e9067a4
      pq authored
      Prep to get us ready to pull in a new dev SDK and bump our analyzer DEP.
      
      * updates `crypto` (required by fresh analyzer)
      * fixes newly flagged dead code warnings
      * fixes switches that fall through and don't return
      3e9067a4
    • pq's avatar
      Dead code and switch cleanup (continued). · e8d1df07
      pq authored
      Prep to get us ready to pull in a new dev SDK and bump our analyzer DEP.
      
      * updates `crypto` (required by fresh analyzer)
      * fixes newly flagged dead code warnings
      * fixes switches that fall through and don't return
      e8d1df07
  6. 15 Jun, 2016 3 commits
  7. 14 Jun, 2016 4 commits
  8. 13 Jun, 2016 2 commits
  9. 12 Jun, 2016 1 commit
  10. 10 Jun, 2016 2 commits
  11. 09 Jun, 2016 4 commits
    • Adam Barth's avatar
      Improve hitTestSelf and hitTestChildren docs (#4484) · 696f4710
      Adam Barth authored
      Fixes #4427
      696f4710
    • Adam Barth's avatar
      DropDownMenu should animation away when interrupted (#4485) · 2be1eb48
      Adam Barth authored
      If you tap outside the drop down menu while its animating in, we should
      animate it away smoothly. Previously, we jumped to the reverseCurve,
      which made the menu disappear immediately. Now we hold the animations as
      state, which means we keep their _curveDirection property and don't
      switch curves unless the animation actually finishes.
      
      Also, fix a subtle bug in CurvedAnimation whereby we'd never set the
      _curveDirection if we didn't see a status change in the parent
      animation. Now we initialize _curveDirection based on the current value
      of the parent's status.
      
      Fixes #4379
      2be1eb48
    • Adam Barth's avatar
      Rename relayoutSubtreeRoot -> relayoutBoundary (#4483) · 4e3e40a1
      Adam Barth authored
      Fixes #4425
      4e3e40a1
    • Adam Barth's avatar
      Remove clients of getTotalMatrix (#4487) · afe3158d
      Adam Barth authored
      Instead of using getTotalMatrix and setMatrix, we can just use
      save/restore, which is more idiomatic.
      
      The getTotalMatrix/setMatrix pattern was introduced to improve
      performance, but the original code was calling getTotalMatrix/setMatrix
      at every node in the sprite tree, which is much slower than the normal
      save/transform/restore pattern.
      
      Related to #4254
      afe3158d