- 19 Oct, 2020 15 commits
-
-
Jonah Williams authored
Fixes #67370 By running most of these executions through flutter, we get the benefit of the flutter error handling and precaching. IN the test where this is not feasible, call pre-cache directly.
-
YeungKC authored
-
Jonah Williams authored
Removes one-off handling for defines test and forces it to run through the DriverTest interface
-
Jonah Williams authored
Split the integration_ui target into individual driver tests. Remove disabled screenshot tests
-
Greg Spencer authored
- - When I added notification of key events before processing them as text, it made it so that shortcut key bindings like the spacebar would prevent spaces from being inserted into text fields, which is obviously not desirable (and so that change was reverted). At the same time, we do want to make it possible to override key events so that they can do things like intercept a tab key or arrow keys that change the focus. This PR changes the behavior of the Shortcuts widget so that if it has a shortcut defined, but no action is bound to the intent, then instead of responding that the key is "handled", it responds as if nothing handled it. This allows the engine to continue to process the key as text entry. This PR includes: - Modification of the callback type for key handlers to return a KeyEventResult instead of a bool, so that we can return more information (i.e. the extra state of "stop propagation"). - Modification of the ActionDispatcher.invokeAction contract to require that Action.isEnabled return true before calling it. It will now assert if the action isn't enabled when invokeAction is called. This is to allow optimization of the number of calls to isEnabled, since the shortcuts widget now wants to know if the action was enabled before deciding to either handle the key or to return ignored. - Modification to ShortcutManager.handleKeypress to return KeyEventResult.ignored for keys which don't have an enabled action associated with them. - Adds an attribute to DoNothingAction that allows it to mark a key as not handled, even though it does have an action associated with it. This will allow disabling of a shortcut for a subtree.
-
Jonah Williams authored
Remove devicelab specific code for shutting down gradle daemon, add --android-gradle-daemon option to build/run/drive`. Avoids need for un-tested devicelab specific handler. There are also some feature requests for this, so 2 birds one stone. Example: flutter build apk --no-android-gradle-daemon will pass --no-daemon on to gradle
-
Kate Lovett authored
-
Jonah Williams authored
The current timeout is too short for some remote workflows. The existing unit test require hitting a real timeout so I've removed it. See b/171005910
-
Jonah Williams authored
This reverts commit ddab72e7.
-
Jonah Williams authored
Remove devicelab specific code for shutting down gradle daemon, add --android-gradle-daemon option to build/run/drive`. Avoids need for un-tested devicelab specific handler. There are also some feature requests for this, so 2 birds one stone. Example: flutter build apk --no-android-gradle-daemon will pass --no-daemon on to gradle
-
Nobuhiro Tabuki authored
This PR suggests improving the IntelliJ plugin "jar" detection logic. Previously: The IntelliJ Flutter plugin was contained flutter-intellij.jar. Currently: It is named flutter-intellij-X.Y.Z.jar and does not contain META-INF/plugin.xml. META-INF/plugin.xml is included in flutter-idea-X.Y.Z.jar. So this PR changes the rules for searching the plugin's jar file. Concretely, it looks for the jar file containing META-INF/plugin.xml in the plugin's package directory and reads the package version from its META-INF/plugin.xml. Co-authored-by: Jonah Williams <jonahwilliams@google.com>
-
Michael Thomsen authored
-
Ayush Bherwani authored
-
Xavier Chrétien authored
-
Jonah Williams authored
This reverts commit a8375576.
-
- 18 Oct, 2020 3 commits
-
-
engine-flutter-autoroll authored
-
Ming Lyu (CareF) authored
Transport `e2e` based perforamnce test to `integration_test` and remove duplicate `watchPerformance` (#67594)
-
nt4f04uNd authored
-
- 17 Oct, 2020 2 commits
-
-
xster authored
-
Marcin Jeleński authored
-
- 16 Oct, 2020 20 commits
-
-
engine-flutter-autoroll authored
-
Lau Ching Jun authored
-
Jonah Williams authored
We'd like to see how many of these flakes are transient and how many involve the device/machine getting temporarily wedged. Add a retry with no delay to see if it is possible to add sufficient error handling to startApp/installApp to handle this.
-
Hamdi Kahloun authored
Date Picker jumps back to initialDatePickerMode after day selection.
-
YeungKC authored
-
Alexandre Ardhuin authored
-
Lau Ching Jun authored
-
Jonah Williams authored
Both start and stop app create an application package, but only start app used the application binary. Create the application package once and pass it to both start and stop app.
-
engine-flutter-autoroll authored
-
Martin Kustermann authored
-
Alexandre Ardhuin authored
-
LongCatIsLooong authored
-
Alexandre Ardhuin authored
-
engine-flutter-autoroll authored
-
Shi-Hao Hong authored
* Generate pubspec.yaml for synthetic package if it did not exist prior
-
engine-flutter-autoroll authored
-
Jonah Williams authored
-
Jonah Williams authored
-
Jenn Magder authored
-
Shi-Hao Hong authored
-