Commits · e83f53e6a0ec01d4301869a0178f065f4bd42476 · abdullh.alsoleman / Front-End

11 Oct, 2023 27 commits

Roll Flutter Engine from 5fcc16772cdd to 2b1b4b97f787 (1 revision) (#136404) · e83f53e6

engine-flutter-autoroll authored Oct 11, 2023

https://github.com/flutter/engine/compare/5fcc16772cdd...2b1b4b97f787

2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from 6cc9f73ea54e to 2459d71707e0 (1 revision) (flutter/engine#46787)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e83f53e6

Switch to Chrome for Testing instead of vanilla Chromium. (#136214) · a277c5fa

Jackson Gardner authored Oct 11, 2023

This switches over to using Chrome for Testing instead of Chromium. This should ensure that we are consistently using an official and consistent build of Chrome on all platforms, rather than whatever we can get from the continuous builds archive, which can potentially put platforms out of sync with each other.

a277c5fa

Reland "Switch flutter_tools to run frontend server from AOT snapshot" (#136282) · 1a44710d
Derek Xu authored Oct 11, 2023
```
This reverts commit a1639be4.
```
1a44710d

Roll Flutter Engine from 4b02631b59bf to 5fcc16772cdd (2 revisions) (#136397) · 58701ac2

engine-flutter-autoroll authored Oct 11, 2023

https://github.com/flutter/engine/compare/4b02631b59bf...5fcc16772cdd

2023-10-11 john@johnmccutchan.com Fix 303652511 and add a regression test (flutter/engine#46743)
2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from bfd9af01b785 to 6cc9f73ea54e (1 revision) (flutter/engine#46784)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

58701ac2

Fix some deprecation details (#136385) · 156e3487

Kate Lovett authored Oct 11, 2023

This fixes/notates a few deprecations from an audit for the next tech debt cycle.

- ThemeData errorColor and backgroundColor are notated as deprecated in multiple places, but one usage had a different version tag. Updated to match the rest.
- ThemeData.copyWith useMaterial3 was deprecated because it did not do what developers expected - it did not automatically reassign all of the color values and such. (confirmed with @HansMuller) I added a note so that when we later remove it we don't introduce a bug.
- the describeEnum deprecation was tagged wrong, it was a very long PR so by the time it merged the version it was finally tagged with was much later. (https://github.com/flutter/flutter/pull/125016)

156e3487

Roll Flutter Engine from ed67e8aa9aba to 4b02631b59bf (1 revision) (#136392) · 9a8a2c7f

engine-flutter-autoroll authored Oct 11, 2023

https://github.com/flutter/engine/compare/ed67e8aa9aba...4b02631b59bf

2023-10-11 bdero@google.com [Impeller] Avoid invalid GL depth calls on macOS desktop. (flutter/engine#46758)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9a8a2c7f

[leak-tracking] Add leak tracking in test/rendering - 1 (#136275) · f84831c1
droidbg authored Oct 11, 2023

f84831c1

Remove the 'Windows_arm64 plugin_test' Devicelab test (#136379) · f2931dbd

Loïc Sharma authored Oct 11, 2023

This removes the `Windows_arm64 plugin_test` as Devicelab tests aren't able to target Android from a Windows Arm64 host yet. I opened https://github.com/flutter/flutter/issues/136378 to track this work.

f2931dbd

Roll Flutter Engine from 68a8ff743539 to ed67e8aa9aba (2 revisions) (#136383) · ea8c6307

engine-flutter-autoroll authored Oct 11, 2023

https://github.com/flutter/engine/compare/68a8ff743539...ed67e8aa9aba

2023-10-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from mLc-VlVTg-p18HjiP... to Qjz4zE4Oe0AO_7T3f... (flutter/engine#46778)
2023-10-11 zanderso@users.noreply.github.com Roll goldctl forward (flutter/engine#46771)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from mLc-VlVTg-p1 to Qjz4zE4Oe0AO

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ea8c6307

extend timeout from default 30 min to 1 hour for windows build tests (#136300) · 5a4497d4
Christopher Fujino authored Oct 11, 2023
```
Fixes https://github.com/flutter/flutter/issues/136299
```
5a4497d4
Add `profilePlatformChannels` service extension (#136051) · a047358c
Kenzie Davisson authored Oct 11, 2023
```
We will expose this from a button in DevTools.
https://github.com/flutter/devtools/issues/6166
```
a047358c

Include size factors when computing the intrinsic size of a `RenderPositionedBox` (#135823) · 6ff02dbc

Maximilian Fischer authored Oct 11, 2023

This PR includes the `widthFactor` and `heightFactor` when computing the intrinsic size of a `RenderPositionedBox`.

<details><summary>Code sample</summary>

Red should have a height of 100, blue one of 200.

```dart
import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Intrinsic Bug',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: Scaffold(
        body: Row(
          crossAxisAlignment: CrossAxisAlignment.start,
          children: [
            Expanded(
              child: IntrinsicHeight(
                child: Align(
                  heightFactor: 0.5,
                  child: Container(
                    height: 200,
                    color: Colors.red,
                  ),
                ),
              ),
            ),
            Expanded(
              child: Container(
                height: 200,
                color: Colors.blue,
              ),
            ),
          ],
        ),
      ),
    );
  }
}
```
</details>

Before:
![grafik](https://github.com/flutter/flutter/assets/45403027/447d8b9b-e7f3-482a-900d-53e436830321)
After:
![grafik](https://github.com/flutter/flutter/assets/45403027/6d1a104b-3327-47e2-8b36-798ed0136793)

Fix #135822

6ff02dbc

[flutter_tool] Delete skipped tests (#136364) · d773c5a9

Zachary Anderson authored Oct 11, 2023

These tests have been skipped due to flakiness for a long time.

Closes https://github.com/dart-lang/webdev/issues/1562
Closes https://github.com/flutter/flutter/issues/124214

d773c5a9

Roll Flutter Engine from ec1d0d69fcf1 to 68a8ff743539 (2 revisions) (#136380) · e090fc1a

engine-flutter-autoroll authored Oct 11, 2023

https://github.com/flutter/engine/compare/ec1d0d69fcf1...68a8ff743539

2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from 60d51fd2c6bd to bfd9af01b785 (2 revisions) (flutter/engine#46774)
2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from c05effecb081 to 60d51fd2c6bd (3 revisions) (flutter/engine#46772)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e090fc1a

[Windows] Add Arm64 benchmarks (#135514) · c6aeab93

Loïc Sharma authored Oct 11, 2023

Part of: https://github.com/flutter/flutter/issues/129806

Test runs kicked off using `led`:
* â [hot_mode_dev_cycle_win_target__benchmark](https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/loicsharma_google.com/2079b030acdb59e82e1798a81a22ba06ebbb29d5fdd4e7ab55e95930037bdd2a/+/build.proto?server=chromium-swarm.appspot.com)
* â [windows_home_scroll_perf__timeline_summary](https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/loicsharma_google.com/56a3b258e4abb451240a4942d337db60de293ff116ad372358e3fa1da941bc83/+/build.proto?server=chromium-swarm.appspot.com)
* â [flutter_tool_startup](https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/loicsharma_google.com/fa6a1056fc447817cea54cac4ca5c4588fbece1a948d30fc03e41fbadd3d4c97/+/build.proto?server=chromium-swarm.appspot.com)

/cc @pbo-linaro

c6aeab93

_RenderSnapshotWidget should dispose created OffsetLayer. (#136267) · cc41e25f
Kostia Sokolovskyi authored Oct 11, 2023

cc41e25f

Roll Flutter Engine from bddb34b09ce9 to ec1d0d69fcf1 (1 revision) (#136368) · 54d58474

engine-flutter-autoroll authored Oct 11, 2023

https://github.com/flutter/engine/compare/bddb34b09ce9...ec1d0d69fcf1

2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from e00577618d81 to c05effecb081 (1 revision) (flutter/engine#46770)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

54d58474

Roll Flutter Engine from d93fe2367d21 to bddb34b09ce9 (2 revisions) (#136352) · ec94ccff

engine-flutter-autoroll authored Oct 11, 2023

https://github.com/flutter/engine/compare/d93fe2367d21...bddb34b09ce9

2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from 11e41e0e2f9f to e00577618d81 (1 revision) (flutter/engine#46763)
2023-10-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from FX5YzwP_ZEnPP0b3v... to hMA99PoacaRZVXHgr... (flutter/engine#46762)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from FX5YzwP_ZEnP to hMA99PoacaRZ

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ec94ccff

Roll Flutter Engine from cb0dabd3b33c to d93fe2367d21 (2 revisions) (#136346) · 1ca09910

engine-flutter-autoroll authored Oct 11, 2023

https://github.com/flutter/engine/compare/cb0dabd3b33c...d93fe2367d21

2023-10-11 leroux_bruno@yahoo.fr [Android] Add support for text processing actions (flutter/engine#44579)
2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from 4935bed4260d to 11e41e0e2f9f (3 revisions) (flutter/engine#46759)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1ca09910

Fix `FlexibleSpaceBar` does compositing with near zero opacity. (#136255) · 692d7ade

Taha Tesser authored Oct 11, 2023

fixes [`flexible_space_bar.dart': Failed assertion: line 475 pos 12: 'needsCompositing': is not true.` is thrown when scrolling down in the list and then up](https://github.com/flutter/flutter/issues/135698)

692d7ade

Roll Flutter Engine from 0d86d529bb7e to cb0dabd3b33c (1 revision) (#136320) · 94f74838

engine-flutter-autoroll authored Oct 11, 2023

https://github.com/flutter/engine/compare/0d86d529bb7e...cb0dabd3b33c

2023-10-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from oTiMPVe_PvyCYnlqR... to mLc-VlVTg-p18HjiP... (flutter/engine#46754)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from oTiMPVe_PvyC to mLc-VlVTg-p1

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

94f74838

Roll Flutter Engine from 80868149792f to 0d86d529bb7e (1 revision) (#136315) · 0d1e73b1

engine-flutter-autoroll authored Oct 11, 2023

https://github.com/flutter/engine/compare/80868149792f...0d86d529bb7e

2023-10-11 bdero@google.com [Impeller] Allow pipeline variant sets to have differing defaults. (flutter/engine#46751)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0d1e73b1

Roll Flutter Engine from ea275c3d27d3 to 80868149792f (4 revisions) (#136307) · 2a221682

engine-flutter-autoroll authored Oct 11, 2023

https://github.com/flutter/engine/compare/ea275c3d27d3...80868149792f

2023-10-11 matanlurey@users.noreply.github.com Remove support for `Paint.enableDithering=false` in `dart:ui`. (flutter/engine#46745)
2023-10-11 chris@bracken.jp Move //third_party/glfw to //flutter/third_party/glfw (flutter/engine#46733)
2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from 06145491fd17 to 4935bed4260d (3 revisions) (flutter/engine#46748)
2023-10-11 bdero@google.com [Impeller] Guard calls to extension proc DebugMessageControlKHR. (flutter/engine#46747)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2a221682

Fix flakiness: finalize dropped gestures in tests to release resources, and... · ad059499
Polina Cherkasova authored Oct 11, 2023
```
Fix flakiness: finalize dropped gestures in tests to release resources, and update doc-comment. (#136136)
```
ad059499
Add `SizeTransition.fixedCrossAxisSizeFactor` (#134659) · b989428f
Valentin Vignal authored Oct 11, 2023
```
Fixes https://github.com/flutter/flutter/issues/134654
```
b989428f

Relaxed a test on `Paint.toString()` to ignore `dither: ...`. (#136302) · f38244f0

Matan Lurey authored Oct 11, 2023

Work towards https://github.com/flutter/flutter/issues/112498.

Behaviorally the same, except doesn't care if `dither: ...` shows up, or
not (it won't when https://github.com/flutter/flutter/issues/112498 is
fixed).

f38244f0

Roll Flutter Engine from 4a4d9de43848 to ea275c3d27d3 (1 revision) (#136301) · a7edafe7

engine-flutter-autoroll authored Oct 11, 2023

https://github.com/flutter/engine/compare/4a4d9de43848...ea275c3d27d3

2023-10-10 jonahwilliams@google.com [Impeller] log specific framebuffer incomplete error. (flutter/engine#46692)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a7edafe7

10 Oct, 2023 13 commits

Roll Flutter Engine from bdeb53455f7c to 4a4d9de43848 (2 revisions) (#136294) · 85e17265

engine-flutter-autoroll authored Oct 10, 2023

https://github.com/flutter/engine/compare/bdeb53455f7c...4a4d9de43848

2023-10-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from dCjN58uZQBmAFWSxN... to FX5YzwP_ZEnPP0b3v... (flutter/engine#46734)
2023-10-10 bdero@google.com [Impeller] Don't cull readbacks outside the damage rect. (flutter/engine#46705)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from dCjN58uZQBmA to FX5YzwP_ZEnP

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

85e17265

Add key event handlers that happen before or after the focus traversal (#136280) · 7e1d366a

Greg Spencer authored Oct 10, 2023

## Description

This adds a mechanism for listening to key events before or after focus traversal occurs.

It adds four methods to the public `FocusManager` API:

- `addEarlyKeyEventHandler` - Adds a handler that can handle events before they are given to the focus tree for handling.
- `removeEarlyKeyEventHandler` - Removes an early event handler.
- `addLateKeyEventHandler` - Adds a handler that can handle events if they have not been handled by anything in the focus tree.
- `removeLateKeyEventHandler` - Removes a late event handler.

This allows an app to get notified for a key anywhere, and prevent the focus tree from seeing that event if it handles it.

For the menu system, this allows it to eat an escape key press and close all the open menus.

## Related Issues
 - https://github.com/flutter/flutter/issues/135334

## Tests
 - Added tests for new functionality.

7e1d366a

[flutter_tools] catch StdinException when setting terminal to SingleCharMode (#136283) · b416473b
Christopher Fujino authored Oct 10, 2023
```
Fixes https://github.com/flutter/flutter/issues/129198
```
b416473b

[Android] Update Java/AGP/Gradle warning compatible Java range (#135710) · 54cf286e

Camille Simon authored Oct 10, 2023

Specifies that compatible Java range stated in warning when Java version is incompatible with our template AGP & Gradle versions notes an exclusive upper bound Java version. This was a bug from https://github.com/flutter/flutter/pull/131444, and I will file a CP request to stable once this lands.

The warning uses [`getJavaVersionFor`](https://github.com/flutter/flutter/blob/b5c8fd11e4906d900039584b4f67c9753327060c/packages/flutter_tools/lib/src/android/gradle_utils.dart#L606), which returns an exclusive upper bound, which is why this fix is necessary.

54cf286e

Roll Flutter Engine from 702f366b1c5d to bdeb53455f7c (6 revisions) (#136292) · 640050ba

engine-flutter-autoroll authored Oct 10, 2023

https://github.com/flutter/engine/compare/702f366b1c5d...bdeb53455f7c

2023-10-10 john@johnmccutchan.com Fix high FPS screen flicker of Platform Views when using ImageReaderPlatformViewRenderTarget (flutter/engine#46724)
2023-10-10 matanlurey@users.noreply.github.com Prepare to move new folders into `third_party/` by adding a `.gitignore`. (flutter/engine#46729)
2023-10-10 godofredoc@google.com Use x86 machines for ios builds. (flutter/engine#46726)
2023-10-10 chinmaygarde@google.com Remove workaround for older versions of MSVC. (flutter/engine#46689)
2023-10-10 skia-flutter-autoroll@skia.org Roll Skia from 475286f0f6f1 to 06145491fd17 (1 revision) (flutter/engine#46728)
2023-10-10 jonahwilliams@google.com [Impeller] Implement framebuffer fetch support for OpenGLES. (flutter/engine#46585)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

640050ba

[framework] restore old zoom page transition for benchmarking. (#133346) · a106b81c

Jonah Williams authored Oct 10, 2023

In the past I switched the implementation of the zoom page transition because the performance of the old transition was terrible, but I'm hopeful that with Impeller we'll be able to identify and fix the issues that made it so slow. In order to evaluate this though, we need to be able to opt into the old transition for benchmarks on CI.

https://github.com/flutter/flutter/issues/129742
https://github.com/flutter/flutter/issues/121325

a106b81c

Seperate localization tests for Material2 and Material3 (#135779) · daa52b25

Mitchell Goodwin authored Oct 10, 2023

Seperates tests for the localizations package into Material2 and Material3 versions and removes dependency on theme.

More info in #127064

daa52b25

[flutter_tools] allow tool integration tests to quit on SIGINT (#136271) · 0fa01b21
Christopher Fujino authored Oct 10, 2023
```
fixes https://github.com/flutter/flutter/issues/136270
```
0fa01b21

Roll Flutter Engine from e0653982dad2 to 702f366b1c5d (1 revision) (#136281) · 09ed4f1f

engine-flutter-autoroll authored Oct 10, 2023

https://github.com/flutter/engine/compare/e0653982dad2...702f366b1c5d

2023-10-10 skia-flutter-autoroll@skia.org Roll Skia from f0653c4a2df5 to 475286f0f6f1 (2 revisions) (flutter/engine#46721)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

09ed4f1f

Roll Flutter Engine from 39bfce213a4f to e0653982dad2 (1 revision) (#136278) · 7deb535c

engine-flutter-autoroll authored Oct 10, 2023

https://github.com/flutter/engine/compare/39bfce213a4f...e0653982dad2

2023-10-10 flar@google.com use TextFrame calls for Impeller in rendertests (flutter/engine#46696)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7deb535c

Roll Flutter Engine from 60e861dfe6b1 to 39bfce213a4f (3 revisions) (#136272) · 38a7d9d1

engine-flutter-autoroll authored Oct 10, 2023

https://github.com/flutter/engine/compare/60e861dfe6b1...39bfce213a4f

2023-10-10 skia-flutter-autoroll@skia.org Roll Skia from c634411c51e6 to f0653c4a2df5 (1 revision) (flutter/engine#46716)
2023-10-10 30870216+gaaclarke@users.noreply.github.com [Impeller] made window size parametric in playground/golden tests (flutter/engine#46682)
2023-10-10 skia-flutter-autoroll@skia.org Roll Skia from c497dae2fedb to c634411c51e6 (1 revision) (flutter/engine#46714)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

38a7d9d1

TimePickerDialog should dispose created ChangeNotifiers. (#136261) · 0a694704
Kostia Sokolovskyi authored Oct 10, 2023

0a694704

Delete simulator after plugin_test_ios (#136265) · e8bd5a32

Victoria Ashworth authored Oct 10, 2023

Remove simulator once it's no longer needed for test `plugin_test_ios` .

Fixes https://github.com/flutter/flutter/issues/136224

e8bd5a32