1. 15 Jun, 2018 1 commit
  2. 13 Jun, 2018 1 commit
    • Chris Bracken's avatar
      Revert elimination of Dart 1 (#18460) · 2ae48845
      Chris Bracken authored
      fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
      from source, flutter_platform.dart automatically runs a kernel compile when
      operating in Dart 2 mode, but this assumes a functional Dart SDK is available
      in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
      directory with an empty temp dir.
      
      Remaining work is:
      1. Get the frontend server building as a dependency on Fuchsia.
      2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.
      
      This also reverts migration to Dart 2 typedef syntax.
      
      This reverts commit 6c56bb24. (#18362)
      This reverts commit 3daebd05. (#18316)
      2ae48845
  3. 11 Jun, 2018 1 commit
    • Greg Spencer's avatar
      Update typedef syntax to use Function notation and turn on lint for old notation. (#18362) · 6c56bb24
      Greg Spencer authored
      Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax.
      
      Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml.
      
      No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
      6c56bb24
  4. 05 Jun, 2018 1 commit
  5. 30 May, 2018 2 commits
  6. 22 May, 2018 1 commit
  7. 04 May, 2018 1 commit
  8. 23 Apr, 2018 1 commit
    • Yegor's avatar
      a11y traversal: sort locally; use new sorting algorithm (#16253) · d3540962
      Yegor authored
      New a11y traversal:
      
      - sort direct sibling SemanticsNodes only
      - use new sorting algorithm
      - implement RTL
      - test semantics in traversal order by default
      - add AppBar traversal test
      - breaking: remove nextNodeId/previousNodeId from the framework
      - breaking: remove DebugSemanticsDumpOrder.geometricOrder
      d3540962
  9. 21 Apr, 2018 1 commit
  10. 20 Apr, 2018 1 commit
  11. 22 Mar, 2018 1 commit
    • Ian Hickson's avatar
      Clean up the existing Navigator API. (#15718) · aba0379d
      Ian Hickson authored
      This is not a grand refactor yet, it's just cleaning up what we have
      already, so that people who keep using this API (e.g. dialogs) have
      something coherent to deal with.
      
      The major changes are that Navigator and NavigatorState have the same
      API now, that most of the examples use `<void>` instead of `<Null>`,
      that the navigator observer can see replaces, and that the `settings`
      is moved from ModalRoute to Route. I also cleaned up some of the API
      documentation.
      aba0379d
  12. 20 Mar, 2018 2 commits
  13. 19 Mar, 2018 1 commit
    • Yegor's avatar
      a11y: remove SemanticsSortOrder; sort locally only; semanticsOwner post-test check (#15537) · 9c49255f
      Yegor authored
      * a11y: remove SemanticsSortOrder; sort locally only; semanticsOwner post-test check
      
      * update accessibility test framework
      
      - default nextNodeId/previousNodeId to -1
      - stop treating null as opt-out from value testing
      - add `id`, `TestSemantics.root`, and `tags` to the suggested code in the TestSemantics failure message
      - fix a small bug with raw string escaping
      - update all tests accordingly
      
      * fix sortKey doc
      
      * prefer const over final
      9c49255f
  14. 09 Mar, 2018 2 commits
  15. 07 Mar, 2018 1 commit
    • Josh Soref's avatar
      Spelling (#15229) · c5a5945e
      Josh Soref authored
      * spelling: accommodate
      
      * spelling: allotted
      
      * spelling: anonymous
      
      * spelling: artificial
      
      * spelling: associated
      
      * spelling: asset
      
      * spelling: button
      
      * spelling: canvas
      
      * spelling: compatibility
      
      * spelling: coverage
      
      * spelling: condition
      
      * spelling: decoration
      
      * spelling: deferring
      
      * spelling: diameter
      
      * spelling: direction
      
      * spelling: displacement
      
      * spelling: dropdown
      
      * spelling: needing
      
      * spelling: environment
      
      * spelling: exited
      
      * spelling: expansion
      
      * spelling: explore
      
      * spelling: families
      
      * spelling: horizontal
      
      * spelling: increment
      
      * spelling: indices
      
      * spelling: internationalization
      
      * spelling: labrador
      
      * spelling: localizations
      
      * spelling: midflight
      
      * spelling: milliseconds
      
      * spelling: minimum
      
      * spelling: multiple
      
      * spelling: multiplication
      
      * spelling: navigator
      
      * spelling: overridden
      
      * spelling: package
      
      * spelling: performance
      
      * spelling: platform
      
      * spelling: porsche
      
      * spelling: position
      
      * spelling: preceded
      
      * spelling: precede
      
      * spelling: precedence
      
      * spelling: print
      
      * spelling: property
      
      * spelling: readily
      
      * spelling: reproducibility
      
      * spelling: rounded
      
      * spelling: scroll
      
      * spelling: separate
      
      * spelling: separator
      
      * spelling: services
      
      * spelling: specific
      
      * spelling: specify
      
      * spelling: synchronously
      
      * spelling: through
      
      * spelling: timeout
      
      * spelling: triangle
      
      * spelling: trivial
      
      * spelling: unusual
      
      * spelling: then
      
      * spelling: vertically
      
      * spelling: visible
      
      * spelling: visited
      
      * spelling: voice
      c5a5945e
  16. 06 Mar, 2018 1 commit
  17. 15 Feb, 2018 1 commit
  18. 14 Feb, 2018 3 commits
  19. 13 Feb, 2018 1 commit
    • Greg Spencer's avatar
      Move geometric sort for semantics to the framework side. (#14539) · 7be0bd1c
      Greg Spencer authored
      This adds geometric sort ordering back in for semantics nodes that don't have a sort order defined.
      
      With this change, widgets that either have no sort order, or have an equivalent sort order, will be compared geometrically. The comparison is between the two starting corners, so it is TextDirection-aware: parent nodes that are set to have LTR text will compare upper left corners of their children, and upper right when set to RTL.
      
      Also fixed a bug in the Transform widget that didn't mark modified nodes as needing a semantics update.
      7be0bd1c
  20. 12 Feb, 2018 1 commit
    • Greg Spencer's avatar
      Swap nextNodeId for previousNodeId, since setTraversalBefore is broken. (#14607) · bfc68334
      Greg Spencer authored
      It seems that setTraversalBefore doesn't work as well as setTraversalAfter for some reason, although I'm using them the same way. Some apps would lock up TalkBack when traversing if setTraversalBefore was set, but not with the equivalent setTraversalAfter.
      
      It's not entirely clear why this is, but I'm going with this to at least get it fixed for apps we know about.
      
      Fixes #14600
      bfc68334
  21. 10 Feb, 2018 2 commits
  22. 06 Feb, 2018 1 commit
    • Greg Spencer's avatar
      Adds the semantic node traversal API. (#14060) · 14309b93
      Greg Spencer authored
      This adds an API for defining the semantic node traversal order.
      
      It adds a sortOrder argument to the Semantics widget, which is a class that can define a list of sort keys to sort on. The keys are sorted globally so that an order that doesn't have to do with the current widget hierarchy may be defined.
      
      It also adds a shortcut sortKey argument to the Semantics widget that simply sets the sortOrder to just contain that key.
      
      The platform side (flutter/engine#4540) gets an additional member in the SemanticsData object that is an integer describing where in the overall order each semantics node belongs. There is an associated engine-side change that takes this integer and uses it to order widgets for the platform's accessibility services.
      14309b93
  23. 02 Feb, 2018 1 commit
  24. 26 Jan, 2018 2 commits
  25. 25 Jan, 2018 1 commit
  26. 17 Jan, 2018 2 commits
  27. 16 Jan, 2018 1 commit
  28. 09 Jan, 2018 2 commits
  29. 05 Jan, 2018 1 commit
  30. 13 Dec, 2017 1 commit
  31. 08 Dec, 2017 1 commit
    • Yegor's avatar
      Make time picker accessible (#13152) · b80751cd
      Yegor authored
      * make time picker accessible
      
      * use new CustomPaint a11y API
      
      * flutter_localizations tests; use bigger distance delta
      
      * fix am/pm control; selected values
      
      * fix translations; remove @mustCallSuper in describeSemanticsConfiguration
      
      * exclude AM/PM announcement from iOS as on iOS the label is read back automatically
      b80751cd