- 15 Jun, 2018 1 commit
-
-
Jonah Williams authored
-
- 13 Jun, 2018 1 commit
-
-
Chris Bracken authored
fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly from source, flutter_platform.dart automatically runs a kernel compile when operating in Dart 2 mode, but this assumes a functional Dart SDK is available in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts directory with an empty temp dir. Remaining work is: 1. Get the frontend server building as a dependency on Fuchsia. 2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server. This also reverts migration to Dart 2 typedef syntax. This reverts commit 6c56bb24. (#18362) This reverts commit 3daebd05. (#18316)
-
- 11 Jun, 2018 1 commit
-
-
Greg Spencer authored
Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax. Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml. No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
-
- 05 Jun, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 30 May, 2018 2 commits
-
-
Greg Spencer authored
Revert "Update typedef syntax to use Function notation and turn on lint for old notation. (#18035)" (#18041) This reverts commit 32586020.
-
Greg Spencer authored
Fixes #18028 Just changes typedef declarations, no logic changes.
-
- 22 May, 2018 1 commit
-
-
Yegor authored
* pass semantics children in traversal and hit test orders * explain why we are inverting _children * Roll engine
-
- 04 May, 2018 1 commit
-
-
Michael Goderbauer authored
-
- 23 Apr, 2018 1 commit
-
-
Yegor authored
New a11y traversal: - sort direct sibling SemanticsNodes only - use new sorting algorithm - implement RTL - test semantics in traversal order by default - add AppBar traversal test - breaking: remove nextNodeId/previousNodeId from the framework - breaking: remove DebugSemanticsDumpOrder.geometricOrder
-
- 21 Apr, 2018 1 commit
-
-
Michael Goderbauer authored
-
- 20 Apr, 2018 1 commit
-
-
Jonah Williams authored
Semantics object support for edge triggered semantics
-
- 22 Mar, 2018 1 commit
-
-
Ian Hickson authored
This is not a grand refactor yet, it's just cleaning up what we have already, so that people who keep using this API (e.g. dialogs) have something coherent to deal with. The major changes are that Navigator and NavigatorState have the same API now, that most of the examples use `<void>` instead of `<Null>`, that the navigator observer can see replaces, and that the `settings` is moved from ModalRoute to Route. I also cleaned up some of the API documentation.
-
- 20 Mar, 2018 2 commits
-
-
Alexandre Ardhuin authored
-
Michael Goderbauer authored
* Support password fields for a11y * rename to obscured * Roll engine to c3ab0c9143029f0267a05b99effbfbd280a4901b
-
- 19 Mar, 2018 1 commit
-
-
Yegor authored
* a11y: remove SemanticsSortOrder; sort locally only; semanticsOwner post-test check * update accessibility test framework - default nextNodeId/previousNodeId to -1 - stop treating null as opt-out from value testing - add `id`, `TestSemantics.root`, and `tags` to the suggested code in the TestSemantics failure message - fix a small bug with raw string escaping - update all tests accordingly * fix sortKey doc * prefer const over final
-
- 09 Mar, 2018 2 commits
-
-
Michael Goderbauer authored
-
Michael Goderbauer authored
-
- 07 Mar, 2018 1 commit
-
-
Josh Soref authored
* spelling: accommodate * spelling: allotted * spelling: anonymous * spelling: artificial * spelling: associated * spelling: asset * spelling: button * spelling: canvas * spelling: compatibility * spelling: coverage * spelling: condition * spelling: decoration * spelling: deferring * spelling: diameter * spelling: direction * spelling: displacement * spelling: dropdown * spelling: needing * spelling: environment * spelling: exited * spelling: expansion * spelling: explore * spelling: families * spelling: horizontal * spelling: increment * spelling: indices * spelling: internationalization * spelling: labrador * spelling: localizations * spelling: midflight * spelling: milliseconds * spelling: minimum * spelling: multiple * spelling: multiplication * spelling: navigator * spelling: overridden * spelling: package * spelling: performance * spelling: platform * spelling: porsche * spelling: position * spelling: preceded * spelling: precede * spelling: precedence * spelling: print * spelling: property * spelling: readily * spelling: reproducibility * spelling: rounded * spelling: scroll * spelling: separate * spelling: separator * spelling: services * spelling: specific * spelling: specify * spelling: synchronously * spelling: through * spelling: timeout * spelling: triangle * spelling: trivial * spelling: unusual * spelling: then * spelling: vertically * spelling: visible * spelling: visited * spelling: voice
-
- 06 Mar, 2018 1 commit
-
-
Yegor authored
* [semantics]: minor docs & style clean-up * remove a
-
- 15 Feb, 2018 1 commit
-
-
Ian Hickson authored
-
- 14 Feb, 2018 3 commits
-
-
Todd Volkert authored
Re-apply "Send nextId in addition to previousId for traversal order (#14676)"
-
Todd Volkert authored
-
Michael Goderbauer authored
-
- 13 Feb, 2018 1 commit
-
-
Greg Spencer authored
This adds geometric sort ordering back in for semantics nodes that don't have a sort order defined. With this change, widgets that either have no sort order, or have an equivalent sort order, will be compared geometrically. The comparison is between the two starting corners, so it is TextDirection-aware: parent nodes that are set to have LTR text will compare upper left corners of their children, and upper right when set to RTL. Also fixed a bug in the Transform widget that didn't mark modified nodes as needing a semantics update.
-
- 12 Feb, 2018 1 commit
-
-
Greg Spencer authored
It seems that setTraversalBefore doesn't work as well as setTraversalAfter for some reason, although I'm using them the same way. Some apps would lock up TalkBack when traversing if setTraversalBefore was set, but not with the equivalent setTraversalAfter. It's not entirely clear why this is, but I'm going with this to at least get it fixed for apps we know about. Fixes #14600
-
- 10 Feb, 2018 2 commits
-
-
Michael Goderbauer authored
-
Michael Goderbauer authored
-
- 06 Feb, 2018 1 commit
-
-
Greg Spencer authored
This adds an API for defining the semantic node traversal order. It adds a sortOrder argument to the Semantics widget, which is a class that can define a list of sort keys to sort on. The keys are sorted globally so that an order that doesn't have to do with the current widget hierarchy may be defined. It also adds a shortcut sortKey argument to the Semantics widget that simply sets the sortOrder to just contain that key. The platform side (flutter/engine#4540) gets an additional member in the SemanticsData object that is an integer describing where in the overall order each semantics node belongs. There is an associated engine-side change that takes this integer and uses it to order widgets for the platform's accessibility services.
-
- 02 Feb, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 26 Jan, 2018 2 commits
-
-
Michael Goderbauer authored
* Roll engine to 6921873c71e700235c0f68f0359be2332f93c8bc
-
Michael Goderbauer authored
Roll engine to 7c34dfafc9acece1a9438f206bfbb0a9bedba3bf
-
- 25 Jan, 2018 1 commit
-
-
Michael Goderbauer authored
Framework side for https://github.com/flutter/engine/pull/4584 & https://github.com/flutter/engine/pull/4587. Also rolls engine to 4c82c566edf394a5cfc237a266aea5bd37a6c172.
-
- 17 Jan, 2018 2 commits
-
-
Michael Goderbauer authored
* Identify CHeckBox and RadioButton as such * review feedback
-
Michael Goderbauer authored
* Document Android's SemanticsAction.tap behavior Fixes https://github.com/flutter/flutter/issues/13219. * review comment
-
- 16 Jan, 2018 1 commit
-
-
Michael Goderbauer authored
-
- 09 Jan, 2018 2 commits
-
-
Michael Goderbauer authored
`RenderSemanticsGestureHandler` is no longer a semantics boundary, which allows us to correctly mark disabled buttons as disabled without having their semantics size and semantics node id change unexpectedly. Fixes https://github.com/flutter/flutter/issues/12589. Fixes https://github.com/flutter/flutter/issues/11991. See also https://github.com/flutter/flutter/issues/11993. This change also required some refactoring to how we deal with `twoPaneSemantics` scrolling as it previously relied on `RenderSemanticsGestureHandler` being a semantics boundary. This should also make the underlying logic easier to understand. In addition, the following minor changes are included in this PR: * Removal of orphaned and unused `SemanticsConfiguration.isMergingDescendantsIntoOneNode`. * Logic optimizations for `markNeedsSemanticsUpdate` . * Fix for edge case where `MergeSemantics` failed to merge semantics. * Use of emojis to better indicate leaf merging in the printed semantics tree. * Better assert message for adding invisible child semantics nodes. * Make some semantics tests robuster by not relying on creation order of SemanticsNode ids across test boundaries. Fixes https://github.com/flutter/flutter/issues/13943.
-
Michael Goderbauer authored
to align with `SemanticsAction` and other enum-like types.
-
- 05 Jan, 2018 1 commit
-
-
- 13 Dec, 2017 1 commit
-
-
Michael Goderbauer authored
**This PR contains a breaking API change:** `SemanticsConfiguration.addAction()` has been removed and replaces by action-specific setters (`onTap`, `onLongPress`, etc.) to take care of the fact that some action handlers (those, who take arguments) have different signatures.
-
- 08 Dec, 2017 1 commit
-
-
Yegor authored
* make time picker accessible * use new CustomPaint a11y API * flutter_localizations tests; use bigger distance delta * fix am/pm control; selected values * fix translations; remove @mustCallSuper in describeSemanticsConfiguration * exclude AM/PM announcement from iOS as on iOS the label is read back automatically
-