- 16 Aug, 2021 2 commits
-
-
Swiftaxe authored
Co-authored-by: Alexander Dahlberg <alexander.dahlberg@sigma.se> The TapGestureRecognizer in the test named 'TapGestureRecognizer _sentTapDown toString' was not disposed, which was breaking a couple of other tests. This worked fine when not shuffling the tests as the test was executed last.
-
Swiftaxe authored
Co-authored-by: Alexander Dahlberg <alexander.dahlberg@sigma.se> Fixes test/animation/animation_controller_test.dart in #85160 Problem: The test 'animateTo can deal with duration == Duration.Zero' was failing with the following error: Expected: <0> Actual: <5> Expected no animation. package:test_api expect package:flutter_test/src/widget_tester.dart 484:3 expect test/animation/animation_controller_test.dart 511:5 main. Following line finds 5 transientCallbacks scheduled, while expecting zero, if shuffled with seed 123: expect(SchedulerBinding.instance!.transientCallbackCount, equals(0), reason: 'Expected no animation.'); This is caused by some other test leaving transientCallbacks scheduled. Fix: By disposing the AnimationController after each test, the transientCallbacks get cleaned up. I chose to dispose all controllers in every test, to make sure there is no risk of leaks.
-
- 15 Aug, 2021 2 commits
-
-
engine-flutter-autoroll authored
99c5f6139 Move test packages from `dependencies` to `dev_dependencies` (flutter/plugins#4231) (#88244)
-
Pierre-Louis authored
* Improved update_icons.dart * Handle _ * Update dartdoc * Rename function * formatting * fix type * Refactor ID generation * rename * cleanup * update comment * replace typedef with type
-
- 14 Aug, 2021 11 commits
-
-
engine-flutter-autoroll authored
* c388bfab7 Roll Skia from 1049d8206120 to abe39f5cb932 (6 revisions) (flutter/engine#28090) * 5ba9ed516 [web] Clean up legacy Paragraph implementation (flutter/engine#28050) * b1ccc4175 Revert "Sets focus before sending a11y focus event in Android (#27992)" (flutter/engine#28092) * 1af0a2079 Roll Fuchsia Linux SDK from WoiEzs7XB... to 54i7Z2kLS... (flutter/engine#28093)
-
engine-flutter-autoroll authored
-
engine-flutter-autoroll authored
-
Zachary Anderson authored
This reverts commit bfe47591.
-
engine-flutter-autoroll authored
-
engine-flutter-autoroll authored
-
LongCatIsLooong authored
Revert "[EditableText] call `onSelectionChanged` only when there're actual selection/cause changes (#87971)" (#88183)
-
yusufm authored
* Adding a timeout and retry to upload results step. * Adding tests for retries and timeout. * Adding async to call * Fixing sleep to trigger the timeout, and adding addition timeout test. * Fixing minor typo. * Fixing some minor flutter style issues. * Adding vs_build dependency to Windows hot_mode_dev_cycle_win_target__benchmark Co-authored-by: yusufm <mohsinally@google.com>
-
Zachary Anderson authored
-
Jenn Magder authored
-
Abhishek Ghaskata authored
-
- 13 Aug, 2021 9 commits
-
-
Michael Goderbauer authored
This reverts commit 91e0759b.
-
Emmanuel Garcia authored
-
engine-flutter-autoroll authored
-
zuvola authored
Moving the focus with the tab key on the external keyboard will move the focus to the widget that is hidden by AnimatedCrossFade.
-
嘟囔 authored
-
Justin McCandless authored
Corrects the exact definition in code and docs of ScaleUpDetails delta.
-
Greg Spencer authored
-
chunhtai authored
-
LongCatIsLooong authored
-
- 12 Aug, 2021 16 commits
-
-
Michael Goderbauer authored
-
keyonghan authored
-
Anurag Roy authored
-
Ian Hickson authored
-
Zachary Anderson authored
-
Ahmed Ashour authored
-
engine-flutter-autoroll authored
-
engine-flutter-autoroll authored
-
Jenn Magder authored
-
Jenn Magder authored
-
engine-flutter-autoroll authored
-
嘟囔 authored
-
Justin McCandless authored
Support for more desktop keyboard keys/shortcuts.
-
嘟囔 authored
-
Greg Spencer authored
Switch document generation to use the snippets package instead of the snippets code in the Flutter repo. In the process, some bugs in sample code analysis have been fixed, and I've fixed some more errors in the samples. This will allow the snippets package to be developed separately from the Flutter repo, and reduce the code in the Flutter repo. The snippets code is deleted in this PR. I also converted some comments in the snippet templates to be regular comments instead of doc comments, because having a doc comment block before the imports causes the Dart import sorter to lose the comment. They should have been regular comments in the first place. The snippets package resides in the assets-for-api-docs repo. The sample analysis has also been converted to be run in parallel, and I've bumped the Dartdoc version to 1.0.2.
-
engine-flutter-autoroll authored
-