1. 05 Jun, 2024 3 commits
    • flutteractionsbot's avatar
      [CP-stable] Add frame number and widget location map service extension (#149345) · e3f15a5b
      flutteractionsbot authored
      This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/wiki/Flutter-Cherrypick-Process#automatically-creates-a-cherry-pick-request)
      Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
      
      ### Issue Link:
      What is the link to the issue this cherry-pick is addressing?
      
      DevTools release 2.36.0: https://dart-review.googlesource.com/c/sdk/+/368762
      
      ### Changelog Description:
      
      This change adds a service extension that DevTools uses to support a "Track widget build counts" feature. This feature is first included in DevTools 2.36.0.
      
      ### Impact Description:
      
      This service extension is required for DevTools 2.36.0, which needs to be [cherry-picked](https://dart-review.googlesource.com/c/sdk/+/368762) into the Dart SDK. This beta release of DevTools missed the code cutoff because we were targeting the date listed on go/dash-team-releases (5/29). Since the beta release went out early, we missed the cut off and need to cherry-pick.
      
      Since this DevTools release depended on the changes from https://github.com/flutter/flutter/pull/148702, we also need to cherry pick those changes into the flutter beta channel.
      
      ### Workaround:
      No. This is required for DevTools 2.36.0 to work properly: https://dart-review.googlesource.com/c/sdk/+/368762.
      
      ### Risk:
      What is the risk level of this cherry-pick?
      
      ### Test Coverage:
      Are you confident that your fix is well-tested by automated tests?
      
      ### Validation Steps:
      What are the steps to validate that this fix works?
      
      With this change, a flutter app connecting to DevTools 2.36.0 (already on the Dart SDK main branch and trying to CP into the Dart SDK beta branch) will be able to use the "Track widget build counts" feature in DevTools.
      e3f15a5b
    • Kevin Chisholm's avatar
      [flutter_releases] Flutter stable 3.22.2 Framework Cherrypicks (#149752) · 95ad5b54
      Kevin Chisholm authored
      # Flutter stable 3.22.2 Framework
      95ad5b54
    • LongCatIsLooong's avatar
      [CP-stable] Remove `TextEditingController` private member access (#149042) (#149208) · 071635b4
      LongCatIsLooong authored
      Manual request (merge conflicts in the test file) for cherry-picking #149042 to stable
      
      ### Issue Link:
      What is the link to the issue this cherry-pick is addressing?
      
      #148692 
      
      ### Changelog Description:
      Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/wiki/Hotfix-Documentation-Best-Practices) for examples
      
      Fixes an `EditableText` crash that happens with a custom `TextEditingController` which only `implements` the `TextEditingController` interface.
      
      ### Impact Description:
      What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
      
      Production apps crash if the user gives an `EditableText` a custom `TextEditingControllor` class that `implements TextEditingControllor`.
      
      ### Workaround:
      Is there a workaround for this issue?
      
      The crash does not happen if the user `extends TextEditingControllor`, but it's not always desirable / feasible. The class could be already extending a different base class.
      
      ### Risk:
      What is the risk level of this cherry-pick?
      
      ### Test Coverage:
      Are you confident that your fix is well-tested by automated tests?
      
      ### Validation Steps:
      What are the steps to validate that this fix works?
      
      Run the test in the PR, or follow the repro steps in https://github.com/flutter/flutter/issues/148692
      071635b4
  2. 04 Jun, 2024 1 commit
    • flutteractionsbot's avatar
      [CP-stable]Enhance ColorScheme.fromSeed with a new `variant` parameter (#148916) · 2ac7536e
      flutteractionsbot authored
      This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/wiki/Flutter-Cherrypick-Process#automatically-creates-a-cherry-pick-request)
      Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
      
      ### Issue Link:
      What is the link to the issue this cherry-pick is addressing?
      
      https://github.com/flutter/flutter/issues/148359
      
      ### Changelog Description:
      Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/wiki/Hotfix-Documentation-Best-Practices) for examples
      
      Provide an option in `ColorScheme.fromSeed` method to respect the seed color even if the seed color is very bright.
      
      ### Impact Description:
      What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
      
      The updated algorithm in `ColorScheme.fromSeed` creates a darker version of `ColorScheme`. This may result in apps looking different from their original color theme.
      
      ### Workaround:
      Is there a workaround for this issue?
      
      Manually construct a desired `ColorScheme` instead of using `ColorScheme.fromSeed`, or use the deprecated `Scheme` class in [MCU package](https://github.com/material-foundation/material-color-utilities/blob/main/dart/lib/scheme/scheme.dart) to build the `ColorScheme`
      
      ### Risk:
      What is the risk level of this cherry-pick?
      
      This cherry-pick does not break the current implementation but only provides an option if users want the `ColorScheme` built by `ColorScheme.fromSeed` respect the seed color.
      
      ### Test Coverage:
      Are you confident that your fix is well-tested by automated tests?
      
      ### Validation Steps:
      What are the steps to validate that this fix works?
      
      With `dynamicSchemeVariant: DynamicSchemeVariant.fidelity`, the color scheme constructed by `ColorScheme.fromSeed()` respects the seed color.
      2ac7536e
  3. 31 May, 2024 1 commit
  4. 22 May, 2024 2 commits
  5. 21 May, 2024 1 commit
  6. 09 May, 2024 1 commit
  7. 24 Apr, 2024 1 commit
  8. 19 Apr, 2024 3 commits
  9. 17 Apr, 2024 1 commit
  10. 16 Apr, 2024 1 commit
    • flutteractionsbot's avatar
      [CP-beta]Fix `getOffsetForCaret` crash (#146813) · 40f3a794
      flutteractionsbot authored
      This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/wiki/Flutter-Cherrypick-Process#automatically-creates-a-cherry-pick-request)
      Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
      
      ### Issue Link:
      What is the link to the issue this cherry-pick is addressing?
      
      b/333560406. Couldn't find a github issue for it
      
      ### Changelog Description:
      Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/wiki/Hotfix-Documentation-Best-Practices) for examples
      
      Fixes a crash that may happen when the user enters certain characters in a text field.
      
      ### Impact Description:
      What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
      
      Production apps crash when the user enters certain characters in certain conditions.
      
      b/333560406 has some related stats.
      
      ### Workaround:
      Is there a workaround for this issue?
      
      No
      
      ### Risk:
      What is the risk level of this cherry-pick?
      
      ### Test Coverage:
      Are you confident that your fix is well-tested by automated tests?
      
      ### Validation Steps:
      What are the steps to validate that this fix works?
      
      Run the test in the PR. The issue didn't come with a real world repro.
      40f3a794
  11. 08 Apr, 2024 2 commits
  12. 04 Apr, 2024 1 commit
  13. 03 Apr, 2024 1 commit
  14. 28 Mar, 2024 14 commits
  15. 27 Mar, 2024 7 commits