1. 08 Mar, 2021 1 commit
  2. 06 Mar, 2021 1 commit
  3. 04 Mar, 2021 1 commit
  4. 27 Feb, 2021 1 commit
  5. 16 Feb, 2021 1 commit
  6. 12 Feb, 2021 1 commit
    • Nathan Walker's avatar
      ListTile Material Ripple and Shape Patch (#74373) · 422916d2
      Nathan Walker authored
      This PR replaces the ColoredBox that ListTile uses with an Ink widget. That Ink widget is given a ShapeDecoration with the ListTile's color and shape. This fixes issues where the ListTile color would obscure material ripple effects, and cause the specified shape to not be respected.
      422916d2
  7. 09 Feb, 2021 1 commit
  8. 04 Feb, 2021 1 commit
  9. 27 Jan, 2021 1 commit
  10. 20 Jan, 2021 2 commits
    • Greg Spencer's avatar
      Revert "ListTile Material Ripple and Shape Patch (#73618)" (#74335) · 2e3d3e65
      Greg Spencer authored
      This reverts commit 024c49da because it breaks Google internal tests.
      2e3d3e65
    • Nathan Walker's avatar
      ListTile Material Ripple and Shape Patch (#73618) · 024c49da
      Nathan Walker authored
      This PR replaces the ColoredBox that ListTile uses with an Ink widget. That Ink widget is given a ShapeDecoration with the ListTile's color and shape. This fixes issues where the ListTile color would obscure material ripple effects, and cause the specified shape to not be respected.
      
      List which issues are fixed by this PR. You must list at least one issue.
      
      Fixes #73616
      Fixes #63877
      Fixes #67117
      
      If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
      
      I modified a handful of tests related to ListTiles. The tests I changed had implementation-specific ways of checking the ListTile color. I have rewritten those so that instead of checking for a ColoredBox with a specific color, they check that a path is painted with the correct color.
      
      I added the following tests to list_tile_test.dart:
      
      "ListTile shows Material ripple effects on top of tileColor" (Regression test for #73616)
      "ListTile shape is painted correctly" (Regression test for #63877)
      I added the following test to sliver_prototype_item_extent_test.dart:
      
      "SliverPrototypeExtentList prototypeItem paint transform is zero" (Regression test for #67117)
      024c49da
  11. 14 Jan, 2021 1 commit
  12. 10 Nov, 2020 1 commit
  13. 07 Nov, 2020 1 commit
  14. 06 Nov, 2020 1 commit
  15. 05 Nov, 2020 1 commit
  16. 02 Nov, 2020 1 commit
  17. 29 Oct, 2020 1 commit
  18. 12 Oct, 2020 2 commits
  19. 15 Jul, 2020 1 commit
  20. 14 Jul, 2020 1 commit
  21. 05 Jul, 2020 1 commit
  22. 11 Jun, 2020 2 commits
  23. 04 Jun, 2020 1 commit
  24. 28 May, 2020 1 commit
  25. 22 Apr, 2020 1 commit
  26. 10 Apr, 2020 1 commit
  27. 07 Apr, 2020 1 commit
    • EricEnslen's avatar
      Allow ListTiles to be autofocused (#54229) · cccfe96e
      EricEnslen authored
      Adds an "autofocus" param to ListTile and its Checkbox, Radio and Switch variants, and passes the given value through to the wrapped InkWell, Switch, etc.
      
      This is important for scenarios like a settings screen, where the first interactable element on a page may be a SwitchListTile, for example.
      cccfe96e
  28. 27 Nov, 2019 1 commit
    • Ian Hickson's avatar
      License update (#45373) · 449f4a66
      Ian Hickson authored
      * Update project.pbxproj files to say Flutter rather than Chromium
      
      Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
      
      * Update the copyright notice checker to require a standard notice on all files
      
      * Update copyrights on Dart files. (This was a mechanical commit.)
      
      * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
      
      Some were already marked "The Flutter Authors", not clear why. Their
      dates have been normalized. Some were missing the blank line after the
      license. Some were randomly different in trivial ways for no apparent
      reason (e.g. missing the trailing period).
      
      * Clean up the copyrights in non-Dart files. (Manual edits.)
      
      Also, make sure templates don't have copyrights.
      
      * Fix some more ORGANIZATIONNAMEs
      449f4a66
  29. 31 Oct, 2019 1 commit
    • Greg Spencer's avatar
      Don't allow Disabled InkWells to be focusable (#43848) · 0028887a
      Greg Spencer authored
      Makes sure that disabled InkWell/InkResponse and widgets that use them don't allow themselves to be focused.
      
      ListTile, PopupMenu, and Stepper were not setting canRequestFocus properly on the InkWell, and InkWell was allowing focus even if it was disabled (it was basically just relying on the containing widget to set canRequestFocus properly). Now InkWell must both be enabled (have an onTap or similar) and have canRequestFocus set to true.
      0028887a
  30. 10 Oct, 2019 1 commit
    • Greg Spencer's avatar
      Re-land keyboard traversal PRs (#42278) · ce150971
      Greg Spencer authored
      This attempts to reland #40186 and #41220, that were reverted in #41945.
      
      The main modifications from the original PRs are that I predefine the shortcuts and actions maps instead of defining them inline in the build function, and I use a new mapEquals to do a deep comparison so that we don't rebuild modified things if the contents of the map haven't changed.
      
      I also eliminated an operator== and hashCode that were defined on the Actions widget, since widgets shouldn't have those. (it's too bad though: I get an 85% speedup if we leave this in! Too bad it prevents rebuilding of the children...)
      
      Fixes #40101
      ce150971
  31. 30 Sep, 2019 1 commit
  32. 13 Jun, 2019 1 commit
  33. 29 Apr, 2019 1 commit
  34. 29 Mar, 2019 1 commit
  35. 01 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      Add missing trailing commas (#28673) · 387f8854
      Alexandre Ardhuin authored
      * add trailing commas on list/map/parameters
      
      * add trailing commas on Invocation with nb of arg>1
      
      * add commas for widget containing widgets
      
      * add trailing commas if instantiation contains trailing comma
      
      * revert bad change
      387f8854
  36. 19 Jan, 2019 1 commit
  37. 14 Jan, 2019 1 commit