- 29 Nov, 2023 2 commits
-
-
Kate Lovett authored
This updates the implementation to use the stopwatch from the Clock object and pipes it through to the TestWidgetsFlutterBinding so it will be kept in sync with FakeAsync. Relands https://github.com/flutter/flutter/pull/138843 attempted to reland https://github.com/flutter/flutter/pull/137381 which attempted to reland #132291 Fixes https://github.com/flutter/flutter/issues/97761 1. The original change was reverted due to flakiness it introduced in tests that use fling gestures. * Using a mocked clock through the test binding fixes this now 2. It was reverted a second time because a change at tip of tree broke it, exposing memory leaks, but it was not rebased before landing. * These leaks are now fixed 3. It was reverted a third time, because we were so excellently quick to revert those other times, that we did not notice the broken benchmark that only runs in postsubmit. * The benchmark is now fixed
-
Kate Lovett authored
-
- 22 Nov, 2023 1 commit
-
-
Jackson Gardner authored
Reverts flutter/flutter#138843 This has broken the Mac_ios microbenchmarks_ios. Example failure: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20microbenchmarks_ios/9339/overview
-
- 21 Nov, 2023 1 commit
-
-
Kate Lovett authored
This updates the implementation to use the stopwatch from the Clock object and piping it through to the TestWidgetsFlutterBinding so it will be kept in sync with FakeAsync. Relands https://github.com/flutter/flutter/pull/137381 which attempted to reland #132291 Fixes https://github.com/flutter/flutter/issues/97761 The original change was reverted due to flakiness it introduced in tests that use fling gestures. * https://github.com/flutter/flutter/issues/135728 It was reverted again due to a change in the leak tracking tests that broke it.
-
- 15 Nov, 2023 2 commits
-
-
auto-submit[bot] authored
Reverts flutter/flutter#137381 Initiated by: Piinks This change reverts the following previous change: Original Description: This updates the implementation to use the stopwatch from the Clock object and piping it through to the TestWidgetsFlutterBinding so it will be kept in sync with FakeAsync. Relands #132291 Fixes https://github.com/flutter/flutter/issues/97761 The change was reverted due to flakiness it introduced in tests that use fling gestures. * https://github.com/flutter/flutter/issues/135728
-
Kate Lovett authored
This updates the implementation to use the stopwatch from the Clock object and piping it through to the TestWidgetsFlutterBinding so it will be kept in sync with FakeAsync. Relands #132291 Fixes https://github.com/flutter/flutter/issues/97761 The change was reverted due to flakiness it introduced in tests that use fling gestures. * https://github.com/flutter/flutter/issues/135728
-
- 22 Oct, 2023 1 commit
-
-
Todd Volkert authored
Before this change, long-running post-frame callbacks wouldn't show up in the timeline at all. This adds a timeline event for post-frame callbacks, with a debug flag that will add timeline events for each individual callback. #testexempt -- we have no way to test calls to the timeline.
-
- 09 Jun, 2023 1 commit
-
-
Tong Mu authored
This is a refactor to make `MouseTracker` use the same callback for both kinds of device update. Instead of using two different callbacks for the two device updating methods, `MouseTracker` now receives a hit testing callback at construction, which is the same hit testing method as the one used for other gestures. This PR not only makes the code cleaner, but also removes the single view assumption from `MouseTracker`, whose code no longer refers to `RendererBinding.renderView`. In the future, we only need to modify `hitTest` (which we will have to do to support gestures for multi-view anyway) to make mouse tracker support multi-view.
-
- 08 Jun, 2023 1 commit
-
-
Michael Goderbauer authored
Follow-up to https://github.com/flutter/flutter/pull/128287.
-
- 07 Jun, 2023 1 commit
-
-
Michael Goderbauer authored
Follow-up to https://github.com/flutter/engine/pull/42493.
-
- 15 Mar, 2023 1 commit
-
-
Michael Goderbauer authored
Remove last few references to window singleton
-
- 01 Feb, 2023 1 commit
-
-
Ian Hickson authored
-
- 31 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 23 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 19 Aug, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 24 Jun, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 17 Jun, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 25 May, 2022 2 commits
-
-
Pierre-Louis authored
Use `curly_braces_in_flow_control_structures` for `foundation`, `gestures`, `painting`, `physics` (#104610) * Use `curly_braces_in_flow_control_structures` for `foundation` * Use `curly_braces_in_flow_control_structures` for `gestures` * Use `curly_braces_in_flow_control_structures` for `painting` * Use `curly_braces_in_flow_control_structures` for `physics` * fix comments * remove trailing space * fix TODO style
-
Greg Spencer authored
A bunch of random cleanup things I found while doing MenuBar development. Changes an if test to an assert in binding.dart, since the if should always be true. Adds the default ShortcutRegistrar that should have been in the ShortcutRegistry PR. Moves a debug message in the FocusManager to print the result after the focus change instead of before. Reorders the test parameters in theme_data_test.dart to match the order of the theme data fields everywhere else.
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 13 Apr, 2022 1 commit
-
-
Callum Moffat authored
* Implement trackpad gestures in framework * Touch and Pan/Zoom pointers have separate IDs now * Handle trackpad pointer device type * Respect supportedDevices for pan/zoom events * Update after rebase * Fix check failures * Avoid error with very short drags * Address feedback * Refactor drag event handler * Address more feedback * Add some missing punctuation
-
- 04 Mar, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 09 Feb, 2022 1 commit
-
-
wangying authored
-
- 03 Feb, 2022 1 commit
-
-
Ian Hickson authored
-
- 12 Dec, 2021 1 commit
-
-
Dan Field authored
-
- 08 Oct, 2021 3 commits
-
-
Ian Hickson authored
-
Zachary Anderson authored
This reverts commit 5fd259be.
-
Ian Hickson authored
-
- 15 Jul, 2021 1 commit
-
- 14 Jul, 2021 3 commits
-
-
Ian Hickson authored
-
Zachary Anderson authored
This reverts commit 31de052e.
-
Ian Hickson authored
-
- 13 Jul, 2021 2 commits
-
-
Ian Hickson authored
This reverts commit e2490f29.
-
Ian Hickson authored
-
- 12 Jun, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 15 Apr, 2021 1 commit
-
-
Michael Goderbauer authored
-
- 17 Feb, 2021 3 commits
-
-
David Reveman authored
This reverts #76179 and relands #73042 with an active timer check fix. Co-authored-by:
David Reveman <reveman@google.com>
-
Jenn Magder authored
This reverts commit 9133deb9.
-
David Reveman authored
Timer based pointer event resampling This provides two improvements to pointer event resampling: 1. PostFrameCallbacks are used instead of scheduling frames. This avoids unnecessary rendering work when resampling is used. 2. Resampling continues when frames are not produced. I.e. input events keep being delivered at a fixed frequency even if frame production is taking a long time. This fixes #72924 Co-authored-by:
David Reveman <reveman@google.com> Co-authored-by:
Tong Mu <dkwingsmt@users.noreply.github.com>
-
- 12 Nov, 2020 1 commit
-
-
Greg Spencer authored
This reverts usages of the binding's platformDispatcher to use window again temporarily, because there isn't a TestPlatformDispatcher yet, and so some tests were failing because they mocked the TestWindow to return certain things (locales) that were returning the real values instead of the test values. Once I've created a TestPlatformDispatcher to allow fake data to be passed to it, we can go back to using the platformDispatcher in all of these places
-