- 11 Jan, 2016 4 commits
-
-
Adam Barth authored
When the TabView widget's children change, we don't change the children we give to the PageViewport because we fail to update _items. This patch watches didChangeConfig and updates _items appropriately. Fixes #1134 Fixes #1168
-
Adam Barth authored
Instead of taking a builder and a generic type, we can just take a List<Widget>.
-
Ian Hickson authored
Without this, FlatButton ends up using two RenderConstrainedBoxes back to back for no good reason.
-
Ian Hickson authored
This makes it more consistent with tightFor(), and also makes it easier to tighten both directions at once when you're not sure you will always do so (e.g. if you have a height and width that might be null, and want to tighten whichever ones aren't null).
-
- 10 Jan, 2016 3 commits
-
-
Ian Hickson authored
-
Ian Hickson authored
-
Ian Hickson authored
This will allow AnimatedPositioned to reuse all the same logic.
-
- 09 Jan, 2016 3 commits
-
-
Ian Hickson authored
Not sure what I was doing when I wrote this assertion, but I'm pretty sure it's wrong. I'm guessing the change here is what I actually meant to write.
-
Ian Hickson authored
- padding is shown in blue with a darker blue around the child - spacing (empty size boxes or padding) is shown in gray - alignment from a RenderPositionedBox is shown with yellow arrows
-
Adam Barth authored
When I tightened up the layout constraints for the Drawer in the Scaffold, I ended up making the edge swipe detector cover the entire screen. This patch fixes that issue by putting the gesture detector for the edge swipe just around the container with the proper width. We now use a global key to maintain the state across hierarchy changes.
-
- 08 Jan, 2016 6 commits
-
-
-
Hans Muller authored
-
Ian Hickson authored
Change how GridPaper works so that it's easier to plug in anywhere. It now takes a child that it will paint the grid over. It defaults to semi-transparent grid-paper-blue. The line spacing is also more configurable now.
-
Adam Barth authored
Previously, we triggered a layout (and hence a repaint) when sliding the draw because we gave the draw loose constraints. The drawer uses an Align to move itself to the proper side of the screen, so it can have tight constraints, which makes it a layout boundary. Also, don't trigger a layout just because the Scaffold rebuilds. There isn't any state in the scaffold custom layout, so it doesn't need to repaint just because we created a new instance of the delegate. Finally, add the debugging infrastructure I used to find these issues.
-
Ian Hickson authored
-
Hans Muller authored
-
- 07 Jan, 2016 9 commits
-
-
Adam Barth authored
The TabBarView wants to remap page indices during tab transitions, which I broke when I refactored TabBarView. Fixes #1119
-
Adam Barth authored
Fixed #1009
-
Adam Barth authored
We'll probably renaming ScrollDirection to Axis in a future patch. Fixes #151
-
Adam Barth authored
Previously MaterialApp was responsible for ending the activity when the back stack was empty. However, this behavior is more general than material. This patch moves the behavior to FlutterWidgetBinding, which has a global view of all the binding observers. Fixes #1086
-
Ian Hickson authored
Make ancestorStateOfType() and ancestorRenderObjectOfType() support subclassing. Fixes https://github.com/flutter/flutter/issues/1087
-
Ian Hickson authored
- make them all have the same style - make them all include the stack trace last - make them all stop printing if their callback is set (if appropriate, they don't yet all have callbacks)
-
Ian Hickson authored
I think I wanted to use this at some point but ended up going a different direction. Instead, object.dart has a private field that serves a similar purpose.
-
Adam Barth authored
If we're already at the target value, we fail to configure the variable. If another variable animates, we re-animate the other variable. Fixes #958
-
Adam Barth authored
-
- 06 Jan, 2016 5 commits
-
-
Adam Barth authored
This patch moves PageableList off HomogeneousViewport and onto RenderList and friends, making it match the new ScrollableList.
-
Adam Barth authored
ScrollableList2 is complete and subsumes all the use cases for the original ScrollableList.
-
Hans Muller authored
-
Adam Barth authored
When paging a scrollable list, we were trying to read the render object's size at a time when we're not allowed to read it. Instead, encode the information into the repaint limit, which is more correct (and faster) anyway.
-
Adam Barth authored
This patch also changed ScrollableList2 to use an Iterable instead of an List for its children. This change lets clients map their underlying data lazily. If the clients actually have a concrete list, we skip the extra copy and grab the child list directly.
-
- 05 Jan, 2016 3 commits
-
-
Adam Barth authored
This patch implements the remaining missing features of ScrollableList2. It should now be nearly a drop-in replacement for ScrollableList. The next patch will switch callers over to the new machinery.
-
Adam Barth authored
Almost none of the clients of ScrollDirection can handle scrolling in both directions. Fixes #151
-
Adam Barth authored
ScrollableList2 uses the same pattern as ScrollableGrid, which requires the client to allocate widgets for every list item but doesn't inflate them unless they're actually needed for the view. It improves on the original ScrollableList by not requiring a rebuild of the whole visible portion of the list when scrolling. In fact, small scrolls can often be handled entirely by repainting.
-
- 04 Jan, 2016 3 commits
-
-
Ian Hickson authored
-
Adam Barth authored
We now support (vertically) scrollable grids with viewporting. If the scroll doesn't reveal any new rows, we execute the scroll with a repaint (i.e., no layout). If the scroll reveals a new row, we trigger a layout to change the set of materialized children in the viewport.
-
Ian Hickson authored
Fixes #1058.
-
- 02 Jan, 2016 4 commits
-
-
Adam Barth authored
This patch make grid layout much more flexible. The behavior is factored out into a GridDelegate that's modeled after the custom layout delegates. The patch includes a MaxTileWidthGridDelegate that implements the old behavior and a FixedColumnCountGridDelegate that implements a grid layout with a fixed number of columns. Fixes #1048
-
Adam Barth authored
Previously we used Position, which makes it harder to accumulate offsets when walking the render tree.
-
Adam Barth authored
When assigning a new overlayPainter, we were detaching the old overlay painter even if the render object itself wasn't attached. Now we only twiddle the attach/detach state of the overlay painter when we're attached ourselves. Fixes #1047
-
Adam Barth authored
We need to put the padding on the inside of the list item. Fixes #1055
-