- 25 Oct, 2023 1 commit
-
-
fzyzcjy authored
Close https://github.com/flutter/flutter/issues/129094 I have demonstrated how this PR fixes the problem using tests in #129094. I will further add tests in this PR if the PR looks roughly acceptable :)
-
- 13 Oct, 2023 1 commit
-
-
Todd Volkert authored
Some render box subclasses have a specific layout contract that is tightly coupled with other render box subclasses (e.g. two private classes in a local project file). In these cases, it is also possible that they use a constraints object that is a subclass of `BoxConstraints`. To allow for this, this change makes the `constraints` argument to `RenderBox.computeDryLayout()` a covariant argument. For completeness' sake, this updates the other render objects in the rendering package to also use the covariant keyword for this argument.
-
- 11 Oct, 2023 1 commit
-
-
Maximilian Fischer authored
This PR includes the `widthFactor` and `heightFactor` when computing the intrinsic size of a `RenderPositionedBox`. <details><summary>Code sample</summary> Red should have a height of 100, blue one of 200. ```dart import 'package:flutter/material.dart'; import 'package:flutter/rendering.dart'; void main() { runApp(const MyApp()); } class MyApp extends StatelessWidget { const MyApp({super.key}); @override Widget build(BuildContext context) { return MaterialApp( title: 'Intrinsic Bug', theme: ThemeData( colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple), useMaterial3: true, ), home: Scaffold( body: Row( crossAxisAlignment: CrossAxisAlignment.start, children: [ Expanded( child: IntrinsicHeight( child: Align( heightFactor: 0.5, child: Container( height: 200, color: Colors.red, ), ), ), ), Expanded( child: Container( height: 200, color: Colors.blue, ), ), ], ), ), ); } } ``` </details> Before:  After:  Fix #135822
-
- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the painting and rendering libraries. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 22 Mar, 2023 1 commit
-
-
Michael Goderbauer authored
Remove 1745 decorative breaks
-
- 21 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 28 Sep, 2022 1 commit
-
-
LongCatIsLooong authored
-
- 20 Sep, 2022 1 commit
-
-
Kate Lovett authored
-
- 29 Aug, 2022 1 commit
-
-
Greg Spencer authored
-
- 06 Jun, 2022 1 commit
-
-
Taha Tesser authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `rendering` * fix comments * fix dangling
-
- 17 May, 2022 1 commit
-
-
Dan Field authored
-
- 26 Apr, 2022 1 commit
-
-
Jonah Williams authored
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 13 Apr, 2022 1 commit
-
-
Kate Lovett authored
-
- 10 Dec, 2021 1 commit
-
-
Ian Hickson authored
-
- 27 Sep, 2021 1 commit
-
-
nt4f04uNd authored
-
- 25 Jun, 2021 1 commit
-
-
Dan Field authored
-
- 03 Apr, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 01 Apr, 2021 1 commit
-
-
Chris Bracken authored
-
- 31 Mar, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 24 Mar, 2021 1 commit
-
-
LongCatIsLooong authored
-
- 19 Mar, 2021 2 commits
-
-
Mouad Debbar authored
This reverts commit 8c44abc0.
-
LongCatIsLooong authored
-
- 26 Jan, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 21 Nov, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 02 Nov, 2020 1 commit
-
-
Greg Spencer authored
-
- 10 Oct, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 09 Oct, 2020 1 commit
-
-
Matej Knopp authored
-
- 27 Sep, 2020 1 commit
-
-
Alexandre Ardhuin authored
* apply upcoming lint cast_nullable_to_non_nullable * make RenderObjectElement.renderObject non-nullable
-
- 27 Aug, 2020 1 commit
-
-
Ian Hickson authored
-
- 25 Aug, 2020 2 commits
-
-
LongCatIsLooong authored
This reverts commit 0ab5ecc8.
-
LongCatIsLooong authored
-
- 15 Jul, 2020 1 commit
-
-
- 17 Jun, 2020 1 commit
-
- 11 Jun, 2020 1 commit
-
-
Alexandre Ardhuin authored
* add language version 2.8 in packages/flutter * enable non-nullable analyzer flag
-
- 31 May, 2020 1 commit
-
-
Mehmet Fidanboylu authored
This reverts commit cd593dae.
-
- 29 May, 2020 1 commit
-
-
liyuqian authored
* Add clipBehavior to RenderFlex * Add clipBehavior to FittedBox * Add clipBehavior to Flex and FittedBox * Add clipBehavior to UnconstrainedBox * Add clipBehavior to Stack and Wrap * Add clipBehavior to TextEditable * Add clipBehavior to ListWheelScrollView * Add clipBehavior to SingleChildScrollView * Add clipBehavior to RenderViewportBase's widgets Those widgets are NestedScrollView and ShrinkWrappingViewport. * Fix tests * Remove enum Overflow and fix typo * Remove clipToSize * Analyze fix * Remove Mixin and other small fixes * Fix tests and respect Stack's default clipBehavior * Add Overflow back to make it non-breaking * Restore clipBehavior to make it non-breaking * Small fixes * Fix rebase
-
- 28 Feb, 2020 1 commit
-
-
Jonah Williams authored
This reverts commit 2132a0c7.
-
- 26 Feb, 2020 1 commit
-