Commits · e002b2da73ce215fe774f19a8274348c07ae9db5 · abdullh.alsoleman / Front-End

20 Nov, 2023 15 commits

Roll Flutter Engine from 7a31543b4630 to 6e8e55ef1a7f (4 revisions) (#138761) · e002b2da

engine-flutter-autoroll authored Nov 20, 2023

https://github.com/flutter/engine/compare/7a31543b4630...6e8e55ef1a7f

2023-11-20 matanlurey@users.noreply.github.com Silence a lint in `common/settings.h` in order to turn on `clang_tidy`. (flutter/engine#48239)
2023-11-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from LnToEykA8o68jv58K... to Q3HcTitDF90ZOPWDa... (flutter/engine#48244)
2023-11-20 skia-flutter-autoroll@skia.org Roll Skia from 2bcc2e8682a6 to c9943f14039f (1 revision) (flutter/engine#48243)
2023-11-20 matanlurey@users.noreply.github.com Make `vulkan/...` compatible with `.clang_tidy`. (flutter/engine#48240)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from LnToEykA8o68 to Q3HcTitDF90Z

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e002b2da

[Reland] Introduce `AnimationStyle` (#138721) · fc917c71

Taha Tesser authored Nov 20, 2023

This PR introduces `AnimationStyle`, it is used to override default
animation curves and durations in several widgets.

fixes [Add the ability to customize MaterialApp theme animation
duration](https://github.com/flutter/flutter/issues/78372)
fixes [Allow customization of showMenu transition animation curves and
duration](https://github.com/flutter/flutter/issues/135638)
fixes [`AnimationStyle.noAnimation` needs to replace `AnimatedTheme`
with just `Theme` in the
`MaterialApp`](https://github.com/flutter/flutter/issues/138618)

Here is an example where popup menu curve and transition duration is
overridden:

```dart
          popUpAnimationStyle: AnimationStyle(
            curve: Easing.emphasizedAccelerate,
            duration: Durations.medium4,
          ),
```

Set `AnimationStyle.noAnimation` to disable animation.
```dart
    return MaterialApp(
      themeAnimationStyle: AnimationStyle.noAnimation,
```

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

fc917c71

Roll Flutter Engine from 337ab58e81f7 to 7a31543b4630 (2 revisions) (#138759) · 2c9d9665

engine-flutter-autoroll authored Nov 20, 2023

https://github.com/flutter/engine/compare/337ab58e81f7...7a31543b4630

2023-11-20 matanlurey@users.noreply.github.com [Impeller] Write a text-decoration test at the `dart:ui` layer (flutter/engine#48101)
2023-11-20 skia-flutter-autoroll@skia.org Roll Skia from 69213ba6f68a to 2bcc2e8682a6 (1 revision) (flutter/engine#48238)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2c9d9665

Reland update bottom navigation bar test for m3 (#137998) · 1a9e866f

Bruno Leroux authored Nov 20, 2023

This is a reland of https://github.com/flutter/flutter/pull/136624 which was reverted because one new M3 golden test failed. The failure was related to the ink sparkle animation.

Ink sparkle is the M3 default animation, it does not play well with golden because it introduces an element of randomness.
One way to avoid this randomness is to use the `InkSparkle.constantTurbulenceSeedSplashFactory`.

This PR has two commits:
- the first one is the original PR (https://github.com/flutter/flutter/pull/136624).
- the second one updates the failing test using `InkSparkle.constantTurbulenceSeedSplashFactory`.

1a9e866f

Roll Flutter Engine from 215853171cdc to 337ab58e81f7 (3 revisions) (#138751) · 9c9e0617

engine-flutter-autoroll authored Nov 20, 2023

https://github.com/flutter/engine/compare/215853171cdc...337ab58e81f7

2023-11-20 reidbaker@google.com Protect sdk upload script from missing ndk, add documentation for checking write access, improve comments to add context (flutter/engine#47989)
2023-11-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 09bd5d71062d to ee7aaca9adcc (1 revision) (flutter/engine#48237)
2023-11-20 skia-flutter-autoroll@skia.org Roll Skia from 151d297efcf5 to 69213ba6f68a (2 revisions) (flutter/engine#48236)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9c9e0617

Roll Flutter Engine from 255f967a3938 to 215853171cdc (2 revisions) (#138746) · 5dbf7f30

engine-flutter-autoroll authored Nov 20, 2023

https://github.com/flutter/engine/compare/255f967a3938...215853171cdc

2023-11-20 skia-flutter-autoroll@skia.org Roll Skia from e9206d29ef07 to 151d297efcf5 (1 revision) (flutter/engine#48235)
2023-11-20 skia-flutter-autoroll@skia.org Roll Skia from 795a259c2f56 to e9206d29ef07 (3 revisions) (flutter/engine#48231)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5dbf7f30

test owners: cyanglaz -> vashworth (#138726) · f155db9b
Chris Yang authored Nov 20, 2023
```
Temperarily transfer test owner to @vashworth 
Thank you Victoria!
```
f155db9b
Fix file deletion crash in BuildIOSArchiveCommand.runCommand (#138734) · e826c63a
Victoria Ashworth authored Nov 20, 2023
```
Fixes https://github.com/flutter/flutter/issues/138030
```
e826c63a

Roll Flutter Engine from 1f1e26c103d0 to 255f967a3938 (3 revisions) (#138739) · 82170c1f

engine-flutter-autoroll authored Nov 20, 2023

https://github.com/flutter/engine/compare/1f1e26c103d0...255f967a3938

2023-11-20 mdebbar@google.com [web] EngineFlutterView.dispose() (flutter/engine#48183)
2023-11-20 skia-flutter-autoroll@skia.org Roll Skia from 64d1e14df168 to 795a259c2f56 (2 revisions) (flutter/engine#48227)
2023-11-20 skia-flutter-autoroll@skia.org Roll Skia from a874e29d71c0 to 64d1e14df168 (1 revision) (flutter/engine#48225)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

82170c1f

Roll Packages from 07b4b298face to c5443ad7e7e0 (13 revisions) (#138724) · 16fc8375

engine-flutter-autoroll authored Nov 20, 2023

https://github.com/flutter/packages/compare/07b4b298face...c5443ad7e7e0

2023-11-20 JeroenWeener@users.noreply.github.com [webview_flutter] Support for handling basic authentication requests (Platform Interface) (flutter/packages#5362)
2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter from 53a57adc to 6cf9ab02 (31 revisions) (flutter/packages#5426)
2023-11-18 kevmoo@users.noreply.github.com [shared_preferences_web] migrate to pkg:web (flutter/packages#5414)
2023-11-18 stuartmorgan@google.com [ci] Roll minimum allowable Flutter to 3.10 (flutter/packages#5425)
2023-11-18 43054281+camsim99@users.noreply.github.com [path_provider_android] Run tests on AVDs running Android 34 (flutter/packages#5222)
2023-11-17 tarrinneal@gmail.com [pigeon] isEnum, isClass, fix swift casting, default values, optional method arguments, named method arguments (flutter/packages#5355)
2023-11-17 stuartmorgan@google.com [plugin_platform_interface] Switch mixin to `mixin class` (flutter/packages#5420)
2023-11-17 stuartmorgan@google.com [go_router] Fixes use of `Iterable` (flutter/packages#5421)
2023-11-17 stuartmorgan@google.com [pigeon] Adds `analyzer` 6.x compatibility (flutter/packages#5418)
2023-11-17 stuartmorgan@google.com Update release step to 3.16 (flutter/packages#5416)
2023-11-17 kevmoo@users.noreply.github.com [file_selector_web] migrate to pkg:web (flutter/packages#5413)
2023-11-16 stuartmorgan@google.com [video_player] Improve macOS frame management (flutter/packages#5078)
2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter from e8c2bb13 to 53a57adc (39 revisions) (flutter/packages#5412)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

16fc8375

Roll Flutter Engine from 81ffbc6754a1 to 1f1e26c103d0 (1 revision) (#138722) · f0065c1c

engine-flutter-autoroll authored Nov 20, 2023

https://github.com/flutter/engine/compare/81ffbc6754a1...1f1e26c103d0

2023-11-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 564cfb2cfe79 to 09bd5d71062d (1 revision) (flutter/engine#48222)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f0065c1c

Roll Flutter Engine from a93f20d892cf to 81ffbc6754a1 (1 revision) (#138717) · 0d1a2948

engine-flutter-autoroll authored Nov 20, 2023

https://github.com/flutter/engine/compare/a93f20d892cf...81ffbc6754a1

2023-11-20 kjlubick@users.noreply.github.com Replace calls to SkFontMgr::RefDefault (flutter/engine#48179)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0d1a2948

Roll Flutter Engine from f59e576d46df to a93f20d892cf (1 revision) (#138712) · 4cd32ffe

engine-flutter-autoroll authored Nov 20, 2023

https://github.com/flutter/engine/compare/f59e576d46df...a93f20d892cf

2023-11-20 skia-flutter-autoroll@skia.org Roll Skia from 5010d0578f4d to a874e29d71c0 (1 revision) (flutter/engine#48216)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4cd32ffe

Roll Flutter Engine from e916d5bfddba to f59e576d46df (2 revisions) (#138702) · fcc32cc1

engine-flutter-autoroll authored Nov 20, 2023

https://github.com/flutter/engine/compare/e916d5bfddba...f59e576d46df

2023-11-20 zanderso@users.noreply.github.com Moves expat, ocmock, libjpeg-turbo, libwebp, and wuffs to //flutter/third_party (flutter/engine#48193)
2023-11-20 skia-flutter-autoroll@skia.org Roll Skia from 343b249b2cac to 5010d0578f4d (1 revision) (flutter/engine#48215)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fcc32cc1

Roll Flutter Engine from 31059ccceee5 to e916d5bfddba (1 revision) (#138698) · d2b67d4c

engine-flutter-autoroll authored Nov 20, 2023

https://github.com/flutter/engine/compare/31059ccceee5...e916d5bfddba

2023-11-20 skia-flutter-autoroll@skia.org Roll Skia from 0d49b661d75a to 343b249b2cac (1 revision) (flutter/engine#48214)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d2b67d4c

19 Nov, 2023 4 commits

Roll Flutter Engine from 9f6f418393ca to 31059ccceee5 (1 revision) (#138686) · 0858ea2c

engine-flutter-autoroll authored Nov 19, 2023

https://github.com/flutter/engine/compare/9f6f418393ca...31059ccceee5

2023-11-19 skia-flutter-autoroll@skia.org Roll Skia from 4ec239a62325 to 0d49b661d75a (1 revision) (flutter/engine#48212)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0858ea2c

Roll Flutter Engine from ad49653e0a5f to 9f6f418393ca (1 revision) (#138684) · 052b7d44

engine-flutter-autoroll authored Nov 19, 2023

https://github.com/flutter/engine/compare/ad49653e0a5f...9f6f418393ca

2023-11-19 skia-flutter-autoroll@skia.org Roll Skia from f320a125e031 to 4ec239a62325 (1 revision) (flutter/engine#48210)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

052b7d44

Roll Flutter Engine from f5de20ccebf2 to ad49653e0a5f (1 revision) (#138681) · e73c050a

engine-flutter-autoroll authored Nov 19, 2023

https://github.com/flutter/engine/compare/f5de20ccebf2...ad49653e0a5f

2023-11-19 skia-flutter-autoroll@skia.org Roll Skia from b311e4d0d21e to f320a125e031 (1 revision) (flutter/engine#48208)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e73c050a

Roll Flutter Engine from d7af5fb60b4c to f5de20ccebf2 (1 revision) (#138679) · 23ee1c43

engine-flutter-autoroll authored Nov 19, 2023

https://github.com/flutter/engine/compare/d7af5fb60b4c...f5de20ccebf2

2023-11-19 skia-flutter-autoroll@skia.org Roll Skia from f9e9bff1714a to b311e4d0d21e (1 revision) (flutter/engine#48207)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

23ee1c43

18 Nov, 2023 7 commits

Roll Flutter Engine from 53c4fde7732b to d7af5fb60b4c (2 revisions) (#138668) · 6cf9ab02

engine-flutter-autoroll authored Nov 18, 2023

https://github.com/flutter/engine/compare/53c4fde7732b...d7af5fb60b4c

2023-11-18 skia-flutter-autoroll@skia.org Roll Skia from 4f22188e5103 to f9e9bff1714a (1 revision) (flutter/engine#48203)
2023-11-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Bcq9TZdt-vtTSL5YH... to LnToEykA8o68jv58K... (flutter/engine#48202)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Bcq9TZdt-vtT to LnToEykA8o68

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6cf9ab02

Update release.yml (#138561) · 4d7608f4

John Ryan authored Nov 18, 2023

Add missing labels tag, which was causing the release notes generation to break.

cc: @MaryaBelanger

4d7608f4

Roll Flutter Engine from 384f75061257 to 53c4fde7732b (2 revisions) (#138660) · 7c130474

engine-flutter-autoroll authored Nov 18, 2023

https://github.com/flutter/engine/compare/384f75061257...53c4fde7732b

2023-11-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 3d4886a2e218 to 564cfb2cfe79 (1 revision) (flutter/engine#48195)
2023-11-18 skia-flutter-autoroll@skia.org Roll Skia from 11b5847aea97 to 4f22188e5103 (1 revision) (flutter/engine#48196)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7c130474

Roll Flutter Engine from 5f40c9f49f88 to 384f75061257 (2 revisions) (#138658) · 29b73342

engine-flutter-autoroll authored Nov 18, 2023

https://github.com/flutter/engine/compare/5f40c9f49f88...384f75061257

2023-11-18 matanlurey@users.noreply.github.com Make `impeller/...` compatible with `.clang-tidy`. (flutter/engine#48155)
2023-11-18 matanlurey@users.noreply.github.com Make `shell/platform/{darwin|embedder}/...` compatible with `.clang-tidy`. (flutter/engine#48160)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

29b73342

Roll Flutter Engine from 66f764a16610 to 5f40c9f49f88 (1 revision) (#138655) · f0b313fc

engine-flutter-autoroll authored Nov 18, 2023

https://github.com/flutter/engine/compare/66f764a16610...5f40c9f49f88

2023-11-18 matanlurey@users.noreply.github.com Make `display_list/...` compatible with `.clang_tidy`. (flutter/engine#48147)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f0b313fc

Roll Flutter Engine from 1d2ee544c5e5 to 66f764a16610 (1 revision) (#138652) · cf083a28

engine-flutter-autoroll authored Nov 18, 2023

https://github.com/flutter/engine/compare/1d2ee544c5e5...66f764a16610

2023-11-17 matanlurey@users.noreply.github.com Make `testing/...` and `vulkan/...` compatible with `.clang-tidy`. (flutter/engine#48161)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cf083a28

Roll Flutter Engine from c38272b5e036 to 1d2ee544c5e5 (3 revisions) (#138650) · 86c432d2

engine-flutter-autoroll authored Nov 18, 2023

https://github.com/flutter/engine/compare/c38272b5e036...1d2ee544c5e5

2023-11-17 matanlurey@users.noreply.github.com Make `impeller/aiks/...` compatible with `.clang-tidy`. (flutter/engine#48152)
2023-11-17 barpac02@gmail.com Fix a few typos (flutter/engine#47960)
2023-11-17 skia-flutter-autoroll@skia.org Roll Skia from 04b0ac194443 to 11b5847aea97 (3 revisions) (flutter/engine#48188)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

86c432d2

17 Nov, 2023 9 commits

Roll Flutter Engine from e010f17eeb10 to c38272b5e036 (4 revisions) (#138647) · cb687c78

engine-flutter-autoroll authored Nov 17, 2023

https://github.com/flutter/engine/compare/e010f17eeb10...c38272b5e036

2023-11-17 matanlurey@users.noreply.github.com Make `fml/...` compatible with `.clang-tidy`. (flutter/engine#48150)
2023-11-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 03cddb5d740d to 3d4886a2e218 (1 revision) (flutter/engine#48187)
2023-11-17 skia-flutter-autoroll@skia.org Roll Skia from dd7a26ead897 to 04b0ac194443 (8 revisions) (flutter/engine#48186)
2023-11-17 jhy03261997@gmail.com [Android] Send " did gain focus" message from engine to framework (flutter/engine#47114)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cb687c78

Update links and surrounding text for new `main-api` docs (#138602) · 096cdc39
Parker Lougheed authored Nov 17, 2023
```
Issue reference: https://github.com/flutter/flutter/issues/133877
```
096cdc39

Roll Flutter Engine from 141a01c5c70b to e010f17eeb10 (2 revisions) (#138643) · a8fbd274

engine-flutter-autoroll authored Nov 17, 2023

https://github.com/flutter/engine/compare/141a01c5c70b...e010f17eeb10

2023-11-17 skia-flutter-autoroll@skia.org Roll Skia from 8e9e168418a0 to dd7a26ead897 (1 revision) (flutter/engine#48178)
2023-11-17 ychris@google.com [Ios] move flutter_test_ios_mrc unittests to arc (flutter/engine#48162)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a8fbd274

Roll Flutter Engine from 90c3ada3682c to 141a01c5c70b (16 revisions) (#138637) · 30b6586f

engine-flutter-autoroll authored Nov 17, 2023

https://github.com/flutter/engine/compare/90c3ada3682c...141a01c5c70b

2023-11-17 dnfield@google.com Reland "[Impeller] Fail if software backend is chosen and Impeller is enabled on iOS." (flutter/engine#46275)
2023-11-17 matanlurey@users.noreply.github.com Make `impeller/geometry/...` compatible with `.clang-tidy`. (flutter/engine#48154)
2023-11-17 matanlurey@users.noreply.github.com Make `impeller/{archivist|compiler|core|entity}/...` compatible with â¦ (flutter/engine#48153)
2023-11-17 109111084+yaakovschectman@users.noreply.github.com Assign mojom `kSwitch` role to switches (flutter/engine#48146)
2023-11-17 mdebbar@google.com [web] Move scene DOM management to DomManager (flutter/engine#47460)
2023-11-17 30870216+gaaclarke@users.noreply.github.com [Impeller] Unify around "transform" (flutter/engine#48184)
2023-11-17 skia-flutter-autoroll@skia.org Roll Dart SDK from a9c212f2f54b to 03cddb5d740d (1 revision) (flutter/engine#48182)
2023-11-17 matanlurey@users.noreply.github.com Actually make `status_or.h` compatible with `.clang-tidy`. (flutter/engine#48151)
2023-11-17 jonahwilliams@google.com [Impeller] Cleanups to geometry interfaces. (flutter/engine#48180)
2023-11-17 mdebbar@google.com [web] Move all DOM creation to DomManager (flutter/engine#48123)
2023-11-17 15619084+vashworth@users.noreply.github.com Reenable UnobstructedPlatformViewTests testMultiplePlatformViewsWithOverlays (flutter/engine#48139)
2023-11-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 46e8b18047eb to a9c212f2f54b (1 revision) (flutter/engine#48176)
2023-11-17 skia-flutter-autoroll@skia.org Roll Skia from bcd22e8f95bc to 8e9e168418a0 (1 revision) (flutter/engine#48173)
2023-11-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from M0zM3CJLIrd5lb0u0... to Bcq9TZdt-vtTSL5YH... (flutter/engine#48172)
2023-11-17 skia-flutter-autoroll@skia.org Roll Skia from c8ee25282849 to bcd22e8f95bc (1 revision) (flutter/engine#48170)
2023-11-17 bdero@google.com [Flutter GPU] Add Textures. (flutter/engine#48118)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from M0zM3CJLIrd5 to Bcq9TZdt-vtT

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

30b6586f

Roll Flutter Engine from 5064aeff00de to 90c3ada3682c (9 revisions) (#138599) · 0d3c87ee

engine-flutter-autoroll authored Nov 17, 2023

https://github.com/flutter/engine/compare/5064aeff00de...90c3ada3682c

2023-11-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 12c5efc94edf to 46e8b18047eb (1 revision) (flutter/engine#48168)
2023-11-17 skia-flutter-autoroll@skia.org Roll Skia from c7d2a4933dfa to c8ee25282849 (2 revisions) (flutter/engine#48164)
2023-11-17 dnfield@google.com Only run systrace test on API 29+, avoid building scenario app for 28 (flutter/engine#48163)
2023-11-17 matanlurey@users.noreply.github.com Make `lib/ui/text/...` compatible with `.clang-tidy`. (flutter/engine#48156)
2023-11-17 matanlurey@users.noreply.github.com Make `flow/...` compatible with `.clang_tidy`. (flutter/engine#48148)
2023-11-17 bdero@google.com [Impeller] Add support for external GL textures to TiledTextureContents. (flutter/engine#47586)
2023-11-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 906f23c1cb20 to 12c5efc94edf (1 revision) (flutter/engine#48157)
2023-11-17 skia-flutter-autoroll@skia.org Roll Skia from 762d95ed65e0 to c7d2a4933dfa (1 revision) (flutter/engine#48159)
2023-11-16 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Size the PictureRecorder when calling Scene.toImage (flutter/engine#48142)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0d3c87ee

Fix NoSplash not being disposed (#138542) · 3c80df50
林洵锋 authored Nov 17, 2023
```
Fix https://github.com/flutter/flutter/issues/136441
```
3c80df50

Reverts "Introduce `AnimationStyle`" (#138628) · 0135a331

auto-submit[bot] authored Nov 17, 2023

Reverts flutter/flutter#137945
Initiated by: HansMuller
This change reverts the following previous change:
Original Description:
This PR introduces `AnimationStyle`, it is used to override default animation curves and durations in several widgets.

fixes  [Add the ability to customize MaterialApp theme animation duration](https://github.com/flutter/flutter/issues/78372)
fixes [Allow customization of showMenu transition animation curves and duration](https://github.com/flutter/flutter/issues/135638)

Here is an example where popup menu curve and transition duration is overriden:

```dart
          popUpAnimationStyle: AnimationStyle(
            curve: Easing.emphasizedAccelerate,
            duration: Durations.medium4,
          ),
```

Set `AnimationStyle.noAnimation` to disable animation.
```dart
    return MaterialApp(
      themeAnimationStyle: AnimationStyle.noAnimation,
```

0135a331

Enable `flutter screenshot` outside Flutter project directory (#138160) · e9de4484

Victor Eronmosele authored Nov 17, 2023

This PR enables the `flutter screenshot` to work outside a Flutter project. 

This works by enabling `ScreenshotCommand` to find target devices not supported by the project. 

Before: 
```bash
$ cd $HOME # not a Flutter directory

$ flutter screenshot

No devices found yet. Checking for wireless devices...

No supported devices connected.

The following devices were found, but are not supported by this project:
sdk gphone64 arm64 (mobile) â¢ emulator-5554 â¢ android-arm64  â¢ Android 13 (API 33) (emulator)
macOS (desktop)             â¢ macos         â¢ darwin-arm64   â¢ macOS 13.3.1 22E772610a darwin-arm64
Chrome (web)                â¢ chrome        â¢ web-javascript â¢ Google Chrome 119.0.6045.105
If you would like your app to run on android or macos or web, consider running `flutter create .` to generate projects for these platforms.
Must have a connected device for screenshot type device
```

After: 

```bash
$ cd $HOME # not a Flutter directory

$ flutter_source screenshot

Screenshot written to flutter_01.png (313kB).
```

Fixes #115790

e9de4484

Roll Flutter Engine from aae07e989b0a to 5064aeff00de (2 revisions) (#138585) · 2e5990ca

engine-flutter-autoroll authored Nov 17, 2023

https://github.com/flutter/engine/compare/aae07e989b0a...5064aeff00de

2023-11-16 jonahwilliams@google.com [Impeller] Clang tidy even more (flutter/engine#48102)
2023-11-16 30870216+gaaclarke@users.noreply.github.com [Impeller] Implements gaussian blur that scales down before applying the blur (flutter/engine#47576)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2e5990ca

16 Nov, 2023 5 commits

Improves output file path logic in Android analyze (#136981) · d8a5f3d1
chunhtai authored Nov 16, 2023

d8a5f3d1
Turn off leak tracker in master to make found leaks not blocking. (#138567) · 2dc81113
Polina Cherkasova authored Nov 16, 2023

2dc81113

Roll Flutter Engine from 094a3383a406 to aae07e989b0a (2 revisions) (#138574) · 86a898e6

engine-flutter-autoroll authored Nov 16, 2023

https://github.com/flutter/engine/compare/094a3383a406...aae07e989b0a

2023-11-16 skia-flutter-autoroll@skia.org Roll Skia from 4c099aaa259f to 762d95ed65e0 (2 revisions) (flutter/engine#48140)
2023-11-16 matanlurey@users.noreply.github.com Re-land "Make `flow/embedded_views.h` compatible with `.clang_tidy`." (flutter/engine#48137)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

86a898e6

Enable the silent flag for invalid string exceptions when building a TextSpan (#138564) · d859865e

Jason Simmons authored Nov 16, 2023

This error can occur in a release app (for example, if the text comes from user input that is not valid UTF-16).  In that case, TextSpan will replace the invalid text with a placeholder character.

d859865e

Roll Flutter Engine from 22baa83db63b to 094a3383a406 (13 revisions) (#138568) · 61d37105

engine-flutter-autoroll authored Nov 16, 2023

https://github.com/flutter/engine/compare/22baa83db63b...094a3383a406

2023-11-16 skia-flutter-autoroll@skia.org Roll Skia from 297049bbfc0d to 4c099aaa259f (5 revisions) (flutter/engine#48138)
2023-11-16 skia-flutter-autoroll@skia.org Roll Dart SDK from b512191e9612 to 906f23c1cb20 (1 revision) (flutter/engine#48136)
2023-11-16 matanlurey@users.noreply.github.com Disable the `runIfNot` clauses in `.ci.yaml`, as they are unsafe. (flutter/engine#48132)
2023-11-16 15619084+vashworth@users.noreply.github.com Fix race condition in Unobstructed Platform View Scenario tests (flutter/engine#48096)
2023-11-16 jonahwilliams@google.com [Impeller] store all path point data in single buffer. (flutter/engine#47896)
2023-11-16 skia-flutter-autoroll@skia.org Roll Skia from b9ead4140f84 to 297049bbfc0d (2 revisions) (flutter/engine#48133)
2023-11-16 chris@bracken.jp [macOS] Replace pasteboard mock with fake (flutter/engine#48110)
2023-11-16 chinmaygarde@google.com [Impeller] Fix issue where the lock was not re-acquired when the wait exits on CV. (flutter/engine#48104)
2023-11-16 jonahwilliams@google.com [Impeller] Create a drawable backed TextureMTL. (flutter/engine#48049)
2023-11-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `flow/embedded_views.h` compatible with `.clang_tidy`." (flutter/engine#48130)
2023-11-16 chris@bracken.jp [macOS] Replace fixture subclasses with usings (flutter/engine#48111)
2023-11-16 matanlurey@users.noreply.github.com Make `flow/embedded_views.h` compatible with `.clang_tidy`. (flutter/engine#47994)
2023-11-16 matanlurey@users.noreply.github.com Make `flow/...` compatible with `.clang_tidy`. (flutter/engine#47995)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

61d37105