- 24 Jan, 2024 1 commit
-
-
Jesús S Guerrero authored
Revert "[web] - Fix broken `TextField` in semantics mode when it's a sibling of `Navigator`" (#142129) Reverts flutter/flutter#138446 b/322136071
-
- 22 Jan, 2024 1 commit
-
-
Hassan Toor authored
When a `TextField` is rendered before a `Navigator`, it breaks in semantics mode. This is because the framework generates the incorrect semantics tree (excludes the TextField) and when that tree gets sent to the engine, we don't get the signal to create the corresponding `<input>` element. This happens for a few reasons: * `ModalBarrier` uses `BlockSemantics` to drop the semantics of routes beneath the current route in `Navigator` * `ModalBarrier` mistakenly recognizes the widget outside of the `Navigator` to be its sibling * So we end up dropping the semantics node of the `TextField` rendered before it. The fix is to let `Navigator` generate a semantics node so that `ModalBarrier` doesn't mistakenly think widgets outside of `Navigator` are its siblings. `Navigator` doesn't currently do this, which causes all the nodes generated from its widget subtree to be directly attached to the parent semantics node above `Navigator` - since this is also the parent of `TextField`, it considers them siblings. Fixes https://github.com/flutter/flutter/issues/129324
-
- 12 Jan, 2024 1 commit
-
-
Taha Tesser authored
fixes [Invisible SliverAppBar title in Material 3 light theme](https://github.com/flutter/flutter/issues/138296) fixes [`FlexibleSpaceBar` title is misaligned without the leading widget](https://github.com/flutter/flutter/issues/138608) Previous attempt https://github.com/flutter/flutter/pull/138611 --- ### Description - fixes the `FlexibleSpaceBar` centered title position when there is a leading widget. - fixes the `FlexibleSpaceBar` title color for Material 3. - Added documentation when using a long `FlexibleSpaceBar` title and update its test. - Improved documentation of default title padding. ### Code sample ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @override Widget build(BuildContext context) { return const MaterialApp( debugShowCheckedModeBanner: false, home: Example(), ); } } class Example extends StatelessWidget { const Example({super.key}); @override Widget build(BuildContext context) { return const Scaffold( body: SafeArea( child: CustomScrollView( slivers: <Widget>[ SliverAppBar( leading: Icon(Icons.favorite_rounded), flexibleSpace: FlexibleSpaceBar( title: ColoredBox( color: Color(0xffff0000), child: Text('SliverAppBar'), ), ), ), ], )), ); } } ``` </details> ### Before ![Screenshot 2024-01-03 at 18 02 25](https://github.com/flutter/flutter/assets/48603081/92ae1062-c78f-4005-8e28-85af617acd60) ### After ![Screenshot 2024-01-03 at 18 02 16](https://github.com/flutter/flutter/assets/48603081/2ef97108-9b50-44f7-a303-018ff1b28db6)
-
- 15 Dec, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 11 Oct, 2023 1 commit
-
-
Taha Tesser authored
fixes [`flexible_space_bar.dart': Failed assertion: line 475 pos 12: 'needsCompositing': is not true.` is thrown when scrolling down in the list and then up](https://github.com/flutter/flutter/issues/135698)
-
- 22 Aug, 2023 1 commit
-
-
Taha Tesser authored
fixes [Long `FlexibleSpaceBar.title` doesn't respect the leading widget ](https://github.com/flutter/flutter/issues/132030) ### Description - This adds `FlexibleSpaceBarSettings.hasLeading` for the `FlexibleSpaceBar`'s title to respect the leading widget. - Use the new `FlexibleSpaceBarSettings.hasLeading` property in the `SliverAppBar` for its `FlexibleSpaceBar`. ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @override Widget build(BuildContext context) { return MaterialApp( debugShowCheckedModeBanner: false, theme: ThemeData( useMaterial3: true, brightness: Brightness.dark, ), home: const Example(), ); } } class Example extends StatelessWidget { const Example({super.key}); @override Widget build(BuildContext context) { return Scaffold( body: Column( mainAxisAlignment: MainAxisAlignment.center, children: [ const Text('TargetPlatform.Android'), Theme( data: Theme.of(context).copyWith( platform: TargetPlatform.android, ), child: Container( height: 250, padding: const EdgeInsets.all(8), decoration: BoxDecoration( border: Border.all( color: Colors.amber, width: 4, ), ), child: const AppBarLeading( showLeading: true, showTitle: false, ), ), ), const Text('TargetPlatform.iOS'), Theme( data: Theme.of(context).copyWith( platform: TargetPlatform.iOS, ), child: Container( height: 250, padding: const EdgeInsets.all(8), decoration: BoxDecoration( border: Border.all( color: Colors.amber, width: 2, ), ), child: const AppBarLeading( showLeading: true, showTitle: false, ), ), ), ], ), ); } } class AppBarLeading extends StatelessWidget { const AppBarLeading({ super.key, required this.showLeading, required this.showTitle, }); final bool showLeading; final bool showTitle; @override Widget build(BuildContext context) { return Scaffold( drawer: const Drawer(), body: CustomScrollView( slivers: [ SliverAppBar( automaticallyImplyLeading: showLeading, iconTheme: const IconThemeData( color: Colors.amber, ), title: showTitle ? const Text('AppBar') : null, flexibleSpace: FlexibleSpaceBar( title: Text('Title ' * 15), // centerTitle: true, ), toolbarHeight: showTitle ? 170 : 100, ), ], ), ); } } ``` </details> ### Before ![Screenshot 2023-08-15 at 18 11 34](https://github.com/flutter/flutter/assets/48603081/4b798998-8549-43aa-b564-933ea14f494c) ### After ![Screenshot 2023-08-15 at 18 11 45](https://github.com/flutter/flutter/assets/48603081/b085a33a-db7d-40d4-8a12-ee37197b5bd4)
-
- 14 Aug, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 10 Aug, 2023 1 commit
-
-
LongCatIsLooong authored
Migrate tests in flutter/flutter. Once the tests here and in `*_customer_testing` are migrated, the default value of the migration flag will be changed from false to true, making the rounding hack disabled by default.
-
- 09 Aug, 2023 1 commit
-
-
Tae Hyung Kim authored
See title.
-
- 22 Jul, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 14 Jul, 2023 1 commit
-
-
LongCatIsLooong authored
-
- 28 Jun, 2023 1 commit
-
-
Jonah Williams authored
This was missing the actual opacity rendering, oops
-
- 13 Jun, 2023 1 commit
-
-
Qun Cheng authored
Updates most of the unit tests in the packages/flutter/test/material folder so that they'll pass if ThemeData.useMaterial3 defaults to true. All of the tests have wired useMaterial3 to false and will need to be updated with a M3 version. related to #127064
-
- 05 Jun, 2023 2 commits
-
-
Jonah Williams authored
Adds a special opacity widget that does not act like a repaint boundary. Better solution for https://github.com/flutter/flutter/pull/128138
-
Jonah Williams authored
Fixes https://github.com/flutter/flutter/issues/127836 The flexible scroll bar needs to rebuild even if the child/opacity hasn't changed. Force this with a value key.
-
- 26 May, 2023 1 commit
-
-
LongCatIsLooong authored
To opt-in, run the tests with: `SKPARAGRAPH_REMOVE_ROUNDING_HACK=1 flutter test --dart-define=SKPARAGRAPH_REMOVE_ROUNDING_HACK=1 ` Migration plans: 1. Turn the flags on in CI, migrate customer tests if needed 1. Migrate internal customers 2. Remove the flag from skparagraph. Remove the framework flag with a manual engine roll. Also fixes https://github.com/flutter/flutter/issues/52038
-
- 21 Dec, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 09 Dec, 2022 1 commit
-
-
Callum Moffat authored
-
- 04 May, 2022 1 commit
-
-
Callum Moffat authored
* Fix position of CupertinoContextMenu within Transform.scale (#97896) * Fix after rebase
-
- 02 May, 2022 2 commits
-
-
Darren Austin authored
This reverts commit 6ddb99e9.
-
Callum Moffat authored
-
- 26 Mar, 2022 1 commit
-
-
Alex Li authored
-
- 25 Mar, 2022 2 commits
-
-
-
Alex Li authored
-
- 05 Nov, 2021 1 commit
-
-
Markus Aksli authored
-
- 03 Nov, 2021 1 commit
-
-
Markus Aksli authored
-
- 19 Aug, 2021 1 commit
-
-
Hans Muller authored
-
- 18 Aug, 2021 2 commits
-
-
Jenn Magder authored
This reverts commit a1ae4fea.
- 17 Aug, 2021 1 commit
-
-
Alex Li authored
-
- 28 Apr, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 23 Apr, 2021 1 commit
-
-
Kate Lovett authored
Revert "Revert "Fix FlexibleSpaceBar Opacity when AppBar.toolbarHeight > ktoolbarHeight (#80453)" (#80545)" (#80589)
-
- 16 Apr, 2021 1 commit
-
-
Kate Lovett authored
-
- 14 Apr, 2021 1 commit
-
-
Kate Lovett authored
-
- 04 Mar, 2021 1 commit
-
-
Greg Spencer authored
-
- 04 Feb, 2021 1 commit
-
-
Ian Hickson authored
-
- 28 Oct, 2020 1 commit
-
-
Greg Spencer authored
Adds MediaQuery.maybeOf to replace calling MediaQuery.of(context, nullOk: true), and removes the nullOk parameter. Also changes MediaQuery.of to return a non-nullable value, and removes many instances of the ! operator, reducing the possible places where a null dereference could occur.
-
- 08 Oct, 2020 1 commit
-
-
Justin McCandless authored
Just converting some test files to NNBD
-
- 08 Sep, 2020 1 commit
-
-
chunhtai authored
-
- 06 Aug, 2020 1 commit
-
-
chunhtai authored
-