- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the painting and rendering libraries. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 15 Aug, 2023 1 commit
-
-
Kate Lovett authored
Fixes https://github.com/flutter/flutter/issues/130685 This fixes an issue where a GridView/SliverGrid with a SliverChildBuilderDelegate would still reflect a max scroll extent of infinity after returning null from the builder. This change incorporates the same way we handle this case in SliverList: https://github.com/flutter/flutter/blob/6d87a23b3722e4fb2e2db993322d5be4adf04fb5/packages/flutter/lib/src/rendering/sliver_list.dart#L305-L307
-
- 10 Aug, 2023 1 commit
-
-
Ian Hickson authored
-
- 29 Mar, 2023 1 commit
-
-
Kate Lovett authored
Fix SliverGridRegularTileLayout.computeMaxScrollOffset for 0 children
-
- 21 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 02 Nov, 2022 1 commit
-
-
Kate Lovett authored
-
- 07 Oct, 2022 1 commit
-
-
Greg Spencer authored
-
- 08 Jul, 2022 1 commit
-
-
Dan Field authored
-
- 16 Jun, 2022 1 commit
-
-
Dan Field authored
-
- 15 Jun, 2022 1 commit
-
-
Dan Field authored
* Make RenderSliverGrid more accurately report overflow * Update packages/flutter/lib/src/rendering/sliver_grid.dart Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: Kate Lovett <katelovett@google.com>
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `rendering` * fix comments * fix dangling
-
- 18 May, 2022 1 commit
-
-
gaaclarke authored
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 04 Oct, 2021 1 commit
-
-
Greg Spencer authored
This does a cleanup of the examples, removing all of the "section" markers and extra comments that we don't need anymore now that the samples are no longer in the source code. It also removes the --template arguments from the {@tool dartpad} and {@tool sample} directives, since those are no longer used. It converts two examples that I discovered were still embedded into linked examples in the examples folder. I didn't delete the templates from the snippets config folder yet, because there are still embedded samples in the dart:ui package from the engine that use them. Once dart:ui no longer uses the templates, they can be removed. I bumped the version of the snippets package to pick up a change that allows removal of the --template argument.
-
- 25 Aug, 2021 1 commit
-
-
Greg Spencer authored
This extracts the sample code out from the API doc comments, and places them in separate files on disk, allowing running of the examples locally, testing them, and building of slightly larger examples.
-
- 03 Apr, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 Mar, 2021 1 commit
-
-
Greg Spencer authored
Update samples to use repo analysis options, Fix sample templates and a ton of analyzer issues (#77868)
-
- 18 Feb, 2021 1 commit
-
-
Chinmoy authored
-
- 01 Feb, 2021 1 commit
-
-
chunhtai authored
-
- 23 Dec, 2020 1 commit
-
-
Chinmoy authored
Added mainAxisExtent to SliverGridDelegateWithFixedCrossAxisCount and SliverGridDelegateWithMaxCrossAxisExtent (#71376)
-
- 27 Sep, 2020 1 commit
-
-
Alexandre Ardhuin authored
* apply upcoming lint cast_nullable_to_non_nullable * make RenderObjectElement.renderObject non-nullable
-
- 08 Sep, 2020 1 commit
-
-
Pedro Massango authored
-
- 03 Sep, 2020 1 commit
-
-
Kate Lovett authored
-
- 28 Aug, 2020 1 commit
-
-
gaowanqiu authored
-
- 27 Aug, 2020 1 commit
-
-
Ian Hickson authored
-
- 08 Jul, 2020 1 commit
-
-
Kate Lovett authored
-
- 11 Jun, 2020 1 commit
-
-
Alexandre Ardhuin authored
* add language version 2.8 in packages/flutter * enable non-nullable analyzer flag
-
- 28 Feb, 2020 1 commit
-
-
Jonah Williams authored
This reverts commit 2132a0c7.
-
- 26 Feb, 2020 1 commit
-
- 25 Feb, 2020 1 commit
-
-
Ferhat authored
-
- 22 Jan, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 04 Dec, 2019 1 commit
-
-
Alexandre Ardhuin authored
* implicit-casts:false in flutter/lib/src/rendering * address review comments
-
- 27 Nov, 2019 1 commit
-
-
Ian Hickson authored
* Update project.pbxproj files to say Flutter rather than Chromium Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright. * Update the copyright notice checker to require a standard notice on all files * Update copyrights on Dart files. (This was a mechanical commit.) * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine. Some were already marked "The Flutter Authors", not clear why. Their dates have been normalized. Some were missing the blank line after the license. Some were randomly different in trivial ways for no apparent reason (e.g. missing the trailing period). * Clean up the copyrights in non-Dart files. (Manual edits.) Also, make sure templates don't have copyrights. * Fix some more ORGANIZATIONNAMEs
-
- 30 May, 2019 1 commit
-
-
chunhtai authored
-
- 20 Feb, 2019 1 commit
-
-
Ali EP authored
-
- 12 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint unnecessary_new * fix tests * fix tests * fix tests
-
- 05 Jun, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 04 May, 2018 1 commit
-
-
Michael Goderbauer authored
-
- 05 Feb, 2018 1 commit
-
-
Ian Hickson authored
* Fix scrolling of multiple SliverLists and SliverGrids * Update sliver_fixed_extent_list.dart * Update sliver_grid.dart
-
- 17 Nov, 2017 1 commit
-
-
Greg Spencer authored
I got tired of drive-by spelling fixes, so I figured I'd just take care of them all at once. This only corrects errors in the dartdocs, not regular comments, and I skipped any sample code in the dartdocs. It doesn't touch any identifiers in the dartdocs either. No code changes, just comments.
-