Commits · dab0d18933042cc8c160430981b5b5a5b0b426fb · abdullh.alsoleman / Front-End

03 Mar, 2024 1 commit

Roll Flutter Engine from 2706c732b22a to 024ea680ceed (1 revision) (#144519) · dab0d189

engine-flutter-autoroll authored Mar 03, 2024

https://github.com/flutter/engine/compare/2706c732b22a...024ea680ceed

2024-03-03 zanderso@users.noreply.github.com Fold the GN dart_pkg template into its only use (flutter/engine#51151)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dab0d189

02 Mar, 2024 2 commits

Roll Flutter Engine from 8ef8543d6001 to 2706c732b22a (1 revision) (#144493) · 65cd84b5

engine-flutter-autoroll authored Mar 02, 2024

https://github.com/flutter/engine/compare/8ef8543d6001...2706c732b22a

2024-03-01 jason-simmons@users.noreply.github.com [Impeller] ASAN/LSAN fixes for the mock Vulkan implementation (flutter/engine#51115)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

65cd84b5

[github actions] rewrite cherry pick template (#144065) · 09b7a1c7

Xilai Zhang authored Mar 02, 2024

Context: @godofredoc pointed out that the fields in the PR template could be simplified and redesigned. Synced with @itsjustkevin and Kevin come up with [changes in this doc](https://docs.google.com/document/d/1Slppqq32toSwwxUyYTX1t6dGUQpyi0xEWxw4niGWspc/edit?resourcekey=0-v6U_9XVsMFSx0Fvx1rANhg&tab=t.0) which would improve the cherry pick template.

Github only supports a limited number of formatting options. This PR uses some workarounds and makes the following changes:
1. use divider to replace text area since Github markdown doesn't support text area
2. remove \<pre\> tags so texts can wrap around
3. use headings over bold
4. use task lists to identify the starting points of user answers

An example cherry pick template would [look like this](https://github.com/flutter/flutter/pull/143785) after the change.

09b7a1c7

01 Mar, 2024 19 commits

Roll Flutter Engine from 2a5a9a6dead0 to 8ef8543d6001 (1 revision) (#144480) · 18712edc

engine-flutter-autoroll authored Mar 01, 2024

https://github.com/flutter/engine/compare/2a5a9a6dead0...8ef8543d6001

2024-03-01 skia-flutter-autoroll@skia.org Roll Skia from b44ad3d40f54 to a57372ca2e66 (1 revision) (flutter/engine#51122)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

18712edc

Roll Packages from 6d02f0359368 to a9c68b83356b (5 revisions) (#144477) · d93f5b7e

engine-flutter-autoroll authored Mar 01, 2024

https://github.com/flutter/packages/compare/6d02f0359368...a9c68b83356b

2024-03-01 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.5 to 3.24.6 (flutter/packages#6234)
2024-02-29 stuartmorgan@google.com [various] Standardize Obj-C doc comment style (flutter/packages#6232)
2024-02-29 joonas.kerttula@codemate.com [google_maps_flutter] Add support for marker clustering - platform interface (flutter/packages#6158)
2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter (stable) from abb292a07e20 to 7482962148e8 (1 revision) (flutter/packages#6230)
2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter from d00bfe82 to e92bca3f (15 revisions) (flutter/packages#6227)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d93f5b7e

Fix `showDateRangePicker` is missing `dartpad` tag and cleanup (#144475) · 9a838455

Taha Tesser authored Mar 01, 2024

fixes [`showDateRangePicker` interactive sample not loading](https://github.com/flutter/flutter/issues/144474)

### Description 

This fixes `showDateRangePicker` example not loading in Dartpad.

Similar fix was made for `showDatePicker` in https://github.com/flutter/flutter/pull/99401

9a838455

Fix `CalendarDatePicker` day selection shape and overlay (#144317) · ba719bc5

Taha Tesser authored Mar 01, 2024

fixes [`DatePickerDialog` date entry hover background and ink splash have different radius](https://github.com/flutter/flutter/issues/141350)
fixes [Ability to customize DatePicker day selection background and overlay shape](https://github.com/flutter/flutter/issues/144220)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: Center(
          child: Builder(builder: (context) {
            return FilledButton(
              onPressed: () {
                showDatePicker(
                  context: context,
                  initialDate: DateTime.now(),
                  firstDate: DateTime.utc(2010),
                  lastDate: DateTime.utc(2030),
                );
              },
              child: const Text('Show Date picker'),
            );
          }),
        ),
      ),
    );
  }
}
```

</details>

### Material DatePicker states specs

![overlay_specs](https://github.com/flutter/flutter/assets/48603081/45ce16cf-7ee9-41e1-a4fa-327de07b78d1)

### Day selection overlay

| Before | After |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/b529d38d-0232-494b-8bf2-55d28420a245" /> | <img src="https://github.com/flutter/flutter/assets/48603081/c4799559-a7ef-45fd-aed9-aeb386370580"  /> |

### Hover, pressed, highlight preview

| Before | After |
| --------------- | --------------- |
| <video src="https://github.com/flutter/flutter/assets/48603081/8edde82a-7f39-4482-afab-183e1bce5991" /> | <video src="https://github.com/flutter/flutter/assets/48603081/04e1502e-67a4-4b33-973d-463067d70151" /> |

### Using `DatePickerThemeData.dayShape` to customize day selection background and overlay shape

| Before | After |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/a0c85f58-a69b-4e14-a45d-41e580ceedce"  />  | <img src="https://github.com/flutter/flutter/assets/48603081/db67cee1-d28d-4168-98b8-fd7a9cb70cda" /> | 

### Example preview

![Screenshot 2024-02-29 at 15 07 50](https://github.com/flutter/flutter/assets/48603081/3770ed5c-28bf-4d0a-9514-87e1cd2ce515)

ba719bc5

Fix chips use square delete button `InkWell` shape instead of circular (#144319) · cfabdca9

Taha Tesser authored Mar 01, 2024

fixes [Chips delete button hover style is square, not circular](https://github.com/flutter/flutter/issues/141335)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: Center(
          child: RawChip(
            label: const Text('Test'),
            onPressed: null,
            deleteIcon: const Icon(Icons.clear, size: 18),
            onDeleted: () {},
          ),
        ),
      ),
    );
  }
}
```

</details>

### Preview

| Before | After |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/c5d62c57-97b3-4f94-b83d-df13559ee3a8" /> | <img src="https://github.com/flutter/flutter/assets/48603081/b76edaab-73e0-4aa9-8ca2-127eedd77814"  /> |

cfabdca9

InputDecorator M3 tests migration - Step4 - Hint tests (#144169) · e8f8a8dc

Bruno Leroux authored Mar 01, 2024

## Description

This PR migrate hint related tests to M3 and adds some missing tests.

It is the fourth step for the M3 test migration for `InputDecorator`.
Step 1: https://github.com/flutter/flutter/pull/142981
Step 2: https://github.com/flutter/flutter/pull/143369
Step 3: https://github.com/flutter/flutter/pull/143520

## Related Issue

Related to https://github.com/flutter/flutter/issues/139076

e8f8a8dc

Roll Flutter Engine from f0037d4fbd67 to 2a5a9a6dead0 (1 revision) (#144468) · f7f4c242

engine-flutter-autoroll authored Mar 01, 2024

https://github.com/flutter/engine/compare/f0037d4fbd67...2a5a9a6dead0

2024-03-01 skia-flutter-autoroll@skia.org Roll Skia from d672d0fe2f0d to b44ad3d40f54 (1 revision) (flutter/engine#51121)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f7f4c242

Roll Flutter Engine from 16e04d264145 to f0037d4fbd67 (1 revision) (#144464) · ca2fb7e8

engine-flutter-autoroll authored Mar 01, 2024

https://github.com/flutter/engine/compare/16e04d264145...f0037d4fbd67

2024-03-01 skia-flutter-autoroll@skia.org Roll Skia from 002f4366e473 to d672d0fe2f0d (2 revisions) (flutter/engine#51119)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ca2fb7e8

Roll Flutter Engine from 1dff89788b18 to 16e04d264145 (1 revision) (#144459) · d2a04ff3

engine-flutter-autoroll authored Mar 01, 2024

https://github.com/flutter/engine/compare/1dff89788b18...16e04d264145

2024-03-01 skia-flutter-autoroll@skia.org Roll Skia from 5961ed9c1d99 to 002f4366e473 (1 revision) (flutter/engine#51117)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d2a04ff3

Horizontally expand text selection toolbar buttons in overflow menu (#144391) · 8a312cd0

Bruno Leroux authored Mar 01, 2024

## Description

This PR expands the items displayed in the overflow menu of a `TextSelectionToolbar` making buttons clickable in the blank area.

| Before | After |
|--------|--------|
| Each item has its own width | All items expand horizontally |
|  ![Capture dâeÌcran 2024-02-29 aÌ 14 43 57](https://github.com/flutter/flutter/assets/840911/f7379eef-9185-4cc4-bf14-e4c916c432b1) | ![Capture dâeÌcran 2024-02-29 aÌ 14 40 47](https://github.com/flutter/flutter/assets/840911/bff272cd-9fe2-4f07-adaf-61edef03d26e) | 

## Related Issue

Fixes https://github.com/flutter/flutter/issues/144089.

## Tests

Adds 1 tests.

8a312cd0

Roll Flutter Engine from f68cc57cbe12 to 1dff89788b18 (2 revisions) (#144457) · 263ffe5f

engine-flutter-autoroll authored Mar 01, 2024

https://github.com/flutter/engine/compare/f68cc57cbe12...1dff89788b18

2024-03-01 jason-simmons@users.noreply.github.com [Impeller] Fix string search in CompilerTest.SkSLTextureLookUpOrderOfOperations (flutter/engine#51109)
2024-03-01 jason-simmons@users.noreply.github.com [Impeller] Fix vertex counts in some display list tests (flutter/engine#51111)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

263ffe5f

Roll Flutter Engine from 76140bc9cec9 to f68cc57cbe12 (2 revisions) (#144455) · ab10e2b1

engine-flutter-autoroll authored Mar 01, 2024

https://github.com/flutter/engine/compare/76140bc9cec9...f68cc57cbe12

2024-03-01 jason-simmons@users.noreply.github.com [Impeller] Fix leak of rectangle packer in typographer tests (flutter/engine#51113)
2024-03-01 skia-flutter-autoroll@skia.org Roll Skia from 01d9566c4db8 to 5961ed9c1d99 (13 revisions) (flutter/engine#51106)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ab10e2b1

Roll Flutter Engine from f300ced56a4e to 76140bc9cec9 (1 revision) (#144453) · 7d5dabab

engine-flutter-autoroll authored Mar 01, 2024

https://github.com/flutter/engine/compare/f300ced56a4e...76140bc9cec9

2024-03-01 zanderso@users.noreply.github.com Run apple SDK finders as gclient hooks (flutter/engine#50957)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7d5dabab

Roll Flutter Engine from 34cf95c7bd82 to f300ced56a4e (1 revision) (#144452) · af4d327a

engine-flutter-autoroll authored Mar 01, 2024

https://github.com/flutter/engine/compare/34cf95c7bd82...f300ced56a4e

2024-03-01 matanlurey@users.noreply.github.com Add a basic e2e-test for `skia_gold_client`. (flutter/engine#51078)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

af4d327a

Roll Flutter Engine from 0db468f7bae5 to 34cf95c7bd82 (1 revision) (#144450) · a78a0d59

engine-flutter-autoroll authored Mar 01, 2024

https://github.com/flutter/engine/compare/0db468f7bae5...34cf95c7bd82

2024-03-01 john@johnmccutchan.com Add et run command (flutter/engine#51037)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a78a0d59

Roll Flutter Engine from 6f8044436eb3 to 0db468f7bae5 (3 revisions) (#144448) · e601f047

engine-flutter-autoroll authored Mar 01, 2024

https://github.com/flutter/engine/compare/6f8044436eb3...0db468f7bae5

2024-03-01 34871572+gmackall@users.noreply.github.com Add instructions for getting code coverage in Android Studio (flutter/engine#51105)
2024-02-29 skia-flutter-autoroll@skia.org Roll Skia from 139461270500 to 01d9566c4db8 (1 revision) (flutter/engine#51093)
2024-02-29 skia-flutter-autoroll@skia.org Manual roll Dart SDK from fdf4a62bd07b to 728fcf0bcbca (3 revisions) (flutter/engine#51098)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e601f047

Remove master from API docs (#144425) · 52bb198f
Michael Goderbauer authored Mar 01, 2024

52bb198f
Enable missing-code-block-language (#144443) · 6995275b
Michael Goderbauer authored Mar 01, 2024

6995275b

Roll Flutter Engine from 7e8fefe4a084 to 6f8044436eb3 (5 revisions) (#144436) · 8e418d18

engine-flutter-autoroll authored Mar 01, 2024

https://github.com/flutter/engine/compare/7e8fefe4a084...6f8044436eb3

2024-02-29 jonahwilliams@google.com [Impeller] use specific format for bootstrap texture. (flutter/engine#51082)
2024-02-29 jonahwilliams@google.com [Impeller] remove warning about device transient depth+stencil. (flutter/engine#51033)
2024-02-29 robert.ancell@canonical.com Refactor GL rendering to prepare for GTK4 (flutter/engine#50754)
2024-02-29 jacksongardner@google.com Reland "[skwasm] Clip pictures if they go beyond the bounds of the window." (flutter/engine#51077)
2024-02-29 matej.knopp@gmail.com Revert "[macOS] Use CVDisplayLink to drive repaint (#49159)" (flutter/engine#51095)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8e418d18

29 Feb, 2024 18 commits

Bump github/codeql-action from 3.24.5 to 3.24.6 (#144424) · fe56a356

dependabot[bot] authored Feb 29, 2024

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.5 to 3.24.6.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.24.6 - 29 Feb 2024</h2>
<p>No user facing changes.</p>
<h2>3.24.5 - 23 Feb 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.3. <a href="https://redirect.github.com/github/codeql-action/pull/2156">#2156</a></li>
</ul>
<h2>3.24.4 - 21 Feb 2024</h2>
<ul>
<li>Fix an issue where an existing, but empty, <code>/sys/fs/cgroup/cpuset.cpus</code> file always resulted in a single-threaded run. <a href="https://redirect.github.com/github/codeql-action/pull/2151">#2151</a></li>
</ul>
<h2>3.24.3 - 15 Feb 2024</h2>
<ul>
<li>Fix an issue where the CodeQL Action would fail to load a configuration specified by the <code>config</code> input to the <code>init</code> Action. <a href="https://redirect.github.com/github/codeql-action/pull/2147">#2147</a></li>
</ul>
<h2>3.24.2 - 15 Feb 2024</h2>
<ul>
<li>Enable improved multi-threaded performance on larger runners for GitHub Enterprise Server users. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/2141">#2141</a></li>
</ul>
<h2>3.24.1 - 13 Feb 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.2. <a href="https://redirect.github.com/github/codeql-action/pull/2124">#2124</a></li>
<li>The CodeQL action no longer fails if it can't write to the telemetry api endpoint. <a href="https://redirect.github.com/github/codeql-action/pull/2121">#2121</a></li>
</ul>
<h2>3.24.0 - 02 Feb 2024</h2>
<ul>
<li>CodeQL Python analysis will no longer install dependencies on GitHub Enterprise Server, as is already the case for GitHub.com. See <a href="https://github.com/github/codeql-action/blob/main/#3230---08-jan-2024">release notes for 3.23.0</a> for more details. <a href="https://redirect.github.com/github/codeql-action/pull/2106">#2106</a></li>
</ul>
<h2>3.23.2 - 26 Jan 2024</h2>
<ul>
<li>On Linux, the maximum possible value for the <code>--threads</code> option now respects the CPU count as specified in <code>cgroup</code> files to more accurately reflect the number of available cores when running in containers. <a href="https://redirect.github.com/github/codeql-action/pull/2083">#2083</a></li>
<li>Update default CodeQL bundle version to 2.16.1. <a href="https://redirect.github.com/github/codeql-action/pull/2096">#2096</a></li>
</ul>
<h2>3.23.1 - 17 Jan 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.0. <a href="https://redirect.github.com/github/codeql-action/pull/2073">#2073</a></li>
<li>Change the retention period for uploaded debug artifacts to 7 days. Previously, this was whatever the repository default was. <a href="https://redirect.github.com/github/codeql-action/pull/2079">#2079</a></li>
</ul>
<h2>3.23.0 - 08 Jan 2024</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/8a470fddafa5cbb6266ee11b37ef4d8aae19c571"><code>8a470fd</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2176">#2176</a> from github/update-v3.24.6-158d0780d</li>
<li><a href="https://github.com/github/codeql-action/commit/d59eafb69b1bbf6ebc4592895da945a4cc588806"><code>d59eafb</code></a> Update changelog for v3.24.6</li>
<li><a href="https://github.com/github/codeql-action/commit/158d0780dc10ed5108b9fb567ea80a54c245dd67"><code>158d078</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2175">#2175</a> from github/henrymercer/fix-languages-init-success</li>
<li><a href="https://github.com/github/codeql-action/commit/2307ff547f1c8a003d306eede350ccff46e0e65d"><code>2307ff5</code></a> Add <code>languages</code> and <code>build_mode</code> to <code>init</code> <code>success</code> status report</li>
<li><a href="https://github.com/github/codeql-action/commit/ccd3f0254505d3abf6b996df24b8cc9a0d77c98f"><code>ccd3f02</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2173">#2173</a> from github/henrymercer/mark-third-party-limits-erro...</li>
<li><a href="https://github.com/github/codeql-action/commit/c0917251d4d0392e762284c11e2c9c1b82195af1"><code>c091725</code></a> Refactoring: Convert <code>ActionName</code> to enum</li>
<li><a href="https://github.com/github/codeql-action/commit/e12a8cc5eb90431cfed6096ac78c48448b5cf331"><code>e12a8cc</code></a> Use <code>isFirstPartyAnalysis</code> for a stronger check</li>
<li><a href="https://github.com/github/codeql-action/commit/888ab31e3edfe95e943195e117426658cc6a3802"><code>888ab31</code></a> Mark third-party SARIF limits errors as configuration errors</li>
<li><a href="https://github.com/github/codeql-action/commit/bd56a05133734527a524799b550f71febf4597b9"><code>bd56a05</code></a> Rename <code>InvalidRequestError</code> to <code>InvalidSarifUploadError</code></li>
<li><a href="https://github.com/github/codeql-action/commit/7bde9061b48b68e993ca909411613cf15bd12708"><code>7bde906</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2172">#2172</a> from github/henrymercer/fix-readme-typos</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/47b3d888fe66b639e431abf22ebca059152f1eea...8a470fddafa5cbb6266ee11b37ef4d8aae19c571">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.24.5&new-version=3.24.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

fe56a356

Reland [a11y] Fix date picker cannot focus on the edit field (#144198) · 14b914ab

hangyu authored Feb 29, 2024

reland https://github.com/flutter/flutter/pull/143117 


fixes: https://github.com/flutter/flutter/issues/143116
fixes: https://github.com/flutter/flutter/issues/141992

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes

14b914ab

Reland "Use dartpad's main channel for master/main docs (#144329)" (#144431) · e41ffcb7

Michael Goderbauer authored Feb 29, 2024

Fix is in the second commit. The logic here went out of sync with the logic in the snippets generator from https://github.com/flutter/assets-for-api-docs, whose version was bumped as part of this change.

e41ffcb7

Make daemon server work on ipv6-only machines. (#144359) · f3ce9d2f
Lau Ching Jun authored Feb 29, 2024
```
Retry binding on ipv6 if binding on ipv4 failed.
```
f3ce9d2f

Remove deprecated `backgroundColor` from `ThemeData` (#144079) · ee6111a7

Qun Cheng authored Feb 29, 2024

This PR is to remove deprecated ThemeData.backgroundColor.

These parameters are made obsolete in https://github.com/flutter/flutter/pull/110162.
Part of https://github.com/flutter/flutter/issues/143956

ee6111a7

Add stateful reordering test for TwoDimensionalViewport (#142375) · 60688913

Amir Panahandeh authored Feb 29, 2024

Adds a test to validate state is preserved after reordering in `TwoDimensionalViewport` (reference: https://github.com/flutter/flutter/pull/141504#pullrequestreview-1837501775).

- Fixes #130754

60688913

Always use local CanvasKit/Skwasm in benchmarks for better hermeticity. (#144423) · 203ec8b8
Jackson Gardner authored Feb 29, 2024
```
We should avoid hitting gstatic in the benchmarks and just use local canvaskit/skwasm instead.
```
203ec8b8

Roll Flutter Engine from bb6c6a01000f to 7e8fefe4a084 (2 revisions) (#144419) · 90b956ce

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/bb6c6a01000f...7e8fefe4a084

2024-02-29 kevmoo@users.noreply.github.com [web] Drop noisy prints from bootstrapping logic (flutter/engine#51097)
2024-02-29 jacksongardner@google.com Fix a few issues rendering text with Skwasm. (flutter/engine#51074)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

90b956ce

Fix a crash in remote device daemon. (#144358) · cfa011dd

Lau Ching Jun authored Feb 29, 2024

The daemon server is expecting the client to pass `deviceId` in `device.shutdownDartDevelopmentService` method.

https://github.com/flutter/flutter/blob/24a792dae105e281962a7e3e4c35cbfd9652ff0a/packages/flutter_tools/lib/src/commands/daemon.dart#L1239

cfa011dd

Reverts "Use dartpad's main channel for master/main docs (#144329)" (#144429) · b099bf0b

auto-submit[bot] authored Feb 29, 2024

Reverts flutter/flutter#144329
Initiated by: goderbauer
Reason for reverting: broke postsubmit doc generation.
Original PR Author: goderbauer

Reviewed By: {devoncarew, HansMuller, gspencergoog}

This change reverts the following previous change:
Original Description:
Dartpad doesn't have a "master" channel anymore, it got renamed to "main". Sadly, specifying "master" is now falling back to "stable" which breaks some of our examples in the docs that require a more current Flutter version, e.g. https://main-api.flutter.dev/flutter/material/TextButton-class.html

b099bf0b

Remove `toggleableActiveColor` from `ThemeData` (#144178) · 1349c591

Qun Cheng authored Feb 29, 2024

This PR is to remove deprecated ThemeData.toggleableActiveColor.

These parameters are made obsolete in https://github.com/flutter/flutter/pull/97972.
Part of https://github.com/flutter/flutter/pull/111080

1349c591

Add `FocusNode.focusabilityListenable` (#144280) · 726e5d28

LongCatIsLooong authored Feb 29, 2024

This is for https://github.com/flutter/flutter/issues/127803: a text field should unregister from the scribble scope, when it becomes unfocusable. 

When a `FocusNode` has listeners and its `_canRequestFocus` flag is set to true, it adds `+1` to `_focusabilityListeningDescendantCount` of all ancestors until it reaches the first ancestor with `descendantsAreFocusable = false`. When the a `FocusNode`'s `descendantsAreFocusable` changes, all listeners that contributed to its `_focusabilityListeningDescendantCount` will be notified.

726e5d28

Roll Flutter Engine from 1f24eaa4979d to bb6c6a01000f (2 revisions) (#144416) · 1abc5cdf

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/1f24eaa4979d...bb6c6a01000f

2024-02-29 jonahwilliams@google.com [Impeller] test removal of submit batching. (flutter/engine#51094)
2024-02-29 zanderso@users.noreply.github.com Use RBE for mac_clang_tidy (flutter/engine#51083)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1abc5cdf

[devicelab] fix motog4 tests and update comment. (#144410) · ec8fcbce

Jonah Williams authored Feb 29, 2024

Fixes https://github.com/flutter/flutter/issues/144406

The A02 have also been running Vulkan for quite a while.

ec8fcbce

Bump dartdocs to 8.0.6 (#144413) · 24a792da
Michael Goderbauer authored Feb 29, 2024

24a792da

Use dartpad's main channel for master/main docs (#144329) · 41eeb2bb

Michael Goderbauer authored Feb 29, 2024

Dartpad doesn't have a "master" channel anymore, it got renamed to "main". Sadly, specifying "master" is now falling back to "stable" which breaks some of our examples in the docs that require a more current Flutter version, e.g. https://main-api.flutter.dev/flutter/material/TextButton-class.html

41eeb2bb

Roll Flutter Engine from 7b3ef43fa7e6 to 1f24eaa4979d (2 revisions) (#144405) · bcb0f901

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/7b3ef43fa7e6...1f24eaa4979d

2024-02-29 dnfield@google.com Reapply "Bump everything to Android 21" (#51056) (flutter/engine#51070)
2024-02-29 737941+loic-sharma@users.noreply.github.com [Windows] Add view ID runner APIs (flutter/engine#51020)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bcb0f901

Roll Flutter Engine from 7dd404724c50 to 7b3ef43fa7e6 (1 revision) (#144399) · ab4bf7c1

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/7dd404724c50...7b3ef43fa7e6

2024-02-29 skia-flutter-autoroll@skia.org Roll Skia from 05a8d57f0e61 to 139461270500 (1 revision) (flutter/engine#51091)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ab4bf7c1