Commits · da23eae33f7274e181a401ca78ddd4c4e3087208 · abdullh.alsoleman / Front-End

07 Nov, 2023 10 commits

[native assets] Tool exit on build failure (#137995) · da23eae3

Daco Harkes authored Nov 07, 2023

If the native assets feature is enabled, and the `build.dart` invocation fails, the `flutter build` and `flutter run` should abort.

Closes: https://github.com/flutter/flutter/issues/137910

da23eae3

Roll Packages from 49eac1fec6c7 to be18d282c5e7 (3 revisions) (#137999) · 5a6a3224

engine-flutter-autoroll authored Nov 07, 2023

https://github.com/flutter/packages/compare/49eac1fec6c7...be18d282c5e7

2023-11-06 engine-flutter-autoroll@skia.org Roll Flutter from 29b25165 to f5a98353 (101 revisions) (flutter/packages#5341)
2023-11-06 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.9.10 to 1.9.20 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#5334)
2023-11-06 krozett@gmail.com [flutter_markdown] Strip leading whitespace from list items (flutter/packages#5294)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5a6a3224

Roll Flutter Engine from b1f2581f05e3 to b91400976b4a (2 revisions) (#138000) · 68e95b9e

engine-flutter-autoroll authored Nov 07, 2023

https://github.com/flutter/engine/compare/b1f2581f05e3...b91400976b4a

2023-11-07 skia-flutter-autoroll@skia.org Roll Skia from 3ac7216f1f6d to 71d865c5211e (1 revision) (flutter/engine#47746)
2023-11-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from NaQb_BU6PSbKXSAoU... to VcFEJiUUTYwkhEAlJ... (flutter/engine#47745)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from NaQb_BU6PSbK to VcFEJiUUTYwk

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

68e95b9e

Roll Flutter Engine from 633065f75b1c to b1f2581f05e3 (1 revision) (#137997) · c1d11b1d

engine-flutter-autoroll authored Nov 07, 2023

https://github.com/flutter/engine/compare/633065f75b1c...b1f2581f05e3

2023-11-07 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from wmM4lS2lYcphFSHPV... to CssR5Ci8l8Wn47xEJ... (flutter/engine#47744)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from wmM4lS2lYcph to CssR5Ci8l8Wn

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c1d11b1d

Roll Flutter Engine from 99149d59cb3d to 633065f75b1c (1 revision) (#137996) · 1b63c299

engine-flutter-autoroll authored Nov 07, 2023

https://github.com/flutter/engine/compare/99149d59cb3d...633065f75b1c

2023-11-07 skia-flutter-autoroll@skia.org Roll Skia from 9fd258076b4d to 3ac7216f1f6d (2 revisions) (flutter/engine#47743)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1b63c299

Roll Flutter Engine from 7f4d56a7f4f7 to 99149d59cb3d (1 revision) (#137987) · 5ff09c27

engine-flutter-autoroll authored Nov 07, 2023

https://github.com/flutter/engine/compare/7f4d56a7f4f7...99149d59cb3d

2023-11-07 jiahaog@users.noreply.github.com Fix ImmutableEnum lint (flutter/engine#47739)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5ff09c27

Roll Flutter Engine from f9f822359f2b to 7f4d56a7f4f7 (1 revision) (#137983) · 6007b91a

engine-flutter-autoroll authored Nov 07, 2023

https://github.com/flutter/engine/compare/f9f822359f2b...7f4d56a7f4f7

2023-11-07 skia-flutter-autoroll@skia.org Roll Dart SDK from aded6314af29 to 15c286ed91ea (1 revision) (flutter/engine#47738)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6007b91a

Roll Flutter Engine from b1a5d772792f to f9f822359f2b (1 revision) (#137980) · 1402d994

engine-flutter-autoroll authored Nov 07, 2023

https://github.com/flutter/engine/compare/b1a5d772792f...f9f822359f2b

2023-11-07 skia-flutter-autoroll@skia.org Roll Skia from 9106e374e08d to 9fd258076b4d (1 revision) (flutter/engine#47735)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1402d994

Roll Flutter Engine from 461d815b48a0 to b1a5d772792f (13 revisions) (#137979) · be81cccd

engine-flutter-autoroll authored Nov 07, 2023

https://github.com/flutter/engine/compare/461d815b48a0...b1a5d772792f

2023-11-07 skia-flutter-autoroll@skia.org Roll Skia from 7e3119240ae4 to 9106e374e08d (1 revision) (flutter/engine#47732)
2023-11-07 skia-flutter-autoroll@skia.org Roll Dart SDK from 82731b940e7f to aded6314af29 (1 revision) (flutter/engine#47731)
2023-11-07 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from HQfFSkurc6-jKM2jh... to wmM4lS2lYcphFSHPV... (flutter/engine#47730)
2023-11-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from _vGlgDiKOrtlKrZAP... to NaQb_BU6PSbKXSAoU... (flutter/engine#47728)
2023-11-07 skia-flutter-autoroll@skia.org Roll Skia from bd5f57c9bd1a to 7e3119240ae4 (10 revisions) (flutter/engine#47726)
2023-11-06 gspencergoog@users.noreply.github.com Add `KeyEventDeviceType` to `KeyData` (flutter/engine#47315)
2023-11-06 skia-flutter-autoroll@skia.org Roll Skia from 2b218381e226 to bd5f57c9bd1a (2 revisions) (flutter/engine#47719)
2023-11-06 skia-flutter-autoroll@skia.org Roll Dart SDK from 07d4c9d85a5a to 82731b940e7f (1 revision) (flutter/engine#47717)
2023-11-06 skia-flutter-autoroll@skia.org Roll Skia from 77aeee3b81a5 to 2b218381e226 (1 revision) (flutter/engine#47715)
2023-11-06 30870216+gaaclarke@users.noreply.github.com [Impeller] scales blur coverage to match rendered output (flutter/engine#47621)
2023-11-06 jonahwilliams@google.com [Impeller] Fix EntityPassTarget::Flip with implict MSAA. (flutter/engine#47701)
2023-11-06 skia-flutter-autoroll@skia.org Roll Dart SDK from 9211fc6406bb to 07d4c9d85a5a (1 revision) (flutter/engine#47709)
2023-11-06 jonahwilliams@google.com [Impeller] fix drawVertices dest fast path to apply alpha. (flutter/engine#47695)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from _vGlgDiKOrtl to NaQb_BU6PSbK
fuchsia/sdk/core/mac-amd64 from HQfFSkurc6-j to wmM4lS2lYcph

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

be81cccd

Roll Flutter Engine from bdfa8aa8f81f to 461d815b48a0 (1 revision) (#137944) · 156ba0f7

engine-flutter-autoroll authored Nov 07, 2023

https://github.com/flutter/engine/compare/bdfa8aa8f81f...461d815b48a0

2023-11-06 zanderso@users.noreply.github.com Move some Dart packages to
//flutter/third_party/pkg (flutter/engine#47654)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

156ba0f7

06 Nov, 2023 18 commits

SemanticsHandle should dispatch creation and disposal events. (#137960) · c0b21b16
Kostia Sokolovskyi authored Nov 06, 2023

c0b21b16
ScrollActivity should dispatch creation and disposal events. (#137961) · 4880aab1
Kostia Sokolovskyi authored Nov 06, 2023

4880aab1
Cover text_selection tests with leak tracking. (#137009) · 2d9a075d
Kostia Sokolovskyi authored Nov 06, 2023

2d9a075d
Roll pub packages (#137862) · db57d286
flutter-pub-roller-bot authored Nov 06, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
db57d286

Migration for `HotEvent` for Flutter hot runner (#137717) · 17e0fe1a

Elias Yishak authored Nov 06, 2023

Related to tracker issue:
- https://github.com/flutter/flutter/issues/128251

For this migration, the `HotEvent` was being referenced in 2 additional files outside of `lib/src/reporting/events.dart`, shown below in the screenshot

<img width="257" alt="image" src="https://github.com/flutter/flutter/assets/42216813/97986f89-2253-4db1-9deb-bbced6321a16">

17e0fe1a

[benchmarks] disable partial repaint for multiple backdrop blur iOS macrobenchmarks. (#137902) · 925f3eee

Jonah Williams authored Nov 06, 2023

Partial repaint is too effective, and we'd like to be able to measure performance without carefully structuring the benchmarks. For example, right now partial repaint is culling any blurs in the multibackdrop case, which we should be using to track  https://github.com/flutter/flutter/issues/132735

925f3eee

Check sample links for malformed links (#137807) · f5a98353

Greg Spencer authored Nov 06, 2023

## Description

This checks API doc strings for malformed links to examples. It prevents errors in capitalization, spacing, number of asterisks, etc.  It won't catch all errors, because it needs to have a minimally indicative string to know that it even is trying to be a link to an example.  At a minimum, the line needs to look like (literally, not as a regexp) `///*seecode.*` in order to be seen as a link to an example.

Separately, I'm going to add a check to the snippets tool that checks to make sure that an `{@tool}` block includes either a link to a sample file or a dart code block.

## Tests
 - Added a test to make sure it catches some malformed links.

f5a98353

Change cast in json parsing (#137708) · defa4bce

Ivan Inozemtsev authored Nov 06, 2023

`jsonDecode` decodes lists as `List<Object?>`, so the cast to `List<Object>` fails at runtime in sound null safety mode.

defa4bce

Reverts "Update BottomNavigationBar tests for M3" (#137948) · 3649deb3

auto-submit[bot] authored Nov 06, 2023

Reverts flutter/flutter#136624
Initiated by: HansMuller
This change reverts the following previous change:
Original Description:
This PR updates `BottomNavigationBar` unit tests for M3 migration.

More info in https://github.com/flutter/flutter/issues/127064

It was somewhat complex because existing tests relied on a lot of magic numbers.

3649deb3

Roll Packages from cccf5d24d703 to 49eac1fec6c7 (2 revisions) (#137943) · 1d66b364

engine-flutter-autoroll authored Nov 06, 2023

https://github.com/flutter/packages/compare/cccf5d24d703...49eac1fec6c7

2023-11-03 katelovett@google.com [two_dimensional_scrollables] Add borderRadius support to TableSpanDecoration (flutter/packages#5184)
2023-11-03 47866232+chunhtai@users.noreply.github.com [go_router] Adds an ability to add a custom codec for serializing/desâ¦ (flutter/packages#5288)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1d66b364

Update BottomNavigationBar tests for M3 (#136624) · 59d4d767

Bruno Leroux authored Nov 06, 2023

This PR updates `BottomNavigationBar` unit tests for M3 migration.

More info in https://github.com/flutter/flutter/issues/127064

It was somewhat complex because existing tests relied on a lot of magic numbers.

59d4d767

Roll Flutter Engine from 4f6ed31bd8bd to bdfa8aa8f81f (1 revision) (#137941) · 2e016b90

engine-flutter-autoroll authored Nov 06, 2023

https://github.com/flutter/engine/compare/4f6ed31bd8bd...bdfa8aa8f81f

2023-11-06 skia-flutter-autoroll@skia.org Roll Dart SDK from 96664852accc to 9211fc6406bb (1 revision) (flutter/engine#47706)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2e016b90

Roll Flutter Engine from b9b3269b0b2c to 4f6ed31bd8bd (2 revisions) (#137935) · 377e40e8

engine-flutter-autoroll authored Nov 06, 2023

https://github.com/flutter/engine/compare/b9b3269b0b2c...4f6ed31bd8bd

2023-11-06 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from V3diHxFGlypUQKNH_... to HQfFSkurc6-jKM2jh... (flutter/engine#47705)
2023-11-06 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kCyxKT7e5lMvkD3Yt... to _vGlgDiKOrtlKrZAP... (flutter/engine#47704)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from kCyxKT7e5lMv to _vGlgDiKOrtl
fuchsia/sdk/core/mac-amd64 from V3diHxFGlypU to HQfFSkurc6-j

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

377e40e8

Provide a helpful error message when `ColorScheme.brightness` doesn't match... · 826bb0a8

Taha Tesser authored Nov 06, 2023

Provide a helpful error message when `ColorScheme.brightness` doesn't match `ThemeData.brightness` (#137611)

fixes [Unexpected behaviour with ColorScheme.fromSeed and Brightness.dark](https://github.com/flutter/flutter/issues/127523)

826bb0a8

Roll Flutter Engine from 555ffa17b55c to b9b3269b0b2c (1 revision) (#137933) · aa3436db

engine-flutter-autoroll authored Nov 06, 2023

https://github.com/flutter/engine/compare/555ffa17b55c...b9b3269b0b2c

2023-11-06 kustermann@google.com Fix FFI-based tonic layer to use proper C++ static_cast<>()s (flutter/engine#47644)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

aa3436db

Fix tool exit message shown when user provides a non-list to "assets" for a... · 12de94d1
Andrew Kolos authored Nov 06, 2023
```
Fix tool exit message shown when user provides a non-list to "assets" for a deferred component (#137837)

Fixes #136163
```
12de94d1

Roll Flutter Engine from 0d8c7ceacc01 to 555ffa17b55c (1 revision) (#137921) · aa82e222

engine-flutter-autoroll authored Nov 06, 2023

https://github.com/flutter/engine/compare/0d8c7ceacc01...555ffa17b55c

2023-11-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from IH6mGM_PvyJB5x7SM... to V3diHxFGlypUQKNH_... (flutter/engine#47696)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from IH6mGM_PvyJB to V3diHxFGlypU

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

aa82e222

Roll Flutter Engine from 11d66db97d3f to 0d8c7ceacc01 (1 revision) (#137920) · 819b309a

engine-flutter-autoroll authored Nov 06, 2023

https://github.com/flutter/engine/compare/11d66db97d3f...0d8c7ceacc01

2023-11-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from qGNZvKP4q2a4jm2Ce... to kCyxKT7e5lMvkD3Yt... (flutter/engine#47697)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from qGNZvKP4q2a4 to kCyxKT7e5lMv

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

819b309a

05 Nov, 2023 3 commits

Roll Flutter Engine from a7592e42464c to 11d66db97d3f (1 revision) (#137914) · 7eb01cde

engine-flutter-autoroll authored Nov 05, 2023

https://github.com/flutter/engine/compare/a7592e42464c...11d66db97d3f

2023-11-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 3dRrKiwZsFq8U8vSM... to qGNZvKP4q2a4jm2Ce... (flutter/engine#47694)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 3dRrKiwZsFq8 to qGNZvKP4q2a4

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7eb01cde

Roll Flutter Engine from 1c6bd97e2288 to a7592e42464c (1 revision) (#137912) · 9a6be0b9

engine-flutter-autoroll authored Nov 05, 2023

https://github.com/flutter/engine/compare/1c6bd97e2288...a7592e42464c

2023-11-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from sZ51VV1mNynI39WtT... to IH6mGM_PvyJB5x7SM... (flutter/engine#47693)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from sZ51VV1mNynI to IH6mGM_PvyJB

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9a6be0b9

Roll Flutter Engine from daf18fe46b72 to 1c6bd97e2288 (1 revision) (#137908) · 55868ed2

engine-flutter-autoroll authored Nov 05, 2023

https://github.com/flutter/engine/compare/daf18fe46b72...1c6bd97e2288

2023-11-05 skia-flutter-autoroll@skia.org Roll Dart SDK from b9ae53ac4663 to 96664852accc (1 revision) (flutter/engine#47692)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

55868ed2

04 Nov, 2023 8 commits

Roll Flutter Engine from a45e679828e6 to daf18fe46b72 (1 revision) (#137904) · 234024e5

engine-flutter-autoroll authored Nov 04, 2023

https://github.com/flutter/engine/compare/a45e679828e6...daf18fe46b72

2023-11-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SmJ_8HFjjm55T4ijL... to 3dRrKiwZsFq8U8vSM... (flutter/engine#47690)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from SmJ_8HFjjm55 to 3dRrKiwZsFq8

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

234024e5

Roll Flutter Engine from fb2a9c20141e to a45e679828e6 (1 revision) (#137903) · e074df0b

engine-flutter-autoroll authored Nov 04, 2023

https://github.com/flutter/engine/compare/fb2a9c20141e...a45e679828e6

2023-11-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from ftLug7WGUYrtgHyy6... to sZ51VV1mNynI39WtT... (flutter/engine#47689)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from ftLug7WGUYrt to sZ51VV1mNynI

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e074df0b

Roll Flutter Engine from 576833873c15 to fb2a9c20141e (1 revision) (#137900) · dedbb399

engine-flutter-autoroll authored Nov 04, 2023

https://github.com/flutter/engine/compare/576833873c15...fb2a9c20141e

2023-11-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from b9ae53ac4663 to 96664852accc (1 revision)" (flutter/engine#47687)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dedbb399

Roll Flutter Engine from 25f5e285f874 to 576833873c15 (1 revision) (#137898) · 5e3b3e25

engine-flutter-autoroll authored Nov 04, 2023

https://github.com/flutter/engine/compare/25f5e285f874...576833873c15

2023-11-04 godofredoc@google.com Fix symbols upload (flutter/engine#47669)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5e3b3e25

Roll Flutter Engine from 7282a5d94ab6 to 25f5e285f874 (2 revisions) (#137892) · 9085183d

engine-flutter-autoroll authored Nov 04, 2023

https://github.com/flutter/engine/compare/7282a5d94ab6...25f5e285f874

2023-11-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8tJt8KJzTzbwwQlUE... to SmJ_8HFjjm55T4ijL... (flutter/engine#47682)
2023-11-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 5GLArzquQ4eL56vdy... to ftLug7WGUYrtgHyy6... (flutter/engine#47681)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 8tJt8KJzTzbw to SmJ_8HFjjm55
fuchsia/sdk/core/mac-amd64 from 5GLArzquQ4eL to ftLug7WGUYrt

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9085183d

Roll Flutter Engine from b66a87626300 to 7282a5d94ab6 (2 revisions) (#137887) · 46d4b11f

engine-flutter-autoroll authored Nov 04, 2023

https://github.com/flutter/engine/compare/b66a87626300...7282a5d94ab6

2023-11-04 skia-flutter-autoroll@skia.org Roll Dart SDK from b9ae53ac4663 to 96664852accc (1 revision) (flutter/engine#47679)
2023-11-04 skia-flutter-autoroll@skia.org Roll Dart SDK from c52fb4fe2d86 to b9ae53ac4663 (1 revision) (flutter/engine#47674)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

46d4b11f

HeroController should dispatch creation and disposal events. (#137835) · e8d9d9bf
Kostia Sokolovskyi authored Nov 04, 2023

e8d9d9bf

Roll Flutter Engine from ec20731de6ff to b66a87626300 (1 revision) (#137877) · 0e7ed929

engine-flutter-autoroll authored Nov 04, 2023

https://github.com/flutter/engine/compare/ec20731de6ff...b66a87626300

2023-11-03 kustermann@google.com Fix incorrect C++ return value of PictureRecorder::endRecording() (flutter/engine#47645)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0e7ed929

03 Nov, 2023 1 commit

InheritedElement.removeDependent() (#129210) · b5fb6652

Alex Isaienko authored Nov 03, 2023

Call the `dependency.removeDependent(this)` instead of `dependency._dependents.remove(this)` inside the `Element.deactivate()`. This allows `InheritedElements` to know when they can release resources associated with a given dependent `Element`.

Fixes #129207

b5fb6652