1. 26 Aug, 2015 3 commits
  2. 21 Aug, 2015 1 commit
  3. 19 Aug, 2015 2 commits
    • Adam Barth's avatar
      Add package:sky/rendering.dart · dea3a092
      Adam Barth authored
      Similar to widgets.dart, rendering.dart exports the entire rendering layer.
      Also, update the examples to use rendering.dart and widgets.dart. Also clean up
      some exports so that the examples have more sensible imports.
      dea3a092
    • Adam Barth's avatar
      Split box.dart into many files · 50bfdedb
      Adam Barth authored
      Sadly, box.dart has grown much longer than 1000 lines. This patch splits it up
      into several files based on the class hierarchy. Fortunately, many of these
      classes are loosely coupled to each other.
      50bfdedb
  4. 17 Aug, 2015 1 commit
    • Eric Seidel's avatar
      Fix analyzer warnings · d5fe622a
      Eric Seidel authored
      We had a remarkable number of analyzer failures.
      
      I'll fix the bots to analyze across the whole project
      in a follow-up patch, that should prevent this
      in the future.
      
      @abarth
      d5fe622a
  5. 13 Aug, 2015 1 commit
  6. 11 Aug, 2015 1 commit
  7. 08 Aug, 2015 1 commit
  8. 26 Jun, 2015 3 commits
  9. 25 Jun, 2015 1 commit
  10. 24 Jun, 2015 1 commit
  11. 22 Jun, 2015 1 commit
    • Hixie's avatar
      Short-circuit the relayoutSubtreeRoot when the child couldn't change... · e352ec9f
      Hixie authored
      Short-circuit the relayoutSubtreeRoot when the child couldn't change dimensions anyway because the parent constrained it.
      
      The relayout subtree root concept is intended to handle the case where
      a node, when it lays itself out for a second time, changes its opinion
      about what dimensions it should be. In such a situation, the parent,
      if it based its own opinion about what size _it_ should be on the
      child's dimensions, would also need to lay itself out again. Thus,
      when this scenario is possible, the child remembers the parent, and
      when it would be told to relayout, we actually start the layout with
      the parent.
      
      In practice, this chains, and we end up with nodes that point to
      ancestors ten or more steps up the tree such that when the inner most
      child re-lays-out, the whole app ends up relaying out.
      
      This patch tries to short-circuit this for the case where the
      constraints being applied to the child are such that actually, the
      child has no choice about its dimensions. In that case, the parent
      can't change dimensions when the child re-lays-out.
      
      This makes a huge difference on the stocks demo app. Without this, on
      the third rendered frame, there are 72 relayoutSubtreeRoot links, the
      deepest chain is 8 deep, and 9 of the chains are only 1 level deep.
      With it, there are 63 relayoutSubtreeRoot links, the deepest chain is
      only 4 deep, and 38 of the chains are only 1 level deep.
      
      R=eseidel@chromium.org
      
      Review URL: https://codereview.chromium.org/1196553004.
      e352ec9f
  12. 18 Jun, 2015 5 commits
    • Hixie's avatar
      Rename editing2/ and theme2/ to editing/ and theme/. · 82fc647c
      Hixie authored
      Flesh out a README.md file for the SDK.
      Make the stocks app test wait for the app to be mounted, to catch some more errors, like typos in the mount callback.
      
      R=abarth@chromium.org
      
      Review URL: https://codereview.chromium.org/1182053012.
      82fc647c
    • Matt Perry's avatar
      Add a Paint::toString() method to describe our Paint objects. · 4d66e7d0
      Matt Perry authored
      Add a test for RenderDecoratedBox sets up the Paint object correctly.
      
      R=abarth@chromium.org
      
      Review URL: https://codereview.chromium.org/1185423003.
      4d66e7d0
    • Adam Barth's avatar
      Fix data loading in the stocks app · d79ef3a6
      Adam Barth authored
      We can't have two copies of |embedder.dart| or |shell.dart| because they take
      ownership of some underlying Mojo handles. Instead of duplicating the code,
      this CL makes the old locations just export all the symbols from the new
      location. I've also done the same with fetch.dart to avoid code duplication.
      
      Finally, I've removed image_cache.dart in the old location because the only
      clients already live in the new world and ought to use the new location.
      
      TBR=ianh@google.com
      
      Review URL: https://codereview.chromium.org/1179923004.
      d79ef3a6
    • Hixie's avatar
      Cleanup of SkyBinding, and resultant yak shaving. · d2d11a04
      Hixie authored
      Some files are moved by this:
        Copy framework/node.dart into types/ - preparing for framework/'s decomissioning.
        Move app/scheduler.dart into sky/scheduler.dart - "app" doesn't really make sense.
      
      As part of the SkyBinding cleanup, I made the hit-testing less
      RenderBox-specific, by having the HitTestEntry.target member be a
      HitTestTarget, which is an interface with the handleEvent() function,
      which is then implemented by RenderBox. In theory, someone could now
      extend hit testing from the RenderBox world into their own tree of
      nodes, and take part in all the same dispatch logic automatically.
      
      This involved moving all the hit testing type definitions into a new
      sky/hittest.dart file.
      
      Renamed SkyBinding._app to SkyBinding._instance for clarity.
      
      Moved code around in SkyBinding so that related things are together.
      
      Made WidgetSkyBinding use the existing SkyBinding.instance singleton
      logic rather than having its own copy.
      
      I also added some stub README.md files that describe dependencies.
      
      R=abarth@chromium.org
      
      Review URL: https://codereview.chromium.org/1187393002.
      d2d11a04
    • Hixie's avatar
      Rename AppView to SkyBinding. · 5136d520
      Hixie authored
      Move app/view.dart to rendering/sky_binding.dart since it's part of the RenderObject API, really (it knows about RenderView intimately).
      The tests pass. I didn't check every last example.
      
      R=abarth@chromium.org
      
      Review URL: https://codereview.chromium.org/1183913006.
      5136d520
  13. 17 Jun, 2015 1 commit
  14. 16 Jun, 2015 2 commits
    • Hans Muller's avatar
      Styling for text fragments · 9cb9e2ed
      Hans Muller authored
      This is a completion of Eric's WIP patch:
      https://codereview.chromium.org/1179663005/
      
      Low level support for creating a paragraph that contains
      runs of styled text. The styles may be nested.
      
      The Paragraph and RenderParagraph classes have been
      replaced by Inline and RenderInline. Styled text is defined
      with a tree of InlineText and InlineStyle objects.
      
      R=abarth@chromium.org
      
      Review URL: https://codereview.chromium.org/1177833012.
      9cb9e2ed
    • Hixie's avatar
      Create an example app that demonstrates interactive coordination of an fn tree... · 249dc8af
      Hixie authored
      Create an example app that demonstrates interactive coordination of an fn tree and a raw RenderObject tree.
      
      Sector changes:
      - implement the intrinsic sizing box API on RenderBoxToRenderSectorAdapter
      - remove some debug print statements
      - fix getIntrinsicDimensions() on RenderSolidColor to return true values
      - factor out the default demo
      
      RenderObject changes:
      - BoxConstraints.isInfinite() now returns true only if both dimensions are infinite
      
      fn changes:
      - implement UINodeToRenderBoxAdapter
      - rename RenderObjectToUINodeAdapter to RenderBoxToUINodeAdapter
      
      Tests:
      - add a test for sector layout
      - make TestRenderView support being run without the unit test framework
      
      R=abarth@chromium.org
      
      Review URL: https://codereview.chromium.org/1175423007.
      249dc8af
  15. 15 Jun, 2015 1 commit
    • Hixie's avatar
      Remove RenderSizedBox. · 86eabcb7
      Hixie authored
      Make old users of RenderSizedBox use RenderConstrainedBox.
      Change the semantics of BoxDecoration.apply* to actually apply the provided constraints to the current constraints, rather than the previous behaviour of merging them neutrally.
      
      R=abarth@chromium.org
      
      Review URL: https://codereview.chromium.org/1189603003.
      86eabcb7
  16. 13 Jun, 2015 1 commit
  17. 12 Jun, 2015 1 commit
  18. 11 Jun, 2015 2 commits
  19. 10 Jun, 2015 1 commit