Commits · d5a0fcd5af87220e5ad6e9492da538e2f341a226 · abdullh.alsoleman / Front-End

08 Aug, 2023 19 commits

Locate the template directory using a TemplatePathProvider. (#132156) · d5a0fcd5
Lau Ching Jun authored Aug 08, 2023
```
So that the paths can be overridden.
```
d5a0fcd5

Roll Flutter Engine from dd03fae51d38 to 934ebb005d02 (4 revisions) (#132159) · 547bdefb

engine-flutter-autoroll authored Aug 08, 2023

https://github.com/flutter/engine/compare/dd03fae51d38...934ebb005d02

2023-08-08 skia-flutter-autoroll@skia.org Roll Skia from 6fa6fdd04783 to 5c8c7faf9131 (3 revisions) (flutter/engine#44506)
2023-08-08 55360120+Matt2D@users.noreply.github.com Flutter iOS Interactive Keyboard: Handle Pointer Up (flutter/engine#44457)
2023-08-08 30870216+gaaclarke@users.noreply.github.com [Impeller] improved glyph hashing performance (flutter/engine#44502)
2023-08-08 skia-flutter-autoroll@skia.org Roll Skia from 30c0319e7e42 to 6fa6fdd04783 (2 revisions) (flutter/engine#44503)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

547bdefb

Roll Flutter Engine from 22bd35a19352 to dd03fae51d38 (3 revisions) (#132149) · e2badf38

engine-flutter-autoroll authored Aug 08, 2023

https://github.com/flutter/engine/compare/22bd35a19352...dd03fae51d38

2023-08-08 10456171+caroqliu@users.noreply.github.com Remove GFX branches from Flutter engine (flutter/engine#44401)
2023-08-08 jason-simmons@users.noreply.github.com Use the Clang unreachable code warning flag in the engine tree (flutter/engine#44458)
2023-08-08 skia-flutter-autoroll@skia.org Roll Skia from 66ba512c613c to 30c0319e7e42 (3 revisions) (flutter/engine#44500)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e2badf38

Fix `TabBarTheme.indicatorColor` not applied in Material 2 (#132123) · ee47267d

Taha Tesser authored Aug 08, 2023

fixes [[Proposal] Improve TabBarTheme styling API for indicator color ](https://github.com/flutter/flutter/issues/130392)

### Description

This fixes an issue where the `TabBarTheme.indicator` isn't applied in Material 2 and also adds indicator color tests for both M3 and M2.

### Code sample

<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

/// Flutter code sample for [TabBar].

void main() => runApp(const TabBarApp());

class TabBarApp extends StatelessWidget {
  const TabBarApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(
        useMaterial3: false,
        tabBarTheme: const TabBarTheme(
          indicatorColor: Colors.amber,
        )
      ),
      home: const TabBarExample(),
    );
  }
}

class TabBarExample extends StatelessWidget {
  const TabBarExample({super.key});

  @override
  Widget build(BuildContext context) {
    return DefaultTabController(
      initialIndex: 1,
      length: 3,
      child: Scaffold(
        appBar: AppBar(
          title: const Text('TabBar Sample'),
          bottom: const TabBar(
            tabs: <Widget>[
              Tab(
                icon: Icon(Icons.cloud_outlined),
                text: 'Cloudy',
              ),
              Tab(
                icon: Icon(Icons.beach_access_sharp),
                text: 'Sunny',
              ),
              Tab(
                icon: Icon(Icons.brightness_5_sharp),
                text: 'Rainy',
              ),
            ],
          ),
        ),
        body: const TabBarView(
          children: <Widget>[
            Center(
              child: Text("It's cloudy here"),
            ),
            Center(
              child: Text("It's rainy here"),
            ),
            Center(
              child: Text("It's sunny here"),
            ),
          ],
        ),
      ),
    );
  }
}
``` 
	
</details>

### Before
![Screenshot 2023-08-08 at 15 39 24](https://github.com/flutter/flutter/assets/48603081/9030e025-8615-45d0-a337-87ba2fdf6ca3)

### After
![Screenshot 2023-08-08 at 15 39 07](https://github.com/flutter/flutter/assets/48603081/4b98ac55-2d51-4a4c-93ba-7d36dc4be1d8)

ee47267d

Paginated Data Table : Fixed Row number at footer in last page (#130389) · 0b813478

Aakash Pamnani authored Aug 08, 2023

Fixed the row count in the footer.

Before
![image](https://github.com/flutter/flutter/assets/76067278/2365b85f-d896-4cea-a5b3-f043970bec98)

After
![image](https://github.com/flutter/flutter/assets/76067278/69b18ecb-a3c9-44ea-961f-b4073ee0384d)

*Issues Resolved*
Fixes #80421

0b813478

[web] Use benchmark callback from `dart:ui_web` (#132087) · a2f48a36

Mouad Debbar authored Aug 08, 2023

Depends on https://github.com/flutter/engine/pull/44461
Fixes https://github.com/flutter/flutter/issues/130175
Part of https://github.com/flutter/flutter/issues/126831

a2f48a36

Roll Flutter Engine from 99fdac88f3c6 to 22bd35a19352 (3 revisions) (#132141) · f10a6ef7

engine-flutter-autoroll authored Aug 08, 2023

https://github.com/flutter/engine/compare/99fdac88f3c6...22bd35a19352

2023-08-08 chris@bracken.jp [macOS] Fix engine/binaryMessenger retain cycle (flutter/engine#44471)
2023-08-08 skia-flutter-autoroll@skia.org Roll Skia from f7162d33afb2 to 66ba512c613c (8 revisions) (flutter/engine#44497)
2023-08-08 mdebbar@google.com [web] Expose the benchmark callback through dart:ui_web (flutter/engine#44461)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f10a6ef7

[framework] Add Search Web to selection controls for iOS (#131898) · d9cb50e6

LouiseHsu authored Aug 08, 2023

This PR adds framework support for the Search Web feature in iOS.

https://github.com/flutter/flutter/assets/36148254/c159f0d9-8f14-45e7-b295-e065b0826fab

The corresponding merged engine PR can be found [here](https://github.com/flutter/engine/pull/43324).
This PR addresses https://github.com/flutter/flutter/issues/82907
More details are available in this [design doc](https://docs.google.com/document/d/1QizXwBiO-2REIcEovl5pK06BaLPOWYmNwOE5jactJZA/edit?resourcekey=0-1pb9mJiAq29Gesmt25GAug)

d9cb50e6

Remove Iterator from _History (#132101) · 96553115
Justin McCandless authored Aug 08, 2023
```
Cleaning up private code in Navigator.
```
96553115
Update dartdoc driver to match current behaviour (#132078) · e60dc301
Ian Hickson authored Aug 08, 2023

e60dc301
More documentation about warm-up frames (#132085) · 9dbd1e98
Ian Hickson authored Aug 08, 2023

9dbd1e98

Roll Flutter Engine from 146c4c9487fc to 99fdac88f3c6 (3 revisions) (#132135) · 23041cb2

engine-flutter-autoroll authored Aug 08, 2023

https://github.com/flutter/engine/compare/146c4c9487fc...99fdac88f3c6

2023-08-08 zanderso@users.noreply.github.com Excludes entity_pass.cc from clang-tidy due to timeouts (flutter/engine#44495)
2023-08-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0Jd9VPJCX145RGnqr... to 9Pl8nd13UI8rrS3JD... (flutter/engine#44494)
2023-08-08 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from r0vBgWqKSvQ6zzFam... to c18Y3Ga7cvdrmy8FQ... (flutter/engine#44492)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 0Jd9VPJCX145 to 9Pl8nd13UI8r
fuchsia/sdk/core/mac-amd64 from r0vBgWqKSvQ6 to c18Y3Ga7cvdr

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

23041cb2

Roll Packages from d7ee75ad59ad to ac4137624a13 (8 revisions) (#132133) · 3886b003

engine-flutter-autoroll authored Aug 08, 2023

https://github.com/flutter/packages/compare/d7ee75ad59ad...ac4137624a13

2023-08-08 engine-flutter-autoroll@skia.org Roll Flutter from ad0aa8de to 436df69a (17 revisions) (flutter/packages#4663)
2023-08-08 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Repeatedly pump WebViews until one is garbage collected (flutter/packages#4662)
2023-08-08 erikgerman917@gmail.com [xdg_directories] Add example app (flutter/packages#4554)
2023-08-08 70025277+Nitin-Poojary@users.noreply.github.com [pigeon] Recursively create output target files (flutter/packages#4458)
2023-08-07 jpnurmi@gmail.com [path_provider] Add getApplicationCachePath() (flutter/packages#4483)
2023-08-07 10687576+bparrishMines@users.noreply.github.com [flutter_markdown] Adopt code excerpts in README (flutter/packages#4656)
2023-08-07 reidbaker@google.com [All] Expand artifact hub to all plugins (flutter/packages#4645)
2023-08-07 engine-flutter-autoroll@skia.org Roll Flutter from 2ba9f7bd to ad0aa8de (31 revisions) (flutter/packages#4659)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3886b003

Handle breaking changes in leak_tracker. (#131998) · acd636f7
Polina Cherkasova authored Aug 08, 2023

acd636f7

Roll Flutter Engine from 9c83d90b01bd to 146c4c9487fc (6 revisions) (#132112) · 436df69a

engine-flutter-autoroll authored Aug 08, 2023

https://github.com/flutter/engine/compare/9c83d90b01bd...146c4c9487fc

2023-08-08 skia-flutter-autoroll@skia.org Roll Skia from b4a893827b2a to f7162d33afb2 (1 revision) (flutter/engine#44479)
2023-08-07 jason-simmons@users.noreply.github.com Revert "[Impeller] DlCanvas implementation wrapping Aiks canvas" (flutter/engine#44466)
2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from 5dd88a48f7e2 to b4a893827b2a (3 revisions) (flutter/engine#44470)
2023-08-07 mdebbar@google.com [web] Silence `pub get` when it's successful (flutter/engine#44445)
2023-08-07 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from mlT1Bm0L9bVynvMFF... to r0vBgWqKSvQ6zzFam... (flutter/engine#44463)
2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from d1ada6624536 to 5dd88a48f7e2 (8 revisions) (flutter/engine#44465)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from mlT1Bm0L9bVy to r0vBgWqKSvQ6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

436df69a

Roll Flutter Engine from c27109291e22 to 9c83d90b01bd (5 revisions) (#132108) · 08b2c444

engine-flutter-autoroll authored Aug 08, 2023

https://github.com/flutter/engine/compare/c27109291e22...9c83d90b01bd

2023-08-07 skia-flutter-autoroll@skia.org Roll Dart SDK from 0816d590a220 to f664f4b9c50d (1 revision) (flutter/engine#44462)
2023-08-07 bdero@google.com [Impeller] Flutter GPU: Add GpuContext. (flutter/engine#44359)
2023-08-07 ftsui@google.com Fix use-after-free crash in glfw embedder (flutter/engine#44358)
2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from 9fbd7296de9a to d1ada6624536 (1 revision) (flutter/engine#44447)
2023-08-07 zanderso@users.noreply.github.com Revert clang back to 6d667d4b261e81f325756fdfd5bb43b3b3d2451d (flutter/engine#44442)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

08b2c444

Roll Flutter Engine from be085f6699b6 to c27109291e22 (3 revisions) (#132086) · 73e1f9f5

engine-flutter-autoroll authored Aug 08, 2023

https://github.com/flutter/engine/compare/be085f6699b6...c27109291e22

2023-08-07 yjbanov@google.com [web] remove leftover comments from
semantics tester (flutter/engine#44350)
2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from 77007f51bf81 to
9fbd7296de9a (4 revisions) (flutter/engine#44443)
2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from f19578685d17 to
77007f51bf81 (1 revision) (flutter/engine#44440)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

73e1f9f5

Revert "Replace TextField.canRequestFocus with TextField.focusNode.canRequestFocus" (#132104) · cef00d0c
Jesús S Guerrero authored Aug 08, 2023
```
Reverts flutter/flutter#130164

reverting because it cause internal google testing failures b/294917394
```
cef00d0c

[Impeller] add drawVertices and drawAtlas benchmarks. (#132080) · 915c5245

Jonah Williams authored Aug 08, 2023

Adds impeller benchmarks to track the progress of improvements made in https://github.com/flutter/flutter/issues/131345

915c5245

07 Aug, 2023 18 commits

Adds more documentations around ignoreSemantics deprecations. (#131287) · b01cb301

chunhtai authored Aug 07, 2023

migration guide update https://github.com/flutter/website/pull/9124

fixes the concerns in https://github.com/flutter/flutter/pull/120619

b01cb301

[web] New HtmlElementView.fromTagName constructor (#130513) · 55fe41be

Mouad Debbar authored Aug 07, 2023

This wraps up the platform view improvements discussed in https://github.com/flutter/flutter/issues/127030.

- Splits `HtmlElementView` into 2 files that are conditionally imported.
- The non-web version can be instantiated but it throws if it ends up being built in a widget tree.
- Out-of-the-box view factories that create visible & invisible DOM elements given a `tagName` parameter.
- New `HtmlElementView.fromTagName()` constructor that uses the default factories to create DOM elements.
- Tests covering the new API.

Depends on https://github.com/flutter/engine/pull/43828

Fixes https://github.com/flutter/flutter/issues/127030

55fe41be

Move mock canvas to flutter_test (#131631) · f054f5aa

Kate Lovett authored Aug 07, 2023

Fixes https://github.com/flutter/flutter/issues/59413

This relocates `mock_canvas.dart` and `recording_canvas.dart` from `flutter/test/rendering` to `flutter_test`.

The testing functionality afforded by mock_canvas should be available to everyone, not just the framework. :)

mock_canvas.dart needed a bit of cleanup - things like formatting and super parameters.

f054f5aa

Add static_path_tessellation macrobenchmark (#131837) · 1c7e2afc

Matej Knopp authored Aug 07, 2023

This adds a macrobenchmark representative of a real world application that uses SVG icons. The scenario of rasterizing complex paths that don't change over time does not seem to be covered by any other macrobenchmark and shows a significantly slower impeller performance compared to skia.

It's actually bit problematic to measure this because on A15 the CPU load with impeller is high enough to trigger CPU frequency change. So in order to get consistent reading I had to add a spinning background thread that would keep the CPU at highest frequency.

```objc
  [NSThread detachNewThreadWithBlock:^{
    while (true) {
      pthread_yield_np();
    }
  }];
```

```bash
flutter drive --profile --local-engine=ios_profile -t test_driver/run_app.dart --driver test_driver/path_tessellation_static_perf_test.dart
```

| average_frame_build_time_millis |Time|
|--|--|
| Impeller | 0.46686524822695047 |
| Skia | 0.4625749999999999 |
| Skia - No RasterCache | 0.47173750000000086|

| average_frame_rasterizer_time_millis | Time |
|--|--|
| Impeller | 6.654328519855595 |
| Skia - Raster Cache |  0.2534123711340209 * |
| Skia - No RasterCache |  0.53424375 |

* Adding the `GeometryPainter` seems to have triggered the complexity threshold for raster cache.

<img alt="screenshot" width="320" src="https://github.com/flutter/flutter/assets/96958/7a2f9384-b512-477b-bffa-058d4d284a41"/>

1c7e2afc

[web] Remove usage of `ui.webOnlyInitializePlatform()` (#131344) · ad0dbc8d
Mouad Debbar authored Aug 07, 2023
```
Part of https://github.com/flutter/flutter/issues/126831
```
ad0dbc8d

Roll Flutter Engine from 39a575f65d50 to be085f6699b6 (1 revision) (#132069) · 0448a11c

engine-flutter-autoroll authored Aug 07, 2023

https://github.com/flutter/engine/compare/39a575f65d50...be085f6699b6

2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from 359808ec2cb1 to f19578685d17 (1 revision) (flutter/engine#44439)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0448a11c

Android context menu theming and visual update (#131816) · ebbb4b38

Justin McCandless authored Aug 07, 2023

Fixes https://github.com/flutter/flutter/issues/89939 and updates the look of the Android context menu to match API 34.

## The problem
Before this PR, setting `surface` in the color scheme caused the background color of the Android context menu to change, but it wasn't possible to change the text color.

```dart
MaterialApp(
  theme: ThemeData(
    // Using a dark theme made the context menu text color be white.
    colorScheme: ThemeData.dark().colorScheme.copyWith(
      // Setting the surface here worked.
      surface: Colors.white,
      // But there was no way to set the text color. This didn't work.
      onSurface: Colors.black,
    ),
  ),
),
```

| Expected (after PR) | Actual (before PR) |
| --- | --- |
| <img width="239" alt="Screenshot 2023-08-07 at 11 45 37 AM" src="https://github.com/flutter/flutter/assets/389558/a9fb75e5-b6c3-4f8e-8c59-2021780c44a7"> | <img width="250" alt="Screenshot 2023-08-07 at 11 51 10 AM" src="https://github.com/flutter/flutter/assets/389558/a5abd2d2-49bb-47a0-836f-864d56af2f58"> |

## Other examples

<table>
<tr>
<th>Scenario</th>
<th>Result</th>
</tr>
<tr>
<td>

```dart
MaterialApp(
  theme: ThemeData(
    colorScheme: ThemeData.light(),
  ),
  ...
),
```

</td>
<td>
<img width="244" alt="Screenshot 2023-08-07 at 11 42 05 AM" src="https://github.com/flutter/flutter/assets/389558/74c6870b-5ff7-4b1a-9e0c-b2bb4809ef1e">
</td>
</tr>
<tr>
<td>

```dart
MaterialApp(
  theme: ThemeData(
    colorScheme: ThemeData.dark(),
  ),
  ...
),
```

</td>
<td>
<img width="239" alt="Screenshot 2023-08-07 at 11 42 23 AM" src="https://github.com/flutter/flutter/assets/389558/91fe32f8-bd62-4d9b-96e8-ae5a9a769745">
</td>
</tr>
<tr>
<td>

```dart
MaterialApp(
  theme: ThemeData(
    colorScheme: ThemeData.light().colorScheme.copyWith(
      surface: Colors.blue,
      onSurface: Colors.red,
    ),
  ),
  ...
),
```

</td>
<td>
<img width="240" alt="Screenshot 2023-08-07 at 11 43 06 AM" src="https://github.com/flutter/flutter/assets/389558/e5752f8b-3738-4391-9055-15c38bd4af21">
</td>
</tr>
<tr>
<td>

```dart
MaterialApp(
  theme: ThemeData(
    colorScheme: ThemeData.light().colorScheme.copyWith(
      surface: Colors.blue,
      onSurface: Colors.red,
    ),
  ),
  ...
),
```

</td>
<td>
<img width="244" alt="Screenshot 2023-08-07 at 11 42 47 AM" src="https://github.com/flutter/flutter/assets/389558/68cc68f0-b338-4d94-8810-d8e46fb1e48e">
</td>
</tr>
</table>

ebbb4b38

Roll Flutter Engine from 39ce1c097bce to 39a575f65d50 (2 revisions) (#132064) · 9cc4f943

engine-flutter-autoroll authored Aug 07, 2023

https://github.com/flutter/engine/compare/39ce1c097bce...39a575f65d50

2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from e327eb094605 to 359808ec2cb1 (2 revisions) (flutter/engine#44438)
2023-08-07 jason-simmons@users.noreply.github.com Do not log exceptions from JNI lookups of APIs that are known to be unavailable on older devices (flutter/engine#44357)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9cc4f943

CupertinoContextMenu improvement (#131030) · ff5b0e14
xhzq233 authored Aug 07, 2023
```
Fixes overlapping gestures in CupertinoContextMenu's subtree
```
ff5b0e14

Roll Flutter Engine from 5b47c0577060 to 39ce1c097bce (3 revisions) (#132057) · 1a31682e

engine-flutter-autoroll authored Aug 07, 2023

https://github.com/flutter/engine/compare/5b47c0577060...39ce1c097bce

2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from 7a98630e0de9 to e327eb094605 (2 revisions) (flutter/engine#44437)
2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from f4047f002891 to 7a98630e0de9 (1 revision) (flutter/engine#44436)
2023-08-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from zVfdIYcZ93Loob7VG... to 0Jd9VPJCX145RGnqr... (flutter/engine#44435)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from zVfdIYcZ93Lo to 0Jd9VPJCX145

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1a31682e

Slider should check `mounted` before start interaction (#132010) · 06ca902d

Mingyu authored Aug 07, 2023

This is a follow up to the following pull requests:
- https://github.com/flutter/flutter/pull/124514

I was finally able to reproduce this bug and found out why it was happening. Consider this code:

```dart
GestureDetector(
  behavior: HitTestBehavior.translucent,
  // Note: Make sure onTap is not null to ensure events
  // are captured by `GestureDetector`
  onTap: () {},
  child: _shouldShowSlider
    ? Slider(value: _value, onChanged: _handleSlide)
    : const SizedBox.shrink().
)
```

Runtime exception happens when:

1. User taps and holds the Slider (drag callback captured by `GestureDetector`)
2. `_shouldShowSlider` changes to false, Slider disappears and unmounts, and unregisters `_handleSlide`. But the callback is still registered by `GestureDetector`
3. Users moves finger as if Slider were still there
4. Drag callback is invoked, `_SliderState.showValueIndicator` is called
5. Exception - Slider is already disposed

This pull request fixes it by adding a mounted check inside `_SliderState.showValueIndicator` to ensure the Slider is actually mounted at the time of invoking drag event callback. I've added a unit test that will fail without this change.

The error stack trace is:

```
The following assertion was thrown while handling a gesture:
This widget has been unmounted, so the State no longer has a context (and should be considered
defunct).
Consider canceling any active work during "dispose" or using the "mounted" getter to determine if
the State is still active.

When the exception was thrown, this was the stack:
#0      State.context.<anonymous closure> (package:flutter/src/widgets/framework.dart:950:9)
#1      State.context (package:flutter/src/widgets/framework.dart:956:6)
#2      _SliderState.showValueIndicator (package:flutter/src/material/slider.dart:968:18)
#3      _RenderSlider._startInteraction (package:flutter/src/material/slider.dart:1487:12)
#4      _RenderSlider._handleDragStart (package:flutter/src/material/slider.dart:1541:5)
#5      DragGestureRecognizer._checkStart.<anonymous closure> (package:flutter/src/gestures/monodrag.dart:531:53)
#6      GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:275:24)
#7      DragGestureRecognizer._checkStart (package:flutter/src/gestures/monodrag.dart:531:7)
#8      DragGestureRecognizer._checkDrag (package:flutter/src/gestures/monodrag.dart:498:5)
#9      DragGestureRecognizer.acceptGesture (package:flutter/src/gestures/monodrag.dart:431:7)
#10     _CombiningGestureArenaMember.acceptGesture (package:flutter/src/gestures/team.dart:45:14)
#11     GestureArenaManager._resolveInFavorOf (package:flutter/src/gestures/arena.dart:281:12)
#12     GestureArenaManager._resolve (package:flutter/src/gestures/arena.dart:239:9)
#13     GestureArenaEntry.resolve (package:flutter/src/gestures/arena.dart:53:12)
#14     _CombiningGestureArenaMember._resolve (package:flutter/src/gestures/team.dart:85:15)
#15     _CombiningGestureArenaEntry.resolve (package:flutter/src/gestures/team.dart:19:15)
#16     OneSequenceGestureRecognizer.resolve (package:flutter/src/gestures/recognizer.dart:375:13)
#17     DragGestureRecognizer.handleEvent (package:flutter/src/gestures/monodrag.dart:414:13)
#18     PointerRouter._dispatch (package:flutter/src/gestures/pointer_router.dart:98:12)
#19     PointerRouter._dispatchEventToRoutes.<anonymous closure> (package:flutter/src/gestures/pointer_router.dart:143:9)
#20     _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:625:13)
#21     PointerRouter._dispatchEventToRoutes (package:flutter/src/gestures/pointer_router.dart:141:18)
#22     PointerRouter.route (package:flutter/src/gestures/pointer_router.dart:127:7)
#23     GestureBinding.handleEvent (package:flutter/src/gestures/binding.dart:488:19)
#24     GestureBinding.dispatchEvent (package:flutter/src/gestures/binding.dart:468:22)
#25     RendererBinding.dispatchEvent (package:flutter/src/rendering/binding.dart:439:11)
#26     GestureBinding._handlePointerEventImmediately (package:flutter/src/gestures/binding.dart:413:7)
#27     GestureBinding.handlePointerEvent (package:flutter/src/gestures/binding.dart:376:5)
#28     GestureBinding._flushPointerEventQueue (package:flutter/src/gestures/binding.dart:323:7)
#29     GestureBinding._handlePointerDataPacket (package:flutter/src/gestures/binding.dart:292:9)
#30     _invoke1 (dart:ui/hooks.dart:186:13)
#31     PlatformDispatcher._dispatchPointerDataPacket (dart:ui/platform_dispatcher.dart:433:7)
#32     _dispatchPointerDataPacket (dart:ui/hooks.dart:119:31)

Handler: "onStart"
Recognizer:
  HorizontalDragGestureRecognizer#a5df2
```

*List which issues are fixed by this PR. You must list at least one issue.*

Internal bug: b/273666179, b/192329942

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

06ca902d

Roll Packages from ce53da1bd741 to d7ee75ad59ad (7 revisions) (#132058) · 122c4295

engine-flutter-autoroll authored Aug 07, 2023

https://github.com/flutter/packages/compare/ce53da1bd741...d7ee75ad59ad

2023-08-05 stuartmorgan@google.com [tool] Skip pathified analysis on resolver errors (flutter/packages#4647)
2023-08-05 stuartmorgan@google.com [ci] Remove tools from Dockerfile (flutter/packages#4649)
2023-08-05 32242716+ricardoamador@users.noreply.github.com Update to not backfill the ci.yaml roller task. (flutter/packages#4651)
2023-08-04 stuartmorgan@google.com [pigeon] Consolidate mock handler tests (flutter/packages#4642)
2023-08-04 stuartmorgan@google.com [camera_web] Adopt code excerpts in README (flutter/packages#4584)
2023-08-04 stuartmorgan@google.com [image_picker] Allows 3.0 web implementation (flutter/packages#4648)
2023-08-04 engine-flutter-autoroll@skia.org Roll Flutter from c00d2419 to 2ba9f7bd (25 revisions) (flutter/packages#4646)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

122c4295

Roll Flutter Engine from b10891e0d8d8 to 5b47c0577060 (1 revision) (#132040) · ad0aa8de

engine-flutter-autoroll authored Aug 07, 2023

https://github.com/flutter/engine/compare/b10891e0d8d8...5b47c0577060

2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from 558d9754241d to f4047f002891 (1 revision) (flutter/engine#44433)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ad0aa8de

Roll Flutter Engine from 4304d6180264 to b10891e0d8d8 (1 revision) (#132037) · c11ac7be

engine-flutter-autoroll authored Aug 07, 2023

https://github.com/flutter/engine/compare/4304d6180264...b10891e0d8d8

2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from b7a1f4fdedc1 to 558d9754241d (1 revision) (flutter/engine#44432)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c11ac7be

Roll Flutter Engine from eb91441398a1 to 4304d6180264 (1 revision) (#132031) · fd61c4a4

engine-flutter-autoroll authored Aug 07, 2023

https://github.com/flutter/engine/compare/eb91441398a1...4304d6180264

2023-08-07 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 9QyQ03F49oT_9slFF... to mlT1Bm0L9bVynvMFF... (flutter/engine#44431)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 9QyQ03F49oT_ to mlT1Bm0L9bVy

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fd61c4a4

Constrain _RenderScaledInlineWidget child size in computeDryLayout (#131765) · 55044a60
Tomasz Gucio authored Aug 07, 2023

55044a60

Roll Flutter Engine from 15b5707af406 to eb91441398a1 (1 revision) (#132025) · 7de053b2

engine-flutter-autoroll authored Aug 07, 2023

https://github.com/flutter/engine/compare/15b5707af406...eb91441398a1

2023-08-07 skia-flutter-autoroll@skia.org Roll Skia from 9c4cfcd16529 to b7a1f4fdedc1 (2 revisions) (flutter/engine#44430)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7de053b2

Roll Flutter Engine from a1d513f78bbb to 15b5707af406 (2 revisions) (#132020) · bfbe79fe

engine-flutter-autoroll authored Aug 07, 2023

https://github.com/flutter/engine/compare/a1d513f78bbb...15b5707af406

2023-08-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from fwCoUCWKEqZSJGPE8... to zVfdIYcZ93Loob7VG... (flutter/engine#44428)
2023-08-06 skia-flutter-autoroll@skia.org Roll Skia from 72264deb9f05 to 9c4cfcd16529 (1 revision) (flutter/engine#44427)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from fwCoUCWKEqZS to zVfdIYcZ93Lo

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bfbe79fe

06 Aug, 2023 3 commits

Roll Flutter Engine from c9bd380ccbb0 to a1d513f78bbb (1 revision) (#132015) · ecef964a

engine-flutter-autoroll authored Aug 06, 2023

https://github.com/flutter/engine/compare/c9bd380ccbb0...a1d513f78bbb

2023-08-06 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from iY3v8FawLUo9HvTeR... to 9QyQ03F49oT_9slFF... (flutter/engine#44425)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from iY3v8FawLUo9 to 9QyQ03F49oT_

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ecef964a

Roll Flutter Engine from 060c95f94364 to c9bd380ccbb0 (1 revision) (#132008) · 310e9114

engine-flutter-autoroll authored Aug 06, 2023

https://github.com/flutter/engine/compare/060c95f94364...c9bd380ccbb0

2023-08-06 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from E0vw_CD-BaFAcSoH4... to fwCoUCWKEqZSJGPE8... (flutter/engine#44424)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from E0vw_CD-BaFA to fwCoUCWKEqZS

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

310e9114

Roll Flutter Engine from af7aaae2f1f9 to 060c95f94364 (1 revision) (#132006) · 11d98460

engine-flutter-autoroll authored Aug 06, 2023

https://github.com/flutter/engine/compare/af7aaae2f1f9...060c95f94364

2023-08-06 skia-flutter-autoroll@skia.org Roll Skia from 1d390344bfca to 72264deb9f05 (1 revision) (flutter/engine#44423)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

11d98460