1. 02 May, 2023 1 commit
    • Casey Rogers's avatar
      Make `future` and `stream` required arguments in their respective builder widgets (#125838) · 4d86f5d0
      Casey Rogers authored
      cc'ing existing conversation participants: @domesticmouse @srawlins
      cc'ing to request review: @goderbauer 
      
      This PR makes the following constructor arguments required:
      1. `FutureBuilder.future`
      2. `StreamBuilderBase.stream`
      3. `StreamBuilder.stream`
      
      This fixes:
      https://github.com/flutter/flutter/issues/83081
      https://github.com/flutter/flutter/issues/125188 (dupe of 83081)
      
      This obviates:
      https://github.com/dart-lang/linter/issues/4309
      (I suggest we skip straight to merging this PR as this should be a low impact breaking change-assuming few to no devs are intentionally using the builders without their relevant arguments, however we could always merge 4309 first and then this)
      https://github.com/flutter/flutter/pull/83101 
      (The above PR required that at least one of future and initial data be non-null, this is undesirable as there are plenty of valid reasons to have both arguments be null)
      
      See above issues for a deeper dive, but here is a summary:
      It is very easy for a developer to forget to specify `future` or `stream` when using the respective `*Builder` widgets. This produces a non-obvious failure where the UI sits in a "no data yet received" state. It is easy for a dev to misinterpret this as the async work backing the future/stream hanging and they thus waste a lot of time trying to debug the async work.
      As such, we should require these two constructor arguments to make it impossible/much harder for devs to make this time-wasting mistake.
      
      This is a breaking change. However, it should break only a small number of active projects given that using a builder without specifying `future` or `stream` seems highly niche.
      The only place I've found non-accidental examples of this is in widget tests where you're calling `pumpWidget` with and without these arguments to test `*Builder.didUpdateWidget`'s behavior. In this and similar cases, it is a trivial fix to add `future: null`/`stream: null`.
      
      *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
      4d86f5d0
  2. 12 Nov, 2022 1 commit
  3. 14 Apr, 2022 1 commit
  4. 07 Dec, 2021 1 commit
  5. 08 Oct, 2021 3 commits
  6. 13 Jul, 2021 1 commit
  7. 28 Apr, 2021 1 commit
  8. 14 Nov, 2020 1 commit
  9. 13 Oct, 2020 1 commit
  10. 10 Aug, 2020 1 commit
  11. 11 Jun, 2020 1 commit
  12. 27 Nov, 2019 1 commit
    • Ian Hickson's avatar
      License update (#45373) · 449f4a66
      Ian Hickson authored
      * Update project.pbxproj files to say Flutter rather than Chromium
      
      Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
      
      * Update the copyright notice checker to require a standard notice on all files
      
      * Update copyrights on Dart files. (This was a mechanical commit.)
      
      * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
      
      Some were already marked "The Flutter Authors", not clear why. Their
      dates have been normalized. Some were missing the blank line after the
      license. Some were randomly different in trivial ways for no apparent
      reason (e.g. missing the trailing period).
      
      * Clean up the copyrights in non-Dart files. (Manual edits.)
      
      Also, make sure templates don't have copyrights.
      
      * Fix some more ORGANIZATIONNAMEs
      449f4a66
  13. 21 Jul, 2019 1 commit
  14. 18 Jul, 2019 1 commit
  15. 01 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      Add missing trailing commas (#28673) · 387f8854
      Alexandre Ardhuin authored
      * add trailing commas on list/map/parameters
      
      * add trailing commas on Invocation with nb of arg>1
      
      * add commas for widget containing widgets
      
      * add trailing commas if instantiation contains trailing comma
      
      * revert bad change
      387f8854
  16. 16 Oct, 2018 1 commit
  17. 12 Sep, 2018 1 commit
  18. 19 Mar, 2018 1 commit
  19. 12 Mar, 2018 1 commit
  20. 06 Jan, 2018 1 commit
  21. 07 Sep, 2017 1 commit
  22. 08 Jun, 2017 1 commit
  23. 23 Apr, 2017 1 commit
  24. 21 Apr, 2017 1 commit
  25. 17 Mar, 2017 1 commit
  26. 01 Mar, 2017 1 commit
  27. 23 Feb, 2017 1 commit
  28. 02 Feb, 2017 1 commit