- 17 Nov, 2017 1 commit
-
-
Greg Spencer authored
I got tired of drive-by spelling fixes, so I figured I'd just take care of them all at once. This only corrects errors in the dartdocs, not regular comments, and I skipped any sample code in the dartdocs. It doesn't touch any identifiers in the dartdocs either. No code changes, just comments.
-
- 25 Oct, 2017 1 commit
-
-
Alexandre Ardhuin authored
* enable lint prefer_foreach * fix tests
-
- 21 Sep, 2017 1 commit
-
-
Alexandre Ardhuin authored
-
- 20 Sep, 2017 1 commit
-
-
xster authored
* Record original pointer event timestamp * review * review * review
-
- 10 Aug, 2017 1 commit
-
-
xster authored
* Add synthesized property to pointer events * test
-
- 03 Aug, 2017 1 commit
-
-
Jacob Richman authored
Add Diagnosticable base class and documentation
-
- 27 Jul, 2017 1 commit
-
-
Ian Hickson authored
It was 8.0. It's now arbitrarily 18.0. Changing this required adjusting some tests. Adjusting the tests required debugging the tests. Debugging the tests required some tools to help debugging gesture recognizers and gesture arenas, so I added some. It also required updating some toString() methods which resulted in some changes to the tree diagnostics logic. Also I cleaned up some docs while I was at it.
-
- 12 Jun, 2017 1 commit
-
-
Ian Hickson authored
- How do you handle a tap on text? - Why is AnimatedOpacity expensive? - Why would you use a gesture arena team? ...and other minor fixes
-
- 05 Jun, 2017 1 commit
-
-
Alexandre Ardhuin authored
-
- 25 Apr, 2017 1 commit
-
-
Ian Hickson authored
Fixes https://github.com/flutter/flutter/issues/8425
-
- 21 Apr, 2017 1 commit
-
-
Ian Hickson authored
Move the Drag*Details classes into drag_details.dart. Move the one-gesture drag recognizers into monodrag.dart. Move Drag into drag.dart. Adjust the comments to claim that Drag is used by other things than MultiDragGestureRecognizer. (Right now this is a lie but it will hopefully be true soon.)
-
- 12 Apr, 2017 1 commit
-
-
Ian Hickson authored
* Manually fix every use of Point.x and Point.y Some of these were moved to dx/dy, but not all. * Manually convert uses of the old gradient API * Remove old reference to Point. * Mechanical changes I applied the following at the root of the Flutter repository: git ls-files -z | xargs -0 sed -i 's/\bPoint[.]origin\b/Offset.zero/g' git ls-files -z | xargs -0 sed -i 's/\bPoint[.]lerp\b/Offset.lerp/g' git ls-files -z | xargs -0 sed -i 's/\bnew Point\b/new Offset/g' git ls-files -z | xargs -0 sed -i 's/\bconst Point\b/const Offset/g' git ls-files -z | xargs -0 sed -i 's/\bstatic Point /static Offset /g' git ls-files -z | xargs -0 sed -i 's/\bfinal Point /final Offset /g' git ls-files -z | xargs -0 sed -i 's/^\( *\)Point /\1Offset /g' git ls-files -z | xargs -0 sed -i 's/ui[.]Point\b/ui.Offset/g' git ls-files -z | xargs -0 sed -i 's/(Point\b/(Offset/g' git ls-files -z | xargs -0 sed -i 's/\([[{,]\) Point\b/\1 Offset/g' git ls-files -z | xargs -0 sed -i 's/@required Point\b/@required Offset/g' git ls-files -z | xargs -0 sed -i 's/<Point>/<Offset>/g' git ls-files -z | xargs -0 sed -i 's/[.]toOffset()//g' git ls-files -z | xargs -0 sed -i 's/[.]toPoint()//g' git ls-files -z | xargs -0 sed -i 's/\bshow Point, /show /g' git ls-files -z | xargs -0 sed -i 's/\bshow Point;/show Offset;/g' * Mechanical changes - dartdocs I applied the following at the root of the Flutter repository: git ls-files -z | xargs -0 sed -i 's/\ba \[Point\]/an [Offset]/g' git ls-files -z | xargs -0 sed -i 's/\[Point\]/[Offset]/g' * Further improvements and a test * Fix minor errors from rebasing... * Roll engine
-
- 04 Mar, 2017 1 commit
-
-
Chris Bracken authored
Covers lib/ in package:flutter.
-
- 22 Jan, 2017 1 commit
-
-
Ian Hickson authored
-
- 06 Jan, 2017 1 commit
-
-
Ian Hickson authored
- more dartdocs for the drag typedefs - more toStrings to aid debugging - require the position for DragUpdateDetails since we were omitting it in some places - add the primaryVelocity to DragEndDetails so that consumers don't have to themselves track the axis in question - fix the velocity tracker so that it doesn't walk the null data. Previously, near time t=0 (which pretty much only matters in tests, but it does matter there) we would walk the velocity data and then also walk missing data, treating it as Point.zero with t=0. - simplify some of the velocity tracker; e.g. instead of trying (and failing?) to clear the velocity tracker when the pointer stalls, just drop the data before a stall during the velocity estimation (where we redundantly had another bigger horizon anyway).
-
- 19 Nov, 2016 1 commit
-
-
Ian Hickson authored
-
- 28 Oct, 2016 1 commit
-
-
Jason Simmons authored
If a recognizer is interrupted by an exception from a callback, it could be left in an inconsistent state and be unable to process future events
-
- 17 Oct, 2016 1 commit
-
-
Adam Barth authored
Previously, we were nulling out the ArenaEntry in MultiDragPointerState too early, which was prevent MultiDragPointerState from rejecting the gesture in `dispose` if we hadn't accepted by the time the pointer went up. Now we properly reject the gesture, which causes the tap gesture to win during `sweep` in the arena. Also, add a bunch of docs and annotations based on information I learned while studying this issue. Finally, rename a private member of tap recognizer to a name that would have confused me less in my investigation. Fixes #1186
-
- 16 Oct, 2016 1 commit
-
-
Adam Barth authored
Previously we would maroon the feedback in the overlay. Now we let the drag proceed and only tear down the gesture recognizer when all the drags it spawns have been resolved. Fixes #6151
-
- 15 Oct, 2016 1 commit
-
-
Adam Barth authored
Previously we were relying on the gesture arena to call us back to cancel our timer. However, in the case where we've already been accepted, asking the gesture arena to reject us doesn't lead to a callback and we fail to stop the timer (and hence trigger an assert). Fixes #6156
-
- 07 Jul, 2016 1 commit
-
-
Adam Barth authored
Fixes #4761
-
- 27 Jun, 2016 1 commit
-
-
Adam Barth authored
This patch adds tests for some code paths we weren't hitting before and removes some dead code that couldn't be tested because it was unreachable.
-
- 20 Jun, 2016 1 commit
-
-
Adam Barth authored
In writing a test for #1927, I found a number of bugs in how Draggable shuts down. Previously it would leak its recongizer. Now it disposes its recognizer and the recognizer knows how to be disposed cleanly. Fixes #1927
-
- 07 Jun, 2016 1 commit
-
-
Adam Barth authored
We have these details objects for the same reason we now have drag details objects: future extensibility.
-
- 18 May, 2016 1 commit
-
-
Adam Barth authored
Also, make some previously private classes public for better documentation.
-
- 17 May, 2016 1 commit
-
-
Adam Barth authored
-
- 12 May, 2016 1 commit
-
-
pq authored
It's safe to remove the unneeded `void`s from setters since the blocking issues in the `always_declare_return_types` lint have been fixed (https://github.com/dart-lang/linter/). We can also safely flip the bit on `avoid_return_types_on_setters`.
-
- 26 Apr, 2016 1 commit
-
-
Adam Barth authored
Wait until the end of the microtask to tell gesture recognizers that they've won in the gesture arena. This lets recognizers dispose reject themselves at arbitrary times without triggering gestures in awkward call stacks. Fixes #3183
-
- 22 Apr, 2016 1 commit
-
-
Ian Hickson authored
The old names were getting silly and started stepping on valuable namespace. The new names are consistent and clear.
-
- 14 Mar, 2016 1 commit
-
-
Hixie authored
-
- 25 Feb, 2016 2 commits
-
-
Adam Barth authored
There's no reason to make clients supply a PointerRounter and a GestureArena when constructing gesture recognizers. These objects are statics and the gesture recognizers can just grab them directly. Also, remove the callback constructor arguments. Almost no code used them. Instead, people seem to prefer using the `..` operator to set callbacks on the recognizers. Removing the arguments removes a bunch of boilerplate.
-
Hixie authored
This allows us to adjust exactly which gestures we're listening for during layout, which I'll use to kill a SizeObserver.
-
- 14 Feb, 2016 1 commit
-
-
Adam Barth authored
We were using an Offset, which represented pixels/second, but it wasn't clear to clients whether that was pixels/ms. Now we use a Velocity class that is explict about the units. Fixes #1510 Fixes #785
-
- 13 Feb, 2016 1 commit
-
-
Hixie authored
-
- 12 Feb, 2016 1 commit
-
-
Hixie authored
...even after winning the arena.
-
- 11 Feb, 2016 1 commit
-
-
Hixie authored
This lets it cooperate with other gestures like tap. The way I implemented this was to refactor the entire Draggable gesture logic to use a new kind of gesture detector called MultiDragGestureRecognizer. It works a bit like MultiTapGestureRecognizer but for drags. Also some tweaks to the velocity estimator.
-